<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[161385] trunk/Source</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/161385">161385</a></dd>
<dt>Author</dt> <dd>seokju@webkit.org</dd>
<dt>Date</dt> <dd>2014-01-06 16:52:17 -0800 (Mon, 06 Jan 2014)</dd>
</dl>
<h3>Log Message</h3>
<pre>Web Inspector: Remove support for FileSystem in Frontend.
https://bugs.webkit.org/show_bug.cgi?id=126369
Reviewed by Joseph Pecoraro.
Source/WebCore:
No new tests, No change in behavior.
Remove leftover codes from protocol after <a href="http://trac.webkit.org/projects/webkit/changeset/156692">r156692</a>.
* CMakeLists.txt:
* DerivedSources.make:
* GNUmakefile.am:
* inspector/InspectorFrontendClient.h:
* inspector/InspectorFrontendClientLocal.h:
* inspector/InspectorFrontendHost.cpp:
* inspector/InspectorFrontendHost.h:
* inspector/InspectorFrontendHost.idl:
* inspector/protocol/FileSystem.json: Removed.
Source/WebInspectorUI:
Update InspectorWebBackendCommands after removing 'FileSystem' domain.
* UserInterface/InspectorWebBackendCommands.js:
* UserInterface/Legacy/6.0/InspectorWebBackendCommands.js:
* UserInterface/Legacy/7.0/InspectorWebBackendCommands.js:
* Versions/Inspector-iOS-6.0.json:
* Versions/Inspector-iOS-7.0.json:</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkSourceWebCoreCMakeListstxt">trunk/Source/WebCore/CMakeLists.txt</a></li>
<li><a href="#trunkSourceWebCoreChangeLog">trunk/Source/WebCore/ChangeLog</a></li>
<li><a href="#trunkSourceWebCoreDerivedSourcesmake">trunk/Source/WebCore/DerivedSources.make</a></li>
<li><a href="#trunkSourceWebCoreGNUmakefileam">trunk/Source/WebCore/GNUmakefile.am</a></li>
<li><a href="#trunkSourceWebCoreinspectorInspectorFrontendClienth">trunk/Source/WebCore/inspector/InspectorFrontendClient.h</a></li>
<li><a href="#trunkSourceWebCoreinspectorInspectorFrontendClientLocalh">trunk/Source/WebCore/inspector/InspectorFrontendClientLocal.h</a></li>
<li><a href="#trunkSourceWebCoreinspectorInspectorFrontendHostcpp">trunk/Source/WebCore/inspector/InspectorFrontendHost.cpp</a></li>
<li><a href="#trunkSourceWebCoreinspectorInspectorFrontendHosth">trunk/Source/WebCore/inspector/InspectorFrontendHost.h</a></li>
<li><a href="#trunkSourceWebCoreinspectorInspectorFrontendHostidl">trunk/Source/WebCore/inspector/InspectorFrontendHost.idl</a></li>
<li><a href="#trunkSourceWebInspectorUIChangeLog">trunk/Source/WebInspectorUI/ChangeLog</a></li>
<li><a href="#trunkSourceWebInspectorUIUserInterfaceInspectorWebBackendCommandsjs">trunk/Source/WebInspectorUI/UserInterface/InspectorWebBackendCommands.js</a></li>
<li><a href="#trunkSourceWebInspectorUIUserInterfaceLegacy60InspectorWebBackendCommandsjs">trunk/Source/WebInspectorUI/UserInterface/Legacy/6.0/InspectorWebBackendCommands.js</a></li>
<li><a href="#trunkSourceWebInspectorUIUserInterfaceLegacy70InspectorWebBackendCommandsjs">trunk/Source/WebInspectorUI/UserInterface/Legacy/7.0/InspectorWebBackendCommands.js</a></li>
<li><a href="#trunkSourceWebInspectorUIVersionsInspectoriOS60json">trunk/Source/WebInspectorUI/Versions/Inspector-iOS-6.0.json</a></li>
<li><a href="#trunkSourceWebInspectorUIVersionsInspectoriOS70json">trunk/Source/WebInspectorUI/Versions/Inspector-iOS-7.0.json</a></li>
</ul>
<h3>Removed Paths</h3>
<ul>
<li><a href="#trunkSourceWebCoreinspectorprotocolFileSystemjson">trunk/Source/WebCore/inspector/protocol/FileSystem.json</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkSourceWebCoreCMakeListstxt"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/CMakeLists.txt (161384 => 161385)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/CMakeLists.txt 2014-01-07 00:42:41 UTC (rev 161384)
+++ trunk/Source/WebCore/CMakeLists.txt 2014-01-07 00:52:17 UTC (rev 161385)
</span><span class="lines">@@ -766,7 +766,6 @@
</span><span class="cx"> inspector/protocol/DOMDebugger.json
</span><span class="cx"> inspector/protocol/DOMStorage.json
</span><span class="cx"> inspector/protocol/Database.json
</span><del>- inspector/protocol/FileSystem.json
</del><span class="cx"> inspector/protocol/HeapProfiler.json
</span><span class="cx"> inspector/protocol/IndexedDB.json
</span><span class="cx"> inspector/protocol/Input.json
</span></span></pre></div>
<a id="trunkSourceWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/ChangeLog (161384 => 161385)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/ChangeLog 2014-01-07 00:42:41 UTC (rev 161384)
+++ trunk/Source/WebCore/ChangeLog 2014-01-07 00:52:17 UTC (rev 161385)
</span><span class="lines">@@ -1,3 +1,24 @@
</span><ins>+2014-01-06 Seokju Kwon <seokju@webkit.org>
+
+ Web Inspector: Remove support for FileSystem in Frontend.
+ https://bugs.webkit.org/show_bug.cgi?id=126369
+
+ Reviewed by Joseph Pecoraro.
+
+ No new tests, No change in behavior.
+
+ Remove leftover codes from protocol after r156692.
+
+ * CMakeLists.txt:
+ * DerivedSources.make:
+ * GNUmakefile.am:
+ * inspector/InspectorFrontendClient.h:
+ * inspector/InspectorFrontendClientLocal.h:
+ * inspector/InspectorFrontendHost.cpp:
+ * inspector/InspectorFrontendHost.h:
+ * inspector/InspectorFrontendHost.idl:
+ * inspector/protocol/FileSystem.json: Removed.
+
</ins><span class="cx"> 2014-01-06 Zoltan Horvath <zoltan@webkit.org>
</span><span class="cx">
</span><span class="cx"> [CSS Regions][CSS Shapes] ASSERTION FAILED: m_segmentRanges.size() < m_segments.size()
</span></span></pre></div>
<a id="trunkSourceWebCoreDerivedSourcesmake"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/DerivedSources.make (161384 => 161385)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/DerivedSources.make 2014-01-07 00:42:41 UTC (rev 161384)
+++ trunk/Source/WebCore/DerivedSources.make 2014-01-07 00:52:17 UTC (rev 161385)
</span><span class="lines">@@ -1084,7 +1084,6 @@
</span><span class="cx"> $(WebCore)/inspector/protocol/DOMDebugger.json \
</span><span class="cx"> $(WebCore)/inspector/protocol/DOMStorage.json \
</span><span class="cx"> $(WebCore)/inspector/protocol/Database.json \
</span><del>- $(WebCore)/inspector/protocol/FileSystem.json \
</del><span class="cx"> $(WebCore)/inspector/protocol/HeapProfiler.json \
</span><span class="cx"> $(WebCore)/inspector/protocol/IndexedDB.json \
</span><span class="cx"> $(WebCore)/inspector/protocol/Input.json \
</span></span></pre></div>
<a id="trunkSourceWebCoreGNUmakefileam"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/GNUmakefile.am (161384 => 161385)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/GNUmakefile.am 2014-01-07 00:42:41 UTC (rev 161384)
+++ trunk/Source/WebCore/GNUmakefile.am 2014-01-07 00:52:17 UTC (rev 161385)
</span><span class="lines">@@ -343,7 +343,6 @@
</span><span class="cx"> $(WebCore)/inspector/protocol/DOMDebugger.json \
</span><span class="cx"> $(WebCore)/inspector/protocol/DOMStorage.json \
</span><span class="cx"> $(WebCore)/inspector/protocol/Database.json \
</span><del>- $(WebCore)/inspector/protocol/FileSystem.json \
</del><span class="cx"> $(WebCore)/inspector/protocol/HeapProfiler.json \
</span><span class="cx"> $(WebCore)/inspector/protocol/IndexedDB.json \
</span><span class="cx"> $(WebCore)/inspector/protocol/Input.json \
</span></span></pre></div>
<a id="trunkSourceWebCoreinspectorInspectorFrontendClienth"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/inspector/InspectorFrontendClient.h (161384 => 161385)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/inspector/InspectorFrontendClient.h 2014-01-07 00:42:41 UTC (rev 161384)
+++ trunk/Source/WebCore/inspector/InspectorFrontendClient.h 2014-01-07 00:52:17 UTC (rev 161385)
</span><span class="lines">@@ -75,11 +75,6 @@
</span><span class="cx">
</span><span class="cx"> virtual void sendMessageToBackend(const String&) = 0;
</span><span class="cx">
</span><del>- virtual bool supportsFileSystems() = 0;
- virtual void requestFileSystems() = 0;
- virtual void addFileSystem() = 0;
- virtual void removeFileSystem(const String& fileSystemPath) = 0;
-
</del><span class="cx"> virtual bool isUnderTest() = 0;
</span><span class="cx"> };
</span><span class="cx">
</span></span></pre></div>
<a id="trunkSourceWebCoreinspectorInspectorFrontendClientLocalh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/inspector/InspectorFrontendClientLocal.h (161384 => 161385)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/inspector/InspectorFrontendClientLocal.h 2014-01-07 00:42:41 UTC (rev 161384)
+++ trunk/Source/WebCore/inspector/InspectorFrontendClientLocal.h 2014-01-07 00:52:17 UTC (rev 161385)
</span><span class="lines">@@ -76,10 +76,6 @@
</span><span class="cx">
</span><span class="cx"> virtual void sendMessageToBackend(const String& message);
</span><span class="cx">
</span><del>- virtual bool supportsFileSystems() { return false; }
- virtual void requestFileSystems() { }
- virtual void addFileSystem() { }
- virtual void removeFileSystem(const String&) { }
</del><span class="cx"> virtual bool isUnderTest();
</span><span class="cx">
</span><span class="cx"> bool canAttachWindow();
</span></span></pre></div>
<a id="trunkSourceWebCoreinspectorInspectorFrontendHostcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/inspector/InspectorFrontendHost.cpp (161384 => 161385)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/inspector/InspectorFrontendHost.cpp 2014-01-07 00:42:41 UTC (rev 161384)
+++ trunk/Source/WebCore/inspector/InspectorFrontendHost.cpp 2014-01-07 00:52:17 UTC (rev 161385)
</span><span class="lines">@@ -313,31 +313,6 @@
</span><span class="cx"> return String::fromUTF8(data.data(), data.size());
</span><span class="cx"> }
</span><span class="cx">
</span><del>-bool InspectorFrontendHost::supportsFileSystems()
-{
- if (m_client)
- return m_client->supportsFileSystems();
- return false;
-}
-
-void InspectorFrontendHost::requestFileSystems()
-{
- if (m_client)
- m_client->requestFileSystems();
-}
-
-void InspectorFrontendHost::addFileSystem()
-{
- if (m_client)
- m_client->addFileSystem();
-}
-
-void InspectorFrontendHost::removeFileSystem(const String& fileSystemPath)
-{
- if (m_client)
- m_client->removeFileSystem(fileSystemPath);
-}
-
</del><span class="cx"> bool InspectorFrontendHost::isUnderTest()
</span><span class="cx"> {
</span><span class="cx"> return m_client && m_client->isUnderTest();
</span></span></pre></div>
<a id="trunkSourceWebCoreinspectorInspectorFrontendHosth"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/inspector/InspectorFrontendHost.h (161384 => 161385)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/inspector/InspectorFrontendHost.h 2014-01-07 00:42:41 UTC (rev 161384)
+++ trunk/Source/WebCore/inspector/InspectorFrontendHost.h 2014-01-07 00:52:17 UTC (rev 161385)
</span><span class="lines">@@ -84,11 +84,6 @@
</span><span class="cx">
</span><span class="cx"> String loadResourceSynchronously(const String& url);
</span><span class="cx">
</span><del>- bool supportsFileSystems();
- void requestFileSystems();
- void addFileSystem();
- void removeFileSystem(const String& fileSystemPath);
-
</del><span class="cx"> bool isUnderTest();
</span><span class="cx">
</span><span class="cx"> void beep();
</span></span></pre></div>
<a id="trunkSourceWebCoreinspectorInspectorFrontendHostidl"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/inspector/InspectorFrontendHost.idl (161384 => 161385)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/inspector/InspectorFrontendHost.idl 2014-01-07 00:42:41 UTC (rev 161384)
+++ trunk/Source/WebCore/inspector/InspectorFrontendHost.idl 2014-01-07 00:52:17 UTC (rev 161385)
</span><span class="lines">@@ -71,11 +71,6 @@
</span><span class="cx">
</span><span class="cx"> DOMString loadResourceSynchronously(DOMString url);
</span><span class="cx">
</span><del>- boolean supportsFileSystems();
- void requestFileSystems();
- void addFileSystem();
- void removeFileSystem(DOMString fileSystemPath);
-
</del><span class="cx"> boolean isUnderTest();
</span><span class="cx">
</span><span class="cx"> void beep();
</span></span></pre></div>
<a id="trunkSourceWebCoreinspectorprotocolFileSystemjson"></a>
<div class="delfile"><h4>Deleted: trunk/Source/WebCore/inspector/protocol/FileSystem.json (161384 => 161385)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/inspector/protocol/FileSystem.json 2014-01-07 00:42:41 UTC (rev 161384)
+++ trunk/Source/WebCore/inspector/protocol/FileSystem.json 2014-01-07 00:52:17 UTC (rev 161385)
</span><span class="lines">@@ -1,102 +0,0 @@
</span><del>-{
- "domain": "FileSystem",
- "types": [
- {
- "id": "Entry",
- "type": "object",
- "properties": [
- { "name": "url", "type": "string", "description": "filesystem: URL for the entry." },
- { "name": "name", "type": "string", "description": "The name of the file or directory." },
- { "name": "isDirectory", "type": "boolean", "description": "True if the entry is a directory." },
- { "name": "mimeType", "type": "string", "optional": true, "description": "MIME type of the entry, available for a file only." },
- { "name": "resourceType", "$ref": "Page.ResourceType", "optional": true, "description": "ResourceType of the entry, available for a file only." },
- { "name": "isTextFile", "type": "boolean", "optional": true, "description": "True if the entry is a text file." }
- ],
- "description": "Represents a browser side file or directory."
- },
- {
- "id": "Metadata",
- "type": "object",
- "properties": [
- { "name": "modificationTime", "type": "number", "description": "Modification time." },
- { "name": "size", "type": "number", "description": "File size. This field is always zero for directories." }
- ],
- "description": "Represents metadata of a file or entry."
- }
- ],
- "commands": [
- {
- "name": "enable",
- "description": "Enables events from backend."
- },
- {
- "name": "disable",
- "description": "Disables events from backend."
- },
- {
- "name": "requestFileSystemRoot",
- "async": true,
- "parameters": [
- { "name": "origin", "type": "string", "description": "Security origin of requesting FileSystem. One of frames in current page needs to have this security origin." },
- { "name": "type", "type": "string", "enum": ["temporary", "persistent"], "description": "FileSystem type of requesting FileSystem." }
- ],
- "returns": [
- { "name": "errorCode", "type": "integer", "description": "0, if no error. Otherwise, errorCode is set to FileError::ErrorCode value." },
- { "name": "root", "$ref": "Entry", "optional": true, "description": "Contains root of the requested FileSystem if the command completed successfully." }
- ],
- "description": "Returns root directory of the FileSystem, if exists."
- },
- {
- "name": "requestDirectoryContent",
- "async": true,
- "parameters": [
- { "name": "url", "type": "string", "description": "URL of the directory that the frontend is requesting to read from." }
- ],
- "returns": [
- { "name": "errorCode", "type": "integer", "description": "0, if no error. Otherwise, errorCode is set to FileError::ErrorCode value." },
- { "name": "entries", "type": "array", "items": { "$ref": "Entry" }, "optional": true, "description": "Contains all entries on directory if the command completed successfully." }
- ],
- "description": "Returns content of the directory."
- },
- {
- "name": "requestMetadata",
- "async": true,
- "parameters": [
- { "name": "url", "type": "string", "description": "URL of the entry that the frontend is requesting to get metadata from." }
- ],
- "returns": [
- { "name": "errorCode", "type": "integer", "description": "0, if no error. Otherwise, errorCode is set to FileError::ErrorCode value." },
- { "name": "metadata", "$ref": "Metadata", "optional": true, "description": "Contains metadata of the entry if the command completed successfully." }
- ],
- "description": "Returns metadata of the entry."
- },
- {
- "name": "requestFileContent",
- "async": true,
- "parameters": [
- { "name": "url", "type": "string", "description": "URL of the file that the frontend is requesting to read from." },
- { "name": "readAsText", "type": "boolean", "description": "True if the content should be read as text, otherwise the result will be returned as base64 encoded text." },
- { "name": "start", "type": "integer", "optional": true, "description": "Specifies the start of range to read." },
- { "name": "end", "type": "integer", "optional": true, "description": "Specifies the end of range to read exclusively." },
- { "name": "charset", "type": "string", "optional": true, "description": "Overrides charset of the content when content is served as text." }
- ],
- "returns": [
- { "name": "errorCode", "type": "integer", "description": "0, if no error. Otherwise, errorCode is set to FileError::ErrorCode value." },
- { "name": "content", "type": "string", "optional": true, "description": "Content of the file." },
- { "name": "charset", "type": "string", "optional": true, "description": "Charset of the content if it is served as text." }
- ],
- "description": "Returns content of the file. Result should be sliced into [start, end)."
- },
- {
- "name": "deleteEntry",
- "async": true,
- "parameters": [
- { "name": "url", "type": "string", "description": "URL of the entry to delete." }
- ],
- "returns": [
- { "name": "errorCode", "type": "integer", "description": "0, if no error. Otherwise errorCode is set to FileError::ErrorCode value." }
- ],
- "description": "Deletes specified entry. If the entry is a directory, the agent deletes children recursively."
- }
- ]
-}
</del></span></pre></div>
<a id="trunkSourceWebInspectorUIChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebInspectorUI/ChangeLog (161384 => 161385)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebInspectorUI/ChangeLog 2014-01-07 00:42:41 UTC (rev 161384)
+++ trunk/Source/WebInspectorUI/ChangeLog 2014-01-07 00:52:17 UTC (rev 161385)
</span><span class="lines">@@ -1,5 +1,20 @@
</span><span class="cx"> 2014-01-06 Seokju Kwon <seokju@webkit.org>
</span><span class="cx">
</span><ins>+ Web Inspector: Remove support for FileSystem in Frontend.
+ https://bugs.webkit.org/show_bug.cgi?id=126369
+
+ Reviewed by Joseph Pecoraro.
+
+ Update InspectorWebBackendCommands after removing 'FileSystem' domain.
+
+ * UserInterface/InspectorWebBackendCommands.js:
+ * UserInterface/Legacy/6.0/InspectorWebBackendCommands.js:
+ * UserInterface/Legacy/7.0/InspectorWebBackendCommands.js:
+ * Versions/Inspector-iOS-6.0.json:
+ * Versions/Inspector-iOS-7.0.json:
+
+2014-01-06 Seokju Kwon <seokju@webkit.org>
+
</ins><span class="cx"> Web Inspector: Get rid of DOM.setFileInputFiles from Protocol
</span><span class="cx"> https://bugs.webkit.org/show_bug.cgi?id=126312
</span><span class="cx">
</span></span></pre></div>
<a id="trunkSourceWebInspectorUIUserInterfaceInspectorWebBackendCommandsjs"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebInspectorUI/UserInterface/InspectorWebBackendCommands.js (161384 => 161385)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebInspectorUI/UserInterface/InspectorWebBackendCommands.js 2014-01-07 00:42:41 UTC (rev 161384)
+++ trunk/Source/WebInspectorUI/UserInterface/InspectorWebBackendCommands.js 2014-01-07 00:52:17 UTC (rev 161385)
</span><span class="lines">@@ -158,16 +158,6 @@
</span><span class="cx"> InspectorBackend.registerCommand("Database.getDatabaseTableNames", [{"name": "databaseId", "type": "string", "optional": false}], ["tableNames"]);
</span><span class="cx"> InspectorBackend.registerCommand("Database.executeSQL", [{"name": "databaseId", "type": "string", "optional": false}, {"name": "query", "type": "string", "optional": false}], ["columnNames", "values", "sqlError"]);
</span><span class="cx">
</span><del>-// FileSystem.
-InspectorBackend.registerFileSystemDispatcher = InspectorBackend.registerDomainDispatcher.bind(InspectorBackend, "FileSystem");
-InspectorBackend.registerCommand("FileSystem.enable", [], []);
-InspectorBackend.registerCommand("FileSystem.disable", [], []);
-InspectorBackend.registerCommand("FileSystem.requestFileSystemRoot", [{"name": "origin", "type": "string", "optional": false}, {"name": "type", "type": "string", "optional": false}], ["errorCode", "root"]);
-InspectorBackend.registerCommand("FileSystem.requestDirectoryContent", [{"name": "url", "type": "string", "optional": false}], ["errorCode", "entries"]);
-InspectorBackend.registerCommand("FileSystem.requestMetadata", [{"name": "url", "type": "string", "optional": false}], ["errorCode", "metadata"]);
-InspectorBackend.registerCommand("FileSystem.requestFileContent", [{"name": "url", "type": "string", "optional": false}, {"name": "readAsText", "type": "boolean", "optional": false}, {"name": "start", "type": "number", "optional": true}, {"name": "end", "type": "number", "optional": true}, {"name": "charset", "type": "string", "optional": true}], ["errorCode", "content", "charset"]);
-InspectorBackend.registerCommand("FileSystem.deleteEntry", [{"name": "url", "type": "string", "optional": false}], ["errorCode"]);
-
</del><span class="cx"> // HeapProfiler.
</span><span class="cx"> InspectorBackend.registerHeapProfilerDispatcher = InspectorBackend.registerDomainDispatcher.bind(InspectorBackend, "HeapProfiler");
</span><span class="cx"> InspectorBackend.registerEvent("HeapProfiler.addProfileHeader", ["header"]);
</span></span></pre></div>
<a id="trunkSourceWebInspectorUIUserInterfaceLegacy60InspectorWebBackendCommandsjs"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebInspectorUI/UserInterface/Legacy/6.0/InspectorWebBackendCommands.js (161384 => 161385)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebInspectorUI/UserInterface/Legacy/6.0/InspectorWebBackendCommands.js 2014-01-07 00:42:41 UTC (rev 161384)
+++ trunk/Source/WebInspectorUI/UserInterface/Legacy/6.0/InspectorWebBackendCommands.js 2014-01-07 00:52:17 UTC (rev 161385)
</span><span class="lines">@@ -141,11 +141,6 @@
</span><span class="cx"> InspectorBackend.registerCommand("ApplicationCache.getManifestForFrame", [{"name": "frameId", "type": "string", "optional": false}], ["manifestURL"]);
</span><span class="cx"> InspectorBackend.registerCommand("ApplicationCache.getApplicationCacheForFrame", [{"name": "frameId", "type": "string", "optional": false}], ["applicationCache"]);
</span><span class="cx">
</span><del>-// FileSystem.
-InspectorBackend.registerFileSystemDispatcher = InspectorBackend.registerDomainDispatcher.bind(InspectorBackend, "FileSystem");
-InspectorBackend.registerCommand("FileSystem.enable", [], []);
-InspectorBackend.registerCommand("FileSystem.disable", [], []);
-
</del><span class="cx"> // DOM.
</span><span class="cx"> InspectorBackend.registerDOMDispatcher = InspectorBackend.registerDomainDispatcher.bind(InspectorBackend, "DOM");
</span><span class="cx"> InspectorBackend.registerEvent("DOM.documentUpdated", []);
</span></span></pre></div>
<a id="trunkSourceWebInspectorUIUserInterfaceLegacy70InspectorWebBackendCommandsjs"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebInspectorUI/UserInterface/Legacy/7.0/InspectorWebBackendCommands.js (161384 => 161385)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebInspectorUI/UserInterface/Legacy/7.0/InspectorWebBackendCommands.js 2014-01-07 00:42:41 UTC (rev 161384)
+++ trunk/Source/WebInspectorUI/UserInterface/Legacy/7.0/InspectorWebBackendCommands.js 2014-01-07 00:52:17 UTC (rev 161385)
</span><span class="lines">@@ -171,16 +171,6 @@
</span><span class="cx"> InspectorBackend.registerCommand("ApplicationCache.getManifestForFrame", [{"name": "frameId", "type": "string", "optional": false}], ["manifestURL"]);
</span><span class="cx"> InspectorBackend.registerCommand("ApplicationCache.getApplicationCacheForFrame", [{"name": "frameId", "type": "string", "optional": false}], ["applicationCache"]);
</span><span class="cx">
</span><del>-// FileSystem.
-InspectorBackend.registerFileSystemDispatcher = InspectorBackend.registerDomainDispatcher.bind(InspectorBackend, "FileSystem");
-InspectorBackend.registerCommand("FileSystem.enable", [], []);
-InspectorBackend.registerCommand("FileSystem.disable", [], []);
-InspectorBackend.registerCommand("FileSystem.requestFileSystemRoot", [{"name": "origin", "type": "string", "optional": false}, {"name": "type", "type": "string", "optional": false}], ["errorCode", "root"]);
-InspectorBackend.registerCommand("FileSystem.requestDirectoryContent", [{"name": "url", "type": "string", "optional": false}], ["errorCode", "entries"]);
-InspectorBackend.registerCommand("FileSystem.requestMetadata", [{"name": "url", "type": "string", "optional": false}], ["errorCode", "metadata"]);
-InspectorBackend.registerCommand("FileSystem.requestFileContent", [{"name": "url", "type": "string", "optional": false}, {"name": "readAsText", "type": "boolean", "optional": false}, {"name": "start", "type": "number", "optional": true}, {"name": "end", "type": "number", "optional": true}, {"name": "charset", "type": "string", "optional": true}], ["errorCode", "content", "charset"]);
-InspectorBackend.registerCommand("FileSystem.deleteEntry", [{"name": "url", "type": "string", "optional": false}], ["errorCode"]);
-
</del><span class="cx"> // DOM.
</span><span class="cx"> InspectorBackend.registerDOMDispatcher = InspectorBackend.registerDomainDispatcher.bind(InspectorBackend, "DOM");
</span><span class="cx"> InspectorBackend.registerEvent("DOM.documentUpdated", []);
</span></span></pre></div>
<a id="trunkSourceWebInspectorUIVersionsInspectoriOS60json"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebInspectorUI/Versions/Inspector-iOS-6.0.json (161384 => 161385)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebInspectorUI/Versions/Inspector-iOS-6.0.json 2014-01-07 00:42:41 UTC (rev 161384)
+++ trunk/Source/WebInspectorUI/Versions/Inspector-iOS-6.0.json 2014-01-07 00:52:17 UTC (rev 161385)
</span><span class="lines">@@ -1339,22 +1339,6 @@
</span><span class="cx"> ]
</span><span class="cx"> },
</span><span class="cx"> {
</span><del>- "domain": "FileSystem",
- "hidden": true,
- "commands": [
- {
- "name": "enable",
- "description": "Enables events from backend."
- },
- {
- "name": "disable",
- "description": "Disables events from backend.."
- }
- ],
- "events": [
- ]
- },
- {
</del><span class="cx"> "domain": "DOM",
</span><span class="cx"> "description": "This domain exposes DOM read/write operations. Each DOM Node is represented with its mirror object that has an <code>id</code>. This <code>id</code> can be used to get additional information on the Node, resolve it into the JavaScript object wrapper, etc. It is important that client receives DOM events only for the nodes that are known to the client. Backend keeps track of the nodes that were sent to the client and never sends the same node twice. It is client's responsibility to collect information about the nodes that were sent to the client.<p>Note that <code>iframe</code> owner elements will return corresponding document elements as their child nodes.</p>",
</span><span class="cx"> "types": [
</span></span></pre></div>
<a id="trunkSourceWebInspectorUIVersionsInspectoriOS70json"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebInspectorUI/Versions/Inspector-iOS-7.0.json (161384 => 161385)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebInspectorUI/Versions/Inspector-iOS-7.0.json 2014-01-07 00:42:41 UTC (rev 161384)
+++ trunk/Source/WebInspectorUI/Versions/Inspector-iOS-7.0.json 2014-01-07 00:52:17 UTC (rev 161385)
</span><span class="lines">@@ -1524,108 +1524,6 @@
</span><span class="cx"> ]
</span><span class="cx"> },
</span><span class="cx"> {
</span><del>- "domain": "FileSystem",
- "types": [
- {
- "id": "Entry",
- "type": "object",
- "properties": [
- { "name": "url", "type": "string", "description": "filesystem: URL for the entry." },
- { "name": "name", "type": "string", "description": "The name of the file or directory." },
- { "name": "isDirectory", "type": "boolean", "description": "True if the entry is a directory." },
- { "name": "mimeType", "type": "string", "optional": true, "description": "MIME type of the entry, available for a file only." },
- { "name": "resourceType", "$ref": "Page.ResourceType", "optional": true, "description": "ResourceType of the entry, available for a file only." },
- { "name": "isTextFile", "type": "boolean", "optional": true, "description": "True if the entry is a text file." }
- ],
- "description": "Represents a browser side file or directory."
- },
- {
- "id": "Metadata",
- "type": "object",
- "properties": [
- { "name": "modificationTime", "type": "number", "description": "Modification time." },
- { "name": "size", "type": "number", "description": "File size. This field is always zero for directories." }
- ],
- "description": "Represents metadata of a file or entry."
- }
- ],
- "commands": [
- {
- "name": "enable",
- "description": "Enables events from backend."
- },
- {
- "name": "disable",
- "description": "Disables events from backend."
- },
- {
- "name": "requestFileSystemRoot",
- "async": true,
- "parameters": [
- { "name": "origin", "type": "string", "description": "Security origin of requesting FileSystem. One of frames in current page needs to have this security origin." },
- { "name": "type", "type": "string", "enum": ["temporary", "persistent"], "description": "FileSystem type of requesting FileSystem." }
- ],
- "returns": [
- { "name": "errorCode", "type": "integer", "description": "0, if no error. Otherwise, errorCode is set to FileError::ErrorCode value." },
- { "name": "root", "$ref": "Entry", "optional": true, "description": "Contains root of the requested FileSystem if the command completed successfully." }
- ],
- "description": "Returns root directory of the FileSystem, if exists."
- },
- {
- "name": "requestDirectoryContent",
- "async": true,
- "parameters": [
- { "name": "url", "type": "string", "description": "URL of the directory that the frontend is requesting to read from." }
- ],
- "returns": [
- { "name": "errorCode", "type": "integer", "description": "0, if no error. Otherwise, errorCode is set to FileError::ErrorCode value." },
- { "name": "entries", "type": "array", "items": { "$ref": "Entry" }, "optional": true, "description": "Contains all entries on directory if the command completed successfully." }
- ],
- "description": "Returns content of the directory."
- },
- {
- "name": "requestMetadata",
- "async": true,
- "parameters": [
- { "name": "url", "type": "string", "description": "URL of the entry that the frontend is requesting to get metadata from." }
- ],
- "returns": [
- { "name": "errorCode", "type": "integer", "description": "0, if no error. Otherwise, errorCode is set to FileError::ErrorCode value." },
- { "name": "metadata", "$ref": "Metadata", "optional": true, "description": "Contains metadata of the entry if the command completed successfully." }
- ],
- "description": "Returns metadata of the entry."
- },
- {
- "name": "requestFileContent",
- "async": true,
- "parameters": [
- { "name": "url", "type": "string", "description": "URL of the file that the frontend is requesting to read from." },
- { "name": "readAsText", "type": "boolean", "description": "True if the content should be read as text, otherwise the result will be returned as base64 encoded text." },
- { "name": "start", "type": "integer", "optional": true, "description": "Specifies the start of range to read." },
- { "name": "end", "type": "integer", "optional": true, "description": "Specifies the end of range to read exclusively." },
- { "name": "charset", "type": "string", "optional": true, "description": "Overrides charset of the content when content is served as text." }
- ],
- "returns": [
- { "name": "errorCode", "type": "integer", "description": "0, if no error. Otherwise, errorCode is set to FileError::ErrorCode value." },
- { "name": "content", "type": "string", "optional": true, "description": "Content of the file." },
- { "name": "charset", "type": "string", "optional": true, "description": "Charset of the content if it is served as text." }
- ],
- "description": "Returns content of the file. Result should be sliced into [start, end)."
- },
- {
- "name": "deleteEntry",
- "async": true,
- "parameters": [
- { "name": "url", "type": "string", "description": "URL of the entry to delete." }
- ],
- "returns": [
- { "name": "errorCode", "type": "integer", "description": "0, if no error. Otherwise errorCode is set to FileError::ErrorCode value." }
- ],
- "description": "Deletes specified entry. If the entry is a directory, the agent deletes children recursively."
- }
- ]
- },
- {
</del><span class="cx"> "domain": "DOM",
</span><span class="cx"> "description": "This domain exposes DOM read/write operations. Each DOM Node is represented with its mirror object that has an <code>id</code>. This <code>id</code> can be used to get additional information on the Node, resolve it into the JavaScript object wrapper, etc. It is important that client receives DOM events only for the nodes that are known to the client. Backend keeps track of the nodes that were sent to the client and never sends the same node twice. It is client's responsibility to collect information about the nodes that were sent to the client.<p>Note that <code>iframe</code> owner elements will return corresponding document elements as their child nodes.</p>",
</span><span class="cx"> "types": [
</span></span></pre>
</div>
</div>
</body>
</html>