<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[161402] trunk/Source</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/161402">161402</a></dd>
<dt>Author</dt> <dd>seokju@webkit.org</dd>
<dt>Date</dt> <dd>2014-01-06 21:19:38 -0800 (Mon, 06 Jan 2014)</dd>
</dl>
<h3>Log Message</h3>
<pre>Web Inspector: Remove canOverrideDeviceMetrics and setDeviceMetricsOverride from protocol
https://bugs.webkit.org/show_bug.cgi?id=126149
Reviewed by Joseph Pecoraro.
Source/WebCore:
No new tests, No changes in behavior.
These are not used anywhere in WebInspectorUI.
So, it removes unused Protocols and APIs.
* inspector/InspectorClient.h:
* inspector/InspectorPageAgent.cpp:
(WebCore::InspectorPageAgent::InspectorPageAgent):
(WebCore::InspectorPageAgent::disable):
* inspector/InspectorPageAgent.h:
* inspector/protocol/Page.json:
Source/WebInspectorUI:
* UserInterface/InspectorWebBackendCommands.js: Remove unused codes.
* UserInterface/Legacy/6.0/InspectorWebBackendCommands.js: Ditto.
* UserInterface/Legacy/7.0/InspectorWebBackendCommands.js: Ditto.
* Versions/Inspector-iOS-6.0.json: Ditto.
* Versions/Inspector-iOS-7.0.json: Ditto.
Source/WebKit/blackberry:
* WebCoreSupport/InspectorClientBlackBerry.cpp: Remove dead codes.
* WebCoreSupport/InspectorClientBlackBerry.h: Ditto.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkSourceWebCoreChangeLog">trunk/Source/WebCore/ChangeLog</a></li>
<li><a href="#trunkSourceWebCoreinspectorInspectorClienth">trunk/Source/WebCore/inspector/InspectorClient.h</a></li>
<li><a href="#trunkSourceWebCoreinspectorInspectorPageAgentcpp">trunk/Source/WebCore/inspector/InspectorPageAgent.cpp</a></li>
<li><a href="#trunkSourceWebCoreinspectorInspectorPageAgenth">trunk/Source/WebCore/inspector/InspectorPageAgent.h</a></li>
<li><a href="#trunkSourceWebCoreinspectorprotocolPagejson">trunk/Source/WebCore/inspector/protocol/Page.json</a></li>
<li><a href="#trunkSourceWebInspectorUIChangeLog">trunk/Source/WebInspectorUI/ChangeLog</a></li>
<li><a href="#trunkSourceWebInspectorUIUserInterfaceInspectorWebBackendCommandsjs">trunk/Source/WebInspectorUI/UserInterface/InspectorWebBackendCommands.js</a></li>
<li><a href="#trunkSourceWebInspectorUIUserInterfaceLegacy60InspectorWebBackendCommandsjs">trunk/Source/WebInspectorUI/UserInterface/Legacy/6.0/InspectorWebBackendCommands.js</a></li>
<li><a href="#trunkSourceWebInspectorUIUserInterfaceLegacy70InspectorWebBackendCommandsjs">trunk/Source/WebInspectorUI/UserInterface/Legacy/7.0/InspectorWebBackendCommands.js</a></li>
<li><a href="#trunkSourceWebInspectorUIVersionsInspectoriOS60json">trunk/Source/WebInspectorUI/Versions/Inspector-iOS-6.0.json</a></li>
<li><a href="#trunkSourceWebInspectorUIVersionsInspectoriOS70json">trunk/Source/WebInspectorUI/Versions/Inspector-iOS-7.0.json</a></li>
<li><a href="#trunkSourceWebKitblackberryChangeLog">trunk/Source/WebKit/blackberry/ChangeLog</a></li>
<li><a href="#trunkSourceWebKitblackberryWebCoreSupportInspectorClientBlackBerrycpp">trunk/Source/WebKit/blackberry/WebCoreSupport/InspectorClientBlackBerry.cpp</a></li>
<li><a href="#trunkSourceWebKitblackberryWebCoreSupportInspectorClientBlackBerryh">trunk/Source/WebKit/blackberry/WebCoreSupport/InspectorClientBlackBerry.h</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkSourceWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/ChangeLog (161401 => 161402)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/ChangeLog 2014-01-07 05:15:07 UTC (rev 161401)
+++ trunk/Source/WebCore/ChangeLog 2014-01-07 05:19:38 UTC (rev 161402)
</span><span class="lines">@@ -1,3 +1,22 @@
</span><ins>+2014-01-06 Seokju Kwon <seokju@webkit.org>
+
+ Web Inspector: Remove canOverrideDeviceMetrics and setDeviceMetricsOverride from protocol
+ https://bugs.webkit.org/show_bug.cgi?id=126149
+
+ Reviewed by Joseph Pecoraro.
+
+ No new tests, No changes in behavior.
+
+ These are not used anywhere in WebInspectorUI.
+ So, it removes unused Protocols and APIs.
+
+ * inspector/InspectorClient.h:
+ * inspector/InspectorPageAgent.cpp:
+ (WebCore::InspectorPageAgent::InspectorPageAgent):
+ (WebCore::InspectorPageAgent::disable):
+ * inspector/InspectorPageAgent.h:
+ * inspector/protocol/Page.json:
+
</ins><span class="cx"> 2014-01-06 Gyuyoung Kim <gyuyoung.kim@samsung.com>
</span><span class="cx">
</span><span class="cx"> Add toHTMLTableSectionElement() functions, and use it
</span></span></pre></div>
<a id="trunkSourceWebCoreinspectorInspectorClienth"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/inspector/InspectorClient.h (161401 => 161402)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/inspector/InspectorClient.h 2014-01-07 05:15:07 UTC (rev 161401)
+++ trunk/Source/WebCore/inspector/InspectorClient.h 2014-01-07 05:19:38 UTC (rev 161402)
</span><span class="lines">@@ -61,8 +61,6 @@
</span><span class="cx"> virtual void clearBrowserCookies() { }
</span><span class="cx"> virtual bool canMonitorMainThread() { return false; }
</span><span class="cx">
</span><del>- virtual bool canOverrideDeviceMetrics() { return false; }
-
</del><span class="cx"> virtual void overrideDeviceMetrics(int /*width*/, int /*height*/, float /*fontScaleFactor*/, bool /*fitWindow*/)
</span><span class="cx"> {
</span><span class="cx"> // FIXME: Platforms may want to implement this (see https://bugs.webkit.org/show_bug.cgi?id=82886).
</span></span></pre></div>
<a id="trunkSourceWebCoreinspectorInspectorPageAgentcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/inspector/InspectorPageAgent.cpp (161401 => 161402)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/inspector/InspectorPageAgent.cpp 2014-01-07 05:15:07 UTC (rev 161401)
+++ trunk/Source/WebCore/inspector/InspectorPageAgent.cpp 2014-01-07 05:19:38 UTC (rev 161402)
</span><span class="lines">@@ -362,8 +362,6 @@
</span><span class="cx"> , m_lastScriptIdentifier(0)
</span><span class="cx"> , m_screenWidthOverride(0)
</span><span class="cx"> , m_screenHeightOverride(0)
</span><del>- , m_fontScaleFactorOverride(1)
- , m_fitWindowOverride(false)
</del><span class="cx"> , m_enabled(false)
</span><span class="cx"> , m_isFirstLayoutAfterOnLoad(false)
</span><span class="cx"> , m_originalScriptExecutionDisabled(false)
</span><span class="lines">@@ -413,15 +411,9 @@
</span><span class="cx"> setEmulatedMedia(0, "");
</span><span class="cx"> setContinuousPaintingEnabled(0, false);
</span><span class="cx">
</span><del>- if (!deviceMetricsChanged(0, 0, 1, false))
- return;
-
</del><span class="cx"> // When disabling the agent, reset the override values if necessary.
</span><del>- updateViewMetrics(0, 0, 1, false);
</del><span class="cx"> m_screenWidthOverride = 0;
</span><span class="cx"> m_screenHeightOverride = 0;
</span><del>- m_fontScaleFactorOverride = 1;
- m_fitWindowOverride = false;
</del><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> void InspectorPageAgent::addScriptToEvaluateOnLoad(ErrorString*, const String& source, String* identifier)
</span><span class="lines">@@ -692,46 +684,6 @@
</span><span class="cx"> DOMPatchSupport::patchDocument(document, html);
</span><span class="cx"> }
</span><span class="cx">
</span><del>-void InspectorPageAgent::canOverrideDeviceMetrics(ErrorString*, bool* result)
-{
- *result = m_client->canOverrideDeviceMetrics();
-}
-
-void InspectorPageAgent::setDeviceMetricsOverride(ErrorString* errorString, int width, int height, double fontScaleFactor, bool fitWindow)
-{
- const static long maxDimension = 10000000;
-
- if (width < 0 || height < 0 || width > maxDimension || height > maxDimension) {
- *errorString = makeString("Width and height values must be positive, not greater than ", String::number(maxDimension));
- return;
- }
-
- if (!width ^ !height) {
- *errorString = "Both width and height must be either zero or non-zero at once";
- return;
- }
-
- if (fontScaleFactor <= 0) {
- *errorString = "fontScaleFactor must be positive";
- return;
- }
-
- if (!deviceMetricsChanged(width, height, fontScaleFactor, fitWindow))
- return;
-
- m_screenWidthOverride = width;
- m_screenHeightOverride = height;
- m_fontScaleFactorOverride = fontScaleFactor;
- m_fitWindowOverride = fitWindow;
-
- updateViewMetrics(width, height, fontScaleFactor, fitWindow);
-}
-
-bool InspectorPageAgent::deviceMetricsChanged(int width, int height, double fontScaleFactor, bool fitWindow)
-{
- return width != m_screenWidthOverride || height != m_screenHeightOverride || fontScaleFactor != m_fontScaleFactorOverride || fitWindow != m_fitWindowOverride;
-}
-
</del><span class="cx"> void InspectorPageAgent::setShowPaintRects(ErrorString*, bool show)
</span><span class="cx"> {
</span><span class="cx"> m_showPaintRects = show;
</span><span class="lines">@@ -1094,16 +1046,6 @@
</span><span class="cx"> return result;
</span><span class="cx"> }
</span><span class="cx">
</span><del>-void InspectorPageAgent::updateViewMetrics(int width, int height, double fontScaleFactor, bool fitWindow)
-{
- m_client->overrideDeviceMetrics(width, height, static_cast<float>(fontScaleFactor), fitWindow);
-
- Document* document = mainFrame()->document();
- if (document)
- document->styleResolverChanged(RecalcStyleImmediately);
- InspectorInstrumentation::mediaQueryResultChanged(document);
-}
-
</del><span class="cx"> #if ENABLE(TOUCH_EVENTS)
</span><span class="cx"> void InspectorPageAgent::updateTouchEventEmulationInPage(bool enabled)
</span><span class="cx"> {
</span></span></pre></div>
<a id="trunkSourceWebCoreinspectorInspectorPageAgenth"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/inspector/InspectorPageAgent.h (161401 => 161402)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/inspector/InspectorPageAgent.h 2014-01-07 05:15:07 UTC (rev 161401)
+++ trunk/Source/WebCore/inspector/InspectorPageAgent.h 2014-01-07 05:19:38 UTC (rev 161402)
</span><span class="lines">@@ -112,8 +112,6 @@
</span><span class="cx"> virtual void searchInResource(ErrorString*, const String& frameId, const String& url, const String& query, const bool* optionalCaseSensitive, const bool* optionalIsRegex, RefPtr<Inspector::TypeBuilder::Array<Inspector::TypeBuilder::GenericTypes::SearchMatch>>&);
</span><span class="cx"> virtual void searchInResources(ErrorString*, const String&, const bool* caseSensitive, const bool* isRegex, RefPtr<Inspector::TypeBuilder::Array<Inspector::TypeBuilder::Page::SearchResult>>&);
</span><span class="cx"> virtual void setDocumentContent(ErrorString*, const String& frameId, const String& html);
</span><del>- virtual void canOverrideDeviceMetrics(ErrorString*, bool*);
- virtual void setDeviceMetricsOverride(ErrorString*, int width, int height, double fontScaleFactor, bool fitWindow);
</del><span class="cx"> virtual void setShowPaintRects(ErrorString*, bool show);
</span><span class="cx"> virtual void canShowDebugBorders(ErrorString*, bool*);
</span><span class="cx"> virtual void setShowDebugBorders(ErrorString*, bool show);
</span><span class="lines">@@ -185,8 +183,6 @@
</span><span class="cx">
</span><span class="cx"> private:
</span><span class="cx"> InspectorPageAgent(InstrumentingAgents*, Page*, InspectorAgent*, InjectedScriptManager*, InspectorClient*, InspectorOverlay*);
</span><del>- bool deviceMetricsChanged(int width, int height, double fontScaleFactor, bool fitWindow);
- void updateViewMetrics(int, int, double, bool);
</del><span class="cx"> #if ENABLE(TOUCH_EVENTS)
</span><span class="cx"> void updateTouchEventEmulationInPage(bool);
</span><span class="cx"> #endif
</span><span class="lines">@@ -213,8 +209,6 @@
</span><span class="cx"> HashMap<DocumentLoader*, String> m_loaderToIdentifier;
</span><span class="cx"> int m_screenWidthOverride;
</span><span class="cx"> int m_screenHeightOverride;
</span><del>- double m_fontScaleFactorOverride;
- bool m_fitWindowOverride;
</del><span class="cx"> bool m_enabled;
</span><span class="cx"> bool m_isFirstLayoutAfterOnLoad;
</span><span class="cx"> bool m_originalScriptExecutionDisabled;
</span></span></pre></div>
<a id="trunkSourceWebCoreinspectorprotocolPagejson"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/inspector/protocol/Page.json (161401 => 161402)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/inspector/protocol/Page.json 2014-01-07 05:15:07 UTC (rev 161401)
+++ trunk/Source/WebCore/inspector/protocol/Page.json 2014-01-07 05:19:38 UTC (rev 161402)
</span><span class="lines">@@ -192,23 +192,6 @@
</span><span class="cx"> ]
</span><span class="cx"> },
</span><span class="cx"> {
</span><del>- "name": "canOverrideDeviceMetrics",
- "description": "Checks whether <code>setDeviceMetricsOverride</code> can be invoked.",
- "returns": [
- { "name": "result", "type": "boolean", "description": "If true, <code>setDeviceMetricsOverride</code> can safely be invoked on the agent." }
- ]
- },
- {
- "name": "setDeviceMetricsOverride",
- "description": "Overrides the values of device screen dimensions (window.screen.width, window.screen.height, window.innerWidth, window.innerHeight, and \"device-width\"/\"device-height\"-related CSS media query results) and the font scale factor.",
- "parameters": [
- { "name": "width", "type": "integer", "description": "Overriding width value in pixels (minimum 0, maximum 10000000). 0 disables the override." },
- { "name": "height", "type": "integer", "description": "Overriding height value in pixels (minimum 0, maximum 10000000). 0 disables the override." },
- { "name": "fontScaleFactor", "type": "number", "description": "Overriding font scale factor value (must be positive). 1 disables the override." },
- { "name": "fitWindow", "type": "boolean", "description": "Whether a view that exceeds the available browser window area should be scaled down to fit." }
- ]
- },
- {
</del><span class="cx"> "name": "setShowPaintRects",
</span><span class="cx"> "description": "Requests that backend shows paint rectangles",
</span><span class="cx"> "parameters": [
</span></span></pre></div>
<a id="trunkSourceWebInspectorUIChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebInspectorUI/ChangeLog (161401 => 161402)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebInspectorUI/ChangeLog 2014-01-07 05:15:07 UTC (rev 161401)
+++ trunk/Source/WebInspectorUI/ChangeLog 2014-01-07 05:19:38 UTC (rev 161402)
</span><span class="lines">@@ -1,5 +1,18 @@
</span><span class="cx"> 2014-01-06 Seokju Kwon <seokju@webkit.org>
</span><span class="cx">
</span><ins>+ Web Inspector: Remove canOverrideDeviceMetrics and setDeviceMetricsOverride from protocol
+ https://bugs.webkit.org/show_bug.cgi?id=126149
+
+ Reviewed by Joseph Pecoraro.
+
+ * UserInterface/InspectorWebBackendCommands.js: Remove unused codes.
+ * UserInterface/Legacy/6.0/InspectorWebBackendCommands.js: Ditto.
+ * UserInterface/Legacy/7.0/InspectorWebBackendCommands.js: Ditto.
+ * Versions/Inspector-iOS-6.0.json: Ditto.
+ * Versions/Inspector-iOS-7.0.json: Ditto.
+
+2014-01-06 Seokju Kwon <seokju@webkit.org>
+
</ins><span class="cx"> Web Inspector: Remove support for FileSystem in Frontend.
</span><span class="cx"> https://bugs.webkit.org/show_bug.cgi?id=126369
</span><span class="cx">
</span></span></pre></div>
<a id="trunkSourceWebInspectorUIUserInterfaceInspectorWebBackendCommandsjs"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebInspectorUI/UserInterface/InspectorWebBackendCommands.js (161401 => 161402)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebInspectorUI/UserInterface/InspectorWebBackendCommands.js 2014-01-07 05:15:07 UTC (rev 161401)
+++ trunk/Source/WebInspectorUI/UserInterface/InspectorWebBackendCommands.js 2014-01-07 05:19:38 UTC (rev 161402)
</span><span class="lines">@@ -260,8 +260,6 @@
</span><span class="cx"> InspectorBackend.registerCommand("Page.searchInResource", [{"name": "frameId", "type": "string", "optional": false}, {"name": "url", "type": "string", "optional": false}, {"name": "query", "type": "string", "optional": false}, {"name": "caseSensitive", "type": "boolean", "optional": true}, {"name": "isRegex", "type": "boolean", "optional": true}], ["result"]);
</span><span class="cx"> InspectorBackend.registerCommand("Page.searchInResources", [{"name": "text", "type": "string", "optional": false}, {"name": "caseSensitive", "type": "boolean", "optional": true}, {"name": "isRegex", "type": "boolean", "optional": true}], ["result"]);
</span><span class="cx"> InspectorBackend.registerCommand("Page.setDocumentContent", [{"name": "frameId", "type": "string", "optional": false}, {"name": "html", "type": "string", "optional": false}], []);
</span><del>-InspectorBackend.registerCommand("Page.canOverrideDeviceMetrics", [], ["result"]);
-InspectorBackend.registerCommand("Page.setDeviceMetricsOverride", [{"name": "width", "type": "number", "optional": false}, {"name": "height", "type": "number", "optional": false}, {"name": "fontScaleFactor", "type": "number", "optional": false}, {"name": "fitWindow", "type": "boolean", "optional": false}], []);
</del><span class="cx"> InspectorBackend.registerCommand("Page.setShowPaintRects", [{"name": "result", "type": "boolean", "optional": false}], []);
</span><span class="cx"> InspectorBackend.registerCommand("Page.canShowDebugBorders", [], ["show"]);
</span><span class="cx"> InspectorBackend.registerCommand("Page.setShowDebugBorders", [{"name": "show", "type": "boolean", "optional": false}], []);
</span></span></pre></div>
<a id="trunkSourceWebInspectorUIUserInterfaceLegacy60InspectorWebBackendCommandsjs"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebInspectorUI/UserInterface/Legacy/6.0/InspectorWebBackendCommands.js (161401 => 161402)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebInspectorUI/UserInterface/Legacy/6.0/InspectorWebBackendCommands.js 2014-01-07 05:15:07 UTC (rev 161401)
+++ trunk/Source/WebInspectorUI/UserInterface/Legacy/6.0/InspectorWebBackendCommands.js 2014-01-07 05:19:38 UTC (rev 161402)
</span><span class="lines">@@ -39,8 +39,6 @@
</span><span class="cx"> InspectorBackend.registerCommand("Page.searchInResource", [{"name": "frameId", "type": "string", "optional": false}, {"name": "url", "type": "string", "optional": false}, {"name": "query", "type": "string", "optional": false}, {"name": "caseSensitive", "type": "boolean", "optional": true}, {"name": "isRegex", "type": "boolean", "optional": true}], ["result"]);
</span><span class="cx"> InspectorBackend.registerCommand("Page.searchInResources", [{"name": "text", "type": "string", "optional": false}, {"name": "caseSensitive", "type": "boolean", "optional": true}, {"name": "isRegex", "type": "boolean", "optional": true}], ["result"]);
</span><span class="cx"> InspectorBackend.registerCommand("Page.setDocumentContent", [{"name": "frameId", "type": "string", "optional": false}, {"name": "html", "type": "string", "optional": false}], []);
</span><del>-InspectorBackend.registerCommand("Page.canOverrideDeviceMetrics", [], ["result"]);
-InspectorBackend.registerCommand("Page.setDeviceMetricsOverride", [{"name": "width", "type": "number", "optional": false}, {"name": "height", "type": "number", "optional": false}, {"name": "fontScaleFactor", "type": "number", "optional": false}, {"name": "fitWindow", "type": "boolean", "optional": false}], []);
</del><span class="cx"> InspectorBackend.registerCommand("Page.setShowPaintRects", [{"name": "result", "type": "boolean", "optional": false}], []);
</span><span class="cx"> InspectorBackend.registerCommand("Page.getScriptExecutionStatus", [], ["result"]);
</span><span class="cx"> InspectorBackend.registerCommand("Page.setScriptExecutionDisabled", [{"name": "value", "type": "boolean", "optional": false}], []);
</span></span></pre></div>
<a id="trunkSourceWebInspectorUIUserInterfaceLegacy70InspectorWebBackendCommandsjs"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebInspectorUI/UserInterface/Legacy/7.0/InspectorWebBackendCommands.js (161401 => 161402)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebInspectorUI/UserInterface/Legacy/7.0/InspectorWebBackendCommands.js 2014-01-07 05:15:07 UTC (rev 161401)
+++ trunk/Source/WebInspectorUI/UserInterface/Legacy/7.0/InspectorWebBackendCommands.js 2014-01-07 05:19:38 UTC (rev 161402)
</span><span class="lines">@@ -46,8 +46,6 @@
</span><span class="cx"> InspectorBackend.registerCommand("Page.searchInResource", [{"name": "frameId", "type": "string", "optional": false}, {"name": "url", "type": "string", "optional": false}, {"name": "query", "type": "string", "optional": false}, {"name": "caseSensitive", "type": "boolean", "optional": true}, {"name": "isRegex", "type": "boolean", "optional": true}], ["result"]);
</span><span class="cx"> InspectorBackend.registerCommand("Page.searchInResources", [{"name": "text", "type": "string", "optional": false}, {"name": "caseSensitive", "type": "boolean", "optional": true}, {"name": "isRegex", "type": "boolean", "optional": true}], ["result"]);
</span><span class="cx"> InspectorBackend.registerCommand("Page.setDocumentContent", [{"name": "frameId", "type": "string", "optional": false}, {"name": "html", "type": "string", "optional": false}], []);
</span><del>-InspectorBackend.registerCommand("Page.canOverrideDeviceMetrics", [], ["result"]);
-InspectorBackend.registerCommand("Page.setDeviceMetricsOverride", [{"name": "width", "type": "number", "optional": false}, {"name": "height", "type": "number", "optional": false}, {"name": "fontScaleFactor", "type": "number", "optional": false}, {"name": "fitWindow", "type": "boolean", "optional": false}], []);
</del><span class="cx"> InspectorBackend.registerCommand("Page.setShowPaintRects", [{"name": "result", "type": "boolean", "optional": false}], []);
</span><span class="cx"> InspectorBackend.registerCommand("Page.canShowDebugBorders", [], ["show"]);
</span><span class="cx"> InspectorBackend.registerCommand("Page.setShowDebugBorders", [{"name": "show", "type": "boolean", "optional": false}], []);
</span></span></pre></div>
<a id="trunkSourceWebInspectorUIVersionsInspectoriOS60json"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebInspectorUI/Versions/Inspector-iOS-6.0.json (161401 => 161402)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebInspectorUI/Versions/Inspector-iOS-6.0.json 2014-01-07 05:15:07 UTC (rev 161401)
+++ trunk/Source/WebInspectorUI/Versions/Inspector-iOS-6.0.json 2014-01-07 05:19:38 UTC (rev 161402)
</span><span class="lines">@@ -310,25 +310,6 @@
</span><span class="cx"> "hidden": true
</span><span class="cx"> },
</span><span class="cx"> {
</span><del>- "name": "canOverrideDeviceMetrics",
- "description": "Checks whether <code>setDeviceMetricsOverride</code> can be invoked.",
- "returns": [
- { "name": "result", "type": "boolean", "description": "If true, <code>setDeviceMetricsOverride</code> can safely be invoked on the agent." }
- ],
- "hidden": true
- },
- {
- "name": "setDeviceMetricsOverride",
- "description": "Overrides the values of device screen dimensions (window.screen.width, window.screen.height, window.innerWidth, window.innerHeight, and \"device-width\"/\"device-height\"-related CSS media query results) and the font scale factor.",
- "parameters": [
- { "name": "width", "type": "integer", "description": "Overriding width value in pixels (minimum 0, maximum 10000000). 0 disables the override." },
- { "name": "height", "type": "integer", "description": "Overriding height value in pixels (minimum 0, maximum 10000000). 0 disables the override." },
- { "name": "fontScaleFactor", "type": "number", "description": "Overriding font scale factor value (must be positive). 1 disables the override." },
- { "name": "fitWindow", "type": "boolean", "description": "Whether a view that exceeds the available browser window area should be scaled down to fit." }
- ],
- "hidden": true
- },
- {
</del><span class="cx"> "name": "setShowPaintRects",
</span><span class="cx"> "description": "Requests that backend shows paint rectangles",
</span><span class="cx"> "parameters": [
</span></span></pre></div>
<a id="trunkSourceWebInspectorUIVersionsInspectoriOS70json"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebInspectorUI/Versions/Inspector-iOS-7.0.json (161401 => 161402)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebInspectorUI/Versions/Inspector-iOS-7.0.json 2014-01-07 05:15:07 UTC (rev 161401)
+++ trunk/Source/WebInspectorUI/Versions/Inspector-iOS-7.0.json 2014-01-07 05:19:38 UTC (rev 161402)
</span><span class="lines">@@ -263,23 +263,6 @@
</span><span class="cx"> ]
</span><span class="cx"> },
</span><span class="cx"> {
</span><del>- "name": "canOverrideDeviceMetrics",
- "description": "Checks whether <code>setDeviceMetricsOverride</code> can be invoked.",
- "returns": [
- { "name": "result", "type": "boolean", "description": "If true, <code>setDeviceMetricsOverride</code> can safely be invoked on the agent." }
- ]
- },
- {
- "name": "setDeviceMetricsOverride",
- "description": "Overrides the values of device screen dimensions (window.screen.width, window.screen.height, window.innerWidth, window.innerHeight, and \"device-width\"/\"device-height\"-related CSS media query results) and the font scale factor.",
- "parameters": [
- { "name": "width", "type": "integer", "description": "Overriding width value in pixels (minimum 0, maximum 10000000). 0 disables the override." },
- { "name": "height", "type": "integer", "description": "Overriding height value in pixels (minimum 0, maximum 10000000). 0 disables the override." },
- { "name": "fontScaleFactor", "type": "number", "description": "Overriding font scale factor value (must be positive). 1 disables the override." },
- { "name": "fitWindow", "type": "boolean", "description": "Whether a view that exceeds the available browser window area should be scaled down to fit." }
- ]
- },
- {
</del><span class="cx"> "name": "setShowPaintRects",
</span><span class="cx"> "description": "Requests that backend shows paint rectangles",
</span><span class="cx"> "parameters": [
</span></span></pre></div>
<a id="trunkSourceWebKitblackberryChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit/blackberry/ChangeLog (161401 => 161402)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit/blackberry/ChangeLog 2014-01-07 05:15:07 UTC (rev 161401)
+++ trunk/Source/WebKit/blackberry/ChangeLog 2014-01-07 05:19:38 UTC (rev 161402)
</span><span class="lines">@@ -1,3 +1,13 @@
</span><ins>+2014-01-06 Seokju Kwon <seokju@webkit.org>
+
+ Web Inspector: Remove canOverrideDeviceMetrics and setDeviceMetricsOverride from protocol
+ https://bugs.webkit.org/show_bug.cgi?id=126149
+
+ Reviewed by Joseph Pecoraro.
+
+ * WebCoreSupport/InspectorClientBlackBerry.cpp: Remove dead codes.
+ * WebCoreSupport/InspectorClientBlackBerry.h: Ditto.
+
</ins><span class="cx"> 2014-01-02 Gavin Barraclough <barraclough@apple.com>
</span><span class="cx">
</span><span class="cx"> Merge didMoveOnscreen / page visibility to isVisible
</span></span></pre></div>
<a id="trunkSourceWebKitblackberryWebCoreSupportInspectorClientBlackBerrycpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit/blackberry/WebCoreSupport/InspectorClientBlackBerry.cpp (161401 => 161402)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit/blackberry/WebCoreSupport/InspectorClientBlackBerry.cpp 2014-01-07 05:15:07 UTC (rev 161401)
+++ trunk/Source/WebKit/blackberry/WebCoreSupport/InspectorClientBlackBerry.cpp 2014-01-07 05:19:38 UTC (rev 161402)
</span><span class="lines">@@ -86,11 +86,6 @@
</span><span class="cx"> m_webPagePrivate->m_client->clearCookies();
</span><span class="cx"> }
</span><span class="cx">
</span><del>-bool InspectorClientBlackBerry::canOverrideDeviceMetrics()
-{
- return true;
-}
-
</del><span class="cx"> void InspectorClientBlackBerry::overrideDeviceMetrics(int width, int height, float fontScaleFactor, bool)
</span><span class="cx"> {
</span><span class="cx"> // Note: when width and height = 0, and fontScaleFactor = 1, this is the signal for restoring to default size.
</span></span></pre></div>
<a id="trunkSourceWebKitblackberryWebCoreSupportInspectorClientBlackBerryh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit/blackberry/WebCoreSupport/InspectorClientBlackBerry.h (161401 => 161402)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit/blackberry/WebCoreSupport/InspectorClientBlackBerry.h 2014-01-07 05:15:07 UTC (rev 161401)
+++ trunk/Source/WebKit/blackberry/WebCoreSupport/InspectorClientBlackBerry.h 2014-01-07 05:19:38 UTC (rev 161402)
</span><span class="lines">@@ -55,7 +55,6 @@
</span><span class="cx"> virtual bool canClearBrowserCookies() { return true; }
</span><span class="cx"> virtual void paintInspectorOverlay(WebCore::GraphicsContext&);
</span><span class="cx">
</span><del>- virtual bool canOverrideDeviceMetrics();
</del><span class="cx"> virtual void overrideDeviceMetrics(int, int, float, bool);
</span><span class="cx"> virtual bool supportsFrameInstrumentation();
</span><span class="cx">
</span></span></pre>
</div>
</div>
</body>
</html>