<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[161360] trunk/Tools</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/161360">161360</a></dd>
<dt>Author</dt> <dd>timothy_horton@apple.com</dd>
<dt>Date</dt> <dd>2014-01-06 12:10:07 -0800 (Mon, 06 Jan 2014)</dd>
</dl>
<h3>Log Message</h3>
<pre>build.webkit.org/dashboard should still function if localStorage is disabled
https://bugs.webkit.org/show_bug.cgi?id=126511
Reviewed by Alexey Proskuryakov.
If localStorage is disabled, we should carry on with a warning.
* BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Main.js:
Don't show the gear if localStorage isn't working.
* BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/QueueView.js:
(QueueView.prototype._updateHiddenState):
Bail if localStorage isn't working.
* BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Settings.js:
(Settings.prototype.available):</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkToolsBuildSlaveSupportbuildwebkitorgconfigpublic_htmldashboardScriptsMainjs">trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Main.js</a></li>
<li><a href="#trunkToolsBuildSlaveSupportbuildwebkitorgconfigpublic_htmldashboardScriptsQueueViewjs">trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/QueueView.js</a></li>
<li><a href="#trunkToolsBuildSlaveSupportbuildwebkitorgconfigpublic_htmldashboardScriptsSettingsjs">trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Settings.js</a></li>
<li><a href="#trunkToolsChangeLog">trunk/Tools/ChangeLog</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkToolsBuildSlaveSupportbuildwebkitorgconfigpublic_htmldashboardScriptsMainjs"></a>
<div class="modfile"><h4>Modified: trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Main.js (161359 => 161360)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Main.js 2014-01-06 20:03:05 UTC (rev 161359)
+++ trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Main.js 2014-01-06 20:10:07 UTC (rev 161360)
</span><span class="lines">@@ -216,13 +216,15 @@
</span><span class="cx">
</span><span class="cx"> document.body.appendChild(table);
</span><span class="cx">
</span><del>- var settingsButton = document.createElement("div");
- settingsButton.addEventListener("click", function () { settings.toggleSettingsDisplay(); });
- settingsButton.classList.add("settings");
- document.body.appendChild(settingsButton);
</del><ins>+ if (settings.available()) {
+ var settingsButton = document.createElement("div");
+ settingsButton.addEventListener("click", function () { settings.toggleSettingsDisplay(); });
+ settingsButton.classList.add("settings");
+ document.body.appendChild(settingsButton);
</ins><span class="cx">
</span><del>- updateHiddenPlatforms();
- settings.addSettingListener("hiddenPlatforms", updateHiddenPlatforms);
</del><ins>+ updateHiddenPlatforms();
+ settings.addSettingListener("hiddenPlatforms", updateHiddenPlatforms);
+ }
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> document.addEventListener("DOMContentLoaded", documentReady);
</span></span></pre></div>
<a id="trunkToolsBuildSlaveSupportbuildwebkitorgconfigpublic_htmldashboardScriptsQueueViewjs"></a>
<div class="modfile"><h4>Modified: trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/QueueView.js (161359 => 161360)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/QueueView.js 2014-01-06 20:03:05 UTC (rev 161359)
+++ trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/QueueView.js 2014-01-06 20:10:07 UTC (rev 161360)
</span><span class="lines">@@ -64,6 +64,9 @@
</span><span class="cx">
</span><span class="cx"> _updateHiddenState: function()
</span><span class="cx"> {
</span><ins>+ if (!settings.available())
+ return;
+
</ins><span class="cx"> var hiddenPlatforms = settings.getObject("hiddenPlatforms");
</span><span class="cx"> var wasHidden = !this.updateTimer;
</span><span class="cx"> var isHidden = hiddenPlatforms && hiddenPlatforms.contains(this.platform);
</span></span></pre></div>
<a id="trunkToolsBuildSlaveSupportbuildwebkitorgconfigpublic_htmldashboardScriptsSettingsjs"></a>
<div class="modfile"><h4>Modified: trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Settings.js (161359 => 161360)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Settings.js 2014-01-06 20:03:05 UTC (rev 161359)
+++ trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Settings.js 2014-01-06 20:10:07 UTC (rev 161360)
</span><span class="lines">@@ -46,6 +46,21 @@
</span><span class="cx"> return JSON.parse(localStorage.getItem(key));
</span><span class="cx"> },
</span><span class="cx">
</span><ins>+ available: function()
+ {
+ try {
+ localStorage.setItem("testLocalStorage", "test");
+ if (localStorage.getItem("testLocalStorage") != "test")
+ return false;
+ localStorage.removeItem("testLocalStorage");
+ } catch(e) {
+ console.log("Couldn't use localStorage, settings won't work: " + e);
+ return false;
+ }
+
+ return true;
+ },
+
</ins><span class="cx"> addSettingListener: function(key, callback)
</span><span class="cx"> {
</span><span class="cx"> if (!this.changeCallbacks[key])
</span></span></pre></div>
<a id="trunkToolsChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Tools/ChangeLog (161359 => 161360)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Tools/ChangeLog 2014-01-06 20:03:05 UTC (rev 161359)
+++ trunk/Tools/ChangeLog 2014-01-06 20:10:07 UTC (rev 161360)
</span><span class="lines">@@ -1,3 +1,22 @@
</span><ins>+2014-01-06 Tim Horton <timothy_horton@apple.com>
+
+ build.webkit.org/dashboard should still function if localStorage is disabled
+ https://bugs.webkit.org/show_bug.cgi?id=126511
+
+ Reviewed by Alexey Proskuryakov.
+
+ If localStorage is disabled, we should carry on with a warning.
+
+ * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Main.js:
+ Don't show the gear if localStorage isn't working.
+
+ * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/QueueView.js:
+ (QueueView.prototype._updateHiddenState):
+ Bail if localStorage isn't working.
+
+ * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Settings.js:
+ (Settings.prototype.available):
+
</ins><span class="cx"> 2014-01-02 Roger Fong <roger_fong@apple.com>
</span><span class="cx">
</span><span class="cx"> Set VSINSTALLDIR in win ews start script.
</span></span></pre>
</div>
</div>
</body>
</html>