<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[161290] trunk/Tools</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/161290">161290</a></dd>
<dt>Author</dt> <dd>ap@apple.com</dd>
<dt>Date</dt> <dd>2014-01-03 15:38:44 -0800 (Fri, 03 Jan 2014)</dd>
</dl>
<h3>Log Message</h3>
<pre>build.webkit.org/dashboard says "failed build" even if it's another step that failed
https://bugs.webkit.org/show_bug.cgi?id=126461
Reviewed by Geoffrey Garen.
* BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotBuilderQueueView.js:
(BuildbotBuilderQueueView.prototype.update.appendBuilderQueueStatus): Link to main
build page if it's not the compilation that failed. Use text from buildbot for description.
Show a yellow icon if it's a different kind of failure.
* BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
(BuildbotIteration.prototype.update): Record whether it was compile-webkit step that failed.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkToolsBuildSlaveSupportbuildwebkitorgconfigpublic_htmldashboardScriptsBuildbotBuilderQueueViewjs">trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotBuilderQueueView.js</a></li>
<li><a href="#trunkToolsBuildSlaveSupportbuildwebkitorgconfigpublic_htmldashboardScriptsBuildbotIterationjs">trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js</a></li>
<li><a href="#trunkToolsChangeLog">trunk/Tools/ChangeLog</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkToolsBuildSlaveSupportbuildwebkitorgconfigpublic_htmldashboardScriptsBuildbotBuilderQueueViewjs"></a>
<div class="modfile"><h4>Modified: trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotBuilderQueueView.js (161289 => 161290)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotBuilderQueueView.js 2014-01-03 23:25:46 UTC (rev 161289)
+++ trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotBuilderQueueView.js 2014-01-03 23:38:44 UTC (rev 161290)
</span><span class="lines">@@ -66,15 +66,25 @@
</span><span class="cx"> if (firstRecentFailedIteration && firstRecentFailedIteration.loaded) {
</span><span class="cx"> var failureCount = queue.recentFailedIterationCount;
</span><span class="cx"> var message = this.revisionContentForIteration(firstRecentFailedIteration);
</span><del>- var url = queue.buildbot.buildLogURLForIteration(firstRecentFailedIteration);
- var status = new StatusLineView(message, StatusLineView.Status.Bad, failureCount > 1 ? "failed builds since" : "failed build", failureCount > 1 ? failureCount : null, url);
</del><ins>+ if (firstRecentFailedIteration.webkitCompilationFailed) {
+ // Link directly to compiler output.
+ // FIXME: Results JSON may contain multiple log links, including one for nicely filtered result.
+ // Which one is best to use? Do we want the filtered one in a popover?
+ var url = queue.buildbot.buildLogURLForIteration(firstRecentFailedIteration);
+ var status = StatusLineView.Status.Bad;
+ } else {
+ // Some other step failed, link to main buildbot page for the iteration.
+ var url = queue.buildbot.buildPageURLForIteration(firstRecentFailedIteration);
+ var status = StatusLineView.Status.Danger;
+ }
+ var status = new StatusLineView(message, status, failureCount > 1 ? "failures since" : firstRecentFailedIteration.text, failureCount > 1 ? failureCount : null, url);
</ins><span class="cx"> this.element.appendChild(status.element);
</span><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> var mostRecentSuccessfulIteration = queue.mostRecentSuccessfulIteration;
</span><span class="cx"> if (mostRecentSuccessfulIteration && mostRecentSuccessfulIteration.loaded) {
</span><span class="cx"> var message = this.revisionContentForIteration(mostRecentSuccessfulIteration);
</span><del>- var url = queue.buildbot.buildLogURLForIteration(mostRecentSuccessfulIteration);
</del><ins>+ var url = queue.buildbot.buildPageURLForIteration(mostRecentSuccessfulIteration);
</ins><span class="cx"> var status = new StatusLineView(message, StatusLineView.Status.Good, firstRecentFailedIteration ? "last successful build" : "latest build", null, url);
</span><span class="cx"> this.element.appendChild(status.element);
</span><span class="cx"> } else {
</span></span></pre></div>
<a id="trunkToolsBuildSlaveSupportbuildwebkitorgconfigpublic_htmldashboardScriptsBuildbotIterationjs"></a>
<div class="modfile"><h4>Modified: trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js (161289 => 161290)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js 2014-01-03 23:25:46 UTC (rev 161289)
+++ trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js 2014-01-03 23:38:44 UTC (rev 161290)
</span><span class="lines">@@ -48,6 +48,14 @@
</span><span class="cx">
</span><span class="cx"> BaseObject.addConstructorFunctions(BuildbotIteration);
</span><span class="cx">
</span><ins>+// JSON result values for both individual steps and the whole iteration.
+BuildbotIteration.SUCCESS = 0;
+BuildbotIteration.WARNINGS = 1;
+BuildbotIteration.FAILURE = 2;
+BuildbotIteration.SKIPPED = 3;
+BuildbotIteration.EXCEPTION = 4;
+BuildbotIteration.RETRY = 5;
+
</ins><span class="cx"> BuildbotIteration.Event = {
</span><span class="cx"> Updated: "updated"
</span><span class="cx"> };
</span><span class="lines">@@ -154,6 +162,10 @@
</span><span class="cx"> var internalRevisionProperty = data.properties.findFirst(function(property) { return property[0] === "internal_got_revision"; });
</span><span class="cx"> this.internalRevision = internalRevisionProperty ? parseInt(internalRevisionProperty[1], 10) : null;
</span><span class="cx">
</span><ins>+ var compileWebKitStep = data.steps.findFirst(function(step) { return step.name === "compile-webkit"; });
+ if (compileWebKitStep)
+ this.webkitCompilationFailed = compileWebKitStep.results[0] !== BuildbotIteration.SUCCESS;
+
</ins><span class="cx"> var layoutTestResults = collectTestResults.call(this, data, "layout-test");
</span><span class="cx"> this.layoutTestResults = layoutTestResults ? new BuildbotTestResults(this, layoutTestResults) : null;
</span><span class="cx">
</span><span class="lines">@@ -174,10 +186,8 @@
</span><span class="cx">
</span><span class="cx"> this.loaded = true;
</span><span class="cx">
</span><del>- // Results values (same for the iteration and for each of its steps):
- // SUCCESS: 0, WARNINGS: 1, FAILURE: 2, SKIPPED: 3, EXCEPTION: 4, RETRY: 5.
</del><span class="cx"> this.failed = !!data.results;
</span><del>- this.willRetry = data.results === 5;
</del><ins>+ this.willRetry = data.results === BuildbotIteration.RETRY;
</ins><span class="cx">
</span><span class="cx"> this.text = data.text.join(" ");
</span><span class="cx">
</span></span></pre></div>
<a id="trunkToolsChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Tools/ChangeLog (161289 => 161290)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Tools/ChangeLog 2014-01-03 23:25:46 UTC (rev 161289)
+++ trunk/Tools/ChangeLog 2014-01-03 23:38:44 UTC (rev 161290)
</span><span class="lines">@@ -1,3 +1,18 @@
</span><ins>+2014-01-03 Alexey Proskuryakov <ap@apple.com>
+
+ build.webkit.org/dashboard says "failed build" even if it's another step that failed
+ https://bugs.webkit.org/show_bug.cgi?id=126461
+
+ Reviewed by Geoffrey Garen.
+
+ * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotBuilderQueueView.js:
+ (BuildbotBuilderQueueView.prototype.update.appendBuilderQueueStatus): Link to main
+ build page if it's not the compilation that failed. Use text from buildbot for description.
+ Show a yellow icon if it's a different kind of failure.
+
+ * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
+ (BuildbotIteration.prototype.update): Record whether it was compile-webkit step that failed.
+
</ins><span class="cx"> 2014-01-03 Bem Jones-Bey <bjonesbe@adobe.com>
</span><span class="cx">
</span><span class="cx"> setup-git-clone fails to get email address from git
</span></span></pre>
</div>
</div>
</body>
</html>