<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[161167] trunk/Source/WebCore</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/161167">161167</a></dd>
<dt>Author</dt> <dd>akling@apple.com</dd>
<dt>Date</dt> <dd>2013-12-30 19:02:25 -0800 (Mon, 30 Dec 2013)</dd>
</dl>
<h3>Log Message</h3>
<pre>InputType should return input renderers wrapped in RenderPtr.
<https://webkit.org/b/126307>
Rename InputType::createRenderer() to createInputRenderer() and
make it return RenderPtr<RenderElement>. Also made it non-const.
Reviewed by Anders Carlsson.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkSourceWebCoreChangeLog">trunk/Source/WebCore/ChangeLog</a></li>
<li><a href="#trunkSourceWebCorehtmlBaseButtonInputTypecpp">trunk/Source/WebCore/html/BaseButtonInputType.cpp</a></li>
<li><a href="#trunkSourceWebCorehtmlBaseButtonInputTypeh">trunk/Source/WebCore/html/BaseButtonInputType.h</a></li>
<li><a href="#trunkSourceWebCorehtmlFileInputTypecpp">trunk/Source/WebCore/html/FileInputType.cpp</a></li>
<li><a href="#trunkSourceWebCorehtmlFileInputTypeh">trunk/Source/WebCore/html/FileInputType.h</a></li>
<li><a href="#trunkSourceWebCorehtmlHTMLInputElementcpp">trunk/Source/WebCore/html/HTMLInputElement.cpp</a></li>
<li><a href="#trunkSourceWebCorehtmlHiddenInputTypecpp">trunk/Source/WebCore/html/HiddenInputType.cpp</a></li>
<li><a href="#trunkSourceWebCorehtmlHiddenInputTypeh">trunk/Source/WebCore/html/HiddenInputType.h</a></li>
<li><a href="#trunkSourceWebCorehtmlImageInputTypecpp">trunk/Source/WebCore/html/ImageInputType.cpp</a></li>
<li><a href="#trunkSourceWebCorehtmlImageInputTypeh">trunk/Source/WebCore/html/ImageInputType.h</a></li>
<li><a href="#trunkSourceWebCorehtmlInputTypecpp">trunk/Source/WebCore/html/InputType.cpp</a></li>
<li><a href="#trunkSourceWebCorehtmlInputTypeh">trunk/Source/WebCore/html/InputType.h</a></li>
<li><a href="#trunkSourceWebCorehtmlRangeInputTypecpp">trunk/Source/WebCore/html/RangeInputType.cpp</a></li>
<li><a href="#trunkSourceWebCorehtmlRangeInputTypeh">trunk/Source/WebCore/html/RangeInputType.h</a></li>
<li><a href="#trunkSourceWebCorehtmlSearchInputTypecpp">trunk/Source/WebCore/html/SearchInputType.cpp</a></li>
<li><a href="#trunkSourceWebCorehtmlSearchInputTypeh">trunk/Source/WebCore/html/SearchInputType.h</a></li>
<li><a href="#trunkSourceWebCorehtmlTextFieldInputTypecpp">trunk/Source/WebCore/html/TextFieldInputType.cpp</a></li>
<li><a href="#trunkSourceWebCorehtmlTextFieldInputTypeh">trunk/Source/WebCore/html/TextFieldInputType.h</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkSourceWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/ChangeLog (161166 => 161167)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/ChangeLog 2013-12-31 02:58:28 UTC (rev 161166)
+++ trunk/Source/WebCore/ChangeLog 2013-12-31 03:02:25 UTC (rev 161167)
</span><span class="lines">@@ -1,3 +1,13 @@
</span><ins>+2013-12-30 Andreas Kling <akling@apple.com>
+
+ InputType should return input renderers wrapped in RenderPtr.
+ <https://webkit.org/b/126307>
+
+ Rename InputType::createRenderer() to createInputRenderer() and
+ make it return RenderPtr<RenderElement>. Also made it non-const.
+
+ Reviewed by Anders Carlsson.
+
</ins><span class="cx"> 2013-12-30 Gyuyoung Kim <gyuyoung.kim@samsung.com>
</span><span class="cx">
</span><span class="cx"> Cleanup static_cast<HTMLFormElement*> by using toHTMLFormElement()
</span></span></pre></div>
<a id="trunkSourceWebCorehtmlBaseButtonInputTypecpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/html/BaseButtonInputType.cpp (161166 => 161167)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/html/BaseButtonInputType.cpp 2013-12-31 02:58:28 UTC (rev 161166)
+++ trunk/Source/WebCore/html/BaseButtonInputType.cpp 2013-12-31 03:02:25 UTC (rev 161167)
</span><span class="lines">@@ -52,9 +52,9 @@
</span><span class="cx"> return false;
</span><span class="cx"> }
</span><span class="cx">
</span><del>-RenderElement* BaseButtonInputType::createRenderer(PassRef<RenderStyle> style) const
</del><ins>+RenderPtr<RenderElement> BaseButtonInputType::createInputRenderer(PassRef<RenderStyle> style)
</ins><span class="cx"> {
</span><del>- return new RenderButton(element(), std::move(style));
</del><ins>+ return createRenderer<RenderButton>(element(), std::move(style));
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> bool BaseButtonInputType::storesValueSeparateFromAttribute()
</span></span></pre></div>
<a id="trunkSourceWebCorehtmlBaseButtonInputTypeh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/html/BaseButtonInputType.h (161166 => 161167)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/html/BaseButtonInputType.h 2013-12-31 02:58:28 UTC (rev 161166)
+++ trunk/Source/WebCore/html/BaseButtonInputType.h 2013-12-31 03:02:25 UTC (rev 161167)
</span><span class="lines">@@ -43,7 +43,7 @@
</span><span class="cx"> private:
</span><span class="cx"> virtual bool shouldSaveAndRestoreFormControlState() const OVERRIDE;
</span><span class="cx"> virtual bool appendFormData(FormDataList&, bool) const OVERRIDE;
</span><del>- virtual RenderElement* createRenderer(PassRef<RenderStyle>) const OVERRIDE;
</del><ins>+ virtual RenderPtr<RenderElement> createInputRenderer(PassRef<RenderStyle>) OVERRIDE;
</ins><span class="cx"> virtual bool storesValueSeparateFromAttribute() OVERRIDE;
</span><span class="cx"> virtual void setValue(const String&, bool, TextFieldEventBehavior) OVERRIDE;
</span><span class="cx"> };
</span></span></pre></div>
<a id="trunkSourceWebCorehtmlFileInputTypecpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/html/FileInputType.cpp (161166 => 161167)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/html/FileInputType.cpp 2013-12-31 02:58:28 UTC (rev 161166)
+++ trunk/Source/WebCore/html/FileInputType.cpp 2013-12-31 03:02:25 UTC (rev 161167)
</span><span class="lines">@@ -208,9 +208,9 @@
</span><span class="cx"> event->setDefaultHandled();
</span><span class="cx"> }
</span><span class="cx">
</span><del>-RenderElement* FileInputType::createRenderer(PassRef<RenderStyle> style) const
</del><ins>+RenderPtr<RenderElement> FileInputType::createInputRenderer(PassRef<RenderStyle> style)
</ins><span class="cx"> {
</span><del>- return new RenderFileUploadControl(element(), std::move(style));
</del><ins>+ return createRenderer<RenderFileUploadControl>(element(), std::move(style));
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> bool FileInputType::canSetStringValue() const
</span></span></pre></div>
<a id="trunkSourceWebCorehtmlFileInputTypeh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/html/FileInputType.h (161166 => 161167)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/html/FileInputType.h 2013-12-31 02:58:28 UTC (rev 161166)
+++ trunk/Source/WebCore/html/FileInputType.h 2013-12-31 03:02:25 UTC (rev 161167)
</span><span class="lines">@@ -58,7 +58,7 @@
</span><span class="cx"> virtual bool valueMissing(const String&) const OVERRIDE;
</span><span class="cx"> virtual String valueMissingText() const OVERRIDE;
</span><span class="cx"> virtual void handleDOMActivateEvent(Event*) OVERRIDE;
</span><del>- virtual RenderElement* createRenderer(PassRef<RenderStyle>) const OVERRIDE;
</del><ins>+ virtual RenderPtr<RenderElement> createInputRenderer(PassRef<RenderStyle>) OVERRIDE;
</ins><span class="cx"> virtual bool canSetStringValue() const OVERRIDE;
</span><span class="cx"> virtual bool canChangeFromAnotherType() const OVERRIDE;
</span><span class="cx"> virtual FileList* files() OVERRIDE;
</span></span></pre></div>
<a id="trunkSourceWebCorehtmlHTMLInputElementcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/html/HTMLInputElement.cpp (161166 => 161167)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/html/HTMLInputElement.cpp 2013-12-31 02:58:28 UTC (rev 161166)
+++ trunk/Source/WebCore/html/HTMLInputElement.cpp 2013-12-31 03:02:25 UTC (rev 161167)
</span><span class="lines">@@ -782,7 +782,7 @@
</span><span class="cx">
</span><span class="cx"> RenderElement* HTMLInputElement::createRenderer(PassRef<RenderStyle> style)
</span><span class="cx"> {
</span><del>- return m_inputType->createRenderer(std::move(style));
</del><ins>+ return m_inputType->createInputRenderer(std::move(style)).leakPtr();
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> void HTMLInputElement::willAttachRenderers()
</span></span></pre></div>
<a id="trunkSourceWebCorehtmlHiddenInputTypecpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/html/HiddenInputType.cpp (161166 => 161167)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/html/HiddenInputType.cpp 2013-12-31 02:58:28 UTC (rev 161166)
+++ trunk/Source/WebCore/html/HiddenInputType.cpp 2013-12-31 03:02:25 UTC (rev 161167)
</span><span class="lines">@@ -37,6 +37,7 @@
</span><span class="cx"> #include "HTMLInputElement.h"
</span><span class="cx"> #include "HTMLNames.h"
</span><span class="cx"> #include "InputTypeNames.h"
</span><ins>+#include "RenderElement.h"
</ins><span class="cx">
</span><span class="cx"> namespace WebCore {
</span><span class="cx">
</span><span class="lines">@@ -66,10 +67,10 @@
</span><span class="cx"> return false;
</span><span class="cx"> }
</span><span class="cx">
</span><del>-RenderElement* HiddenInputType::createRenderer(PassRef<RenderStyle>) const
</del><ins>+RenderPtr<RenderElement> HiddenInputType::createInputRenderer(PassRef<RenderStyle>)
</ins><span class="cx"> {
</span><span class="cx"> ASSERT_NOT_REACHED();
</span><del>- return 0;
</del><ins>+ return nullptr;
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> void HiddenInputType::accessKeyAction(bool)
</span></span></pre></div>
<a id="trunkSourceWebCorehtmlHiddenInputTypeh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/html/HiddenInputType.h (161166 => 161167)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/html/HiddenInputType.h 2013-12-31 02:58:28 UTC (rev 161166)
+++ trunk/Source/WebCore/html/HiddenInputType.h 2013-12-31 03:02:25 UTC (rev 161167)
</span><span class="lines">@@ -44,7 +44,7 @@
</span><span class="cx"> virtual FormControlState saveFormControlState() const OVERRIDE;
</span><span class="cx"> virtual void restoreFormControlState(const FormControlState&) OVERRIDE;
</span><span class="cx"> virtual bool supportsValidation() const OVERRIDE;
</span><del>- virtual RenderElement* createRenderer(PassRef<RenderStyle>) const OVERRIDE;
</del><ins>+ virtual RenderPtr<RenderElement> createInputRenderer(PassRef<RenderStyle>) OVERRIDE;
</ins><span class="cx"> virtual void accessKeyAction(bool sendMouseEvents) OVERRIDE;
</span><span class="cx"> virtual bool rendererIsNeeded() OVERRIDE;
</span><span class="cx"> virtual bool storesValueSeparateFromAttribute() OVERRIDE;
</span></span></pre></div>
<a id="trunkSourceWebCorehtmlImageInputTypecpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/html/ImageInputType.cpp (161166 => 161167)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/html/ImageInputType.cpp 2013-12-31 02:58:28 UTC (rev 161166)
+++ trunk/Source/WebCore/html/ImageInputType.cpp 2013-12-31 03:02:25 UTC (rev 161167)
</span><span class="lines">@@ -101,11 +101,11 @@
</span><span class="cx"> event->setDefaultHandled();
</span><span class="cx"> }
</span><span class="cx">
</span><del>-RenderElement* ImageInputType::createRenderer(PassRef<RenderStyle> style) const
</del><ins>+RenderPtr<RenderElement> ImageInputType::createInputRenderer(PassRef<RenderStyle> style)
</ins><span class="cx"> {
</span><del>- RenderImage* image = new RenderImage(element(), std::move(style));
</del><ins>+ auto image = createRenderer<RenderImage>(element(), std::move(style));
</ins><span class="cx"> image->setImageResource(RenderImageResource::create());
</span><del>- return image;
</del><ins>+ return std::move(image);
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> void ImageInputType::altAttributeChanged()
</span></span></pre></div>
<a id="trunkSourceWebCorehtmlImageInputTypeh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/html/ImageInputType.h (161166 => 161167)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/html/ImageInputType.h 2013-12-31 02:58:28 UTC (rev 161166)
+++ trunk/Source/WebCore/html/ImageInputType.h 2013-12-31 03:02:25 UTC (rev 161167)
</span><span class="lines">@@ -47,7 +47,7 @@
</span><span class="cx"> virtual bool isFormDataAppendable() const OVERRIDE;
</span><span class="cx"> virtual bool appendFormData(FormDataList&, bool) const OVERRIDE;
</span><span class="cx"> virtual bool supportsValidation() const OVERRIDE;
</span><del>- virtual RenderElement* createRenderer(PassRef<RenderStyle>) const OVERRIDE;
</del><ins>+ virtual RenderPtr<RenderElement> createInputRenderer(PassRef<RenderStyle>) OVERRIDE;
</ins><span class="cx"> virtual void handleDOMActivateEvent(Event*) OVERRIDE;
</span><span class="cx"> virtual void altAttributeChanged() OVERRIDE;
</span><span class="cx"> virtual void srcAttributeChanged() OVERRIDE;
</span></span></pre></div>
<a id="trunkSourceWebCorehtmlInputTypecpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/html/InputType.cpp (161166 => 161167)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/html/InputType.cpp 2013-12-31 02:58:28 UTC (rev 161166)
+++ trunk/Source/WebCore/html/InputType.cpp 2013-12-31 03:02:25 UTC (rev 161167)
</span><span class="lines">@@ -479,9 +479,9 @@
</span><span class="cx"> return element().form();
</span><span class="cx"> }
</span><span class="cx">
</span><del>-RenderElement* InputType::createRenderer(PassRef<RenderStyle> style) const
</del><ins>+RenderPtr<RenderElement> InputType::createInputRenderer(PassRef<RenderStyle> style)
</ins><span class="cx"> {
</span><del>- return RenderElement::createFor(element(), std::move(style));
</del><ins>+ return RenderPtr<RenderElement>(RenderElement::createFor(element(), std::move(style)));
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> void InputType::blur()
</span></span></pre></div>
<a id="trunkSourceWebCorehtmlInputTypeh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/html/InputType.h (161166 => 161167)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/html/InputType.h 2013-12-31 02:58:28 UTC (rev 161166)
+++ trunk/Source/WebCore/html/InputType.h 2013-12-31 03:02:25 UTC (rev 161167)
</span><span class="lines">@@ -35,6 +35,7 @@
</span><span class="cx">
</span><span class="cx"> #include "FeatureObserver.h"
</span><span class="cx"> #include "HTMLTextFormControlElement.h"
</span><ins>+#include "RenderPtr.h"
</ins><span class="cx"> #include "StepRange.h"
</span><span class="cx"> #include <wtf/FastMalloc.h>
</span><span class="cx"> #include <wtf/Forward.h>
</span><span class="lines">@@ -236,7 +237,7 @@
</span><span class="cx"> // Miscellaneous functions
</span><span class="cx">
</span><span class="cx"> virtual bool rendererIsNeeded();
</span><del>- virtual RenderElement* createRenderer(PassRef<RenderStyle>) const;
</del><ins>+ virtual RenderPtr<RenderElement> createInputRenderer(PassRef<RenderStyle>);
</ins><span class="cx"> virtual void addSearchResult();
</span><span class="cx"> virtual void attach();
</span><span class="cx"> virtual void detach();
</span></span></pre></div>
<a id="trunkSourceWebCorehtmlRangeInputTypecpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/html/RangeInputType.cpp (161166 => 161167)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/html/RangeInputType.cpp 2013-12-31 02:58:28 UTC (rev 161166)
+++ trunk/Source/WebCore/html/RangeInputType.cpp 2013-12-31 03:02:25 UTC (rev 161167)
</span><span class="lines">@@ -289,9 +289,9 @@
</span><span class="cx"> return &typedSliderThumbElement();
</span><span class="cx"> }
</span><span class="cx">
</span><del>-RenderElement* RangeInputType::createRenderer(PassRef<RenderStyle> style) const
</del><ins>+RenderPtr<RenderElement> RangeInputType::createInputRenderer(PassRef<RenderStyle> style)
</ins><span class="cx"> {
</span><del>- return new RenderSlider(element(), std::move(style));
</del><ins>+ return createRenderer<RenderSlider>(element(), std::move(style));
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> Decimal RangeInputType::parseToNumber(const String& src, const Decimal& defaultValue) const
</span></span></pre></div>
<a id="trunkSourceWebCorehtmlRangeInputTypeh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/html/RangeInputType.h (161166 => 161167)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/html/RangeInputType.h 2013-12-31 02:58:28 UTC (rev 161166)
+++ trunk/Source/WebCore/html/RangeInputType.h 2013-12-31 03:02:25 UTC (rev 161167)
</span><span class="lines">@@ -55,7 +55,7 @@
</span><span class="cx"> virtual void handleMouseDownEvent(MouseEvent*) OVERRIDE;
</span><span class="cx"> #endif
</span><span class="cx"> virtual void handleKeydownEvent(KeyboardEvent*) OVERRIDE;
</span><del>- virtual RenderElement* createRenderer(PassRef<RenderStyle>) const OVERRIDE;
</del><ins>+ virtual RenderPtr<RenderElement> createInputRenderer(PassRef<RenderStyle>) OVERRIDE;
</ins><span class="cx"> virtual void createShadowSubtree() OVERRIDE;
</span><span class="cx"> virtual Decimal parseToNumber(const String&, const Decimal&) const OVERRIDE;
</span><span class="cx"> virtual String serialize(const Decimal&) const OVERRIDE;
</span></span></pre></div>
<a id="trunkSourceWebCorehtmlSearchInputTypecpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/html/SearchInputType.cpp (161166 => 161167)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/html/SearchInputType.cpp 2013-12-31 02:58:28 UTC (rev 161166)
+++ trunk/Source/WebCore/html/SearchInputType.cpp 2013-12-31 03:02:25 UTC (rev 161167)
</span><span class="lines">@@ -65,9 +65,9 @@
</span><span class="cx"> #endif
</span><span class="cx"> }
</span><span class="cx">
</span><del>-RenderElement* SearchInputType::createRenderer(PassRef<RenderStyle> style) const
</del><ins>+RenderPtr<RenderElement> SearchInputType::createInputRenderer(PassRef<RenderStyle> style)
</ins><span class="cx"> {
</span><del>- return new RenderSearchField(element(), std::move(style));
</del><ins>+ return createRenderer<RenderSearchField>(element(), std::move(style));
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> const AtomicString& SearchInputType::formControlType() const
</span></span></pre></div>
<a id="trunkSourceWebCorehtmlSearchInputTypeh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/html/SearchInputType.h (161166 => 161167)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/html/SearchInputType.h 2013-12-31 02:58:28 UTC (rev 161166)
+++ trunk/Source/WebCore/html/SearchInputType.h 2013-12-31 03:02:25 UTC (rev 161167)
</span><span class="lines">@@ -48,7 +48,7 @@
</span><span class="cx"> private:
</span><span class="cx"> virtual void attach() OVERRIDE;
</span><span class="cx"> virtual void addSearchResult() OVERRIDE;
</span><del>- virtual RenderElement* createRenderer(PassRef<RenderStyle>) const OVERRIDE;
</del><ins>+ virtual RenderPtr<RenderElement> createInputRenderer(PassRef<RenderStyle>) OVERRIDE;
</ins><span class="cx"> virtual const AtomicString& formControlType() const OVERRIDE;
</span><span class="cx"> virtual bool shouldRespectSpeechAttribute() OVERRIDE;
</span><span class="cx"> virtual bool isSearchField() const OVERRIDE;
</span></span></pre></div>
<a id="trunkSourceWebCorehtmlTextFieldInputTypecpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/html/TextFieldInputType.cpp (161166 => 161167)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/html/TextFieldInputType.cpp 2013-12-31 02:58:28 UTC (rev 161166)
+++ trunk/Source/WebCore/html/TextFieldInputType.cpp 2013-12-31 03:02:25 UTC (rev 161167)
</span><span class="lines">@@ -205,9 +205,9 @@
</span><span class="cx"> return (event->type() == eventNames().textInputEvent && event->eventInterface() == TextEventInterfaceType && static_cast<TextEvent*>(event)->data() == "\n") || InputType::shouldSubmitImplicitly(event);
</span><span class="cx"> }
</span><span class="cx">
</span><del>-RenderElement* TextFieldInputType::createRenderer(PassRef<RenderStyle> style) const
</del><ins>+RenderPtr<RenderElement> TextFieldInputType::createInputRenderer(PassRef<RenderStyle> style)
</ins><span class="cx"> {
</span><del>- return new RenderTextControlSingleLine(element(), std::move(style));
</del><ins>+ return createRenderer<RenderTextControlSingleLine>(element(), std::move(style));
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> bool TextFieldInputType::needsContainer() const
</span></span></pre></div>
<a id="trunkSourceWebCorehtmlTextFieldInputTypeh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/html/TextFieldInputType.h (161166 => 161167)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/html/TextFieldInputType.h 2013-12-31 02:58:28 UTC (rev 161166)
+++ trunk/Source/WebCore/html/TextFieldInputType.h 2013-12-31 03:02:25 UTC (rev 161167)
</span><span class="lines">@@ -88,7 +88,7 @@
</span><span class="cx"> virtual void handleBeforeTextInsertedEvent(BeforeTextInsertedEvent*) OVERRIDE;
</span><span class="cx"> virtual void forwardEvent(Event*) OVERRIDE;
</span><span class="cx"> virtual bool shouldSubmitImplicitly(Event*) OVERRIDE;
</span><del>- virtual RenderElement* createRenderer(PassRef<RenderStyle>) const OVERRIDE;
</del><ins>+ virtual RenderPtr<RenderElement> createInputRenderer(PassRef<RenderStyle>) OVERRIDE;
</ins><span class="cx"> virtual bool shouldUseInputMethod() const OVERRIDE;
</span><span class="cx"> #if !PLATFORM(IOS)
</span><span class="cx"> virtual String sanitizeValue(const String&) const OVERRIDE;
</span></span></pre>
</div>
</div>
</body>
</html>