<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[161124] trunk/Tools</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/161124">161124</a></dd>
<dt>Author</dt> <dd>ap@apple.com</dd>
<dt>Date</dt> <dd>2013-12-29 13:17:29 -0800 (Sun, 29 Dec 2013)</dd>
</dl>
<h3>Log Message</h3>
<pre>Please display (and link to) revision ranges at build.webkit.org/dashboard
https://bugs.webkit.org/show_bug.cgi?id=122187
Reviewed by Timothy Hatcher.
Added popovers for revision numbers. Removed direct links, because they were misleading -
a test run covers a revision range, not just the latest revision. This also makes
selecting a revision for copy easier.
All revision numbers have the popovers for consistency, although they are most useful
for iterations that are not the last ones in a view, because the content is a delta
from previous iteration.
* BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotBuilderQueueView.js:
(BuildbotBuilderQueueView.prototype.update.appendBuilderQueueStatus):
revisionLinksForIteration() is now named revisionContentForIteration().
* BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
(BuildbotTesterQueueView.prototype.update.appendBuilderQueueStatus):
Ditto.
* BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
(BuildbotIteration.prototype.get previous): Added a function to go back in iteration history.
* BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
Refactored to support the new popover variation. Replaced revisionLinksForIteration()
with a function that builds an element with popover.
* BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/PopoverTracker.js:
Changed to take a function for popover presentation instead of delegate object.
We only need one delegate function, and it's easier to have multiple popovers per view class
this way.
* BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
Removed a rule for selectable class. It's replaced with a semantic rule in StatusLineView.css.
* BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/QueueView.css:
Renamed pending-commits-popover class to commit-history-popover.
* BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/StatusLineView.css:
(.status-line .message .revision-number): Added a rule for revision numbers.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkToolsBuildSlaveSupportbuildwebkitorgconfigpublic_htmldashboardScriptsBuildbotBuilderQueueViewjs">trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotBuilderQueueView.js</a></li>
<li><a href="#trunkToolsBuildSlaveSupportbuildwebkitorgconfigpublic_htmldashboardScriptsBuildbotIterationjs">trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js</a></li>
<li><a href="#trunkToolsBuildSlaveSupportbuildwebkitorgconfigpublic_htmldashboardScriptsBuildbotQueueViewjs">trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js</a></li>
<li><a href="#trunkToolsBuildSlaveSupportbuildwebkitorgconfigpublic_htmldashboardScriptsBuildbotTesterQueueViewjs">trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js</a></li>
<li><a href="#trunkToolsBuildSlaveSupportbuildwebkitorgconfigpublic_htmldashboardScriptsPopoverTrackerjs">trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/PopoverTracker.js</a></li>
<li><a href="#trunkToolsBuildSlaveSupportbuildwebkitorgconfigpublic_htmldashboardStylesMaincss">trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css</a></li>
<li><a href="#trunkToolsBuildSlaveSupportbuildwebkitorgconfigpublic_htmldashboardStylesQueueViewcss">trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/QueueView.css</a></li>
<li><a href="#trunkToolsBuildSlaveSupportbuildwebkitorgconfigpublic_htmldashboardStylesStatusLineViewcss">trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/StatusLineView.css</a></li>
<li><a href="#trunkToolsChangeLog">trunk/Tools/ChangeLog</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkToolsBuildSlaveSupportbuildwebkitorgconfigpublic_htmldashboardScriptsBuildbotBuilderQueueViewjs"></a>
<div class="modfile"><h4>Modified: trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotBuilderQueueView.js (161123 => 161124)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotBuilderQueueView.js 2013-12-29 20:57:32 UTC (rev 161123)
+++ trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotBuilderQueueView.js 2013-12-29 21:17:29 UTC (rev 161124)
</span><span class="lines">@@ -65,7 +65,7 @@
</span><span class="cx"> var firstRecentFailedIteration = queue.firstRecentFailedIteration;
</span><span class="cx"> if (firstRecentFailedIteration && firstRecentFailedIteration.loaded) {
</span><span class="cx"> var failureCount = queue.recentFailedIterationCount;
</span><del>- var message = this.revisionLinksForIteration(firstRecentFailedIteration);
</del><ins>+ var message = this.revisionContentForIteration(firstRecentFailedIteration);
</ins><span class="cx"> var url = queue.buildbot.buildLogURLForIteration(firstRecentFailedIteration);
</span><span class="cx"> var status = new StatusLineView(message, StatusLineView.Status.Bad, failureCount > 1 ? "failed builds since" : "failed build", failureCount > 1 ? failureCount : null, url);
</span><span class="cx"> this.element.appendChild(status.element);
</span><span class="lines">@@ -73,7 +73,7 @@
</span><span class="cx">
</span><span class="cx"> var mostRecentSuccessfulIteration = queue.mostRecentSuccessfulIteration;
</span><span class="cx"> if (mostRecentSuccessfulIteration && mostRecentSuccessfulIteration.loaded) {
</span><del>- var message = this.revisionLinksForIteration(mostRecentSuccessfulIteration);
</del><ins>+ var message = this.revisionContentForIteration(mostRecentSuccessfulIteration);
</ins><span class="cx"> var url = queue.buildbot.buildLogURLForIteration(mostRecentSuccessfulIteration);
</span><span class="cx"> var status = new StatusLineView(message, StatusLineView.Status.Good, firstRecentFailedIteration ? "last successful build" : "latest build", null, url);
</span><span class="cx"> this.element.appendChild(status.element);
</span></span></pre></div>
<a id="trunkToolsBuildSlaveSupportbuildwebkitorgconfigpublic_htmldashboardScriptsBuildbotIterationjs"></a>
<div class="modfile"><h4>Modified: trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js (161123 => 161124)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js 2013-12-29 20:57:32 UTC (rev 161123)
+++ trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js 2013-12-29 21:17:29 UTC (rev 161124)
</span><span class="lines">@@ -66,6 +66,15 @@
</span><span class="cx"> this._finished = x;
</span><span class="cx"> },
</span><span class="cx">
</span><ins>+ get previous()
+ {
+ for (var i = 0; i < this.queue.iterations.length - 1; ++i) {
+ if (this.queue.iterations[i] === this)
+ return this.queue.iterations[i + 1];
+ }
+ return null;
+ },
+
</ins><span class="cx"> update: function()
</span><span class="cx"> {
</span><span class="cx"> if (this.loaded && this._finished)
</span></span></pre></div>
<a id="trunkToolsBuildSlaveSupportbuildwebkitorgconfigpublic_htmldashboardScriptsBuildbotQueueViewjs"></a>
<div class="modfile"><h4>Modified: trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js (161123 => 161124)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js 2013-12-29 20:57:32 UTC (rev 161123)
+++ trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js 2013-12-29 21:17:29 UTC (rev 161124)
</span><span class="lines">@@ -105,15 +105,11 @@
</span><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> if (status)
</span><del>- new PopoverTracker(status.messageElement, this, queue);
</del><ins>+ new PopoverTracker(status.messageElement, this._presentPopoverForPendingCommits.bind(this), queue);
</ins><span class="cx"> },
</span><span class="cx">
</span><del>- presentPopoverForElement: function(element, popover, queue)
</del><ins>+ _popoverLinesForCommitRange: function(trac, firstRevisionNumber, lastRevisionNumber)
</ins><span class="cx"> {
</span><del>- var latestFinishedIteration = this._latestFinishedIteration(queue);
- if (!latestFinishedIteration)
- return false;
-
</del><span class="cx"> function lineForCommit(trac, commit)
</span><span class="cx"> {
</span><span class="cx"> var result = document.createElement("div");
</span><span class="lines">@@ -139,64 +135,128 @@
</span><span class="cx"> return result;
</span><span class="cx"> }
</span><span class="cx">
</span><del>- var content = document.createElement("div");
- content.className = "pending-commits-popover";
</del><ins>+ // This function only adds lines about commits that the trac object knows about.
+ // Alternatively, it could add links without info and/or trigger loading additional
+ // data, but this probably doesn't matter for Dashboard use.
+ var result = [];
+ for (var i = trac.recordedCommits.length - 1; i >= 0; --i) {
+ var commit = trac.recordedCommits[i];
+ if (commit.revisionNumber > lastRevisionNumber)
+ continue;
</ins><span class="cx">
</span><del>- for (var i = webkitTrac.recordedCommits.length - 1; i >= 0; --i) {
- var commit = webkitTrac.recordedCommits[i];
- if (commit.revisionNumber <= latestFinishedIteration.openSourceRevision)
</del><ins>+ if (commit.revisionNumber < firstRevisionNumber)
</ins><span class="cx"> break;
</span><span class="cx">
</span><del>- content.appendChild(lineForCommit(webkitTrac, commit));
</del><ins>+ result.push(lineForCommit(trac, commit));
</ins><span class="cx"> }
</span><span class="cx">
</span><del>- if (latestFinishedIteration.internalRevision && internalTrac.latestRecordedRevisionNumber) {
- if (latestFinishedIteration.internalRevision < internalTrac.latestRecordedRevisionNumber && content.hasChildNodes()) {
- var divider = document.createElement("div");
- divider.className = "divider";
- content.appendChild(divider);
- }
</del><ins>+ return result;
+ },
</ins><span class="cx">
</span><del>- for (var i = internalTrac.recordedCommits.length - 1; i >= 0; --i) {
- var commit = internalTrac.recordedCommits[i];
- if (commit.revisionNumber <= latestFinishedIteration.internalRevision)
- break;
</del><ins>+ _presentPopoverForPendingCommits: function(element, popover, queue)
+ {
+ var latestFinishedIteration = this._latestFinishedIteration(queue);
+ if (!latestFinishedIteration)
+ return false;
</ins><span class="cx">
</span><del>- content.appendChild(lineForCommit(internalTrac, commit));
- }
</del><ins>+ var content = document.createElement("div");
+ content.className = "commit-history-popover";
+
+ var linesForOpenSource = this._popoverLinesForCommitRange(webkitTrac, latestFinishedIteration.openSourceRevision + 1, webkitTrac.latestRecordedRevisionNumber);
+ for (var i = 0; i != linesForOpenSource.length; ++i)
+ content.appendChild(linesForOpenSource[i]);
+
+ var linesForInternal = [];
+ if (latestFinishedIteration.internalRevision && internalTrac.latestRecordedRevisionNumber)
+ var linesForInternal = this._popoverLinesForCommitRange(internalTrac, latestFinishedIteration.internalRevision + 1, internalTrac.latestRecordedRevisionNumber);
+
+ if (linesForOpenSource.length && linesForInternal.length) {
+ var divider = document.createElement("div");
+ divider.className = "divider";
+ content.appendChild(divider);
</ins><span class="cx"> }
</span><span class="cx">
</span><ins>+ for (var i = 0; i != linesForInternal.length; ++i)
+ content.appendChild(linesForInternal[i]);
+
</ins><span class="cx"> var rect = Dashboard.Rect.rectFromClientRect(element.getBoundingClientRect());
</span><span class="cx"> popover.present(rect, content, [Dashboard.RectEdge.MIN_Y, Dashboard.RectEdge.MAX_Y, Dashboard.RectEdge.MAX_X, Dashboard.RectEdge.MIN_X]);
</span><span class="cx">
</span><span class="cx"> return true;
</span><span class="cx"> },
</span><span class="cx">
</span><del>- revisionLinksForIteration: function(iteration)
</del><ins>+ _presentPopoverForRevisionRange: function(element, popover, context)
</ins><span class="cx"> {
</span><del>- function linkForRevision(revision, trac)
- {
- var linkElement = document.createElement("a");
- linkElement.href = trac.revisionURL(revision);
- linkElement.target = "_blank";
- linkElement.textContent = "r" + revision;
- linkElement.classList.add("selectable");
</del><ins>+ var content = document.createElement("div");
+ content.className = "commit-history-popover";
</ins><span class="cx">
</span><del>- return linkElement;
</del><ins>+ var linesForCommits = this._popoverLinesForCommitRange(context.trac, context.firstRevision, context.lastRevision);
+ if (!linesForCommits.length)
+ return false;
+
+ for (var i = 0; i != linesForCommits.length; ++i)
+ content.appendChild(linesForCommits[i]);
+
+ var rect = Dashboard.Rect.rectFromClientRect(element.getBoundingClientRect());
+ popover.present(rect, content, [Dashboard.RectEdge.MIN_Y, Dashboard.RectEdge.MAX_Y, Dashboard.RectEdge.MAX_X, Dashboard.RectEdge.MIN_X]);
+
+ return true;
+ },
+
+ _presentNoChangePopover: function(element, popover, context)
+ {
+ var content = document.createElement("div");
+ content.className = "commit-history-popover";
+
+ var line = document.createElement("div");
+ line.className = "no-commits";
+ line.textContent = "no new commits in this buildbot queue iteration";
+
+ content.appendChild(line);
+
+ var rect = Dashboard.Rect.rectFromClientRect(element.getBoundingClientRect());
+ popover.present(rect, content, [Dashboard.RectEdge.MIN_Y, Dashboard.RectEdge.MAX_Y, Dashboard.RectEdge.MAX_X, Dashboard.RectEdge.MIN_X]);
+
+ return true;
+ },
+
+ _revisionPopoverContentForIteration: function(iteration, internal)
+ {
+ var contentElement = document.createElement("span");
+ contentElement.textContent = "r" + (internal ? iteration.internalRevision : iteration.openSourceRevision);
+ contentElement.classList.add("revision-number");
+
+ // FIXME: It would be better to display changes from the previous finished run, ignoring those that were interrupted and don't have results.
+ var previousIteration = iteration.previous;
+ if (previousIteration) {
+ var context = {
+ trac: internal ? internalTrac : webkitTrac,
+ firstRevision: (internal ? previousIteration.internalRevision : previousIteration.openSourceRevision) + 1,
+ lastRevision: internal ? iteration.internalRevision : iteration.openSourceRevision
+ };
+ if (context.firstRevision <= context.lastRevision)
+ new PopoverTracker(contentElement, this._presentPopoverForRevisionRange.bind(this), context);
+ else
+ new PopoverTracker(contentElement, this._presentNoChangePopover.bind(this), context);
</ins><span class="cx"> }
</span><span class="cx">
</span><ins>+ return contentElement;
+ },
+
+ revisionContentForIteration: function(iteration)
+ {
</ins><span class="cx"> console.assert(iteration.openSourceRevision);
</span><del>- var openSourceLink = linkForRevision(iteration.openSourceRevision, webkitTrac);
</del><ins>+ var openSourceContent = this._revisionPopoverContentForIteration(iteration);
</ins><span class="cx">
</span><span class="cx"> if (!iteration.internalRevision)
</span><del>- return openSourceLink;
</del><ins>+ return openSourceContent;
</ins><span class="cx">
</span><del>- var internalLink = linkForRevision(iteration.internalRevision, internalTrac);
</del><ins>+ var internalContent = this._revisionPopoverContentForIteration(iteration, true);
</ins><span class="cx">
</span><span class="cx"> var fragment = document.createDocumentFragment();
</span><del>- fragment.appendChild(openSourceLink);
</del><ins>+ fragment.appendChild(openSourceContent);
</ins><span class="cx"> fragment.appendChild(document.createTextNode(" \uff0b "));
</span><del>- fragment.appendChild(internalLink);
</del><ins>+ fragment.appendChild(internalContent);
</ins><span class="cx"> return fragment;
</span><span class="cx"> },
</span><span class="cx">
</span></span></pre></div>
<a id="trunkToolsBuildSlaveSupportbuildwebkitorgconfigpublic_htmldashboardScriptsBuildbotTesterQueueViewjs"></a>
<div class="modfile"><h4>Modified: trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js (161123 => 161124)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js 2013-12-29 20:57:32 UTC (rev 161123)
+++ trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js 2013-12-29 21:17:29 UTC (rev 161124)
</span><span class="lines">@@ -56,7 +56,7 @@
</span><span class="cx">
</span><span class="cx"> --limit;
</span><span class="cx">
</span><del>- var messageLinkElement = this.revisionLinksForIteration(iteration);
</del><ins>+ var messageElement = this.revisionContentForIteration(iteration);
</ins><span class="cx">
</span><span class="cx"> var layoutTestResults = iteration.layoutTestResults || {failureCount: 0};
</span><span class="cx"> var javascriptTestResults = iteration.javascriptTestResults || {failureCount: 0};
</span><span class="lines">@@ -66,34 +66,34 @@
</span><span class="cx"> var bindingTestResults = iteration.bindingTestResults || {errorOccurred: false};
</span><span class="cx">
</span><span class="cx"> if (!iteration.failed) {
</span><del>- var status = new StatusLineView(messageLinkElement, StatusLineView.Status.Good, "all tests passed");
</del><ins>+ var status = new StatusLineView(messageElement, StatusLineView.Status.Good, "all tests passed");
</ins><span class="cx"> limit = 0;
</span><span class="cx"> } else if (!layoutTestResults.failureCount && !javascriptTestResults.failureCount && !apiTestResults.failureCount && !pythonTestResults.failureCount && !perlTestResults.failureCount && !bindingTestResults.errorOccurred) {
</span><span class="cx"> // Something wrong happened, but it was not a test failure.
</span><span class="cx"> var url = iteration.queue.buildbot.buildPageURLForIteration(iteration);
</span><del>- var status = new StatusLineView(messageLinkElement, StatusLineView.Status.Danger, iteration.text, undefined, url);
</del><ins>+ var status = new StatusLineView(messageElement, StatusLineView.Status.Danger, iteration.text, undefined, url);
</ins><span class="cx"> } else if (layoutTestResults.failureCount && !javascriptTestResults.failureCount && !apiTestResults.failureCount && !pythonTestResults.failureCount && !perlTestResults.failureCount && !bindingTestResults.errorOccurred) {
</span><span class="cx"> var url = iteration.queue.buildbot.layoutTestResultsURLForIteration(iteration);
</span><del>- var status = new StatusLineView(messageLinkElement, StatusLineView.Status.Bad, layoutTestResults.failureCount === 1 ? "layout test failure" : "layout test failures", layoutTestResults.tooManyFailures ? layoutTestResults.failureCount + "\uff0b" : layoutTestResults.failureCount, url);
</del><ins>+ var status = new StatusLineView(messageElement, StatusLineView.Status.Bad, layoutTestResults.failureCount === 1 ? "layout test failure" : "layout test failures", layoutTestResults.tooManyFailures ? layoutTestResults.failureCount + "\uff0b" : layoutTestResults.failureCount, url);
</ins><span class="cx"> } else if (!layoutTestResults.failureCount && javascriptTestResults.failureCount && !apiTestResults.failureCount && !pythonTestResults.failureCount && !perlTestResults.failureCount && !bindingTestResults.errorOccurred) {
</span><span class="cx"> var url = iteration.queue.buildbot.javascriptTestResultsURLForIteration(iteration);
</span><del>- var status = new StatusLineView(messageLinkElement, StatusLineView.Status.Bad, javascriptTestResults.failureCount === 1 ? "javascript test failure" : "javascript test failures", javascriptTestResults.failureCount, url);
</del><ins>+ var status = new StatusLineView(messageElement, StatusLineView.Status.Bad, javascriptTestResults.failureCount === 1 ? "javascript test failure" : "javascript test failures", javascriptTestResults.failureCount, url);
</ins><span class="cx"> } else if (!layoutTestResults.failureCount && !javascriptTestResults.failureCount && apiTestResults.failureCount && !pythonTestResults.failureCount && !perlTestResults.failureCount && !bindingTestResults.errorOccurred) {
</span><span class="cx"> var url = iteration.queue.buildbot.apiTestResultsURLForIteration(iteration);
</span><del>- var status = new StatusLineView(messageLinkElement, StatusLineView.Status.Bad, apiTestResults.failureCount === 1 ? "api test failure" : "api test failures", apiTestResults.failureCount, url);
</del><ins>+ var status = new StatusLineView(messageElement, StatusLineView.Status.Bad, apiTestResults.failureCount === 1 ? "api test failure" : "api test failures", apiTestResults.failureCount, url);
</ins><span class="cx"> } else if (!layoutTestResults.failureCount && !javascriptTestResults.failureCount && !apiTestResults.failureCount && pythonTestResults.failureCount && !perlTestResults.failureCount && !bindingTestResults.errorOccurred) {
</span><span class="cx"> var url = iteration.queue.buildbot.webkitpyTestResultsURLForIteration(iteration);
</span><del>- var status = new StatusLineView(messageLinkElement, StatusLineView.Status.Bad, pythonTestResults.failureCount === 1 ? "webkitpy test failure" : "webkitpy test failures", pythonTestResults.failureCount, url);
</del><ins>+ var status = new StatusLineView(messageElement, StatusLineView.Status.Bad, pythonTestResults.failureCount === 1 ? "webkitpy test failure" : "webkitpy test failures", pythonTestResults.failureCount, url);
</ins><span class="cx"> } else if (!layoutTestResults.failureCount && !javascriptTestResults.failureCount && !apiTestResults.failureCount && !pythonTestResults.failureCount && perlTestResults.failureCount && !bindingTestResults.errorOccurred) {
</span><span class="cx"> var url = iteration.queue.buildbot.webkitperlTestResultsURLForIteration(iteration);
</span><del>- var status = new StatusLineView(messageLinkElement, StatusLineView.Status.Bad, perlTestResults.failureCount === 1 ? "webkitperl test failure" : "webkitperl test failures", perlTestResults.failureCount, url);
</del><ins>+ var status = new StatusLineView(messageElement, StatusLineView.Status.Bad, perlTestResults.failureCount === 1 ? "webkitperl test failure" : "webkitperl test failures", perlTestResults.failureCount, url);
</ins><span class="cx"> } else if (!layoutTestResults.failureCount && !javascriptTestResults.failureCount && !apiTestResults.failureCount && !pythonTestResults.failureCount && !perlTestResults.failureCount && bindingTestResults.errorOccurred) {
</span><span class="cx"> var url = iteration.queue.buildbot.bindingsTestResultsURLForIteration(iteration);
</span><del>- var status = new StatusLineView(messageLinkElement, StatusLineView.Status.Bad, "bindings tests failed", undefined, url);
</del><ins>+ var status = new StatusLineView(messageElement, StatusLineView.Status.Bad, "bindings tests failed", undefined, url);
</ins><span class="cx"> } else {
</span><span class="cx"> var url = iteration.queue.buildbot.buildPageURLForIteration(iteration);
</span><span class="cx"> var totalFailures = layoutTestResults.failureCount + javascriptTestResults.failureCount + apiTestResults.failureCount + pythonTestResults.failureCount + perlTestResults.failureCount + bindingTestResults.errorOccurred;
</span><del>- var status = new StatusLineView(messageLinkElement, StatusLineView.Status.Bad, totalFailures === 1 ? "test failure" : "test failures", totalFailures, url);
</del><ins>+ var status = new StatusLineView(messageElement, StatusLineView.Status.Bad, totalFailures === 1 ? "test failure" : "test failures", totalFailures, url);
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> this.element.appendChild(status.element);
</span></span></pre></div>
<a id="trunkToolsBuildSlaveSupportbuildwebkitorgconfigpublic_htmldashboardScriptsPopoverTrackerjs"></a>
<div class="modfile"><h4>Modified: trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/PopoverTracker.js (161123 => 161124)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/PopoverTracker.js 2013-12-29 20:57:32 UTC (rev 161123)
+++ trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/PopoverTracker.js 2013-12-29 21:17:29 UTC (rev 161124)
</span><span class="lines">@@ -23,12 +23,15 @@
</span><span class="cx"> * THE POSSIBILITY OF SUCH DAMAGE.
</span><span class="cx"> */
</span><span class="cx">
</span><del>-PopoverTracker = function(element, delegate, context)
</del><ins>+PopoverTracker = function(element, presentPopoverCallback, context)
</ins><span class="cx"> {
</span><span class="cx"> BaseObject.call(this);
</span><span class="cx">
</span><ins>+ console.assert(element);
+ console.assert(presentPopoverCallback && typeof presentPopoverCallback == "function");
+
</ins><span class="cx"> this._element = element;
</span><del>- this._delegate = delegate;
</del><ins>+ this._presentPopover = presentPopoverCallback;
</ins><span class="cx"> this._context = context;
</span><span class="cx"> this._active = false;
</span><span class="cx">
</span><span class="lines">@@ -61,11 +64,8 @@
</span><span class="cx"> }
</span><span class="cx"> console.assert(!PopoverTracker._popover);
</span><span class="cx">
</span><del>- if (!this._delegate || !this._delegate.presentPopoverForElement || typeof this._delegate.presentPopoverForElement != "function")
- return;
-
</del><span class="cx"> var popover = new Dashboard.Popover(this);
</span><del>- if (!this._delegate.presentPopoverForElement(event.target, popover, this._context))
</del><ins>+ if (!this._presentPopover(event.target, popover, this._context))
</ins><span class="cx"> return;
</span><span class="cx">
</span><span class="cx"> if (popoverWasVisible)
</span></span></pre></div>
<a id="trunkToolsBuildSlaveSupportbuildwebkitorgconfigpublic_htmldashboardStylesMaincss"></a>
<div class="modfile"><h4>Modified: trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css (161123 => 161124)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css 2013-12-29 20:57:32 UTC (rev 161123)
+++ trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css 2013-12-29 21:17:29 UTC (rev 161124)
</span><span class="lines">@@ -37,10 +37,6 @@
</span><span class="cx"> text-decoration: underline;
</span><span class="cx"> }
</span><span class="cx">
</span><del>-.selectable {
- -webkit-user-select: auto;
-}
-
</del><span class="cx"> div.cellButton {
</span><span class="cx"> font-family: "HelveticaNeue-Light", sans-serif;
</span><span class="cx"> font-size: 12px;
</span></span></pre></div>
<a id="trunkToolsBuildSlaveSupportbuildwebkitorgconfigpublic_htmldashboardStylesQueueViewcss"></a>
<div class="modfile"><h4>Modified: trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/QueueView.css (161123 => 161124)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/QueueView.css 2013-12-29 20:57:32 UTC (rev 161123)
+++ trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/QueueView.css 2013-12-29 21:17:29 UTC (rev 161124)
</span><span class="lines">@@ -40,7 +40,8 @@
</span><span class="cx"> margin-top: 10px;
</span><span class="cx"> }
</span><span class="cx">
</span><del>-.pending-commits-popover > .pending-commit {
</del><ins>+.commit-history-popover > .pending-commit,
+.commit-history-popover > .no-commits {
</ins><span class="cx"> font-family: "HelveticaNeue-Light", "Helvetica Neue", sans-serif;
</span><span class="cx"> color: rgb(145, 135, 95);
</span><span class="cx"> font-size: 12px;
</span><span class="lines">@@ -49,15 +50,15 @@
</span><span class="cx"> user-select: auto;
</span><span class="cx"> }
</span><span class="cx">
</span><del>-.pending-commits-popover > .pending-commit > .author {
</del><ins>+.commit-history-popover > .pending-commit > .author {
</ins><span class="cx"> padding-left: 5px;
</span><span class="cx"> padding-right: 5px;
</span><span class="cx"> }
</span><span class="cx">
</span><del>-.pending-commits-popover > .pending-commit > .title {
</del><ins>+.commit-history-popover > .pending-commit > .title {
</ins><span class="cx"> color: black;
</span><span class="cx"> }
</span><span class="cx">
</span><del>-.pending-commits-popover > .divider {
</del><ins>+.commit-history-popover > .divider {
</ins><span class="cx"> height: 7px;
</span><span class="cx"> }
</span></span></pre></div>
<a id="trunkToolsBuildSlaveSupportbuildwebkitorgconfigpublic_htmldashboardStylesStatusLineViewcss"></a>
<div class="modfile"><h4>Modified: trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/StatusLineView.css (161123 => 161124)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/StatusLineView.css 2013-12-29 20:57:32 UTC (rev 161123)
+++ trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/StatusLineView.css 2013-12-29 21:17:29 UTC (rev 161124)
</span><span class="lines">@@ -101,6 +101,10 @@
</span><span class="cx"> color: inherit;
</span><span class="cx"> }
</span><span class="cx">
</span><ins>+.status-line .message .revision-number {
+ -webkit-user-select: auto;
+}
+
</ins><span class="cx"> .status-line.no-label .message {
</span><span class="cx"> line-height: 28px;
</span><span class="cx"> }
</span></span></pre></div>
<a id="trunkToolsChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Tools/ChangeLog (161123 => 161124)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Tools/ChangeLog 2013-12-29 20:57:32 UTC (rev 161123)
+++ trunk/Tools/ChangeLog 2013-12-29 21:17:29 UTC (rev 161124)
</span><span class="lines">@@ -1,5 +1,49 @@
</span><span class="cx"> 2013-12-29 Alexey Proskuryakov <ap@apple.com>
</span><span class="cx">
</span><ins>+ Please display (and link to) revision ranges at build.webkit.org/dashboard
+ https://bugs.webkit.org/show_bug.cgi?id=122187
+
+ Reviewed by Timothy Hatcher.
+
+ Added popovers for revision numbers. Removed direct links, because they were misleading -
+ a test run covers a revision range, not just the latest revision. This also makes
+ selecting a revision for copy easier.
+
+ All revision numbers have the popovers for consistency, although they are most useful
+ for iterations that are not the last ones in a view, because the content is a delta
+ from previous iteration.
+
+ * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotBuilderQueueView.js:
+ (BuildbotBuilderQueueView.prototype.update.appendBuilderQueueStatus):
+ revisionLinksForIteration() is now named revisionContentForIteration().
+
+ * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
+ (BuildbotTesterQueueView.prototype.update.appendBuilderQueueStatus):
+ Ditto.
+
+ * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
+ (BuildbotIteration.prototype.get previous): Added a function to go back in iteration history.
+
+ * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
+ Refactored to support the new popover variation. Replaced revisionLinksForIteration()
+ with a function that builds an element with popover.
+
+ * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/PopoverTracker.js:
+ Changed to take a function for popover presentation instead of delegate object.
+ We only need one delegate function, and it's easier to have multiple popovers per view class
+ this way.
+
+ * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
+ Removed a rule for selectable class. It's replaced with a semantic rule in StatusLineView.css.
+
+ * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/QueueView.css:
+ Renamed pending-commits-popover class to commit-history-popover.
+
+ * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/StatusLineView.css:
+ (.status-line .message .revision-number): Added a rule for revision numbers.
+
+2013-12-29 Alexey Proskuryakov <ap@apple.com>
+
</ins><span class="cx"> Please display information about pending runs in build.webkit.org/dashboard
</span><span class="cx"> https://bugs.webkit.org/show_bug.cgi?id=122180
</span><span class="cx">
</span></span></pre>
</div>
</div>
</body>
</html>