<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[161092] trunk/Tools</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/161092">161092</a></dd>
<dt>Author</dt> <dd>ap@apple.com</dd>
<dt>Date</dt> <dd>2013-12-26 11:20:22 -0800 (Thu, 26 Dec 2013)</dd>
</dl>
<h3>Log Message</h3>
<pre>Some links at build.webkit.org/dashboard don't show status messages, and aren't keyboard accessible
https://bugs.webkit.org/show_bug.cgi?id=126234
Reviewed by Timothy Hatcher.
Changed elements that are semantically links from <div> to <a>.
* BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/StatusLineView.js:
(StatusLineView): Create <a> or <div> elements conditionally on whether we have a URL.
Don't try simulate a link with CSS/JS, it's not needed any more.
(StatusLineView.prototype._clicked): Removed.
* BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/BuildbotQueueView.css:
Removed text-decoration rules, default ones in Main.css now work for queue elements.
* BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
Simplified cursor rules.
Added a universal rule for links to only show underline on hover, as this is what
we want almost everywhere.
* BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/StatusLineView.css:
(.status-line .bubble): Added text-decoration: none, as this is the one place where
we don't want it even on hover.
(.status-line .label): Force display: block for consistent layout between <a>
and <div>.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkToolsBuildSlaveSupportbuildwebkitorgconfigpublic_htmldashboardScriptsStatusLineViewjs">trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/StatusLineView.js</a></li>
<li><a href="#trunkToolsBuildSlaveSupportbuildwebkitorgconfigpublic_htmldashboardStylesBuildbotQueueViewcss">trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/BuildbotQueueView.css</a></li>
<li><a href="#trunkToolsBuildSlaveSupportbuildwebkitorgconfigpublic_htmldashboardStylesMaincss">trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css</a></li>
<li><a href="#trunkToolsBuildSlaveSupportbuildwebkitorgconfigpublic_htmldashboardStylesStatusLineViewcss">trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/StatusLineView.css</a></li>
<li><a href="#trunkToolsChangeLog">trunk/Tools/ChangeLog</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkToolsBuildSlaveSupportbuildwebkitorgconfigpublic_htmldashboardScriptsStatusLineViewjs"></a>
<div class="modfile"><h4>Modified: trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/StatusLineView.js (161091 => 161092)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/StatusLineView.js 2013-12-26 18:19:20 UTC (rev 161091)
+++ trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/StatusLineView.js 2013-12-26 19:20:22 UTC (rev 161092)
</span><span class="lines">@@ -33,12 +33,22 @@
</span><span class="cx"> this.element.classList.add("status-line");
</span><span class="cx"> this.element.__statusLineView = this;
</span><span class="cx">
</span><del>- this._statusBubbleElement = document.createElement("div");
</del><ins>+ if (url) {
+ this._statusBubbleElement = document.createElement("a");
+ this._statusBubbleElement.href = url;
+ this._statusBubbleElement.target = "_blank";
+ } else
+ this._statusBubbleElement = document.createElement("div");
</ins><span class="cx"> this._statusBubbleElement.classList.add("bubble");
</span><span class="cx"> if (status != StatusLineView.Status.NoBubble)
</span><span class="cx"> this.element.appendChild(this._statusBubbleElement);
</span><span class="cx">
</span><del>- this._labelElement = document.createElement("div");
</del><ins>+ if (url) {
+ this._labelElement = document.createElement("a");
+ this._labelElement.href = url;
+ this._labelElement.target = "_blank";
+ } else
+ this._labelElement = document.createElement("div");
</ins><span class="cx"> this._labelElement.classList.add("label");
</span><span class="cx">
</span><span class="cx"> this._messageElement = document.createElement("div");
</span><span class="lines">@@ -50,11 +60,6 @@
</span><span class="cx"> this.label = label || "";
</span><span class="cx"> this.repeatCount = repeatCount || 0;
</span><span class="cx"> this.url = url || null;
</span><del>-
- if (url) {
- this.element.addEventListener("click", this._clicked.bind(this));
- this.element.classList.add("linked");
- }
</del><span class="cx"> };
</span><span class="cx">
</span><span class="cx"> StatusLineView.Status = {
</span><span class="lines">@@ -155,17 +160,5 @@
</span><span class="cx"> } else {
</span><span class="cx"> this._messageElement.textContent = x;
</span><span class="cx"> }
</span><del>- },
-
- _clicked: function(event)
- {
- if (!this.url)
- return;
-
- var anchor = document.createElement("a");
- anchor.href = this.url;
- anchor.target = "_blank";
-
- anchor.click();
</del><span class="cx"> }
</span><span class="cx"> };
</span></span></pre></div>
<a id="trunkToolsBuildSlaveSupportbuildwebkitorgconfigpublic_htmldashboardStylesBuildbotQueueViewcss"></a>
<div class="modfile"><h4>Modified: trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/BuildbotQueueView.css (161091 => 161092)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/BuildbotQueueView.css 2013-12-26 18:19:20 UTC (rev 161091)
+++ trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/BuildbotQueueView.css 2013-12-26 19:20:22 UTC (rev 161092)
</span><span class="lines">@@ -34,13 +34,8 @@
</span><span class="cx"> font-family: "HelveticaNeue-Light", "Helvetica Neue", sans-serif;
</span><span class="cx"> color: rgb(145, 135, 95);
</span><span class="cx"> text-align: left;
</span><del>- text-decoration: none;
</del><span class="cx"> }
</span><span class="cx">
</span><del>-.queue-view .queueLabel:hover {
- text-decoration: underline;
-}
-
</del><span class="cx"> .queue-view .queueLabel:not(:first-child) {
</span><span class="cx"> margin-top: 10px;
</span><span class="cx"> }
</span></span></pre></div>
<a id="trunkToolsBuildSlaveSupportbuildwebkitorgconfigpublic_htmldashboardStylesMaincss"></a>
<div class="modfile"><h4>Modified: trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css (161091 => 161092)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css 2013-12-26 18:19:20 UTC (rev 161091)
+++ trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css 2013-12-26 19:20:22 UTC (rev 161092)
</span><span class="lines">@@ -25,15 +25,18 @@
</span><span class="cx">
</span><span class="cx"> * {
</span><span class="cx"> box-sizing: border-box;
</span><del>- cursor: default;
</del><span class="cx"> -webkit-user-select: none;
</span><span class="cx"> -webkit-user-drag: none;
</span><span class="cx"> }
</span><span class="cx">
</span><del>-a:link {
- cursor: pointer;
</del><ins>+a {
+ text-decoration: none;
</ins><span class="cx"> }
</span><span class="cx">
</span><ins>+a:hover {
+ text-decoration: underline;
+}
+
</ins><span class="cx"> .selectable {
</span><span class="cx"> -webkit-user-select: auto;
</span><span class="cx"> }
</span></span></pre></div>
<a id="trunkToolsBuildSlaveSupportbuildwebkitorgconfigpublic_htmldashboardStylesStatusLineViewcss"></a>
<div class="modfile"><h4>Modified: trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/StatusLineView.css (161091 => 161092)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/StatusLineView.css 2013-12-26 18:19:20 UTC (rev 161091)
+++ trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/StatusLineView.css 2013-12-26 19:20:22 UTC (rev 161092)
</span><span class="lines">@@ -29,11 +29,6 @@
</span><span class="cx"> padding: 2px 0;
</span><span class="cx"> }
</span><span class="cx">
</span><del>-.status-line.linked,
-.status-line.linked * {
- cursor: pointer;
-}
-
</del><span class="cx"> .status-line .bubble {
</span><span class="cx"> float: left;
</span><span class="cx"> min-width: 24px;
</span><span class="lines">@@ -48,6 +43,7 @@
</span><span class="cx"> overflow: hidden;
</span><span class="cx"> margin-top: 2px;
</span><span class="cx"> margin-right: 6px;
</span><ins>+ text-decoration: none;
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> .status-line.neutral .bubble {
</span><span class="lines">@@ -92,6 +88,7 @@
</span><span class="cx"> text-transform: lowercase;
</span><span class="cx"> line-height: 11px;
</span><span class="cx"> padding-top: 1px;
</span><ins>+ display: block;
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> .status-line .message {
</span><span class="lines">@@ -104,14 +101,6 @@
</span><span class="cx"> color: inherit;
</span><span class="cx"> }
</span><span class="cx">
</span><del>-.status-line .message a:link {
- text-decoration: none;
-}
-
-.status-line .message a:link:hover {
- text-decoration: underline;
-}
-
</del><span class="cx"> .status-line.no-label .message {
</span><span class="cx"> line-height: 28px;
</span><span class="cx"> }
</span><span class="lines">@@ -141,7 +130,3 @@
</span><span class="cx"> .status-line.bad .message {
</span><span class="cx"> color: rgb(191, 67, 41);
</span><span class="cx"> }
</span><del>-
-.status-line.linked .label:hover {
- text-decoration: underline;
-}
</del><span class="cx">\ No newline at end of file
</span></span></pre></div>
<a id="trunkToolsChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Tools/ChangeLog (161091 => 161092)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Tools/ChangeLog 2013-12-26 18:19:20 UTC (rev 161091)
+++ trunk/Tools/ChangeLog 2013-12-26 19:20:22 UTC (rev 161092)
</span><span class="lines">@@ -1,3 +1,31 @@
</span><ins>+2013-12-26 Alexey Proskuryakov <ap@apple.com>
+
+ Some links at build.webkit.org/dashboard don't show status messages, and aren't keyboard accessible
+ https://bugs.webkit.org/show_bug.cgi?id=126234
+
+ Reviewed by Timothy Hatcher.
+
+ Changed elements that are semantically links from <div> to <a>.
+
+ * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/StatusLineView.js:
+ (StatusLineView): Create <a> or <div> elements conditionally on whether we have a URL.
+ Don't try simulate a link with CSS/JS, it's not needed any more.
+ (StatusLineView.prototype._clicked): Removed.
+
+ * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/BuildbotQueueView.css:
+ Removed text-decoration rules, default ones in Main.css now work for queue elements.
+
+ * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
+ Simplified cursor rules.
+ Added a universal rule for links to only show underline on hover, as this is what
+ we want almost everywhere.
+
+ * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/StatusLineView.css:
+ (.status-line .bubble): Added text-decoration: none, as this is the one place where
+ we don't want it even on hover.
+ (.status-line .label): Force display: block for consistent layout between <a>
+ and <div>.
+
</ins><span class="cx"> 2013-12-25 Alexey Proskuryakov <ap@apple.com>
</span><span class="cx">
</span><span class="cx"> Please clarify "pending" reporting at build.webkit.org/dashboard
</span></span></pre>
</div>
</div>
</body>
</html>