<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[161025] branches/jsCStack/Source/JavaScriptCore</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/161025">161025</a></dd>
<dt>Author</dt> <dd>mark.lam@apple.com</dd>
<dt>Date</dt> <dd>2013-12-23 15:04:13 -0800 (Mon, 23 Dec 2013)</dd>
</dl>
<h3>Log Message</h3>
<pre>CStack: Cosmetic: rename reservationEnd() to reservationTop().
https://bugs.webkit.org/show_bug.cgi?id=126181.
Not yet reviewed.
reservationEnd() computes the end of the stack at the top. The value
is computed as:
char* reservationEnd = static_cast<char*>(m_reservation.base());
return reinterpret_cast_ptr<Register*>(reservationEnd);
Since m_reservation.base() points at a slot of memory that is within the
allocatable range of the stack, naming this function reservationEnd() is
inappropriate. Per Geoff's input, "end" usually refers to the slot past
the end of a buffer. Calling it "top" is more appropriate. Hence, I'm
renaming it to reservationTop().
* interpreter/JSStack.cpp:
(JSC::JSStack::enableErrorStackReserve):
(JSC::JSStack::disableErrorStackReserve):
* interpreter/JSStack.h:
(JSC::JSStack::reservationTop):</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#branchesjsCStackSourceJavaScriptCoreChangeLog">branches/jsCStack/Source/JavaScriptCore/ChangeLog</a></li>
<li><a href="#branchesjsCStackSourceJavaScriptCoreinterpreterJSStackcpp">branches/jsCStack/Source/JavaScriptCore/interpreter/JSStack.cpp</a></li>
<li><a href="#branchesjsCStackSourceJavaScriptCoreinterpreterJSStackh">branches/jsCStack/Source/JavaScriptCore/interpreter/JSStack.h</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="branchesjsCStackSourceJavaScriptCoreChangeLog"></a>
<div class="modfile"><h4>Modified: branches/jsCStack/Source/JavaScriptCore/ChangeLog (161024 => 161025)</h4>
<pre class="diff"><span>
<span class="info">--- branches/jsCStack/Source/JavaScriptCore/ChangeLog        2013-12-23 22:51:21 UTC (rev 161024)
+++ branches/jsCStack/Source/JavaScriptCore/ChangeLog        2013-12-23 23:04:13 UTC (rev 161025)
</span><span class="lines">@@ -1,3 +1,28 @@
</span><ins>+2013-12-23 Mark Lam <mark.lam@apple.com>
+
+ CStack: Cosmetic: rename reservationEnd() to reservationTop().
+ https://bugs.webkit.org/show_bug.cgi?id=126181.
+
+ Not yet reviewed.
+
+ reservationEnd() computes the end of the stack at the top. The value
+ is computed as:
+
+ char* reservationEnd = static_cast<char*>(m_reservation.base());
+ return reinterpret_cast_ptr<Register*>(reservationEnd);
+
+ Since m_reservation.base() points at a slot of memory that is within the
+ allocatable range of the stack, naming this function reservationEnd() is
+ inappropriate. Per Geoff's input, "end" usually refers to the slot past
+ the end of a buffer. Calling it "top" is more appropriate. Hence, I'm
+ renaming it to reservationTop().
+
+ * interpreter/JSStack.cpp:
+ (JSC::JSStack::enableErrorStackReserve):
+ (JSC::JSStack::disableErrorStackReserve):
+ * interpreter/JSStack.h:
+ (JSC::JSStack::reservationTop):
+
</ins><span class="cx"> 2013-12-23 Filip Pizlo <fpizlo@apple.com>
</span><span class="cx">
</span><span class="cx"> CStack Branch: Several dfg-arguments-osr-exit tests fail
</span></span></pre></div>
<a id="branchesjsCStackSourceJavaScriptCoreinterpreterJSStackcpp"></a>
<div class="modfile"><h4>Modified: branches/jsCStack/Source/JavaScriptCore/interpreter/JSStack.cpp (161024 => 161025)</h4>
<pre class="diff"><span>
<span class="info">--- branches/jsCStack/Source/JavaScriptCore/interpreter/JSStack.cpp        2013-12-23 22:51:21 UTC (rev 161024)
+++ branches/jsCStack/Source/JavaScriptCore/interpreter/JSStack.cpp        2013-12-23 23:04:13 UTC (rev 161025)
</span><span class="lines">@@ -147,12 +147,12 @@
</span><span class="cx">
</span><span class="cx"> void JSStack::enableErrorStackReserve()
</span><span class="cx"> {
</span><del>- m_useableEnd = reservationEnd();
</del><ins>+ m_useableEnd = reservationTop();
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> void JSStack::disableErrorStackReserve()
</span><span class="cx"> {
</span><del>- char* useableEnd = reinterpret_cast<char*>(reservationEnd()) + commitSize;
</del><ins>+ char* useableEnd = reinterpret_cast<char*>(reservationTop()) + commitSize;
</ins><span class="cx"> m_useableEnd = reinterpret_cast_ptr<Register*>(useableEnd);
</span><span class="cx">
</span><span class="cx"> // By the time we get here, we are guaranteed to be destructing the last
</span></span></pre></div>
<a id="branchesjsCStackSourceJavaScriptCoreinterpreterJSStackh"></a>
<div class="modfile"><h4>Modified: branches/jsCStack/Source/JavaScriptCore/interpreter/JSStack.h (161024 => 161025)</h4>
<pre class="diff"><span>
<span class="info">--- branches/jsCStack/Source/JavaScriptCore/interpreter/JSStack.h        2013-12-23 22:51:21 UTC (rev 161024)
+++ branches/jsCStack/Source/JavaScriptCore/interpreter/JSStack.h        2013-12-23 23:04:13 UTC (rev 161025)
</span><span class="lines">@@ -146,10 +146,10 @@
</span><span class="cx"> #endif // ENABLE(LLINT_C_LOOP)
</span><span class="cx">
</span><span class="cx"> #if ENABLE(LLINT_C_LOOP)
</span><del>- Register* reservationEnd() const
</del><ins>+ Register* reservationTop() const
</ins><span class="cx"> {
</span><del>- char* reservationEnd = static_cast<char*>(m_reservation.base());
- return reinterpret_cast_ptr<Register*>(reservationEnd);
</del><ins>+ char* reservationTop = static_cast<char*>(m_reservation.base());
+ return reinterpret_cast_ptr<Register*>(reservationTop);
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> #if ENABLE(DEBUG_JSSTACK)
</span></span></pre>
</div>
</div>
</body>
</html>