<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[160931] branches/jsCStack/Source/JavaScriptCore</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/160931">160931</a></dd>
<dt>Author</dt> <dd>msaboff@apple.com</dd>
<dt>Date</dt> <dd>2013-12-20 15:04:25 -0800 (Fri, 20 Dec 2013)</dd>
</dl>
<h3>Log Message</h3>
<pre>CStack Branch: CodeBlocks aren't being marked by garbage collector
https://bugs.webkit.org/show_bug.cgi?id=126084
Reviewed by Filip Pizlo.
Changed the native stack marking to include marking CodeBlocks and JITStubRoutines.
Patterned the code after what was in JSStack::gatherConservativeRoots()
* heap/Heap.cpp:
(JSC::Heap::markRoots):
* heap/MachineStackMarker.cpp:
(JSC::MachineThreads::gatherFromCurrentThread):
(JSC::MachineThreads::gatherFromOtherThread):
(JSC::MachineThreads::gatherConservativeRoots):
* heap/MachineStackMarker.h:</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#branchesjsCStackSourceJavaScriptCoreChangeLog">branches/jsCStack/Source/JavaScriptCore/ChangeLog</a></li>
<li><a href="#branchesjsCStackSourceJavaScriptCoreheapHeapcpp">branches/jsCStack/Source/JavaScriptCore/heap/Heap.cpp</a></li>
<li><a href="#branchesjsCStackSourceJavaScriptCoreheapMachineStackMarkercpp">branches/jsCStack/Source/JavaScriptCore/heap/MachineStackMarker.cpp</a></li>
<li><a href="#branchesjsCStackSourceJavaScriptCoreheapMachineStackMarkerh">branches/jsCStack/Source/JavaScriptCore/heap/MachineStackMarker.h</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="branchesjsCStackSourceJavaScriptCoreChangeLog"></a>
<div class="modfile"><h4>Modified: branches/jsCStack/Source/JavaScriptCore/ChangeLog (160930 => 160931)</h4>
<pre class="diff"><span>
<span class="info">--- branches/jsCStack/Source/JavaScriptCore/ChangeLog 2013-12-20 23:01:10 UTC (rev 160930)
+++ branches/jsCStack/Source/JavaScriptCore/ChangeLog 2013-12-20 23:04:25 UTC (rev 160931)
</span><span class="lines">@@ -1,5 +1,23 @@
</span><span class="cx"> 2013-12-20 Michael Saboff <msaboff@apple.com>
</span><span class="cx">
</span><ins>+ CStack Branch: CodeBlocks aren't being marked by garbage collector
+ https://bugs.webkit.org/show_bug.cgi?id=126084
+
+ Reviewed by Filip Pizlo.
+
+ Changed the native stack marking to include marking CodeBlocks and JITStubRoutines.
+ Patterned the code after what was in JSStack::gatherConservativeRoots()
+
+ * heap/Heap.cpp:
+ (JSC::Heap::markRoots):
+ * heap/MachineStackMarker.cpp:
+ (JSC::MachineThreads::gatherFromCurrentThread):
+ (JSC::MachineThreads::gatherFromOtherThread):
+ (JSC::MachineThreads::gatherConservativeRoots):
+ * heap/MachineStackMarker.h:
+
+2013-12-20 Michael Saboff <msaboff@apple.com>
+
</ins><span class="cx"> Unreviewed build fix for building without the FTL.
</span><span class="cx">
</span><span class="cx"> * jit/RegisterPreservationWrapperGenerator.cpp:
</span></span></pre></div>
<a id="branchesjsCStackSourceJavaScriptCoreheapHeapcpp"></a>
<div class="modfile"><h4>Modified: branches/jsCStack/Source/JavaScriptCore/heap/Heap.cpp (160930 => 160931)</h4>
<pre class="diff"><span>
<span class="info">--- branches/jsCStack/Source/JavaScriptCore/heap/Heap.cpp 2013-12-20 23:01:10 UTC (rev 160930)
+++ branches/jsCStack/Source/JavaScriptCore/heap/Heap.cpp 2013-12-20 23:04:25 UTC (rev 160931)
</span><span class="lines">@@ -447,20 +447,20 @@
</span><span class="cx"> double gcStartTime = WTF::monotonicallyIncreasingTime();
</span><span class="cx"> #endif
</span><span class="cx">
</span><ins>+ m_codeBlocks.clearMarks();
</ins><span class="cx"> void* dummy;
</span><del>-
</del><ins>+
</ins><span class="cx"> // We gather conservative roots before clearing mark bits because conservative
</span><span class="cx"> // gathering uses the mark bits to determine whether a reference is valid.
</span><span class="cx"> ConservativeRoots machineThreadRoots(&m_objectSpace.blocks(), &m_storageSpace);
</span><span class="cx"> m_jitStubRoutines.clearMarks();
</span><span class="cx"> {
</span><span class="cx"> GCPHASE(GatherConservativeRoots);
</span><del>- m_machineThreads.gatherConservativeRoots(machineThreadRoots, &dummy);
</del><ins>+ m_machineThreads.gatherConservativeRoots(machineThreadRoots, m_jitStubRoutines, m_codeBlocks, &dummy);
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> #if ENABLE(LLINT_CLOOP)
</span><span class="cx"> ConservativeRoots stackRoots(&m_objectSpace.blocks(), &m_storageSpace);
</span><del>- m_codeBlocks.clearMarks();
</del><span class="cx"> {
</span><span class="cx"> GCPHASE(GatherStackRoots);
</span><span class="cx"> stack().gatherConservativeRoots(stackRoots, m_jitStubRoutines, m_codeBlocks);
</span></span></pre></div>
<a id="branchesjsCStackSourceJavaScriptCoreheapMachineStackMarkercpp"></a>
<div class="modfile"><h4>Modified: branches/jsCStack/Source/JavaScriptCore/heap/MachineStackMarker.cpp (160930 => 160931)</h4>
<pre class="diff"><span>
<span class="info">--- branches/jsCStack/Source/JavaScriptCore/heap/MachineStackMarker.cpp 2013-12-20 23:01:10 UTC (rev 160930)
+++ branches/jsCStack/Source/JavaScriptCore/heap/MachineStackMarker.cpp 2013-12-20 23:04:25 UTC (rev 160931)
</span><span class="lines">@@ -239,7 +239,7 @@
</span><span class="cx"> #define REGISTER_BUFFER_ALIGNMENT
</span><span class="cx"> #endif
</span><span class="cx">
</span><del>-void MachineThreads::gatherFromCurrentThread(ConservativeRoots& conservativeRoots, void* stackCurrent)
</del><ins>+void MachineThreads::gatherFromCurrentThread(ConservativeRoots& conservativeRoots, JITStubRoutineSet& jitStubRoutines, CodeBlockSet& codeBlocks, void* stackCurrent)
</ins><span class="cx"> {
</span><span class="cx"> // setjmp forces volatile registers onto the stack
</span><span class="cx"> jmp_buf registers REGISTER_BUFFER_ALIGNMENT;
</span><span class="lines">@@ -255,12 +255,12 @@
</span><span class="cx"> void* registersBegin = &registers;
</span><span class="cx"> void* registersEnd = reinterpret_cast<void*>(roundUpToMultipleOf<sizeof(void*)>(reinterpret_cast<uintptr_t>(&registers + 1)));
</span><span class="cx"> swapIfBackwards(registersBegin, registersEnd);
</span><del>- conservativeRoots.add(registersBegin, registersEnd);
</del><ins>+ conservativeRoots.add(registersBegin, registersEnd, jitStubRoutines, codeBlocks);
</ins><span class="cx">
</span><span class="cx"> void* stackBegin = stackCurrent;
</span><span class="cx"> void* stackEnd = wtfThreadData().stack().origin();
</span><span class="cx"> swapIfBackwards(stackBegin, stackEnd);
</span><del>- conservativeRoots.add(stackBegin, stackEnd);
</del><ins>+ conservativeRoots.add(stackBegin, stackEnd, jitStubRoutines, codeBlocks);
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> static inline void suspendThread(const PlatformThread& platformThread)
</span><span class="lines">@@ -462,24 +462,24 @@
</span><span class="cx"> #endif
</span><span class="cx"> }
</span><span class="cx">
</span><del>-void MachineThreads::gatherFromOtherThread(ConservativeRoots& conservativeRoots, Thread* thread)
</del><ins>+void MachineThreads::gatherFromOtherThread(ConservativeRoots& conservativeRoots, Thread* thread, JITStubRoutineSet& jitStubRoutines, CodeBlockSet& codeBlocks)
</ins><span class="cx"> {
</span><span class="cx"> PlatformThreadRegisters regs;
</span><span class="cx"> size_t regSize = getPlatformThreadRegisters(thread->platformThread, regs);
</span><span class="cx">
</span><del>- conservativeRoots.add(static_cast<void*>(&regs), static_cast<void*>(reinterpret_cast<char*>(&regs) + regSize));
</del><ins>+ conservativeRoots.add(static_cast<void*>(&regs), static_cast<void*>(reinterpret_cast<char*>(&regs) + regSize), jitStubRoutines, codeBlocks);
</ins><span class="cx">
</span><span class="cx"> void* stackPointer = otherThreadStackPointer(regs);
</span><span class="cx"> void* stackBase = thread->stackBase;
</span><span class="cx"> swapIfBackwards(stackPointer, stackBase);
</span><del>- conservativeRoots.add(stackPointer, stackBase);
</del><ins>+ conservativeRoots.add(stackPointer, stackBase, jitStubRoutines, codeBlocks);
</ins><span class="cx">
</span><span class="cx"> freePlatformThreadRegisters(regs);
</span><span class="cx"> }
</span><span class="cx">
</span><del>-void MachineThreads::gatherConservativeRoots(ConservativeRoots& conservativeRoots, void* stackCurrent)
</del><ins>+void MachineThreads::gatherConservativeRoots(ConservativeRoots& conservativeRoots, JITStubRoutineSet& jitStubRoutines, CodeBlockSet& codeBlocks, void* stackCurrent)
</ins><span class="cx"> {
</span><del>- gatherFromCurrentThread(conservativeRoots, stackCurrent);
</del><ins>+ gatherFromCurrentThread(conservativeRoots, jitStubRoutines, codeBlocks, stackCurrent);
</ins><span class="cx">
</span><span class="cx"> if (m_threadSpecific) {
</span><span class="cx"> PlatformThread currentPlatformThread = getCurrentPlatformThread();
</span><span class="lines">@@ -501,7 +501,7 @@
</span><span class="cx"> // and since this is a shared heap, they are real locks.
</span><span class="cx"> for (Thread* thread = m_registeredThreads; thread; thread = thread->next) {
</span><span class="cx"> if (!equalThread(thread->platformThread, currentPlatformThread))
</span><del>- gatherFromOtherThread(conservativeRoots, thread);
</del><ins>+ gatherFromOtherThread(conservativeRoots, thread, jitStubRoutines, codeBlocks);
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> for (Thread* thread = m_registeredThreads; thread; thread = thread->next) {
</span></span></pre></div>
<a id="branchesjsCStackSourceJavaScriptCoreheapMachineStackMarkerh"></a>
<div class="modfile"><h4>Modified: branches/jsCStack/Source/JavaScriptCore/heap/MachineStackMarker.h (160930 => 160931)</h4>
<pre class="diff"><span>
<span class="info">--- branches/jsCStack/Source/JavaScriptCore/heap/MachineStackMarker.h 2013-12-20 23:01:10 UTC (rev 160930)
+++ branches/jsCStack/Source/JavaScriptCore/heap/MachineStackMarker.h 2013-12-20 23:04:25 UTC (rev 160931)
</span><span class="lines">@@ -28,8 +28,10 @@
</span><span class="cx">
</span><span class="cx"> namespace JSC {
</span><span class="cx">
</span><ins>+ class CodeBlockSet;
</ins><span class="cx"> class ConservativeRoots;
</span><span class="cx"> class Heap;
</span><ins>+ class JITStubRoutineSet;
</ins><span class="cx">
</span><span class="cx"> class MachineThreads {
</span><span class="cx"> WTF_MAKE_NONCOPYABLE(MachineThreads);
</span><span class="lines">@@ -37,20 +39,20 @@
</span><span class="cx"> MachineThreads(Heap*);
</span><span class="cx"> ~MachineThreads();
</span><span class="cx">
</span><del>- void gatherConservativeRoots(ConservativeRoots&, void* stackCurrent);
</del><ins>+ void gatherConservativeRoots(ConservativeRoots&, JITStubRoutineSet&, CodeBlockSet&, void* stackCurrent);
</ins><span class="cx">
</span><span class="cx"> JS_EXPORT_PRIVATE void makeUsableFromMultipleThreads();
</span><span class="cx"> JS_EXPORT_PRIVATE void addCurrentThread(); // Only needs to be called by clients that can use the same heap from multiple threads.
</span><span class="cx">
</span><span class="cx"> private:
</span><del>- void gatherFromCurrentThread(ConservativeRoots&, void* stackCurrent);
</del><ins>+ void gatherFromCurrentThread(ConservativeRoots&, JITStubRoutineSet&, CodeBlockSet&, void* stackCurrent);
</ins><span class="cx">
</span><span class="cx"> class Thread;
</span><span class="cx">
</span><span class="cx"> static void removeThread(void*);
</span><span class="cx"> void removeCurrentThread();
</span><span class="cx">
</span><del>- void gatherFromOtherThread(ConservativeRoots&, Thread*);
</del><ins>+ void gatherFromOtherThread(ConservativeRoots&, Thread*, JITStubRoutineSet&, CodeBlockSet&);
</ins><span class="cx">
</span><span class="cx"> Mutex m_registeredThreadsMutex;
</span><span class="cx"> Thread* m_registeredThreads;
</span></span></pre>
</div>
</div>
</body>
</html>