<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[160940] trunk/Source/WebKit2</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/160940">160940</a></dd>
<dt>Author</dt> <dd>commit-queue@webkit.org</dd>
<dt>Date</dt> <dd>2013-12-20 15:56:38 -0800 (Fri, 20 Dec 2013)</dd>
</dl>
<h3>Log Message</h3>
<pre>Rename PlugInAutoStartProvider's ...EntriesAddedBeforeTime facility to ...EntriesAddedAfterTime
https://bugs.webkit.org/show_bug.cgi?id=126078
Patch by Ricky Mondello <rmondello@apple.com> on 2013-12-20
Reviewed by Anders Carlsson.
<a href="http://trac.webkit.org/projects/webkit/changeset/160922">r160922</a> accidentally named a facility for filtering out data added after a certain time,
"...FilteringOutEntriesAddedBeforeTime", which was incorrect. This patch renames those instances
to "...FilteringOutEntriesAddedAfterTime".
* UIProcess/API/C/WKContext.cpp:
(WKContextSetPlugInAutoStartOriginsFilteringOutEntriesAddedAfterTime):
* UIProcess/API/C/WKContext.h:
* UIProcess/Plugins/PlugInAutoStartProvider.cpp:
(WebKit::PlugInAutoStartProvider::setAutoStartOriginsFilteringOutEntriesAddedAfterTime):
* UIProcess/Plugins/PlugInAutoStartProvider.h:
* UIProcess/WebContext.cpp:
(WebKit::WebContext::setPlugInAutoStartOriginsFilteringOutEntriesAddedAfterTime):
* UIProcess/WebContext.h:</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkSourceWebKit2ChangeLog">trunk/Source/WebKit2/ChangeLog</a></li>
<li><a href="#trunkSourceWebKit2UIProcessAPICWKContextcpp">trunk/Source/WebKit2/UIProcess/API/C/WKContext.cpp</a></li>
<li><a href="#trunkSourceWebKit2UIProcessAPICWKContexth">trunk/Source/WebKit2/UIProcess/API/C/WKContext.h</a></li>
<li><a href="#trunkSourceWebKit2UIProcessPluginsPlugInAutoStartProvidercpp">trunk/Source/WebKit2/UIProcess/Plugins/PlugInAutoStartProvider.cpp</a></li>
<li><a href="#trunkSourceWebKit2UIProcessPluginsPlugInAutoStartProviderh">trunk/Source/WebKit2/UIProcess/Plugins/PlugInAutoStartProvider.h</a></li>
<li><a href="#trunkSourceWebKit2UIProcessWebContextcpp">trunk/Source/WebKit2/UIProcess/WebContext.cpp</a></li>
<li><a href="#trunkSourceWebKit2UIProcessWebContexth">trunk/Source/WebKit2/UIProcess/WebContext.h</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkSourceWebKit2ChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit2/ChangeLog (160939 => 160940)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit2/ChangeLog 2013-12-20 23:55:04 UTC (rev 160939)
+++ trunk/Source/WebKit2/ChangeLog 2013-12-20 23:56:38 UTC (rev 160940)
</span><span class="lines">@@ -1,3 +1,24 @@
</span><ins>+2013-12-20 Ricky Mondello <rmondello@apple.com>
+
+ Rename PlugInAutoStartProvider's ...EntriesAddedBeforeTime facility to ...EntriesAddedAfterTime
+ https://bugs.webkit.org/show_bug.cgi?id=126078
+
+ Reviewed by Anders Carlsson.
+
+ r160922 accidentally named a facility for filtering out data added after a certain time,
+ "...FilteringOutEntriesAddedBeforeTime", which was incorrect. This patch renames those instances
+ to "...FilteringOutEntriesAddedAfterTime".
+
+ * UIProcess/API/C/WKContext.cpp:
+ (WKContextSetPlugInAutoStartOriginsFilteringOutEntriesAddedAfterTime):
+ * UIProcess/API/C/WKContext.h:
+ * UIProcess/Plugins/PlugInAutoStartProvider.cpp:
+ (WebKit::PlugInAutoStartProvider::setAutoStartOriginsFilteringOutEntriesAddedAfterTime):
+ * UIProcess/Plugins/PlugInAutoStartProvider.h:
+ * UIProcess/WebContext.cpp:
+ (WebKit::WebContext::setPlugInAutoStartOriginsFilteringOutEntriesAddedAfterTime):
+ * UIProcess/WebContext.h:
+
</ins><span class="cx"> 2013-12-20 Sam Weinig <sam@webkit.org>
</span><span class="cx">
</span><span class="cx"> [WK2] Add SPI for using a custom protocol handler
</span></span></pre></div>
<a id="trunkSourceWebKit2UIProcessAPICWKContextcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit2/UIProcess/API/C/WKContext.cpp (160939 => 160940)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit2/UIProcess/API/C/WKContext.cpp 2013-12-20 23:55:04 UTC (rev 160939)
+++ trunk/Source/WebKit2/UIProcess/API/C/WKContext.cpp 2013-12-20 23:56:38 UTC (rev 160940)
</span><span class="lines">@@ -391,11 +391,11 @@
</span><span class="cx"> toImpl(contextRef)->setPlugInAutoStartOriginHashes(*toImpl(dictionaryRef));
</span><span class="cx"> }
</span><span class="cx">
</span><del>-void WKContextSetPlugInAutoStartOriginsFilteringOutEntriesAddedBeforeTime(WKContextRef contextRef, WKDictionaryRef dictionaryRef, double time)
</del><ins>+void WKContextSetPlugInAutoStartOriginsFilteringOutEntriesAddedAfterTime(WKContextRef contextRef, WKDictionaryRef dictionaryRef, double time)
</ins><span class="cx"> {
</span><span class="cx"> if (!dictionaryRef)
</span><span class="cx"> return;
</span><del>- toImpl(contextRef)->setPlugInAutoStartOriginsFilteringOutEntriesAddedBeforeTime(*toImpl(dictionaryRef), time);
</del><ins>+ toImpl(contextRef)->setPlugInAutoStartOriginsFilteringOutEntriesAddedAfterTime(*toImpl(dictionaryRef), time);
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> void WKContextSetPlugInAutoStartOrigins(WKContextRef contextRef, WKArrayRef arrayRef)
</span></span></pre></div>
<a id="trunkSourceWebKit2UIProcessAPICWKContexth"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit2/UIProcess/API/C/WKContext.h (160939 => 160940)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit2/UIProcess/API/C/WKContext.h 2013-12-20 23:55:04 UTC (rev 160939)
+++ trunk/Source/WebKit2/UIProcess/API/C/WKContext.h 2013-12-20 23:56:38 UTC (rev 160940)
</span><span class="lines">@@ -139,7 +139,7 @@
</span><span class="cx"> WK_EXPORT WKDictionaryRef WKContextCopyPlugInAutoStartOriginHashes(WKContextRef context);
</span><span class="cx"> WK_EXPORT void WKContextSetPlugInAutoStartOriginHashes(WKContextRef context, WKDictionaryRef dictionary);
</span><span class="cx"> WK_EXPORT void WKContextSetPlugInAutoStartOrigins(WKContextRef contextRef, WKArrayRef arrayRef);
</span><del>-WK_EXPORT void WKContextSetPlugInAutoStartOriginsFilteringOutEntriesAddedBeforeTime(WKContextRef contextRef, WKDictionaryRef dictionaryRef, double time);
</del><ins>+WK_EXPORT void WKContextSetPlugInAutoStartOriginsFilteringOutEntriesAddedAfterTime(WKContextRef contextRef, WKDictionaryRef dictionaryRef, double time);
</ins><span class="cx">
</span><span class="cx"> #ifdef __cplusplus
</span><span class="cx"> }
</span></span></pre></div>
<a id="trunkSourceWebKit2UIProcessPluginsPlugInAutoStartProvidercpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit2/UIProcess/Plugins/PlugInAutoStartProvider.cpp (160939 => 160940)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit2/UIProcess/Plugins/PlugInAutoStartProvider.cpp 2013-12-20 23:55:04 UTC (rev 160939)
+++ trunk/Source/WebKit2/UIProcess/Plugins/PlugInAutoStartProvider.cpp 2013-12-20 23:56:38 UTC (rev 160940)
</span><span class="lines">@@ -106,7 +106,7 @@
</span><span class="cx"> });
</span><span class="cx"> }
</span><span class="cx">
</span><del>-void PlugInAutoStartProvider::setAutoStartOriginsFilteringOutEntriesAddedBeforeTime(ImmutableDictionary& table, double time)
</del><ins>+void PlugInAutoStartProvider::setAutoStartOriginsFilteringOutEntriesAddedAfterTime(ImmutableDictionary& table, double time)
</ins><span class="cx"> {
</span><span class="cx"> double adjustedTimestamp = time + plugInAutoStartExpirationTimeThreshold;
</span><span class="cx"> setAutoStartOriginsTableWithItemsPassingTest(table, [adjustedTimestamp](double expirationTimestamp) {
</span></span></pre></div>
<a id="trunkSourceWebKit2UIProcessPluginsPlugInAutoStartProviderh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit2/UIProcess/Plugins/PlugInAutoStartProvider.h (160939 => 160940)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit2/UIProcess/Plugins/PlugInAutoStartProvider.h 2013-12-20 23:55:04 UTC (rev 160939)
+++ trunk/Source/WebKit2/UIProcess/Plugins/PlugInAutoStartProvider.h 2013-12-20 23:56:38 UTC (rev 160940)
</span><span class="lines">@@ -56,7 +56,7 @@
</span><span class="cx">
</span><span class="cx"> PassRefPtr<ImmutableDictionary> autoStartOriginsTableCopy() const;
</span><span class="cx"> void setAutoStartOriginsTable(ImmutableDictionary&);
</span><del>- void setAutoStartOriginsFilteringOutEntriesAddedBeforeTime(ImmutableDictionary&, double time);
</del><ins>+ void setAutoStartOriginsFilteringOutEntriesAddedAfterTime(ImmutableDictionary&, double time);
</ins><span class="cx"> void setAutoStartOriginsArray(API::Array&);
</span><span class="cx">
</span><span class="cx"> PlugInAutoStartOriginHash autoStartOriginHashesCopy() const;
</span></span></pre></div>
<a id="trunkSourceWebKit2UIProcessWebContextcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit2/UIProcess/WebContext.cpp (160939 => 160940)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit2/UIProcess/WebContext.cpp 2013-12-20 23:55:04 UTC (rev 160939)
+++ trunk/Source/WebKit2/UIProcess/WebContext.cpp 2013-12-20 23:56:38 UTC (rev 160940)
</span><span class="lines">@@ -1279,9 +1279,9 @@
</span><span class="cx"> m_plugInAutoStartProvider.setAutoStartOriginsArray(array);
</span><span class="cx"> }
</span><span class="cx">
</span><del>-void WebContext::setPlugInAutoStartOriginsFilteringOutEntriesAddedBeforeTime(ImmutableDictionary& dictionary, double time)
</del><ins>+void WebContext::setPlugInAutoStartOriginsFilteringOutEntriesAddedAfterTime(ImmutableDictionary& dictionary, double time)
</ins><span class="cx"> {
</span><del>- m_plugInAutoStartProvider.setAutoStartOriginsFilteringOutEntriesAddedBeforeTime(dictionary, time);
</del><ins>+ m_plugInAutoStartProvider.setAutoStartOriginsFilteringOutEntriesAddedAfterTime(dictionary, time);
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> #if ENABLE(CUSTOM_PROTOCOLS)
</span></span></pre></div>
<a id="trunkSourceWebKit2UIProcessWebContexth"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit2/UIProcess/WebContext.h (160939 => 160940)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit2/UIProcess/WebContext.h 2013-12-20 23:55:04 UTC (rev 160939)
+++ trunk/Source/WebKit2/UIProcess/WebContext.h 2013-12-20 23:56:38 UTC (rev 160940)
</span><span class="lines">@@ -262,7 +262,7 @@
</span><span class="cx"> PassRefPtr<ImmutableDictionary> plugInAutoStartOriginHashes() const;
</span><span class="cx"> void setPlugInAutoStartOriginHashes(ImmutableDictionary&);
</span><span class="cx"> void setPlugInAutoStartOrigins(API::Array&);
</span><del>- void setPlugInAutoStartOriginsFilteringOutEntriesAddedBeforeTime(ImmutableDictionary&, double time);
</del><ins>+ void setPlugInAutoStartOriginsFilteringOutEntriesAddedAfterTime(ImmutableDictionary&, double time);
</ins><span class="cx">
</span><span class="cx"> // Network Process Management
</span><span class="cx">
</span></span></pre>
</div>
</div>
</body>
</html>