<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[160900] trunk/Tools</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/160900">160900</a></dd>
<dt>Author</dt> <dd>commit-queue@webkit.org</dd>
<dt>Date</dt> <dd>2013-12-20 03:00:51 -0800 (Fri, 20 Dec 2013)</dd>
</dl>
<h3>Log Message</h3>
<pre>Removed unused BUILDER_BASE_URL.
https://bugs.webkit.org/show_bug.cgi?id=125442
Patch by Peter Molnar <pmolnar.u-szeged@partner.samsung.com> on 2013-12-20
Reviewed by Csaba Osztrogonác.
The string constant BUILDER_BASE_URL is passed around several times,
but we don't use it anywhere. It is a leftover from Chromium, cleaned it up.
* Scripts/webkitpy/layout_tests/controllers/manager.py:
(Manager._upload_json_files):
* Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
(JSONLayoutResultsGenerator.__init__):
* Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
(JSONResultsGenerator.__init__):</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkToolsChangeLog">trunk/Tools/ChangeLog</a></li>
<li><a href="#trunkToolsScriptswebkitpylayout_testscontrollersmanagerpy">trunk/Tools/Scripts/webkitpy/layout_tests/controllers/manager.py</a></li>
<li><a href="#trunkToolsScriptswebkitpylayout_testslayout_packagejson_layout_results_generatorpy">trunk/Tools/Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py</a></li>
<li><a href="#trunkToolsScriptswebkitpylayout_testslayout_packagejson_results_generatorpy">trunk/Tools/Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkToolsChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Tools/ChangeLog (160899 => 160900)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Tools/ChangeLog 2013-12-20 10:52:32 UTC (rev 160899)
+++ trunk/Tools/ChangeLog 2013-12-20 11:00:51 UTC (rev 160900)
</span><span class="lines">@@ -1,3 +1,20 @@
</span><ins>+2013-12-20 Peter Molnar <pmolnar.u-szeged@partner.samsung.com>
+
+ Removed unused BUILDER_BASE_URL.
+ https://bugs.webkit.org/show_bug.cgi?id=125442
+
+ Reviewed by Csaba Osztrogonác.
+
+ The string constant BUILDER_BASE_URL is passed around several times,
+ but we don't use it anywhere. It is a leftover from Chromium, cleaned it up.
+
+ * Scripts/webkitpy/layout_tests/controllers/manager.py:
+ (Manager._upload_json_files):
+ * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
+ (JSONLayoutResultsGenerator.__init__):
+ * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
+ (JSONResultsGenerator.__init__):
+
</ins><span class="cx"> 2013-12-19 Myles C. Maxfield <mmaxfield@apple.com>
</span><span class="cx">
</span><span class="cx"> check-webkit-style mistakenly flags assigning to a dereferenced pointer
</span></span></pre></div>
<a id="trunkToolsScriptswebkitpylayout_testscontrollersmanagerpy"></a>
<div class="modfile"><h4>Modified: trunk/Tools/Scripts/webkitpy/layout_tests/controllers/manager.py (160899 => 160900)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Tools/Scripts/webkitpy/layout_tests/controllers/manager.py 2013-12-20 10:52:32 UTC (rev 160899)
+++ trunk/Tools/Scripts/webkitpy/layout_tests/controllers/manager.py 2013-12-20 11:00:51 UTC (rev 160900)
</span><span class="lines">@@ -54,9 +54,6 @@
</span><span class="cx">
</span><span class="cx"> _log = logging.getLogger(__name__)
</span><span class="cx">
</span><del>-# Builder base URL where we have the archived test results.
-BUILDER_BASE_URL = "http://build.chromium.org/buildbot/layout_test_results/"
-
</del><span class="cx"> TestExpectations = test_expectations.TestExpectations
</span><span class="cx">
</span><span class="cx">
</span><span class="lines">@@ -356,7 +353,6 @@
</span><span class="cx"> generator = json_layout_results_generator.JSONLayoutResultsGenerator(
</span><span class="cx"> self._port, self._options.builder_name, self._options.build_name,
</span><span class="cx"> self._options.build_number, self._results_directory,
</span><del>- BUILDER_BASE_URL,
</del><span class="cx"> self._expectations, initial_results,
</span><span class="cx"> self._options.test_results_server,
</span><span class="cx"> "layout-tests",
</span></span></pre></div>
<a id="trunkToolsScriptswebkitpylayout_testslayout_packagejson_layout_results_generatorpy"></a>
<div class="modfile"><h4>Modified: trunk/Tools/Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py (160899 => 160900)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Tools/Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py 2013-12-20 10:52:32 UTC (rev 160899)
+++ trunk/Tools/Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py 2013-12-20 11:00:51 UTC (rev 160900)
</span><span class="lines">@@ -52,7 +52,7 @@
</span><span class="cx"> test_expectations.IMAGE_PLUS_TEXT: "Z"}
</span><span class="cx">
</span><span class="cx"> def __init__(self, port, builder_name, build_name, build_number,
</span><del>- results_file_base_path, builder_base_url,
</del><ins>+ results_file_base_path,
</ins><span class="cx"> expectations, run_results,
</span><span class="cx"> test_results_server=None, test_type="", master_name=""):
</span><span class="cx"> """Modifies the results.json file. Grabs it off the archive directory
</span><span class="lines">@@ -63,7 +63,7 @@
</span><span class="cx"> """
</span><span class="cx"> super(JSONLayoutResultsGenerator, self).__init__(
</span><span class="cx"> port, builder_name, build_name, build_number, results_file_base_path,
</span><del>- builder_base_url, {}, port.repository_paths(),
</del><ins>+ {}, port.repository_paths(),
</ins><span class="cx"> test_results_server, test_type, master_name)
</span><span class="cx">
</span><span class="cx"> self._expectations = expectations
</span></span></pre></div>
<a id="trunkToolsScriptswebkitpylayout_testslayout_packagejson_results_generatorpy"></a>
<div class="modfile"><h4>Modified: trunk/Tools/Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py (160899 => 160900)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Tools/Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py 2013-12-20 10:52:32 UTC (rev 160899)
+++ trunk/Tools/Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py 2013-12-20 11:00:51 UTC (rev 160900)
</span><span class="lines">@@ -189,7 +189,7 @@
</span><span class="cx"> URL_FOR_TEST_LIST_JSON = "http://%s/testfile?builder=%s&name=%s&testlistjson=1&testtype=%s&master=%s"
</span><span class="cx">
</span><span class="cx"> def __init__(self, port, builder_name, build_name, build_number,
</span><del>- results_file_base_path, builder_base_url,
</del><ins>+ results_file_base_path,
</ins><span class="cx"> test_results_map, svn_repositories=None,
</span><span class="cx"> test_results_server=None,
</span><span class="cx"> test_type="",
</span><span class="lines">@@ -204,8 +204,6 @@
</span><span class="cx"> build_number: the build number.
</span><span class="cx"> results_file_base_path: Absolute path to the directory containing the
</span><span class="cx"> results json file.
</span><del>- builder_base_url: the URL where we have the archived test results.
- If this is None no archived results will be retrieved.
</del><span class="cx"> test_results_map: A dictionary that maps test_name to TestResult.
</span><span class="cx"> svn_repositories: A (json_field_name, svn_path) pair for SVN
</span><span class="cx"> repositories that tests rely on. The SVN revision will be
</span><span class="lines">@@ -220,7 +218,6 @@
</span><span class="cx"> self._builder_name = builder_name
</span><span class="cx"> self._build_name = build_name
</span><span class="cx"> self._build_number = build_number
</span><del>- self._builder_base_url = builder_base_url
</del><span class="cx"> self._results_directory = results_file_base_path
</span><span class="cx">
</span><span class="cx"> self._test_results_map = test_results_map
</span></span></pre>
</div>
</div>
</body>
</html>