<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[160905] trunk</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/160905">160905</a></dd>
<dt>Author</dt> <dd>stavila@adobe.com</dd>
<dt>Date</dt> <dd>2013-12-20 05:44:45 -0800 (Fri, 20 Dec 2013)</dd>
</dl>
<h3>Log Message</h3>
<pre>[CSS Regions] When changing flow-from/flow-into on :hover, elements overflowing the region are not correctly repainted
https://bugs.webkit.org/show_bug.cgi?id=117259
Reviewed by Antti Koivisto.
Source/WebCore:
When computing the repaint rect for a region, the existing visual overflow must be taken into consideration.
For this purpose, I overridden the visualOverflowRect method in RenderNamedFlowFragment, which ends up being
called from RenderBox::clippedOverflowRectForRepaint.
Test: fast/regions/hover-single-flow-from-none-overflow.html
fast/regions/hover-single-flow-from-none-overflow-top.html
* rendering/RenderNamedFlowFragment.cpp:
(WebCore::RenderNamedFlowFragment::visualOverflowRect):
* rendering/RenderNamedFlowFragment.h:
LayoutTests:
Added new tests and rebased existing test.
* fast/regions/hover-single-flow-from-none-overflow-expected.html: Added.
* fast/regions/hover-single-flow-from-none-overflow.html: Added.
* fast/regions/hover-single-flow-from-none-overflow-top-expected.html: Added.
* fast/regions/hover-single-flow-from-none-overflow-top.html: Added.
* fast/regions/repaint/repaint-regions-overflow-expected.txt: Rebased.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkLayoutTestsChangeLog">trunk/LayoutTests/ChangeLog</a></li>
<li><a href="#trunkLayoutTestsfastregionsrepaintrepaintregionsoverflowexpectedtxt">trunk/LayoutTests/fast/regions/repaint/repaint-regions-overflow-expected.txt</a></li>
<li><a href="#trunkSourceWebCoreChangeLog">trunk/Source/WebCore/ChangeLog</a></li>
<li><a href="#trunkSourceWebCorerenderingRenderNamedFlowFragmentcpp">trunk/Source/WebCore/rendering/RenderNamedFlowFragment.cpp</a></li>
<li><a href="#trunkSourceWebCorerenderingRenderNamedFlowFragmenth">trunk/Source/WebCore/rendering/RenderNamedFlowFragment.h</a></li>
</ul>
<h3>Added Paths</h3>
<ul>
<li><a href="#trunkLayoutTestsfastregionshoversingleflowfromnoneoverflowexpectedhtml">trunk/LayoutTests/fast/regions/hover-single-flow-from-none-overflow-expected.html</a></li>
<li><a href="#trunkLayoutTestsfastregionshoversingleflowfromnoneoverflowtopexpectedhtml">trunk/LayoutTests/fast/regions/hover-single-flow-from-none-overflow-top-expected.html</a></li>
<li><a href="#trunkLayoutTestsfastregionshoversingleflowfromnoneoverflowtophtml">trunk/LayoutTests/fast/regions/hover-single-flow-from-none-overflow-top.html</a></li>
<li><a href="#trunkLayoutTestsfastregionshoversingleflowfromnoneoverflowhtml">trunk/LayoutTests/fast/regions/hover-single-flow-from-none-overflow.html</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkLayoutTestsChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/ChangeLog (160904 => 160905)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/ChangeLog 2013-12-20 12:11:45 UTC (rev 160904)
+++ trunk/LayoutTests/ChangeLog 2013-12-20 13:44:45 UTC (rev 160905)
</span><span class="lines">@@ -1,3 +1,18 @@
</span><ins>+2013-12-20 Radu Stavila <stavila@adobe.com>
+
+ [CSS Regions] When changing flow-from/flow-into on :hover, elements overflowing the region are not correctly repainted
+ https://bugs.webkit.org/show_bug.cgi?id=117259
+
+ Reviewed by Antti Koivisto.
+
+ Added new tests and rebased existing test.
+
+ * fast/regions/hover-single-flow-from-none-overflow-expected.html: Added.
+ * fast/regions/hover-single-flow-from-none-overflow.html: Added.
+ * fast/regions/hover-single-flow-from-none-overflow-top-expected.html: Added.
+ * fast/regions/hover-single-flow-from-none-overflow-top.html: Added.
+ * fast/regions/repaint/repaint-regions-overflow-expected.txt: Rebased.
+
</ins><span class="cx"> 2013-12-20 Mario Sanchez Prada <mario.prada@samsung.com>
</span><span class="cx">
</span><span class="cx"> Programmatically-inserted children lack accessibility events
</span></span></pre></div>
<a id="trunkLayoutTestsfastregionshoversingleflowfromnoneoverflowexpectedhtml"></a>
<div class="addfile"><h4>Added: trunk/LayoutTests/fast/regions/hover-single-flow-from-none-overflow-expected.html (0 => 160905)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/fast/regions/hover-single-flow-from-none-overflow-expected.html (rev 0)
+++ trunk/LayoutTests/fast/regions/hover-single-flow-from-none-overflow-expected.html 2013-12-20 13:44:45 UTC (rev 160905)
</span><span class="lines">@@ -0,0 +1,23 @@
</span><ins>+<!doctype html>
+<html lang="en">
+<head>
+ <style>
+ p, div {
+ font: 12px/1 monospace;
+ }
+ #region {
+ width: 300px;
+ height: 190px;
+ border: 5px solid green;
+ border-left: 100px solid green;
+ border-color: darkred;
+ background-color: #ddddff;
+ }
+ </style>
+</head>
+<body>
+ <a href="https://bugs.webkit.org/show_bug.cgi?id=117259">[CSS Regions] When changing flow-from/flow-into on :hover, elements overflowing the region are not correctly repainted</a>
+ <p>When hovering the <span style="color:green"><b>region</b></span>, the <span style="color:blue"><b>blue</b></span> box <b>and its overflow</b> should disappear (the region's <b>flow-from</b> will change to "none")</p>
+ <div id="region"></div>
+</body>
+</html>
</ins><span class="cx">\ No newline at end of file
</span></span></pre></div>
<a id="trunkLayoutTestsfastregionshoversingleflowfromnoneoverflowtopexpectedhtml"></a>
<div class="addfile"><h4>Added: trunk/LayoutTests/fast/regions/hover-single-flow-from-none-overflow-top-expected.html (0 => 160905)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/fast/regions/hover-single-flow-from-none-overflow-top-expected.html (rev 0)
+++ trunk/LayoutTests/fast/regions/hover-single-flow-from-none-overflow-top-expected.html 2013-12-20 13:44:45 UTC (rev 160905)
</span><span class="lines">@@ -0,0 +1,25 @@
</span><ins>+<!doctype html>
+<html lang="en">
+<head>
+ <style>
+ p, div {
+ font: 12px/1 monospace;
+ }
+ #region {
+ width: 300px;
+ height: 190px;
+ border: 5px solid green;
+ border-left: 100px solid green;
+ border-color: darkred;
+ background-color: #ddddff;
+ margin-top: 50px;
+ margin-left: 50px;
+ }
+ </style>
+</head>
+<body>
+ <a href="https://bugs.webkit.org/show_bug.cgi?id=117259">[CSS Regions] When changing flow-from/flow-into on :hover, elements overflowing the region are not correctly repainted</a>
+ <p>When hovering the <span style="color:green"><b>region</b></span>, the <span style="color:blue"><b>blue</b></span> box <b>and its overflow</b> should disappear (the region's <b>flow-from</b> will change to "none")</p>
+ <div id="region"></div>
+</body>
+</html>
</ins><span class="cx">\ No newline at end of file
</span></span></pre></div>
<a id="trunkLayoutTestsfastregionshoversingleflowfromnoneoverflowtophtml"></a>
<div class="addfile"><h4>Added: trunk/LayoutTests/fast/regions/hover-single-flow-from-none-overflow-top.html (0 => 160905)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/fast/regions/hover-single-flow-from-none-overflow-top.html (rev 0)
+++ trunk/LayoutTests/fast/regions/hover-single-flow-from-none-overflow-top.html 2013-12-20 13:44:45 UTC (rev 160905)
</span><span class="lines">@@ -0,0 +1,62 @@
</span><ins>+<!doctype html>
+<html lang="en">
+<head>
+ <style>
+ p, div {
+ font: 12px/1 monospace;
+ }
+ .box {
+ width: 260px;
+ padding: 5px;
+ margin: 10px;
+ }
+
+ #region {
+ -webkit-flow-from: flow;
+ width: 300px;
+ height: 190px;
+ border: 5px solid green;
+ border-left: 100px solid green;
+ background-color: #ddddff;
+ margin-top: 50px;
+ margin-left: 50px;
+ }
+ #region:hover {
+ border-color: darkred;
+ -webkit-flow-from: none;
+ }
+
+ #content {
+ -webkit-flow-into: flow;
+ border: 5px solid blue;
+ margin-top: -50px;
+ margin-left: -130px;
+ height: 250px;
+ }
+ </style>
+</head>
+
+<script type="text/javascript">
+ if (window.testRunner)
+ testRunner.waitUntilDone();
+
+ function beginTest() {
+ if (window.eventSender) {
+ var region = document.querySelector("#region");
+
+ // move mouse on the hover test object
+ eventSender.mouseMoveTo(region.offsetLeft + 280, region.offsetTop + 20);
+ eventSender.mouseDown(0);
+
+ testRunner.notifyDone();
+ }
+ }
+</script>
+
+<body onload="beginTest()">
+ <a href="https://bugs.webkit.org/show_bug.cgi?id=117259">[CSS Regions] When changing flow-from/flow-into on :hover, elements overflowing the region are not correctly repainted</a>
+ <p>When hovering the <span style="color:green"><b>region</b></span>, the <span style="color:blue"><b>blue</b></span> box <b>and its overflow</b> should disappear (the region's <b>flow-from</b> will change to "none")</p>
+ <div id="region"></div>
+ <div id="content" class="box">This box is flowed into the <span style="color:green"><b>region</b></span></div>
+</body>
+</html>
</ins><span class="cx">\ No newline at end of file
</span></span></pre></div>
<a id="trunkLayoutTestsfastregionshoversingleflowfromnoneoverflowhtml"></a>
<div class="addfile"><h4>Added: trunk/LayoutTests/fast/regions/hover-single-flow-from-none-overflow.html (0 => 160905)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/fast/regions/hover-single-flow-from-none-overflow.html (rev 0)
+++ trunk/LayoutTests/fast/regions/hover-single-flow-from-none-overflow.html 2013-12-20 13:44:45 UTC (rev 160905)
</span><span class="lines">@@ -0,0 +1,59 @@
</span><ins>+<!doctype html>
+<html lang="en">
+<head>
+ <style>
+ p, div {
+ font: 12px/1 monospace;
+ }
+ .box {
+ width: 260px;
+ height: 120px;
+ padding: 5px;
+ margin: 10px;
+ }
+
+ #region {
+ -webkit-flow-from: flow;
+ width: 300px;
+ height: 190px;
+ border: 5px solid green;
+ border-left: 100px solid green;
+ background-color: #ddddff;
+ }
+ #region:hover {
+ border-color: darkred;
+ -webkit-flow-from: none;
+ }
+
+ #content {
+ -webkit-flow-into: flow;
+ border: 5px solid blue;
+ height: 250px;
+ }
+ </style>
+</head>
+
+<script type="text/javascript">
+ if (window.testRunner)
+ testRunner.waitUntilDone();
+
+ function beginTest() {
+ if (window.eventSender) {
+ var region = document.querySelector("#region");
+
+ // move mouse on the hover test object
+ eventSender.mouseMoveTo(region.offsetLeft + 20, region.offsetTop + 20);
+ eventSender.mouseDown(0);
+
+ testRunner.notifyDone();
+ }
+ }
+</script>
+
+<body onload="beginTest()">
+ <a href="https://bugs.webkit.org/show_bug.cgi?id=117259">[CSS Regions] When changing flow-from/flow-into on :hover, elements overflowing the region are not correctly repainted</a>
+ <p>When hovering the <span style="color:green"><b>region</b></span>, the <span style="color:blue"><b>blue</b></span> box <b>and its overflow</b> should disappear (the region's <b>flow-from</b> will change to "none")</p>
+ <div id="region"></div>
+ <div id="content" class="box">This box is flowed into the <span style="color:green"><b>region</b></span></div>
+</body>
+</html>
</ins><span class="cx">\ No newline at end of file
</span></span></pre></div>
<a id="trunkLayoutTestsfastregionsrepaintrepaintregionsoverflowexpectedtxt"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/fast/regions/repaint/repaint-regions-overflow-expected.txt (160904 => 160905)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/fast/regions/repaint/repaint-regions-overflow-expected.txt 2013-12-20 12:11:45 UTC (rev 160904)
+++ trunk/LayoutTests/fast/regions/repaint/repaint-regions-overflow-expected.txt 2013-12-20 13:44:45 UTC (rev 160905)
</span><span class="lines">@@ -5,15 +5,15 @@
</span><span class="cx"> LAST LINE
</span><span class="cx">
</span><span class="cx"> (repaint rects
</span><del>- (rect 106 206 300 100)
</del><ins>+ (rect 106 306 300 160)
</ins><span class="cx"> (rect 14 72 300 210)
</span><span class="cx"> (rect 106 122 300 210)
</span><span class="cx"> (rect 14 298 300 18)
</span><span class="cx"> (rect 106 348 300 18)
</span><span class="cx"> (rect 14 56 300 260)
</span><span class="cx"> (rect 106 106 300 260)
</span><del>- (rect 60 150 312 112)
- (rect 100 200 312 112)
</del><ins>+ (rect 60 150 312 266)
+ (rect 100 200 312 266)
</ins><span class="cx"> (rect 14 56 300 260)
</span><span class="cx"> (rect 106 106 300 260)
</span><span class="cx"> (rect 14 56 300 260)
</span></span></pre></div>
<a id="trunkSourceWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/ChangeLog (160904 => 160905)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/ChangeLog 2013-12-20 12:11:45 UTC (rev 160904)
+++ trunk/Source/WebCore/ChangeLog 2013-12-20 13:44:45 UTC (rev 160905)
</span><span class="lines">@@ -1,3 +1,21 @@
</span><ins>+2013-12-20 Radu Stavila <stavila@adobe.com>
+
+ [CSS Regions] When changing flow-from/flow-into on :hover, elements overflowing the region are not correctly repainted
+ https://bugs.webkit.org/show_bug.cgi?id=117259
+
+ Reviewed by Antti Koivisto.
+
+ When computing the repaint rect for a region, the existing visual overflow must be taken into consideration.
+ For this purpose, I overridden the visualOverflowRect method in RenderNamedFlowFragment, which ends up being
+ called from RenderBox::clippedOverflowRectForRepaint.
+
+ Test: fast/regions/hover-single-flow-from-none-overflow.html
+ fast/regions/hover-single-flow-from-none-overflow-top.html
+
+ * rendering/RenderNamedFlowFragment.cpp:
+ (WebCore::RenderNamedFlowFragment::visualOverflowRect):
+ * rendering/RenderNamedFlowFragment.h:
+
</ins><span class="cx"> 2013-12-20 Mario Sanchez Prada <mario.prada@samsung.com>
</span><span class="cx">
</span><span class="cx"> Programmatically-inserted children lack accessibility events
</span></span></pre></div>
<a id="trunkSourceWebCorerenderingRenderNamedFlowFragmentcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/rendering/RenderNamedFlowFragment.cpp (160904 => 160905)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/rendering/RenderNamedFlowFragment.cpp 2013-12-20 12:11:45 UTC (rev 160904)
+++ trunk/Source/WebCore/rendering/RenderNamedFlowFragment.cpp 2013-12-20 13:44:45 UTC (rev 160905)
</span><span class="lines">@@ -266,4 +266,15 @@
</span><span class="cx"> return toRenderNamedFlowThread(flowThread());
</span><span class="cx"> }
</span><span class="cx">
</span><ins>+LayoutRect RenderNamedFlowFragment::visualOverflowRect() const
+{
+ if (isValid()) {
+ RenderBoxRegionInfo* boxInfo = renderBoxRegionInfo(flowThread());
+ if (boxInfo && boxInfo->overflow())
+ return boxInfo->overflow()->visualOverflowRect();
+ }
+
+ return RenderRegion::visualOverflowRect();
+}
+
</ins><span class="cx"> } // namespace WebCore
</span></span></pre></div>
<a id="trunkSourceWebCorerenderingRenderNamedFlowFragmenth"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/rendering/RenderNamedFlowFragment.h (160904 => 160905)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/rendering/RenderNamedFlowFragment.h 2013-12-20 12:11:45 UTC (rev 160904)
+++ trunk/Source/WebCore/rendering/RenderNamedFlowFragment.h 2013-12-20 13:44:45 UTC (rev 160905)
</span><span class="lines">@@ -74,6 +74,8 @@
</span><span class="cx">
</span><span class="cx"> void setRegionObjectsRegionStyle();
</span><span class="cx"> void restoreRegionObjectsOriginalStyle();
</span><ins>+
+ virtual LayoutRect visualOverflowRect() const OVERRIDE;
</ins><span class="cx">
</span><span class="cx"> RenderNamedFlowThread* namedFlowThread() const;
</span><span class="cx">
</span></span></pre>
</div>
</div>
</body>
</html>