<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[160850] trunk</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/160850">160850</a></dd>
<dt>Author</dt> <dd>commit-queue@webkit.org</dd>
<dt>Date</dt> <dd>2013-12-19 11:49:35 -0800 (Thu, 19 Dec 2013)</dd>
</dl>
<h3>Log Message</h3>
<pre>Unreviewed, rolling out <a href="http://trac.webkit.org/projects/webkit/changeset/160842">r160842</a>.
http://trac.webkit.org/changeset/160842
https://bugs.webkit.org/show_bug.cgi?id=126003
broke accessibility/loading-iframe-updates-axtree.html
(Requested by ap on #webkit).
Tools:
* DumpRenderTree/AccessibilityUIElement.cpp:
(AccessibilityUIElement::makeJSAccessibilityUIElement):
* DumpRenderTree/AccessibilityUIElement.h:
(AccessibilityUIElement::platformUIElement):
LayoutTests:
* accessibility/deleting-iframe-destroys-axcache.html:
* accessibility/loading-iframe-updates-axtree-expected.txt:
* accessibility/loading-iframe-updates-axtree.html:
* accessibility/non-data-table-cell-title-ui-element.html:
* platform/gtk/accessibility/roles-exposed-expected.txt:
* platform/gtk/accessibility/roles-exposed.html:
* platform/mac-wk2/TestExpectations:
* platform/mac/accessibility/search-predicate-expected.txt:
* platform/mac/accessibility/search-predicate.html:
* platform/mac/accessibility/search-when-element-starts-in-table-expected.txt:
* platform/mac/accessibility/search-when-element-starts-in-table.html:</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkLayoutTestsChangeLog">trunk/LayoutTests/ChangeLog</a></li>
<li><a href="#trunkLayoutTestsaccessibilitydeletingiframedestroysaxcachehtml">trunk/LayoutTests/accessibility/deleting-iframe-destroys-axcache.html</a></li>
<li><a href="#trunkLayoutTestsaccessibilityloadingiframeupdatesaxtreeexpectedtxt">trunk/LayoutTests/accessibility/loading-iframe-updates-axtree-expected.txt</a></li>
<li><a href="#trunkLayoutTestsaccessibilityloadingiframeupdatesaxtreehtml">trunk/LayoutTests/accessibility/loading-iframe-updates-axtree.html</a></li>
<li><a href="#trunkLayoutTestsaccessibilitynondatatablecelltitleuielementhtml">trunk/LayoutTests/accessibility/non-data-table-cell-title-ui-element.html</a></li>
<li><a href="#trunkLayoutTestsplatformgtkaccessibilityrolesexposedexpectedtxt">trunk/LayoutTests/platform/gtk/accessibility/roles-exposed-expected.txt</a></li>
<li><a href="#trunkLayoutTestsplatformgtkaccessibilityrolesexposedhtml">trunk/LayoutTests/platform/gtk/accessibility/roles-exposed.html</a></li>
<li><a href="#trunkLayoutTestsplatformmacaccessibilitysearchpredicateexpectedtxt">trunk/LayoutTests/platform/mac/accessibility/search-predicate-expected.txt</a></li>
<li><a href="#trunkLayoutTestsplatformmacaccessibilitysearchpredicatehtml">trunk/LayoutTests/platform/mac/accessibility/search-predicate.html</a></li>
<li><a href="#trunkLayoutTestsplatformmacaccessibilitysearchwhenelementstartsintableexpectedtxt">trunk/LayoutTests/platform/mac/accessibility/search-when-element-starts-in-table-expected.txt</a></li>
<li><a href="#trunkLayoutTestsplatformmacaccessibilitysearchwhenelementstartsintablehtml">trunk/LayoutTests/platform/mac/accessibility/search-when-element-starts-in-table.html</a></li>
<li><a href="#trunkLayoutTestsplatformmacwk2TestExpectations">trunk/LayoutTests/platform/mac-wk2/TestExpectations</a></li>
<li><a href="#trunkToolsChangeLog">trunk/Tools/ChangeLog</a></li>
<li><a href="#trunkToolsDumpRenderTreeAccessibilityUIElementcpp">trunk/Tools/DumpRenderTree/AccessibilityUIElement.cpp</a></li>
<li><a href="#trunkToolsDumpRenderTreeAccessibilityUIElementh">trunk/Tools/DumpRenderTree/AccessibilityUIElement.h</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkLayoutTestsChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/ChangeLog (160849 => 160850)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/ChangeLog 2013-12-19 19:42:22 UTC (rev 160849)
+++ trunk/LayoutTests/ChangeLog 2013-12-19 19:49:35 UTC (rev 160850)
</span><span class="lines">@@ -1,3 +1,24 @@
</span><ins>+2013-12-19 Commit Queue <commit-queue@webkit.org>
+
+ Unreviewed, rolling out r160842.
+ http://trac.webkit.org/changeset/160842
+ https://bugs.webkit.org/show_bug.cgi?id=126003
+
+ broke accessibility/loading-iframe-updates-axtree.html
+ (Requested by ap on #webkit).
+
+ * accessibility/deleting-iframe-destroys-axcache.html:
+ * accessibility/loading-iframe-updates-axtree-expected.txt:
+ * accessibility/loading-iframe-updates-axtree.html:
+ * accessibility/non-data-table-cell-title-ui-element.html:
+ * platform/gtk/accessibility/roles-exposed-expected.txt:
+ * platform/gtk/accessibility/roles-exposed.html:
+ * platform/mac-wk2/TestExpectations:
+ * platform/mac/accessibility/search-predicate-expected.txt:
+ * platform/mac/accessibility/search-predicate.html:
+ * platform/mac/accessibility/search-when-element-starts-in-table-expected.txt:
+ * platform/mac/accessibility/search-when-element-starts-in-table.html:
+
</ins><span class="cx"> 2013-12-19 Ryosuke Niwa <rniwa@webkit.org>
</span><span class="cx">
</span><span class="cx"> overflowchanged event could cause a crash
</span></span></pre></div>
<a id="trunkLayoutTestsaccessibilitydeletingiframedestroysaxcachehtml"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/accessibility/deleting-iframe-destroys-axcache.html (160849 => 160850)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/accessibility/deleting-iframe-destroys-axcache.html 2013-12-19 19:42:22 UTC (rev 160849)
+++ trunk/LayoutTests/accessibility/deleting-iframe-destroys-axcache.html 2013-12-19 19:49:35 UTC (rev 160850)
</span><span class="lines">@@ -38,9 +38,9 @@
</span><span class="cx"> if (window.accessibilityController) {
</span><span class="cx"> window.root = accessibilityController.rootElement;
</span><span class="cx"> window.body = root.childAtIndex(0);
</span><del>- window.before = body.childAtIndex(0);
</del><ins>+ window.before = body.childAtIndex(0).childAtIndex(0);
</ins><span class="cx"> window.iframe = body.childAtIndex(1).childAtIndex(0);
</span><del>- window.after = body.childAtIndex(2);
</del><ins>+ window.after = body.childAtIndex(2).childAtIndex(0);
</ins><span class="cx">
</span><span class="cx"> window.frameBody = window.iframe.childAtIndex(0);
</span><span class="cx"> window.frameBodyRole = window.frameBody.role;
</span><span class="lines">@@ -57,8 +57,8 @@
</span><span class="cx">
</span><span class="cx"> window.newRoot = accessibilityController.rootElement;
</span><span class="cx"> window.newBody = newRoot.childAtIndex(0);
</span><del>- window.newBefore = newBody.childAtIndex(0);
- window.newAfter = newBody.childAtIndex(1);
</del><ins>+ window.newBefore = newBody.childAtIndex(0).childAtIndex(0);
+ window.newAfter = newBody.childAtIndex(1).childAtIndex(0);
</ins><span class="cx">
</span><span class="cx"> document.getElementById("console").innerText += "\nAfter:\n";
</span><span class="cx"> buildAccessibilityTree(newRoot, 0);
</span></span></pre></div>
<a id="trunkLayoutTestsaccessibilityloadingiframeupdatesaxtreeexpectedtxt"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/accessibility/loading-iframe-updates-axtree-expected.txt (160849 => 160850)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/accessibility/loading-iframe-updates-axtree-expected.txt 2013-12-19 19:42:22 UTC (rev 160849)
+++ trunk/LayoutTests/accessibility/loading-iframe-updates-axtree-expected.txt 2013-12-19 19:49:35 UTC (rev 160850)
</span><span class="lines">@@ -12,7 +12,7 @@
</span><span class="cx">
</span><span class="cx"> PASS iframe.isEqual(newIframe) is true
</span><span class="cx"> PASS scrollarea.isEqual(newScrollarea) is false
</span><del>-PASS newSubwebarea.isEqual(subwebarea) is false
</del><ins>+PASS subwebarea.isEqual(newSubwebarea) is false
</ins><span class="cx"> PASS newSubwebarea.childrenCount > 0 is true
</span><span class="cx">
</span><span class="cx"> TEST COMPLETE
</span></span></pre></div>
<a id="trunkLayoutTestsaccessibilityloadingiframeupdatesaxtreehtml"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/accessibility/loading-iframe-updates-axtree.html (160849 => 160850)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/accessibility/loading-iframe-updates-axtree.html 2013-12-19 19:42:22 UTC (rev 160849)
+++ trunk/LayoutTests/accessibility/loading-iframe-updates-axtree.html 2013-12-19 19:49:35 UTC (rev 160850)
</span><span class="lines">@@ -25,7 +25,7 @@
</span><span class="cx">
</span><span class="cx"> shouldBeTrue("iframe.isEqual(newIframe)");
</span><span class="cx"> shouldBeFalse("scrollarea.isEqual(newScrollarea)");
</span><del>- shouldBeFalse("newSubwebarea.isEqual(subwebarea)");
</del><ins>+ shouldBeFalse("subwebarea.isEqual(newSubwebarea)");
</ins><span class="cx"> shouldBeTrue("newSubwebarea.childrenCount > 0");
</span><span class="cx"> }
</span><span class="cx">
</span></span></pre></div>
<a id="trunkLayoutTestsaccessibilitynondatatablecelltitleuielementhtml"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/accessibility/non-data-table-cell-title-ui-element.html (160849 => 160850)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/accessibility/non-data-table-cell-title-ui-element.html 2013-12-19 19:42:22 UTC (rev 160849)
+++ trunk/LayoutTests/accessibility/non-data-table-cell-title-ui-element.html 2013-12-19 19:49:35 UTC (rev 160850)
</span><span class="lines">@@ -14,7 +14,7 @@
</span><span class="cx"> <th>issue</th>
</span><span class="cx"> <th>fail</th>
</span><span class="cx"> <th>blocked</th>
</span><del>-<th id="skip">skip</th>
</del><ins>+<th>skip</th>
</ins><span class="cx"> <th>test</th>
</span><span class="cx"> </tr>
</span><span class="cx"> </tbody>
</span><span class="lines">@@ -28,8 +28,9 @@
</span><span class="cx"> var result = document.getElementById("result");
</span><span class="cx">
</span><span class="cx"> var pass = document.getElementById("body");
</span><ins>+ body.focus();
</ins><span class="cx"> // get the <th>skip</th> element
</span><del>- var group = accessibilityController.accessibleElementById("skip");
</del><ins>+ var group = accessibilityController.focusedElement.childAtIndex(5);
</ins><span class="cx"> var titleUI = group.titleUIElement();
</span><span class="cx"> var allAttributes = "";
</span><span class="cx"> if (titleUI)
</span></span></pre></div>
<a id="trunkLayoutTestsplatformgtkaccessibilityrolesexposedexpectedtxt"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/platform/gtk/accessibility/roles-exposed-expected.txt (160849 => 160850)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/platform/gtk/accessibility/roles-exposed-expected.txt 2013-12-19 19:42:22 UTC (rev 160849)
+++ trunk/LayoutTests/platform/gtk/accessibility/roles-exposed-expected.txt 2013-12-19 19:49:35 UTC (rev 160850)
</span><span class="lines">@@ -172,21 +172,21 @@
</span><span class="cx"> AXRole: AXTable
</span><span class="cx">
</span><span class="cx"> FAIL: tr
</span><del>- AXRole: (no element)
</del><ins>+
</ins><span class="cx"> Expected: AXRow
</span><span class="cx">
</span><span class="cx"> PASS: th
</span><span class="cx"> AXRole: AXCell
</span><span class="cx">
</span><span class="cx"> FAIL: tr
</span><del>- AXRole: (no element)
</del><ins>+
</ins><span class="cx"> Expected: AXRow
</span><span class="cx">
</span><span class="cx"> PASS: td
</span><span class="cx"> AXRole: AXCell
</span><span class="cx">
</span><span class="cx"> FAIL: tr
</span><del>- AXRole: (no element)
</del><ins>+
</ins><span class="cx"> Expected: AXRow
</span><span class="cx">
</span><span class="cx"> PASS: th
</span><span class="lines">@@ -279,12 +279,11 @@
</span><span class="cx"> PASS: div[role=grid]
</span><span class="cx"> AXRole: AXTable
</span><span class="cx">
</span><del>-FAIL: div[role=rowgroup]
- AXRole: (no element)
- Expected:
-
</del><ins>+PASS: div[role=rowgroup]
+
+
</ins><span class="cx"> FAIL: div[role=row]
</span><del>- AXRole: (no element)
</del><ins>+
</ins><span class="cx"> Expected: AXRow
</span><span class="cx">
</span><span class="cx"> PASS: div[role=gridcell]
</span><span class="lines">@@ -399,12 +398,11 @@
</span><span class="cx"> PASS: div[role=treegrid]
</span><span class="cx"> AXRole: AXTable
</span><span class="cx">
</span><del>-FAIL: div[role=rowgroup]
- AXRole: (no element)
- Expected:
-
</del><ins>+PASS: div[role=rowgroup]
+
+
</ins><span class="cx"> FAIL: div[role=row]
</span><del>- AXRole: (no element)
</del><ins>+
</ins><span class="cx"> Expected: AXRow
</span><span class="cx">
</span><span class="cx"> PASS: div[role=gridcell]
</span></span></pre></div>
<a id="trunkLayoutTestsplatformgtkaccessibilityrolesexposedhtml"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/platform/gtk/accessibility/roles-exposed.html (160849 => 160850)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/platform/gtk/accessibility/roles-exposed.html 2013-12-19 19:42:22 UTC (rev 160849)
+++ trunk/LayoutTests/platform/gtk/accessibility/roles-exposed.html 2013-12-19 19:49:35 UTC (rev 160850)
</span><span class="lines">@@ -291,7 +291,7 @@
</span><span class="cx"> if (axElement)
</span><span class="cx"> role = axElement.role;
</span><span class="cx"> else
</span><del>- role = 'AXRole: (no element)';
</del><ins>+ role = 'AXRole: ';
</ins><span class="cx">
</span><span class="cx"> output = el.tagName.toLowerCase() + (ariaRole?("[role="+ariaRole+"]"):'');
</span><span class="cx"> if (el.getAttribute('data-note')) {
</span></span></pre></div>
<a id="trunkLayoutTestsplatformmacaccessibilitysearchpredicateexpectedtxt"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/platform/mac/accessibility/search-predicate-expected.txt (160849 => 160850)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/platform/mac/accessibility/search-predicate-expected.txt 2013-12-19 19:42:22 UTC (rev 160849)
+++ trunk/LayoutTests/platform/mac/accessibility/search-predicate-expected.txt 2013-12-19 19:49:35 UTC (rev 160850)
</span><span class="lines">@@ -145,7 +145,7 @@
</span><span class="cx"> PASS resultElement.title is 'AXTitle: test button 2'
</span><span class="cx"> PASS resultElement.role is 'AXRole: AXButton'
</span><span class="cx"> PASS resultElement.title is 'AXTitle: Submit'
</span><del>-PASS resultElement is undefined.
</del><ins>+PASS resultElement.role is 'AXRole: '
</ins><span class="cx"> PASS successfullyParsed is true
</span><span class="cx">
</span><span class="cx"> TEST COMPLETE
</span></span></pre></div>
<a id="trunkLayoutTestsplatformmacaccessibilitysearchpredicatehtml"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/platform/mac/accessibility/search-predicate.html (160849 => 160850)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/platform/mac/accessibility/search-predicate.html 2013-12-19 19:42:22 UTC (rev 160849)
+++ trunk/LayoutTests/platform/mac/accessibility/search-predicate.html 2013-12-19 19:49:35 UTC (rev 160850)
</span><span class="lines">@@ -364,7 +364,7 @@
</span><span class="cx">
</span><span class="cx"> // there should be no more visible buttons
</span><span class="cx"> resultElement = containerElement.uiElementForSearchPredicate(resultElement, true, "AXButtonSearchKey", "", true);
</span><del>- shouldBeUndefined("resultElement");
</del><ins>+ shouldBe("resultElement.role", "'AXRole: '");
</ins><span class="cx">
</span><span class="cx"> }
</span><span class="cx">
</span></span></pre></div>
<a id="trunkLayoutTestsplatformmacaccessibilitysearchwhenelementstartsintableexpectedtxt"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/platform/mac/accessibility/search-when-element-starts-in-table-expected.txt (160849 => 160850)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/platform/mac/accessibility/search-when-element-starts-in-table-expected.txt 2013-12-19 19:42:22 UTC (rev 160849)
+++ trunk/LayoutTests/platform/mac/accessibility/search-when-element-starts-in-table-expected.txt 2013-12-19 19:49:35 UTC (rev 160850)
</span><span class="lines">@@ -10,7 +10,7 @@
</span><span class="cx">
</span><span class="cx"> PASS resultElement.role is 'AXRole: AXHeading'
</span><span class="cx"> PASS resultElement.title is 'AXTitle: outside heading'
</span><del>-PASS resultElement is undefined.
</del><ins>+PASS resultElement.role is 'AXRole: '
</ins><span class="cx"> PASS resultElement.role is 'AXRole: AXHeading'
</span><span class="cx"> PASS resultElement.role is 'AXRole: AXCell'
</span><span class="cx"> PASS resultElement.role is 'AXRole: AXRow'
</span></span></pre></div>
<a id="trunkLayoutTestsplatformmacaccessibilitysearchwhenelementstartsintablehtml"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/platform/mac/accessibility/search-when-element-starts-in-table.html (160849 => 160850)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/platform/mac/accessibility/search-when-element-starts-in-table.html 2013-12-19 19:42:22 UTC (rev 160849)
+++ trunk/LayoutTests/platform/mac/accessibility/search-when-element-starts-in-table.html 2013-12-19 19:49:35 UTC (rev 160850)
</span><span class="lines">@@ -32,7 +32,7 @@
</span><span class="cx">
</span><span class="cx"> // A search for the previous heading should return nothing.
</span><span class="cx"> resultElement = containerElement.uiElementForSearchPredicate(heading, false, "AXHeadingSearchKey", "", false);
</span><del>- shouldBeUndefined("resultElement");
</del><ins>+ shouldBe("resultElement.role", "'AXRole: '");
</ins><span class="cx">
</span><span class="cx"> // When asking the child of the heading for the previous element, it should return the heading.
</span><span class="cx"> resultElement = containerElement.uiElementForSearchPredicate(heading.childAtIndex(0), false, "AXAnyTypeSearchKey", "", false);
</span></span></pre></div>
<a id="trunkLayoutTestsplatformmacwk2TestExpectations"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/platform/mac-wk2/TestExpectations (160849 => 160850)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/platform/mac-wk2/TestExpectations 2013-12-19 19:42:22 UTC (rev 160849)
+++ trunk/LayoutTests/platform/mac-wk2/TestExpectations 2013-12-19 19:49:35 UTC (rev 160850)
</span><span class="lines">@@ -382,9 +382,6 @@
</span><span class="cx">
</span><span class="cx"> webkit.org/b/124476 platform/mac-wk2/plugins/slow/asynchronous-plugin-initialization-multiple.html [ Pass Failure ]
</span><span class="cx">
</span><del>-# uiElementForSearchPredicate() is not returning an undefined object when the search returns no results
-webkit.org/b/125996 platform/mac/accessibility/search-when-element-starts-in-table.html [ Failure ]
-
</del><span class="cx"> ### END OF (1) Classified failures with bug reports
</span><span class="cx"> ########################################
</span><span class="cx">
</span></span></pre></div>
<a id="trunkToolsChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Tools/ChangeLog (160849 => 160850)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Tools/ChangeLog 2013-12-19 19:42:22 UTC (rev 160849)
+++ trunk/Tools/ChangeLog 2013-12-19 19:49:35 UTC (rev 160850)
</span><span class="lines">@@ -1,3 +1,17 @@
</span><ins>+2013-12-19 Commit Queue <commit-queue@webkit.org>
+
+ Unreviewed, rolling out r160842.
+ http://trac.webkit.org/changeset/160842
+ https://bugs.webkit.org/show_bug.cgi?id=126003
+
+ broke accessibility/loading-iframe-updates-axtree.html
+ (Requested by ap on #webkit).
+
+ * DumpRenderTree/AccessibilityUIElement.cpp:
+ (AccessibilityUIElement::makeJSAccessibilityUIElement):
+ * DumpRenderTree/AccessibilityUIElement.h:
+ (AccessibilityUIElement::platformUIElement):
+
</ins><span class="cx"> 2013-12-19 Dániel Bátyai <dbatyai.u-szeged@partner.samsung.com>
</span><span class="cx">
</span><span class="cx"> get_test_baseline should get Host from test_config
</span></span></pre></div>
<a id="trunkToolsDumpRenderTreeAccessibilityUIElementcpp"></a>
<div class="modfile"><h4>Modified: trunk/Tools/DumpRenderTree/AccessibilityUIElement.cpp (160849 => 160850)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Tools/DumpRenderTree/AccessibilityUIElement.cpp 2013-12-19 19:42:22 UTC (rev 160849)
+++ trunk/Tools/DumpRenderTree/AccessibilityUIElement.cpp 2013-12-19 19:49:35 UTC (rev 160850)
</span><span class="lines">@@ -1358,9 +1358,6 @@
</span><span class="cx">
</span><span class="cx"> JSObjectRef AccessibilityUIElement::makeJSAccessibilityUIElement(JSContextRef context, const AccessibilityUIElement& element)
</span><span class="cx"> {
</span><del>- if (!element.platformUIElement())
- return nullptr;
-
</del><span class="cx"> return JSObjectMake(context, AccessibilityUIElement::getJSClass(), new AccessibilityUIElement(element));
</span><span class="cx"> }
</span><span class="cx">
</span></span></pre></div>
<a id="trunkToolsDumpRenderTreeAccessibilityUIElementh"></a>
<div class="modfile"><h4>Modified: trunk/Tools/DumpRenderTree/AccessibilityUIElement.h (160849 => 160850)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Tools/DumpRenderTree/AccessibilityUIElement.h 2013-12-19 19:42:22 UTC (rev 160849)
+++ trunk/Tools/DumpRenderTree/AccessibilityUIElement.h 2013-12-19 19:49:35 UTC (rev 160850)
</span><span class="lines">@@ -67,7 +67,7 @@
</span><span class="cx"> AccessibilityUIElement(const AccessibilityUIElement&);
</span><span class="cx"> ~AccessibilityUIElement();
</span><span class="cx">
</span><del>- PlatformUIElement platformUIElement() const { return m_element; }
</del><ins>+ PlatformUIElement platformUIElement() { return m_element; }
</ins><span class="cx">
</span><span class="cx"> static JSObjectRef makeJSAccessibilityUIElement(JSContextRef, const AccessibilityUIElement&);
</span><span class="cx">
</span></span></pre>
</div>
</div>
</body>
</html>