<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[160864] trunk/Tools</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/160864">160864</a></dd>
<dt>Author</dt> <dd>commit-queue@webkit.org</dd>
<dt>Date</dt> <dd>2013-12-19 15:23:37 -0800 (Thu, 19 Dec 2013)</dd>
</dl>
<h3>Log Message</h3>
<pre>check-webkit-style marks rvalue references as violations
https://bugs.webkit.org/show_bug.cgi?id=126000
Patch by Myles C. Maxfield <mmaxfield@apple.com> on 2013-12-19
Reviewed by Ryosuke Niwa.
Previously, check-webkit-style was making sure that any line with "&&" had
spaces around it. However, we can now legitimately use "&&" without a previous
space when declaring an rvalue reference. This patch relaxes this check.
* Scripts/webkitpy/style/checkers/cpp.py:
(check_spacing):
* Scripts/webkitpy/style/checkers/cpp_unittest.py:
(CppStyleTest.test_spacing_for_binary_ops):</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkToolsChangeLog">trunk/Tools/ChangeLog</a></li>
<li><a href="#trunkToolsScriptswebkitpystylecheckerscpppy">trunk/Tools/Scripts/webkitpy/style/checkers/cpp.py</a></li>
<li><a href="#trunkToolsScriptswebkitpystylecheckerscpp_unittestpy">trunk/Tools/Scripts/webkitpy/style/checkers/cpp_unittest.py</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkToolsChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Tools/ChangeLog (160863 => 160864)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Tools/ChangeLog 2013-12-19 23:22:09 UTC (rev 160863)
+++ trunk/Tools/ChangeLog 2013-12-19 23:23:37 UTC (rev 160864)
</span><span class="lines">@@ -1,5 +1,21 @@
</span><span class="cx"> 2013-12-19 Myles C. Maxfield <mmaxfield@apple.com>
</span><span class="cx">
</span><ins>+ check-webkit-style marks rvalue references as violations
+ https://bugs.webkit.org/show_bug.cgi?id=126000
+
+ Reviewed by Ryosuke Niwa.
+
+ Previously, check-webkit-style was making sure that any line with "&&" had
+ spaces around it. However, we can now legitimately use "&&" without a previous
+ space when declaring an rvalue reference. This patch relaxes this check.
+
+ * Scripts/webkitpy/style/checkers/cpp.py:
+ (check_spacing):
+ * Scripts/webkitpy/style/checkers/cpp_unittest.py:
+ (CppStyleTest.test_spacing_for_binary_ops):
+
+2013-12-19 Myles C. Maxfield <mmaxfield@apple.com>
+
</ins><span class="cx"> check-webkit-style marks auto return types for functions as violations
</span><span class="cx"> https://bugs.webkit.org/show_bug.cgi?id=125999
</span><span class="cx">
</span></span></pre></div>
<a id="trunkToolsScriptswebkitpystylecheckerscpppy"></a>
<div class="modfile"><h4>Modified: trunk/Tools/Scripts/webkitpy/style/checkers/cpp.py (160863 => 160864)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Tools/Scripts/webkitpy/style/checkers/cpp.py 2013-12-19 23:22:09 UTC (rev 160863)
+++ trunk/Tools/Scripts/webkitpy/style/checkers/cpp.py 2013-12-19 23:23:37 UTC (rev 160864)
</span><span class="lines">@@ -1850,10 +1850,10 @@
</span><span class="cx"> # FIXME: It's not ok to have spaces around binary operators like .
</span><span class="cx">
</span><span class="cx"> # You should always have whitespace around binary operators.
</span><del>- # Alas, we can't test <, >, <<, or >> because they're legitimately used sans spaces
- # (a->b, vector<int> a). The only time we can tell is a < with no >, and
</del><ins>+ # Alas, we can't test <, >, <<, >>, or && because they're legitimately used sans spaces
+ # (a->b, vector<int> a, Foo&& a). The only time we can tell is a < with no >, and
</ins><span class="cx"> # only if it's not template params list spilling into the next line.
</span><del>- matched = search(r'[^<>=!\s](==|!=|\+=|-=|\*=|/=|/|\|=|&=|<<=|>>=|<=|>=|\|\||\||&&)[^<>=!\s]', line)
</del><ins>+ matched = search(r'[^<>=!\s](==|!=|\+=|-=|\*=|/=|/|\|=|&=|<<=|>>=|<=|>=|\|\||\|)[^<>=!\s]', line)
</ins><span class="cx"> if not matched:
</span><span class="cx"> # Note that while it seems that the '<[^<]*' term in the following
</span><span class="cx"> # regexp could be simplified to '<.*', which would indeed match
</span></span></pre></div>
<a id="trunkToolsScriptswebkitpystylecheckerscpp_unittestpy"></a>
<div class="modfile"><h4>Modified: trunk/Tools/Scripts/webkitpy/style/checkers/cpp_unittest.py (160863 => 160864)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Tools/Scripts/webkitpy/style/checkers/cpp_unittest.py 2013-12-19 23:22:09 UTC (rev 160863)
+++ trunk/Tools/Scripts/webkitpy/style/checkers/cpp_unittest.py 2013-12-19 23:23:37 UTC (rev 160864)
</span><span class="lines">@@ -1751,12 +1751,12 @@
</span><span class="cx"> 'Should have a space between // and comment '
</span><span class="cx"> '[whitespace/comments] [4]',
</span><span class="cx"> 'Missing spaces around || [whitespace/operators] [3]'])
</span><del>- self.assert_lint('a<Foo*> t <<= b&&c; // Test', 'Missing spaces around'
- ' && [whitespace/operators] [3]')
- self.assert_lint('a<Foo*> t <<= b&&&c; // Test', 'Missing spaces around'
- ' && [whitespace/operators] [3]')
- self.assert_lint('a<Foo*> t <<= b&&*c; // Test', 'Missing spaces around'
- ' && [whitespace/operators] [3]')
</del><ins>+ self.assert_lint('a<Foo*> t <<= b||c; // Test', 'Missing spaces around'
+ ' || [whitespace/operators] [3]')
+ self.assert_lint('a<Foo*> t <<= b||&c; // Test', 'Missing spaces around'
+ ' || [whitespace/operators] [3]')
+ self.assert_lint('a<Foo*> t <<= b||*c; // Test', 'Missing spaces around'
+ ' || [whitespace/operators] [3]')
</ins><span class="cx"> self.assert_lint('a<Foo*> t <<= b && *c; // Test', '')
</span><span class="cx"> self.assert_lint('a<Foo*> t <<= b && &c; // Test', '')
</span><span class="cx"> self.assert_lint('a<Foo*> t <<= b || &c; /*Test', 'Complex multi-line '
</span><span class="lines">@@ -1772,6 +1772,7 @@
</span><span class="cx"> self.assert_multi_line_lint('#include <sys/io.h>\n', '')
</span><span class="cx"> self.assert_multi_line_lint('#import <foo/bar.h>\n', '')
</span><span class="cx"> self.assert_multi_line_lint('#if __has_include(<ApplicationServices/ApplicationServicesPriv.h>)\n', '')
</span><ins>+ self.assert_lint('Foo&& a = bar();', '')
</ins><span class="cx">
</span><span class="cx"> def test_operator_methods(self):
</span><span class="cx"> self.assert_lint('String operator+(const String&, const String&);', '')
</span></span></pre>
</div>
</div>
</body>
</html>