<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[160880] trunk/Source/WebCore</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/160880">160880</a></dd>
<dt>Author</dt> <dd>andersca@apple.com</dd>
<dt>Date</dt> <dd>2013-12-19 17:18:49 -0800 (Thu, 19 Dec 2013)</dd>
</dl>
<h3>Log Message</h3>
<pre>Begin stubbing out the KeyedDecoder class
https://bugs.webkit.org/show_bug.cgi?id=126031
Reviewed by Andreas Kling.
KeyedDecoder is going to be the new way to decode back forward trees.
* history/HistoryItem.cpp:
(WebCore::HistoryItem::decodeBackForwardTree):
* history/HistoryItem.h:
* platform/KeyedCoding.h:
(WebCore::KeyedDecoder::~KeyedDecoder):</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkSourceWebCoreChangeLog">trunk/Source/WebCore/ChangeLog</a></li>
<li><a href="#trunkSourceWebCorehistoryHistoryItemcpp">trunk/Source/WebCore/history/HistoryItem.cpp</a></li>
<li><a href="#trunkSourceWebCorehistoryHistoryItemh">trunk/Source/WebCore/history/HistoryItem.h</a></li>
<li><a href="#trunkSourceWebCoreplatformKeyedCodingh">trunk/Source/WebCore/platform/KeyedCoding.h</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkSourceWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/ChangeLog (160879 => 160880)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/ChangeLog 2013-12-20 00:52:06 UTC (rev 160879)
+++ trunk/Source/WebCore/ChangeLog 2013-12-20 01:18:49 UTC (rev 160880)
</span><span class="lines">@@ -1,3 +1,18 @@
</span><ins>+2013-12-19 Anders Carlsson <andersca@apple.com>
+
+ Begin stubbing out the KeyedDecoder class
+ https://bugs.webkit.org/show_bug.cgi?id=126031
+
+ Reviewed by Andreas Kling.
+
+ KeyedDecoder is going to be the new way to decode back forward trees.
+
+ * history/HistoryItem.cpp:
+ (WebCore::HistoryItem::decodeBackForwardTree):
+ * history/HistoryItem.h:
+ * platform/KeyedCoding.h:
+ (WebCore::KeyedDecoder::~KeyedDecoder):
+
</ins><span class="cx"> 2013-12-19 Oliver Hunt <oliver@apple.com>
</span><span class="cx">
</span><span class="cx"> DOM bindings should use thisValue for attributes
</span></span></pre></div>
<a id="trunkSourceWebCorehistoryHistoryItemcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/history/HistoryItem.cpp (160879 => 160880)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/history/HistoryItem.cpp 2013-12-20 00:52:06 UTC (rev 160879)
+++ trunk/Source/WebCore/history/HistoryItem.cpp 2013-12-20 01:18:49 UTC (rev 160880)
</span><span class="lines">@@ -924,6 +924,19 @@
</span><span class="cx"> return node.release();
</span><span class="cx"> }
</span><span class="cx">
</span><ins>+PassRefPtr<HistoryItem> HistoryItem::decodeBackForwardTree(const String&, const String&, const String&, KeyedDecoder& decoder)
+{
+ uint32_t version;
+ if (!decoder.decodeUInt32("version", version))
+ return nullptr;
+
+ if (version != backForwardTreeEncodingVersion)
+ return nullptr;
+
+ // FIXME: Implement.
+ return nullptr;
+}
+
</ins><span class="cx"> #ifndef NDEBUG
</span><span class="cx">
</span><span class="cx"> int HistoryItem::showTree() const
</span></span></pre></div>
<a id="trunkSourceWebCorehistoryHistoryItemh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/history/HistoryItem.h (160879 => 160880)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/history/HistoryItem.h 2013-12-20 00:52:06 UTC (rev 160879)
+++ trunk/Source/WebCore/history/HistoryItem.h 2013-12-20 01:18:49 UTC (rev 160880)
</span><span class="lines">@@ -54,6 +54,7 @@
</span><span class="cx"> class FormData;
</span><span class="cx"> class HistoryItem;
</span><span class="cx"> class Image;
</span><ins>+class KeyedDecoder;
</ins><span class="cx"> class KeyedEncoder;
</span><span class="cx"> class ResourceRequest;
</span><span class="cx"> class URL;
</span><span class="lines">@@ -95,6 +96,7 @@
</span><span class="cx"> void encodeBackForwardTree(Encoder&) const;
</span><span class="cx"> void encodeBackForwardTree(KeyedEncoder&) const;
</span><span class="cx"> static PassRefPtr<HistoryItem> decodeBackForwardTree(const String& urlString, const String& title, const String& originalURLString, Decoder&);
</span><ins>+ static PassRefPtr<HistoryItem> decodeBackForwardTree(const String& urlString, const String& title, const String& originalURLString, KeyedDecoder&);
</ins><span class="cx">
</span><span class="cx"> const String& originalURLString() const;
</span><span class="cx"> const String& urlString() const;
</span></span></pre></div>
<a id="trunkSourceWebCoreplatformKeyedCodingh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/platform/KeyedCoding.h (160879 => 160880)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/platform/KeyedCoding.h 2013-12-20 00:52:06 UTC (rev 160879)
+++ trunk/Source/WebCore/platform/KeyedCoding.h 2013-12-20 01:18:49 UTC (rev 160880)
</span><span class="lines">@@ -30,6 +30,14 @@
</span><span class="cx">
</span><span class="cx"> namespace WebCore {
</span><span class="cx">
</span><ins>+class KeyedDecoder {
+protected:
+ virtual ~KeyedDecoder() { }
+
+public:
+ virtual bool decodeUInt32(const String& key, uint32_t&) = 0;
+};
+
</ins><span class="cx"> class KeyedEncoder {
</span><span class="cx"> protected:
</span><span class="cx"> virtual ~KeyedEncoder() { }
</span></span></pre>
</div>
</div>
</body>
</html>