<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[160775] trunk/Source/WebCore</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/160775">160775</a></dd>
<dt>Author</dt> <dd>oliver@apple.com</dd>
<dt>Date</dt> <dd>2013-12-18 10:26:09 -0800 (Wed, 18 Dec 2013)</dd>
</dl>
<h3>Log Message</h3>
<pre>Remove JSInlineGetOwnPropertySlot attribute as it is no longer necessary
https://bugs.webkit.org/show_bug.cgi?id=125875
Reviewed by Brady Eidson.
Tested this on dromaeo and acid3 (the original reason for this attribute)
and it no longer provided any benefit. This makes it easier to reason about
creation of getOwnPropertySlot during binding generation.
* bindings/scripts/CodeGeneratorJS.pm:
(GenerateHeader):
(GenerateImplementation):
* bindings/scripts/IDLAttributes.txt:
* dom/Document.idl:
* dom/Element.idl:
* dom/Node.idl:</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkSourceWebCoreChangeLog">trunk/Source/WebCore/ChangeLog</a></li>
<li><a href="#trunkSourceWebCorebindingsscriptsCodeGeneratorJSpm">trunk/Source/WebCore/bindings/scripts/CodeGeneratorJS.pm</a></li>
<li><a href="#trunkSourceWebCorebindingsscriptsIDLAttributestxt">trunk/Source/WebCore/bindings/scripts/IDLAttributes.txt</a></li>
<li><a href="#trunkSourceWebCoredomDocumentidl">trunk/Source/WebCore/dom/Document.idl</a></li>
<li><a href="#trunkSourceWebCoredomElementidl">trunk/Source/WebCore/dom/Element.idl</a></li>
<li><a href="#trunkSourceWebCoredomNodeidl">trunk/Source/WebCore/dom/Node.idl</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkSourceWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/ChangeLog (160774 => 160775)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/ChangeLog 2013-12-18 18:14:12 UTC (rev 160774)
+++ trunk/Source/WebCore/ChangeLog 2013-12-18 18:26:09 UTC (rev 160775)
</span><span class="lines">@@ -1,3 +1,22 @@
</span><ins>+2013-12-17 Oliver Hunt <oliver@apple.com>
+
+ Remove JSInlineGetOwnPropertySlot attribute as it is no longer necessary
+ https://bugs.webkit.org/show_bug.cgi?id=125875
+
+ Reviewed by Brady Eidson.
+
+ Tested this on dromaeo and acid3 (the original reason for this attribute)
+ and it no longer provided any benefit. This makes it easier to reason about
+ creation of getOwnPropertySlot during binding generation.
+
+ * bindings/scripts/CodeGeneratorJS.pm:
+ (GenerateHeader):
+ (GenerateImplementation):
+ * bindings/scripts/IDLAttributes.txt:
+ * dom/Document.idl:
+ * dom/Element.idl:
+ * dom/Node.idl:
+
</ins><span class="cx"> 2013-12-18 Tamas Gergely <tgergely.u-szeged@partner.samsung.com>
</span><span class="cx">
</span><span class="cx"> Fix ASSERTION FAILED in WebCore::SVGLengthContext::determineViewport
</span></span></pre></div>
<a id="trunkSourceWebCorebindingsscriptsCodeGeneratorJSpm"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/bindings/scripts/CodeGeneratorJS.pm (160774 => 160775)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/bindings/scripts/CodeGeneratorJS.pm 2013-12-18 18:14:12 UTC (rev 160774)
+++ trunk/Source/WebCore/bindings/scripts/CodeGeneratorJS.pm 2013-12-18 18:26:09 UTC (rev 160775)
</span><span class="lines">@@ -588,10 +588,6 @@
</span><span class="cx"> $headerIncludes{"<runtime/CallData.h>"} = 1;
</span><span class="cx"> }
</span><span class="cx">
</span><del>- if ($interface->extendedAttributes->{"JSInlineGetOwnPropertySlot"}) {
- $headerIncludes{"<runtime/Lookup.h>"} = 1;
- }
-
</del><span class="cx"> if ($hasParent && $interface->extendedAttributes->{"JSGenerateToNativeObject"}) {
</span><span class="cx"> $headerIncludes{"$interfaceName.h"} = 1;
</span><span class="cx"> }
</span><span class="lines">@@ -913,15 +909,6 @@
</span><span class="cx">
</span><span class="cx"> push(@headerContent, "};\n\n");
</span><span class="cx">
</span><del>- if ($interface->extendedAttributes->{"JSInlineGetOwnPropertySlot"} && !$interface->extendedAttributes->{"CustomGetOwnPropertySlot"}) {
- push(@headerContent, "ALWAYS_INLINE bool ${className}::getOwnPropertySlot(JSC::JSObject* object, JSC::ExecState* exec, JSC::PropertyName propertyName, JSC::PropertySlot& slot)\n");
- push(@headerContent, "{\n");
- push(@headerContent, " ${className}* thisObject = JSC::jsCast<${className}*>(object);\n");
- push(@headerContent, " ASSERT_GC_OBJECT_INHERITS(thisObject, info());\n");
- push(@headerContent, GenerateGetOwnPropertySlotBody($interface, $interfaceName, $className, $numAttributes > 0, 1));
- push(@headerContent, "}\n\n");
- }
-
</del><span class="cx"> if (!$hasParent ||
</span><span class="cx"> GetGenerateIsReachable($interface) ||
</span><span class="cx"> GetCustomIsReachable($interface) ||
</span><span class="lines">@@ -1797,14 +1784,12 @@
</span><span class="cx"> # Attributes
</span><span class="cx"> if ($hasGetter) {
</span><span class="cx"> if (!$interface->extendedAttributes->{"CustomGetOwnPropertySlot"}) {
</span><del>- if (!$interface->extendedAttributes->{"JSInlineGetOwnPropertySlot"}) {
- push(@implContent, "bool ${className}::getOwnPropertySlot(JSObject* object, ExecState* exec, PropertyName propertyName, PropertySlot& slot)\n");
- push(@implContent, "{\n");
- push(@implContent, " ${className}* thisObject = jsCast<${className}*>(object);\n");
- push(@implContent, " ASSERT_GC_OBJECT_INHERITS(thisObject, info());\n");
- push(@implContent, GenerateGetOwnPropertySlotBody($interface, $interfaceName, $className, $numAttributes > 0, 0));
- push(@implContent, "}\n\n");
- }
</del><ins>+ push(@implContent, "bool ${className}::getOwnPropertySlot(JSObject* object, ExecState* exec, PropertyName propertyName, PropertySlot& slot)\n");
+ push(@implContent, "{\n");
+ push(@implContent, " ${className}* thisObject = jsCast<${className}*>(object);\n");
+ push(@implContent, " ASSERT_GC_OBJECT_INHERITS(thisObject, info());\n");
+ push(@implContent, GenerateGetOwnPropertySlotBody($interface, $interfaceName, $className, $numAttributes > 0, 0));
+ push(@implContent, "}\n\n");
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> if ($indexedGetterFunction || $namedGetterFunction
</span></span></pre></div>
<a id="trunkSourceWebCorebindingsscriptsIDLAttributestxt"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/bindings/scripts/IDLAttributes.txt (160774 => 160775)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/bindings/scripts/IDLAttributes.txt 2013-12-18 18:14:12 UTC (rev 160774)
+++ trunk/Source/WebCore/bindings/scripts/IDLAttributes.txt 2013-12-18 18:26:09 UTC (rev 160775)
</span><span class="lines">@@ -78,7 +78,6 @@
</span><span class="cx"> JSCustomToNativeObject
</span><span class="cx"> JSGenerateToJSObject
</span><span class="cx"> JSGenerateToNativeObject
</span><del>-JSInlineGetOwnPropertySlot
</del><span class="cx"> JSLegacyParent=*
</span><span class="cx"> JSNoStaticTables
</span><span class="cx"> JSWindowEventListener
</span></span></pre></div>
<a id="trunkSourceWebCoredomDocumentidl"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/dom/Document.idl (160774 => 160775)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/dom/Document.idl 2013-12-18 18:14:12 UTC (rev 160774)
+++ trunk/Source/WebCore/dom/Document.idl 2013-12-18 18:26:09 UTC (rev 160775)
</span><span class="lines">@@ -21,7 +21,6 @@
</span><span class="cx"> [
</span><span class="cx"> CustomToJSObject,
</span><span class="cx"> JSGenerateToNativeObject,
</span><del>- JSInlineGetOwnPropertySlot,
</del><span class="cx"> ] interface Document : Node {
</span><span class="cx">
</span><span class="cx"> // DOM Level 1 Core
</span></span></pre></div>
<a id="trunkSourceWebCoredomElementidl"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/dom/Element.idl (160774 => 160775)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/dom/Element.idl 2013-12-18 18:14:12 UTC (rev 160774)
+++ trunk/Source/WebCore/dom/Element.idl 2013-12-18 18:26:09 UTC (rev 160775)
</span><span class="lines">@@ -20,7 +20,6 @@
</span><span class="cx">
</span><span class="cx"> [
</span><span class="cx"> JSGenerateToNativeObject,
</span><del>- JSInlineGetOwnPropertySlot,
</del><span class="cx"> ] interface Element : Node {
</span><span class="cx">
</span><span class="cx"> // DOM Level 1 Core
</span></span></pre></div>
<a id="trunkSourceWebCoredomNodeidl"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/dom/Node.idl (160774 => 160775)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/dom/Node.idl 2013-12-18 18:14:12 UTC (rev 160774)
+++ trunk/Source/WebCore/dom/Node.idl 2013-12-18 18:26:09 UTC (rev 160775)
</span><span class="lines">@@ -26,7 +26,6 @@
</span><span class="cx"> CustomToJSObject,
</span><span class="cx"> EventTarget,
</span><span class="cx"> JSGenerateToNativeObject,
</span><del>- JSInlineGetOwnPropertySlot,
</del><span class="cx"> ObjCPolymorphic,
</span><span class="cx"> ] interface Node
</span><span class="cx"> #if defined(LANGUAGE_OBJECTIVE_C) && LANGUAGE_OBJECTIVE_C
</span></span></pre>
</div>
</div>
</body>
</html>