<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[160764] trunk/Source/WebCore</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/160764">160764</a></dd>
<dt>Author</dt> <dd>akling@apple.com</dd>
<dt>Date</dt> <dd>2013-12-18 07:04:42 -0800 (Wed, 18 Dec 2013)</dd>
</dl>
<h3>Log Message</h3>
<pre>Use range for syntax in Frame and FrameView.
<https://webkit.org/b/125922>
Convert code in Frame and FrameView to use C++11's range for syntax.
Reviewed by Antti Koivisto.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkSourceWebCoreChangeLog">trunk/Source/WebCore/ChangeLog</a></li>
<li><a href="#trunkSourceWebCorepageFramecpp">trunk/Source/WebCore/page/Frame.cpp</a></li>
<li><a href="#trunkSourceWebCorepageFrameViewcpp">trunk/Source/WebCore/page/FrameView.cpp</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkSourceWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/ChangeLog (160763 => 160764)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/ChangeLog 2013-12-18 15:02:45 UTC (rev 160763)
+++ trunk/Source/WebCore/ChangeLog 2013-12-18 15:04:42 UTC (rev 160764)
</span><span class="lines">@@ -1,5 +1,14 @@
</span><span class="cx"> 2013-12-18 Andreas Kling <akling@apple.com>
</span><span class="cx">
</span><ins>+ Use range for syntax in Frame and FrameView.
+ <https://webkit.org/b/125922>
+
+ Convert code in Frame and FrameView to use C++11's range for syntax.
+
+ Reviewed by Antti Koivisto.
+
+2013-12-18 Andreas Kling <akling@apple.com>
+
</ins><span class="cx"> RenderElement-ize adjustForAbsoluteZoom() and friends.
</span><span class="cx"> <https://webkit.org/b/125921>
</span><span class="cx">
</span></span></pre></div>
<a id="trunkSourceWebCorepageFramecpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/page/Frame.cpp (160763 => 160764)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/page/Frame.cpp 2013-12-18 15:02:45 UTC (rev 160763)
+++ trunk/Source/WebCore/page/Frame.cpp 2013-12-18 15:04:42 UTC (rev 160764)
</span><span class="lines">@@ -223,9 +223,8 @@
</span><span class="cx">
</span><span class="cx"> disconnectOwnerElement();
</span><span class="cx">
</span><del>- HashSet<FrameDestructionObserver*>::iterator stop = m_destructionObservers.end();
- for (HashSet<FrameDestructionObserver*>::iterator it = m_destructionObservers.begin(); it != stop; ++it)
- (*it)->frameDestroyed();
</del><ins>+ for (auto& observer : m_destructionObservers)
+ observer->frameDestroyed();
</ins><span class="cx">
</span><span class="cx"> if (!isMainFrame())
</span><span class="cx"> m_mainFrame.selfOnlyDeref();
</span><span class="lines">@@ -614,9 +613,8 @@
</span><span class="cx"> if (Frame* parent = tree().parent())
</span><span class="cx"> parent->loader().checkLoadComplete();
</span><span class="cx">
</span><del>- HashSet<FrameDestructionObserver*>::iterator stop = m_destructionObservers.end();
- for (HashSet<FrameDestructionObserver*>::iterator it = m_destructionObservers.begin(); it != stop; ++it)
- (*it)->willDetachPage();
</del><ins>+ for (auto& observer : m_destructionObservers)
+ observer->willDetachPage();
</ins><span class="cx">
</span><span class="cx"> // FIXME: It's unclear as to why this is called more than once, but it is,
</span><span class="cx"> // so page() could be NULL.
</span></span></pre></div>
<a id="trunkSourceWebCorepageFrameViewcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/page/FrameView.cpp (160763 => 160764)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/page/FrameView.cpp 2013-12-18 15:02:45 UTC (rev 160763)
+++ trunk/Source/WebCore/page/FrameView.cpp 2013-12-18 15:04:42 UTC (rev 160764)
</span><span class="lines">@@ -1645,8 +1645,7 @@
</span><span class="cx">
</span><span class="cx"> // Get the rects of the fixed objects visible in the rectToScroll
</span><span class="cx"> Region regionToUpdate;
</span><del>- for (auto it = m_viewportConstrainedObjects->begin(), end = m_viewportConstrainedObjects->end(); it != end; ++it) {
- RenderElement* renderer = *it;
</del><ins>+ for (auto& renderer : *m_viewportConstrainedObjects) {
</ins><span class="cx"> if (!renderer->style().hasViewportConstrainedPosition())
</span><span class="cx"> continue;
</span><span class="cx"> #if USE(ACCELERATED_COMPOSITING)
</span><span class="lines">@@ -1745,8 +1744,8 @@
</span><span class="cx">
</span><span class="cx"> // Renderers with fixed backgrounds may be in compositing layers, so we need to explicitly
</span><span class="cx"> // repaint them after scrolling.
</span><del>- for (auto it = m_slowRepaintObjects->begin(), end = m_slowRepaintObjects->end(); it != end; ++it)
- (*it)->repaint();
</del><ins>+ for (auto& renderer : *m_slowRepaintObjects)
+ renderer->repaint();
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> // Note that this gets called at painting time.
</span><span class="lines">@@ -1945,8 +1944,8 @@
</span><span class="cx"> if (!hasViewportConstrainedObjects())
</span><span class="cx"> return;
</span><span class="cx">
</span><del>- for (auto it = m_viewportConstrainedObjects->begin(), end = m_viewportConstrainedObjects->end(); it != end; ++it)
- (*it)->setNeedsLayout();
</del><ins>+ for (auto& renderer : *m_viewportConstrainedObjects)
+ renderer->setNeedsLayout();
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> void FrameView::scrollPositionChangedViaPlatformWidget()
</span><span class="lines">@@ -2591,8 +2590,7 @@
</span><span class="cx"> return;
</span><span class="cx">
</span><span class="cx"> Vector<ScheduledEvent> eventsToDispatch = std::move(m_scheduledEvents);
</span><del>- for (auto it = eventsToDispatch.begin(), end = eventsToDispatch.end(); it != end; ++it) {
- ScheduledEvent& scheduledEvent = *it;
</del><ins>+ for (auto& scheduledEvent : eventsToDispatch) {
</ins><span class="cx"> if (!scheduledEvent.target->inDocument())
</span><span class="cx"> continue;
</span><span class="cx"> scheduledEvent.target->dispatchEvent(scheduledEvent.event.release(), IGNORE_EXCEPTION);
</span><span class="lines">@@ -3168,10 +3166,8 @@
</span><span class="cx"> if (!m_scrollableAreas)
</span><span class="cx"> return;
</span><span class="cx">
</span><del>- for (HashSet<ScrollableArea*>::const_iterator it = m_scrollableAreas->begin(), end = m_scrollableAreas->end(); it != end; ++it) {
- ScrollableArea* scrollableArea = *it;
</del><ins>+ for (auto& scrollableArea : *m_scrollableAreas)
</ins><span class="cx"> scrollableArea->contentAreaWillPaint();
</span><del>- }
</del><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> bool FrameView::scrollAnimatorEnabled() const
</span><span class="lines">@@ -3318,14 +3314,12 @@
</span><span class="cx">
</span><span class="cx"> bool FrameView::hasCustomScrollbars() const
</span><span class="cx"> {
</span><del>- for (auto it = children().begin(), end = children().end(); it != end; ++it) {
- Widget* widget = it->get();
</del><ins>+ for (auto& widget : children()) {
</ins><span class="cx"> if (widget->isFrameView()) {
</span><del>- if (toFrameView(widget)->hasCustomScrollbars())
</del><ins>+ if (toFrameView(*widget).hasCustomScrollbars())
</ins><span class="cx"> return true;
</span><span class="cx"> } else if (widget->isScrollbar()) {
</span><del>- Scrollbar* scrollbar = static_cast<Scrollbar*>(widget);
- if (scrollbar->isCustomScrollbar())
</del><ins>+ if (toScrollbar(*widget).isCustomScrollbar())
</ins><span class="cx"> return true;
</span><span class="cx"> }
</span><span class="cx"> }
</span><span class="lines">@@ -3631,9 +3625,9 @@
</span><span class="cx"> // and thus mutates the children() set.
</span><span class="cx"> Vector<Ref<FrameView>, 16> childViews;
</span><span class="cx"> childViews.reserveInitialCapacity(children().size());
</span><del>- for (auto it = children().begin(), end = children().end(); it != end; ++it) {
- if (it->get()->isFrameView())
- childViews.uncheckedAppend(*toFrameView(it->get()));
</del><ins>+ for (auto& widget : children()) {
+ if (widget->isFrameView())
+ childViews.uncheckedAppend(toFrameView(*widget));
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> for (unsigned i = 0; i < childViews.size(); ++i)
</span></span></pre>
</div>
</div>
</body>
</html>