<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[160715] trunk</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/160715">160715</a></dd>
<dt>Author</dt> <dd>bjonesbe@adobe.com</dd>
<dt>Date</dt> <dd>2013-12-17 10:38:46 -0800 (Tue, 17 Dec 2013)</dd>
</dl>
<h3>Log Message</h3>
<pre>REGRESSION(<a href="http://trac.webkit.org/projects/webkit/changeset/159166">r159166</a>?): fast/block/float/float-with-fractional-height-vertical-lr.html, fast/block/float/float-with-fractional-height.html are failing
https://bugs.webkit.org/show_bug.cgi?id=124506
Reviewed by Dirk Schulze.
Source/WebCore:
Floor the endpoints of the floating object interval to keep the old
behavior until a better fix can be created.
No new tests, fixes regression in existing tests.
* rendering/FloatingObjects.cpp:
(WebCore::FloatingObjects::intervalForFloatingObject):
LayoutTests:
Remove lines for tests that have been fixed by this patch.
* platform/efl/TestExpectations:
* platform/gtk/TestExpectations:</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkLayoutTestsChangeLog">trunk/LayoutTests/ChangeLog</a></li>
<li><a href="#trunkLayoutTestsplatformeflTestExpectations">trunk/LayoutTests/platform/efl/TestExpectations</a></li>
<li><a href="#trunkLayoutTestsplatformgtkTestExpectations">trunk/LayoutTests/platform/gtk/TestExpectations</a></li>
<li><a href="#trunkSourceWebCoreChangeLog">trunk/Source/WebCore/ChangeLog</a></li>
<li><a href="#trunkSourceWebCorerenderingFloatingObjectscpp">trunk/Source/WebCore/rendering/FloatingObjects.cpp</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkLayoutTestsChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/ChangeLog (160714 => 160715)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/ChangeLog 2013-12-17 18:25:27 UTC (rev 160714)
+++ trunk/LayoutTests/ChangeLog 2013-12-17 18:38:46 UTC (rev 160715)
</span><span class="lines">@@ -1,3 +1,15 @@
</span><ins>+2013-12-17 Bem Jones-Bey <bjonesbe@adobe.com>
+
+ REGRESSION(r159166?): fast/block/float/float-with-fractional-height-vertical-lr.html, fast/block/float/float-with-fractional-height.html are failing
+ https://bugs.webkit.org/show_bug.cgi?id=124506
+
+ Reviewed by Dirk Schulze.
+
+ Remove lines for tests that have been fixed by this patch.
+
+ * platform/efl/TestExpectations:
+ * platform/gtk/TestExpectations:
+
</ins><span class="cx"> 2013-12-17 Mario Sanchez Prada <mario.prada@samsung.com>
</span><span class="cx">
</span><span class="cx"> [ATK] Expose accessibility objects for <dl>, <dt> and <dd>
</span></span></pre></div>
<a id="trunkLayoutTestsplatformeflTestExpectations"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/platform/efl/TestExpectations (160714 => 160715)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/platform/efl/TestExpectations 2013-12-17 18:25:27 UTC (rev 160714)
+++ trunk/LayoutTests/platform/efl/TestExpectations 2013-12-17 18:38:46 UTC (rev 160715)
</span><span class="lines">@@ -1730,9 +1730,6 @@
</span><span class="cx"> webkit.org/b/118126 css3/flexbox/image-percent-max-height.html [ ImageOnlyFailure ]
</span><span class="cx"> webkit.org/b/118126 fast/flexbox/image-percent-max-height.html [ ImageOnlyFailure ]
</span><span class="cx">
</span><del>-webkit.org/b/124506 fast/block/float/float-with-fractional-height-vertical-lr.html [ ImageOnlyFailure ]
-webkit.org/b/124506 fast/block/float/float-with-fractional-height.html [ ImageOnlyFailure ]
-
</del><span class="cx"> webkit.org/b/124656 fast/css3-text/css3-text-decoration/text-decoration-skip/text-decoration-skip-ink.html [ ImageOnlyFailure ]
</span><span class="cx">
</span><span class="cx"> webkit.org/b/124657 fast/dom/SelectorAPI/resig-SelectorsAPI-test.xhtml [ Failure ]
</span></span></pre></div>
<a id="trunkLayoutTestsplatformgtkTestExpectations"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/platform/gtk/TestExpectations (160714 => 160715)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/platform/gtk/TestExpectations 2013-12-17 18:25:27 UTC (rev 160714)
+++ trunk/LayoutTests/platform/gtk/TestExpectations 2013-12-17 18:38:46 UTC (rev 160715)
</span><span class="lines">@@ -1492,9 +1492,6 @@
</span><span class="cx"> webkit.org/b/124509 media/video-controls-captions-trackmenu-hide-on-click-outside.html [ Failure ]
</span><span class="cx"> webkit.org/b/124509 media/video-controls-captions-trackmenu-hide-on-click.html [ Failure ]
</span><span class="cx">
</span><del>-webkit.org/b/124506 fast/block/float/float-with-fractional-height-vertical-lr.html [ ImageOnlyFailure ]
-webkit.org/b/124506 fast/block/float/float-with-fractional-height.html [ ImageOnlyFailure ]
-
</del><span class="cx"> webkit.org/b/124565 fast/multicol/seamless-flowed-through-columns.html [ ImageOnlyFailure ]
</span><span class="cx">
</span><span class="cx"> webkit.org/b/124566 fast/dom/SelectorAPI/resig-SelectorsAPI-test.xhtml [ Failure ]
</span></span></pre></div>
<a id="trunkSourceWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/ChangeLog (160714 => 160715)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/ChangeLog 2013-12-17 18:25:27 UTC (rev 160714)
+++ trunk/Source/WebCore/ChangeLog 2013-12-17 18:38:46 UTC (rev 160715)
</span><span class="lines">@@ -1,3 +1,18 @@
</span><ins>+2013-12-17 Bem Jones-Bey <bjonesbe@adobe.com>
+
+ REGRESSION(r159166?): fast/block/float/float-with-fractional-height-vertical-lr.html, fast/block/float/float-with-fractional-height.html are failing
+ https://bugs.webkit.org/show_bug.cgi?id=124506
+
+ Reviewed by Dirk Schulze.
+
+ Floor the endpoints of the floating object interval to keep the old
+ behavior until a better fix can be created.
+
+ No new tests, fixes regression in existing tests.
+
+ * rendering/FloatingObjects.cpp:
+ (WebCore::FloatingObjects::intervalForFloatingObject):
+
</ins><span class="cx"> 2013-12-17 Alex Christensen <achristensen@webkit.org>
</span><span class="cx">
</span><span class="cx"> [Win] Visual Studio workaround for compiling WebGL.
</span></span></pre></div>
<a id="trunkSourceWebCorerenderingFloatingObjectscpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/rendering/FloatingObjects.cpp (160714 => 160715)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/rendering/FloatingObjects.cpp 2013-12-17 18:25:27 UTC (rev 160714)
+++ trunk/Source/WebCore/rendering/FloatingObjects.cpp 2013-12-17 18:38:46 UTC (rev 160715)
</span><span class="lines">@@ -280,9 +280,11 @@
</span><span class="cx">
</span><span class="cx"> FloatingObjectInterval FloatingObjects::intervalForFloatingObject(FloatingObject* floatingObject)
</span><span class="cx"> {
</span><ins>+ // FIXME The endpoints of the floating object interval shouldn't need to be
+ // floored. See http://wkb.ug/125831 for more details.
</ins><span class="cx"> if (m_horizontalWritingMode)
</span><del>- return FloatingObjectInterval(floatingObject->frameRect().y(), floatingObject->frameRect().maxY(), floatingObject);
- return FloatingObjectInterval(floatingObject->frameRect().x(), floatingObject->frameRect().maxX(), floatingObject);
</del><ins>+ return FloatingObjectInterval(floatingObject->frameRect().y().floor(), floatingObject->frameRect().maxY().floor(), floatingObject);
+ return FloatingObjectInterval(floatingObject->frameRect().x().floor(), floatingObject->frameRect().maxX().floor(), floatingObject);
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> void FloatingObjects::addPlacedObject(FloatingObject* floatingObject)
</span></span></pre>
</div>
</div>
</body>
</html>