<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[160712] trunk</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/160712">160712</a></dd>
<dt>Author</dt> <dd>mario.prada@samsung.com</dd>
<dt>Date</dt> <dd>2013-12-17 10:08:34 -0800 (Tue, 17 Dec 2013)</dd>
</dl>
<h3>Log Message</h3>
<pre>[ATK] Expose accessibility objects for <dl>, <dt> and <dd>
https://bugs.webkit.org/show_bug.cgi?id=125857
Reviewed by Chris Fleizach.
Source/WebCore:
Map description lists to the newly introduced ATK roles
ATK_ROLE_DESCRIPTION_LIST, ATK_ROLE_DESCRIPTION_TERM and
ATK_ROLE_DESCRIPTION_VALUE, introduced in ATK 2.11.4.
* accessibility/atk/WebKitAccessibleWrapperAtk.cpp:
(atkRole): Do the right mapping.
(webkitAccessibleGetRole): Update call to atkRole, now that it
receives an AccessibilityObject* as parameter.
Tools:
Add mappings to DRT & WKTR for the newly exposed roles, and
increase the version of ATK used by the internal jhbuild.
* DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
* WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
* gtk/jhbuild.modules: Raise version of ATK up to 2.11.4.
LayoutTests:
Update test to update expectations.
* platform/gtk/accessibility/roles-exposed-expected.txt:
* platform/gtk/accessibility/roles-exposed.html:
Updated test expectations for other test using description lists.
* platform/efl-wk1/accessibility/lists-expected.txt:
* platform/efl-wk2/accessibility/lists-expected.txt:
* platform/gtk/accessibility/lists-expected.txt:</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkLayoutTestsChangeLog">trunk/LayoutTests/ChangeLog</a></li>
<li><a href="#trunkLayoutTestsplatformeflwk1accessibilitylistsexpectedtxt">trunk/LayoutTests/platform/efl-wk1/accessibility/lists-expected.txt</a></li>
<li><a href="#trunkLayoutTestsplatformeflwk2accessibilitylistsexpectedtxt">trunk/LayoutTests/platform/efl-wk2/accessibility/lists-expected.txt</a></li>
<li><a href="#trunkLayoutTestsplatformgtkaccessibilitylistsexpectedtxt">trunk/LayoutTests/platform/gtk/accessibility/lists-expected.txt</a></li>
<li><a href="#trunkLayoutTestsplatformgtkaccessibilityrolesexposedexpectedtxt">trunk/LayoutTests/platform/gtk/accessibility/roles-exposed-expected.txt</a></li>
<li><a href="#trunkLayoutTestsplatformgtkaccessibilityrolesexposedhtml">trunk/LayoutTests/platform/gtk/accessibility/roles-exposed.html</a></li>
<li><a href="#trunkSourceWebCoreChangeLog">trunk/Source/WebCore/ChangeLog</a></li>
<li><a href="#trunkSourceWebCoreaccessibilityatkWebKitAccessibleWrapperAtkcpp">trunk/Source/WebCore/accessibility/atk/WebKitAccessibleWrapperAtk.cpp</a></li>
<li><a href="#trunkToolsChangeLog">trunk/Tools/ChangeLog</a></li>
<li><a href="#trunkToolsDumpRenderTreeatkAccessibilityUIElementAtkcpp">trunk/Tools/DumpRenderTree/atk/AccessibilityUIElementAtk.cpp</a></li>
<li><a href="#trunkToolsWebKitTestRunnerInjectedBundleatkAccessibilityUIElementAtkcpp">trunk/Tools/WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp</a></li>
<li><a href="#trunkToolsgtkjhbuildmodules">trunk/Tools/gtk/jhbuild.modules</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkLayoutTestsChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/ChangeLog (160711 => 160712)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/ChangeLog 2013-12-17 17:56:21 UTC (rev 160711)
+++ trunk/LayoutTests/ChangeLog 2013-12-17 18:08:34 UTC (rev 160712)
</span><span class="lines">@@ -1,3 +1,22 @@
</span><ins>+2013-12-17 Mario Sanchez Prada <mario.prada@samsung.com>
+
+ [ATK] Expose accessibility objects for <dl>, <dt> and <dd>
+ https://bugs.webkit.org/show_bug.cgi?id=125857
+
+ Reviewed by Chris Fleizach.
+
+ Update test to update expectations.
+
+ * platform/gtk/accessibility/roles-exposed-expected.txt:
+ * platform/gtk/accessibility/roles-exposed.html:
+
+ Updated test expectations for other test using description lists.
+
+ * platform/efl-wk1/accessibility/lists-expected.txt:
+ * platform/efl-wk2/accessibility/lists-expected.txt:
+ * platform/gtk/accessibility/lists-expected.txt:
+
+
</ins><span class="cx"> 2013-12-17 Frédéric Wang <fred.wang@free.fr>
</span><span class="cx">
</span><span class="cx"> Ensure inferred mrows for msqrt, mstyle, merror, mphantom and math.
</span></span></pre></div>
<a id="trunkLayoutTestsplatformeflwk1accessibilitylistsexpectedtxt"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/platform/efl-wk1/accessibility/lists-expected.txt (160711 => 160712)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/platform/efl-wk1/accessibility/lists-expected.txt 2013-12-17 17:56:21 UTC (rev 160711)
+++ trunk/LayoutTests/platform/efl-wk1/accessibility/lists-expected.txt 2013-12-17 18:08:34 UTC (rev 160712)
</span><span class="lines">@@ -47,7 +47,7 @@
</span><span class="cx"> AXChecked: 0
</span><span class="cx"> AXPlatformAttributes: toolkit:WebKitEfl
</span><span class="cx"> ------------
</span><del>-AXRole: AXList
</del><ins>+AXRole: AXDescriptionList
</ins><span class="cx"> AXParent: AXWebArea
</span><span class="cx"> AXChildren: 5
</span><span class="cx"> AXPosition: { 8.000000, 120.000000 }
</span><span class="lines">@@ -204,8 +204,8 @@
</span><span class="cx"> ------------
</span><span class="cx">
</span><span class="cx">
</span><del>-AXRole: AXUnknown
-AXParent: AXList
</del><ins>+AXRole: AXDescriptionTerm
+AXParent: AXDescriptionList
</ins><span class="cx"> AXChildren: 0
</span><span class="cx"> AXPosition: { 8.000000, 120.000000 }
</span><span class="cx"> AXSize: { 769.000000, 18.000000 }
</span><span class="lines">@@ -223,8 +223,8 @@
</span><span class="cx"> AXChecked: 0
</span><span class="cx"> AXPlatformAttributes: toolkit:WebKitEfl
</span><span class="cx"> ------------
</span><del>-AXRole: AXUnknown
-AXParent: AXList
</del><ins>+AXRole: AXDescriptionValue
+AXParent: AXDescriptionList
</ins><span class="cx"> AXChildren: 0
</span><span class="cx"> AXPosition: { 48.000000, 138.000000 }
</span><span class="cx"> AXSize: { 729.000000, 18.000000 }
</span><span class="lines">@@ -242,8 +242,8 @@
</span><span class="cx"> AXChecked: 0
</span><span class="cx"> AXPlatformAttributes: toolkit:WebKitEfl
</span><span class="cx"> ------------
</span><del>-AXRole: AXUnknown
-AXParent: AXList
</del><ins>+AXRole: AXDescriptionTerm
+AXParent: AXDescriptionList
</ins><span class="cx"> AXChildren: 0
</span><span class="cx"> AXPosition: { 8.000000, 156.000000 }
</span><span class="cx"> AXSize: { 769.000000, 18.000000 }
</span><span class="lines">@@ -261,8 +261,8 @@
</span><span class="cx"> AXChecked: 0
</span><span class="cx"> AXPlatformAttributes: toolkit:WebKitEfl
</span><span class="cx"> ------------
</span><del>-AXRole: AXUnknown
-AXParent: AXList
</del><ins>+AXRole: AXDescriptionValue
+AXParent: AXDescriptionList
</ins><span class="cx"> AXChildren: 0
</span><span class="cx"> AXPosition: { 48.000000, 174.000000 }
</span><span class="cx"> AXSize: { 729.000000, 18.000000 }
</span><span class="lines">@@ -280,8 +280,8 @@
</span><span class="cx"> AXChecked: 0
</span><span class="cx"> AXPlatformAttributes: toolkit:WebKitEfl
</span><span class="cx"> ------------
</span><del>-AXRole: AXUnknown
-AXParent: AXList
</del><ins>+AXRole: AXDescriptionValue
+AXParent: AXDescriptionList
</ins><span class="cx"> AXChildren: 0
</span><span class="cx"> AXPosition: { 48.000000, 192.000000 }
</span><span class="cx"> AXSize: { 729.000000, 18.000000 }
</span></span></pre></div>
<a id="trunkLayoutTestsplatformeflwk2accessibilitylistsexpectedtxt"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/platform/efl-wk2/accessibility/lists-expected.txt (160711 => 160712)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/platform/efl-wk2/accessibility/lists-expected.txt 2013-12-17 17:56:21 UTC (rev 160711)
+++ trunk/LayoutTests/platform/efl-wk2/accessibility/lists-expected.txt 2013-12-17 18:08:34 UTC (rev 160712)
</span><span class="lines">@@ -47,7 +47,7 @@
</span><span class="cx"> AXChecked: 0
</span><span class="cx"> AXPlatformAttributes: toolkit:WebKitEfl
</span><span class="cx"> ------------
</span><del>-AXRole: AXList
</del><ins>+AXRole: AXDescriptionList
</ins><span class="cx"> AXParent: AXWebArea
</span><span class="cx"> AXChildren: 5
</span><span class="cx"> AXPosition: { 0.000000, 0.000000 }
</span><span class="lines">@@ -204,8 +204,8 @@
</span><span class="cx"> ------------
</span><span class="cx">
</span><span class="cx">
</span><del>-AXRole: AXUnknown
-AXParent: AXList
</del><ins>+AXRole: AXDescriptionTerm
+AXParent: AXDescriptionList
</ins><span class="cx"> AXChildren: 0
</span><span class="cx"> AXPosition: { 0.000000, 0.000000 }
</span><span class="cx"> AXSize: { 769.000000, 18.000000 }
</span><span class="lines">@@ -223,8 +223,8 @@
</span><span class="cx"> AXChecked: 0
</span><span class="cx"> AXPlatformAttributes: toolkit:WebKitEfl
</span><span class="cx"> ------------
</span><del>-AXRole: AXUnknown
-AXParent: AXList
</del><ins>+AXRole: AXDescriptionValue
+AXParent: AXDescriptionList
</ins><span class="cx"> AXChildren: 0
</span><span class="cx"> AXPosition: { 0.000000, 0.000000 }
</span><span class="cx"> AXSize: { 729.000000, 18.000000 }
</span><span class="lines">@@ -242,8 +242,8 @@
</span><span class="cx"> AXChecked: 0
</span><span class="cx"> AXPlatformAttributes: toolkit:WebKitEfl
</span><span class="cx"> ------------
</span><del>-AXRole: AXUnknown
-AXParent: AXList
</del><ins>+AXRole: AXDescriptionTerm
+AXParent: AXDescriptionList
</ins><span class="cx"> AXChildren: 0
</span><span class="cx"> AXPosition: { 0.000000, 0.000000 }
</span><span class="cx"> AXSize: { 769.000000, 18.000000 }
</span><span class="lines">@@ -261,8 +261,8 @@
</span><span class="cx"> AXChecked: 0
</span><span class="cx"> AXPlatformAttributes: toolkit:WebKitEfl
</span><span class="cx"> ------------
</span><del>-AXRole: AXUnknown
-AXParent: AXList
</del><ins>+AXRole: AXDescriptionValue
+AXParent: AXDescriptionList
</ins><span class="cx"> AXChildren: 0
</span><span class="cx"> AXPosition: { 0.000000, 0.000000 }
</span><span class="cx"> AXSize: { 729.000000, 18.000000 }
</span><span class="lines">@@ -280,8 +280,8 @@
</span><span class="cx"> AXChecked: 0
</span><span class="cx"> AXPlatformAttributes: toolkit:WebKitEfl
</span><span class="cx"> ------------
</span><del>-AXRole: AXUnknown
-AXParent: AXList
</del><ins>+AXRole: AXDescriptionValue
+AXParent: AXDescriptionList
</ins><span class="cx"> AXChildren: 0
</span><span class="cx"> AXPosition: { 0.000000, 0.000000 }
</span><span class="cx"> AXSize: { 729.000000, 18.000000 }
</span></span></pre></div>
<a id="trunkLayoutTestsplatformgtkaccessibilitylistsexpectedtxt"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/platform/gtk/accessibility/lists-expected.txt (160711 => 160712)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/platform/gtk/accessibility/lists-expected.txt 2013-12-17 17:56:21 UTC (rev 160711)
+++ trunk/LayoutTests/platform/gtk/accessibility/lists-expected.txt 2013-12-17 18:08:34 UTC (rev 160712)
</span><span class="lines">@@ -47,7 +47,7 @@
</span><span class="cx"> AXChecked: 0
</span><span class="cx"> AXPlatformAttributes: toolkit:WebKitGtk
</span><span class="cx"> ------------
</span><del>-AXRole: AXList
</del><ins>+AXRole: AXDescriptionList
</ins><span class="cx"> AXParent: AXWebArea
</span><span class="cx"> AXChildren: 5
</span><span class="cx"> AXPosition: { 8.000000, 116.000000 }
</span><span class="lines">@@ -204,8 +204,8 @@
</span><span class="cx"> ------------
</span><span class="cx">
</span><span class="cx">
</span><del>-AXRole: AXUnknown
-AXParent: AXList
</del><ins>+AXRole: AXDescriptionTerm
+AXParent: AXDescriptionList
</ins><span class="cx"> AXChildren: 0
</span><span class="cx"> AXPosition: { 8.000000, 116.000000 }
</span><span class="cx"> AXSize: { 769.000000, 17.000000 }
</span><span class="lines">@@ -223,8 +223,8 @@
</span><span class="cx"> AXChecked: 0
</span><span class="cx"> AXPlatformAttributes: toolkit:WebKitGtk
</span><span class="cx"> ------------
</span><del>-AXRole: AXUnknown
-AXParent: AXList
</del><ins>+AXRole: AXDescriptionValue
+AXParent: AXDescriptionList
</ins><span class="cx"> AXChildren: 0
</span><span class="cx"> AXPosition: { 48.000000, 133.000000 }
</span><span class="cx"> AXSize: { 729.000000, 17.000000 }
</span><span class="lines">@@ -242,8 +242,8 @@
</span><span class="cx"> AXChecked: 0
</span><span class="cx"> AXPlatformAttributes: toolkit:WebKitGtk
</span><span class="cx"> ------------
</span><del>-AXRole: AXUnknown
-AXParent: AXList
</del><ins>+AXRole: AXDescriptionTerm
+AXParent: AXDescriptionList
</ins><span class="cx"> AXChildren: 0
</span><span class="cx"> AXPosition: { 8.000000, 150.000000 }
</span><span class="cx"> AXSize: { 769.000000, 17.000000 }
</span><span class="lines">@@ -261,8 +261,8 @@
</span><span class="cx"> AXChecked: 0
</span><span class="cx"> AXPlatformAttributes: toolkit:WebKitGtk
</span><span class="cx"> ------------
</span><del>-AXRole: AXUnknown
-AXParent: AXList
</del><ins>+AXRole: AXDescriptionValue
+AXParent: AXDescriptionList
</ins><span class="cx"> AXChildren: 0
</span><span class="cx"> AXPosition: { 48.000000, 167.000000 }
</span><span class="cx"> AXSize: { 729.000000, 17.000000 }
</span><span class="lines">@@ -280,8 +280,8 @@
</span><span class="cx"> AXChecked: 0
</span><span class="cx"> AXPlatformAttributes: toolkit:WebKitGtk
</span><span class="cx"> ------------
</span><del>-AXRole: AXUnknown
-AXParent: AXList
</del><ins>+AXRole: AXDescriptionValue
+AXParent: AXDescriptionList
</ins><span class="cx"> AXChildren: 0
</span><span class="cx"> AXPosition: { 48.000000, 184.000000 }
</span><span class="cx"> AXSize: { 729.000000, 17.000000 }
</span></span></pre></div>
<a id="trunkLayoutTestsplatformgtkaccessibilityrolesexposedexpectedtxt"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/platform/gtk/accessibility/roles-exposed-expected.txt (160711 => 160712)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/platform/gtk/accessibility/roles-exposed-expected.txt 2013-12-17 17:56:21 UTC (rev 160711)
+++ trunk/LayoutTests/platform/gtk/accessibility/roles-exposed-expected.txt 2013-12-17 18:08:34 UTC (rev 160712)
</span><span class="lines">@@ -21,6 +21,15 @@
</span><span class="cx"> PASS: button
</span><span class="cx"> AXRole: AXButton
</span><span class="cx">
</span><ins>+PASS: dl
+ AXRole: AXDescriptionList
+
+PASS: dt
+ AXRole: AXDescriptionTerm
+
+PASS: dd
+ AXRole: AXDescriptionValue
+
</ins><span class="cx"> PASS: div
</span><span class="cx"> AXRole: AXSection
</span><span class="cx">
</span></span></pre></div>
<a id="trunkLayoutTestsplatformgtkaccessibilityrolesexposedhtml"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/platform/gtk/accessibility/roles-exposed.html (160711 => 160712)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/platform/gtk/accessibility/roles-exposed.html 2013-12-17 17:56:21 UTC (rev 160711)
+++ trunk/LayoutTests/platform/gtk/accessibility/roles-exposed.html 2013-12-17 18:08:34 UTC (rev 160712)
</span><span class="lines">@@ -26,10 +26,10 @@
</span><span class="cx"> <!-- skipped ATK: not focusable <del data-role="" class="ex">X</del>-->
</span><span class="cx"> <!-- skipped <details/summary> http://webkit.org/b/108979 -->
</span><span class="cx"> <!-- skipped <dfn data-role="AXGroup" class="ex">X</dfn> -->
</span><del>-<!-- http://webkit.org/b/125493 <dl data-role="AXDefinitionList" list" class="ex">-->
- <!-- http://webkit.org/b/125493 <dt data-role="AXGroup" class="ex">X</dt> -->
- <!-- http://webkit.org/b/125493 <dd data-role="AXGroup" class="ex">X</dd> -->
-<!-- </dl> -->
</del><ins>+<dl data-role="AXDescriptionList" class="ex">
+ <dt data-role="AXDescriptionTerm" class="ex">X</dt>
+ <dd data-role="AXDescriptionValue" class="ex">X</dd>
+</dl>
</ins><span class="cx"> <div data-role="AXSection" class="ex">X</div>
</span><span class="cx"> <!-- skipped ATK: not focusable <em data-role="" class="ex">X</em>-->
</span><span class="cx"> <!-- skipped <embed> -->
</span></span></pre></div>
<a id="trunkSourceWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/ChangeLog (160711 => 160712)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/ChangeLog 2013-12-17 17:56:21 UTC (rev 160711)
+++ trunk/Source/WebCore/ChangeLog 2013-12-17 18:08:34 UTC (rev 160712)
</span><span class="lines">@@ -1,3 +1,19 @@
</span><ins>+2013-12-17 Mario Sanchez Prada <mario.prada@samsung.com>
+
+ [ATK] Expose accessibility objects for <dl>, <dt> and <dd>
+ https://bugs.webkit.org/show_bug.cgi?id=125857
+
+ Reviewed by Chris Fleizach.
+
+ Map description lists to the newly introduced ATK roles
+ ATK_ROLE_DESCRIPTION_LIST, ATK_ROLE_DESCRIPTION_TERM and
+ ATK_ROLE_DESCRIPTION_VALUE, introduced in ATK 2.11.4.
+
+ * accessibility/atk/WebKitAccessibleWrapperAtk.cpp:
+ (atkRole): Do the right mapping.
+ (webkitAccessibleGetRole): Update call to atkRole, now that it
+ receives an AccessibilityObject* as parameter.
+
</ins><span class="cx"> 2013-12-17 Frédéric Wang <fred.wang@free.fr>
</span><span class="cx">
</span><span class="cx"> Ensure inferred mrows for msqrt, mstyle, merror, mphantom and math.
</span></span></pre></div>
<a id="trunkSourceWebCoreaccessibilityatkWebKitAccessibleWrapperAtkcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/accessibility/atk/WebKitAccessibleWrapperAtk.cpp (160711 => 160712)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/accessibility/atk/WebKitAccessibleWrapperAtk.cpp 2013-12-17 17:56:21 UTC (rev 160711)
+++ trunk/Source/WebCore/accessibility/atk/WebKitAccessibleWrapperAtk.cpp 2013-12-17 18:08:34 UTC (rev 160712)
</span><span class="lines">@@ -35,6 +35,7 @@
</span><span class="cx"> #if HAVE(ACCESSIBILITY)
</span><span class="cx">
</span><span class="cx"> #include "AXObjectCache.h"
</span><ins>+#include "AccessibilityList.h"
</ins><span class="cx"> #include "AccessibilityListBoxOption.h"
</span><span class="cx"> #include "Document.h"
</span><span class="cx"> #include "Frame.h"
</span><span class="lines">@@ -557,8 +558,9 @@
</span><span class="cx"> return attributeSet;
</span><span class="cx"> }
</span><span class="cx">
</span><del>-static AtkRole atkRole(AccessibilityRole role)
</del><ins>+static AtkRole atkRole(AccessibilityObject* coreObject)
</ins><span class="cx"> {
</span><ins>+ AccessibilityRole role = coreObject->roleValue();
</ins><span class="cx"> switch (role) {
</span><span class="cx"> case ApplicationAlertDialogRole:
</span><span class="cx"> case ApplicationAlertRole:
</span><span class="lines">@@ -632,6 +634,10 @@
</span><span class="cx"> case ColorWellRole:
</span><span class="cx"> return ATK_ROLE_COLOR_CHOOSER;
</span><span class="cx"> case ListRole:
</span><ins>+#if ATK_CHECK_VERSION(2, 11, 4)
+ if (coreObject->isList() && toAccessibilityList(coreObject)->isDescriptionList())
+ return ATK_ROLE_DESCRIPTION_LIST;
+#endif
</ins><span class="cx"> return ATK_ROLE_LIST;
</span><span class="cx"> case ScrollBarRole:
</span><span class="cx"> return ATK_ROLE_SCROLL_BAR;
</span><span class="lines">@@ -716,6 +722,14 @@
</span><span class="cx"> case LandmarkSearchRole:
</span><span class="cx"> return ATK_ROLE_LANDMARK;
</span><span class="cx"> #endif
</span><ins>+#if ATK_CHECK_VERSION(2, 11, 4)
+ case DescriptionListRole:
+ return ATK_ROLE_DESCRIPTION_LIST;
+ case DescriptionListTermRole:
+ return ATK_ROLE_DESCRIPTION_TERM;
+ case DescriptionListDetailRole:
+ return ATK_ROLE_DESCRIPTION_VALUE;
+#endif
</ins><span class="cx"> default:
</span><span class="cx"> return ATK_ROLE_UNKNOWN;
</span><span class="cx"> }
</span><span class="lines">@@ -735,7 +749,7 @@
</span><span class="cx"> if (coreObject->isPasswordField())
</span><span class="cx"> return ATK_ROLE_PASSWORD_TEXT;
</span><span class="cx">
</span><del>- return atkRole(coreObject->roleValue());
</del><ins>+ return atkRole(coreObject);
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> static bool isTextWithCaret(AccessibilityObject* coreObject)
</span></span></pre></div>
<a id="trunkToolsChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Tools/ChangeLog (160711 => 160712)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Tools/ChangeLog 2013-12-17 17:56:21 UTC (rev 160711)
+++ trunk/Tools/ChangeLog 2013-12-17 18:08:34 UTC (rev 160712)
</span><span class="lines">@@ -1,3 +1,17 @@
</span><ins>+2013-12-17 Mario Sanchez Prada <mario.prada@samsung.com>
+
+ [ATK] Expose accessibility objects for <dl>, <dt> and <dd>
+ https://bugs.webkit.org/show_bug.cgi?id=125857
+
+ Reviewed by Chris Fleizach.
+
+ Add mappings to DRT & WKTR for the newly exposed roles, and
+ increase the version of ATK used by the internal jhbuild.
+
+ * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
+ * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
+ * gtk/jhbuild.modules: Raise version of ATK up to 2.11.4.
+
</ins><span class="cx"> 2013-12-17 Alex Christensen <achristensen@webkit.org>
</span><span class="cx">
</span><span class="cx"> [WinCairo] Adding support for GStreamer and GLib.
</span></span></pre></div>
<a id="trunkToolsDumpRenderTreeatkAccessibilityUIElementAtkcpp"></a>
<div class="modfile"><h4>Modified: trunk/Tools/DumpRenderTree/atk/AccessibilityUIElementAtk.cpp (160711 => 160712)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Tools/DumpRenderTree/atk/AccessibilityUIElementAtk.cpp 2013-12-17 17:56:21 UTC (rev 160711)
+++ trunk/Tools/DumpRenderTree/atk/AccessibilityUIElementAtk.cpp 2013-12-17 18:08:34 UTC (rev 160712)
</span><span class="lines">@@ -340,6 +340,14 @@
</span><span class="cx"> case ATK_ROLE_TIMER:
</span><span class="cx"> return "AXTimer";
</span><span class="cx"> #endif
</span><ins>+#if ATK_CHECK_VERSION(2, 11, 4)
+ case ATK_ROLE_DESCRIPTION_LIST:
+ return "AXDescriptionList";
+ case ATK_ROLE_DESCRIPTION_TERM:
+ return "AXDescriptionTerm";
+ case ATK_ROLE_DESCRIPTION_VALUE:
+ return "AXDescriptionValue";
+#endif
</ins><span class="cx"> default:
</span><span class="cx"> // We want to distinguish ATK_ROLE_UNKNOWN from a known AtkRole which
</span><span class="cx"> // our DRT isn't properly handling.
</span></span></pre></div>
<a id="trunkToolsWebKitTestRunnerInjectedBundleatkAccessibilityUIElementAtkcpp"></a>
<div class="modfile"><h4>Modified: trunk/Tools/WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp (160711 => 160712)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Tools/WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp 2013-12-17 17:56:21 UTC (rev 160711)
+++ trunk/Tools/WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp 2013-12-17 18:08:34 UTC (rev 160712)
</span><span class="lines">@@ -429,6 +429,14 @@
</span><span class="cx"> case ATK_ROLE_TIMER:
</span><span class="cx"> return "AXTimer";
</span><span class="cx"> #endif
</span><ins>+#if ATK_CHECK_VERSION(2, 11, 4)
+ case ATK_ROLE_DESCRIPTION_LIST:
+ return "AXDescriptionList";
+ case ATK_ROLE_DESCRIPTION_TERM:
+ return "AXDescriptionTerm";
+ case ATK_ROLE_DESCRIPTION_VALUE:
+ return "AXDescriptionValue";
+#endif
</ins><span class="cx"> default:
</span><span class="cx"> // We want to distinguish ATK_ROLE_UNKNOWN from a known AtkRole which
</span><span class="cx"> // our DRT isn't properly handling.
</span></span></pre></div>
<a id="trunkToolsgtkjhbuildmodules"></a>
<div class="modfile"><h4>Modified: trunk/Tools/gtk/jhbuild.modules (160711 => 160712)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Tools/gtk/jhbuild.modules 2013-12-17 17:56:21 UTC (rev 160711)
+++ trunk/Tools/gtk/jhbuild.modules 2013-12-17 18:08:34 UTC (rev 160712)
</span><span class="lines">@@ -232,9 +232,9 @@
</span><span class="cx"> <autotools id="atk"
</span><span class="cx"> autogen-sh="configure"
</span><span class="cx"> autogenargs="--disable-introspection">
</span><del>- <branch module="pub/GNOME/sources/atk/2.11/atk-2.11.3.tar.xz" version="2.11.3"
</del><ins>+ <branch module="pub/GNOME/sources/atk/2.11/atk-2.11.4.tar.xz" version="2.11.4"
</ins><span class="cx"> repo="ftp.gnome.org"
</span><del>- hash="sha256:b3c63668638dbb627a81f4333a00b744c503531d07b168405ef5f27f382a0ae4"/>
</del><ins>+ hash="sha256:b609fa7a3f21147d40f0fe0f47278a62c263de0eadbbbe9839f2b63a0cb07d41"/>
</ins><span class="cx"> </autotools>
</span><span class="cx">
</span><span class="cx"> <autotools id="at-spi2-core"
</span></span></pre>
</div>
</div>
</body>
</html>