<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[160748] trunk</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/160748">160748</a></dd>
<dt>Author</dt> <dd>eric.carlson@apple.com</dd>
<dt>Date</dt> <dd>2013-12-17 20:32:23 -0800 (Tue, 17 Dec 2013)</dd>
</dl>
<h3>Log Message</h3>
<pre>ASSERT setting pseudoID with registered DOMSubtreeModified listener
https://bugs.webkit.org/show_bug.cgi?id=125900
Reviewed by Ryosuke Niwa.
Source/WebCore:
Test: fast/dom/attribute-set-before-element-in-tree.html
* dom/Node.cpp:
(WebCore::Node::dispatchSubtreeModifiedEvent): Return early if the node does not have a
parent and does not have a DOMSubtreeModified listener.
LayoutTests:
* fast/dom/attribute-set-before-element-in-tree-expected.txt: Added.
* fast/dom/attribute-set-before-element-in-tree.html: Added.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkLayoutTestsChangeLog">trunk/LayoutTests/ChangeLog</a></li>
<li><a href="#trunkSourceWebCoreChangeLog">trunk/Source/WebCore/ChangeLog</a></li>
<li><a href="#trunkSourceWebCoredomNodecpp">trunk/Source/WebCore/dom/Node.cpp</a></li>
</ul>
<h3>Added Paths</h3>
<ul>
<li><a href="#trunkLayoutTestsfastdomattributesetbeforeelementintreeexpectedtxt">trunk/LayoutTests/fast/dom/attribute-set-before-element-in-tree-expected.txt</a></li>
<li><a href="#trunkLayoutTestsfastdomattributesetbeforeelementintreehtml">trunk/LayoutTests/fast/dom/attribute-set-before-element-in-tree.html</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkLayoutTestsChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/ChangeLog (160747 => 160748)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/ChangeLog 2013-12-18 04:18:02 UTC (rev 160747)
+++ trunk/LayoutTests/ChangeLog 2013-12-18 04:32:23 UTC (rev 160748)
</span><span class="lines">@@ -1,3 +1,13 @@
</span><ins>+2013-12-17 Eric Carlson <eric.carlson@apple.com>
+
+ ASSERT setting pseudoID with registered DOMSubtreeModified listener
+ https://bugs.webkit.org/show_bug.cgi?id=125900
+
+ Reviewed by Ryosuke Niwa.
+
+ * fast/dom/attribute-set-before-element-in-tree-expected.txt: Added.
+ * fast/dom/attribute-set-before-element-in-tree.html: Added.
+
</ins><span class="cx"> 2013-12-17 Jer Noble <jer.noble@apple.com>
</span><span class="cx">
</span><span class="cx"> [MSE] Update duration after appending samples, per spec.
</span></span></pre></div>
<a id="trunkLayoutTestsfastdomattributesetbeforeelementintreeexpectedtxt"></a>
<div class="addfile"><h4>Added: trunk/LayoutTests/fast/dom/attribute-set-before-element-in-tree-expected.txt (0 => 160748)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/fast/dom/attribute-set-before-element-in-tree-expected.txt (rev 0)
+++ trunk/LayoutTests/fast/dom/attribute-set-before-element-in-tree-expected.txt 2013-12-18 04:32:23 UTC (rev 160748)
</span><span class="lines">@@ -0,0 +1,10 @@
</span><ins>+Test MutationObserver not dispatched for a parentless element with no listeners
+
+On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
+
+
+PASS Test passed, no crash.
+PASS successfullyParsed is true
+
+TEST COMPLETE
+
</ins></span></pre></div>
<a id="trunkLayoutTestsfastdomattributesetbeforeelementintreehtml"></a>
<div class="addfile"><h4>Added: trunk/LayoutTests/fast/dom/attribute-set-before-element-in-tree.html (0 => 160748)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/fast/dom/attribute-set-before-element-in-tree.html (rev 0)
+++ trunk/LayoutTests/fast/dom/attribute-set-before-element-in-tree.html 2013-12-18 04:32:23 UTC (rev 160748)
</span><span class="lines">@@ -0,0 +1,31 @@
</span><ins>+<!DOCTYPE html>
+<html>
+ <head>
+ <script src="../../resources/js-test-pre.js"></script>
+ <script>
+ window.jsTestIsAsync = true;
+
+ function test()
+ {
+ description("Test MutationObserver not dispatched for a parentless element with no listeners");
+
+ document.body.addEventListener('DOMSubtreeModified', function(){ }, true);
+
+ // HTMLKeygenElement creates a <select> element, which sets its 'pseudo' attribute
+ // in the constructor.
+ var keygen = document.createElement('keygen');
+ setTimeout(finish, 0);
+ }
+
+ function finish()
+ {
+ testPassed("Test passed, no crash.");
+ finishJSTest();
+ }
+
+ </script>
+ </head>
+ <body onload="test()">
+ <script src="../../resources/js-test-post.js"></script>
+ </body>
+</html>
</ins></span></pre></div>
<a id="trunkSourceWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/ChangeLog (160747 => 160748)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/ChangeLog 2013-12-18 04:18:02 UTC (rev 160747)
+++ trunk/Source/WebCore/ChangeLog 2013-12-18 04:32:23 UTC (rev 160748)
</span><span class="lines">@@ -1,3 +1,16 @@
</span><ins>+2013-12-17 Eric Carlson <eric.carlson@apple.com>
+
+ ASSERT setting pseudoID with registered DOMSubtreeModified listener
+ https://bugs.webkit.org/show_bug.cgi?id=125900
+
+ Reviewed by Ryosuke Niwa.
+
+ Test: fast/dom/attribute-set-before-element-in-tree.html
+
+ * dom/Node.cpp:
+ (WebCore::Node::dispatchSubtreeModifiedEvent): Return early if the node does not have a
+ parent and does not have a DOMSubtreeModified listener.
+
</ins><span class="cx"> 2013-12-17 Ryosuke Niwa <rniwa@webkit.org>
</span><span class="cx">
</span><span class="cx"> Remove dead code for reflected attributes from audio, video, and track elements
</span></span></pre></div>
<a id="trunkSourceWebCoredomNodecpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/dom/Node.cpp (160747 => 160748)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/dom/Node.cpp 2013-12-18 04:18:02 UTC (rev 160747)
+++ trunk/Source/WebCore/dom/Node.cpp 2013-12-18 04:32:23 UTC (rev 160748)
</span><span class="lines">@@ -2045,8 +2045,11 @@
</span><span class="cx">
</span><span class="cx"> if (!document().hasListenerType(Document::DOMSUBTREEMODIFIED_LISTENER))
</span><span class="cx"> return;
</span><ins>+ const AtomicString& subtreeModifiedEventName = eventNames().DOMSubtreeModifiedEvent;
+ if (!parentNode() && !hasEventListeners(subtreeModifiedEventName))
+ return;
</ins><span class="cx">
</span><del>- dispatchScopedEvent(MutationEvent::create(eventNames().DOMSubtreeModifiedEvent, true));
</del><ins>+ dispatchScopedEvent(MutationEvent::create(subtreeModifiedEventName, true));
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> bool Node::dispatchDOMActivateEvent(int detail, PassRefPtr<Event> underlyingEvent)
</span></span></pre>
</div>
</div>
</body>
</html>