<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[160731] trunk</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/160731">160731</a></dd>
<dt>Author</dt> <dd>barraclough@apple.com</dd>
<dt>Date</dt> <dd>2013-12-17 15:42:56 -0800 (Tue, 17 Dec 2013)</dd>
</dl>
<h3>Log Message</h3>
<pre>Remove PageVisibilityStateUnloaded
https://bugs.webkit.org/show_bug.cgi?id=125869
Reviewed by Anders Carlsson.
This is not currently supported by WebKit, remove this enum value.
We can always add this back later if/when we add support for this state.
Source/WebCore:
* page/PageVisibilityState.cpp:
(WebCore::pageVisibilityStateString):
* page/PageVisibilityState.h:
- removed PageVisibilityStateUnloaded
Source/WebKit/mac:
* WebView/WebView.mm:
(core):
(kit):
* WebView/WebViewPrivate.h:
- removed PageVisibilityStateUnloaded/WebPageVisibilityStateUnloaded
Source/WebKit2:
* Shared/API/c/WKPageVisibilityTypes.h:
* Shared/API/c/WKSharedAPICast.h:
(WebKit::toPageVisibilityState):
- removed PageVisibilityStateUnloaded/kWKPageVisibilityStateUnloaded
Tools:
* DumpRenderTree/mac/TestRunnerMac.mm:
(TestRunner::setPageVisibility):
* TestWebKitAPI/Tests/WebKit2/PageVisibilityState.cpp:
(TestWebKitAPI::didRunStep3StateChangePrerenderToUnloaded):
* WebKitTestRunner/InjectedBundle/TestRunner.cpp:
(WTR::TestRunner::setPageVisibility):
- remove test for visibility state "unloaded"; this is no longer supported (it never really was).
LayoutTests:
* fast/events/page-visibility-transition-test-expected.txt:
* fast/events/page-visibility-transition-test.html:
- remove test for visibility state "unloaded"; this is no longer supported (it never really was).</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkLayoutTestsChangeLog">trunk/LayoutTests/ChangeLog</a></li>
<li><a href="#trunkLayoutTestsfasteventspagevisibilitytransitiontestexpectedtxt">trunk/LayoutTests/fast/events/page-visibility-transition-test-expected.txt</a></li>
<li><a href="#trunkLayoutTestsfasteventspagevisibilitytransitiontesthtml">trunk/LayoutTests/fast/events/page-visibility-transition-test.html</a></li>
<li><a href="#trunkSourceWebCoreChangeLog">trunk/Source/WebCore/ChangeLog</a></li>
<li><a href="#trunkSourceWebCorepagePageVisibilityStatecpp">trunk/Source/WebCore/page/PageVisibilityState.cpp</a></li>
<li><a href="#trunkSourceWebCorepagePageVisibilityStateh">trunk/Source/WebCore/page/PageVisibilityState.h</a></li>
<li><a href="#trunkSourceWebKiteflWebCoreSupportAssertMatchingEnumscpp">trunk/Source/WebKit/efl/WebCoreSupport/AssertMatchingEnums.cpp</a></li>
<li><a href="#trunkSourceWebKiteflewkewk_viewcpp">trunk/Source/WebKit/efl/ewk/ewk_view.cpp</a></li>
<li><a href="#trunkSourceWebKitmacChangeLog">trunk/Source/WebKit/mac/ChangeLog</a></li>
<li><a href="#trunkSourceWebKitmacWebViewWebViewmm">trunk/Source/WebKit/mac/WebView/WebView.mm</a></li>
<li><a href="#trunkSourceWebKitmacWebViewWebViewPrivateh">trunk/Source/WebKit/mac/WebView/WebViewPrivate.h</a></li>
<li><a href="#trunkSourceWebKit2ChangeLog">trunk/Source/WebKit2/ChangeLog</a></li>
<li><a href="#trunkSourceWebKit2SharedAPIcWKPageVisibilityTypesh">trunk/Source/WebKit2/Shared/API/c/WKPageVisibilityTypes.h</a></li>
<li><a href="#trunkSourceWebKit2SharedAPIcWKSharedAPICasth">trunk/Source/WebKit2/Shared/API/c/WKSharedAPICast.h</a></li>
<li><a href="#trunkToolsChangeLog">trunk/Tools/ChangeLog</a></li>
<li><a href="#trunkToolsDumpRenderTreeeflTestRunnerEflcpp">trunk/Tools/DumpRenderTree/efl/TestRunnerEfl.cpp</a></li>
<li><a href="#trunkToolsDumpRenderTreemacTestRunnerMacmm">trunk/Tools/DumpRenderTree/mac/TestRunnerMac.mm</a></li>
<li><a href="#trunkToolsTestWebKitAPITestsWebKit2PageVisibilityStatecpp">trunk/Tools/TestWebKitAPI/Tests/WebKit2/PageVisibilityState.cpp</a></li>
<li><a href="#trunkToolsWebKitTestRunnerInjectedBundleTestRunnercpp">trunk/Tools/WebKitTestRunner/InjectedBundle/TestRunner.cpp</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkLayoutTestsChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/ChangeLog (160730 => 160731)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/ChangeLog 2013-12-17 23:30:04 UTC (rev 160730)
+++ trunk/LayoutTests/ChangeLog 2013-12-17 23:42:56 UTC (rev 160731)
</span><span class="lines">@@ -1,3 +1,17 @@
</span><ins>+2013-12-17 Gavin Barraclough <barraclough@apple.com>
+
+ Remove PageVisibilityStateUnloaded
+ https://bugs.webkit.org/show_bug.cgi?id=125869
+
+ Reviewed by Anders Carlsson.
+
+ This is not currently supported by WebKit, remove this enum value.
+ We can always add this back later if/when we add support for this state.
+
+ * fast/events/page-visibility-transition-test-expected.txt:
+ * fast/events/page-visibility-transition-test.html:
+ - remove test for visibility state "unloaded"; this is no longer supported (it never really was).
+
</ins><span class="cx"> 2013-12-17 Alexey Proskuryakov <ap@apple.com>
</span><span class="cx">
</span><span class="cx"> Sanitize skip entries for pop-up menu tests.
</span></span></pre></div>
<a id="trunkLayoutTestsfasteventspagevisibilitytransitiontestexpectedtxt"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/fast/events/page-visibility-transition-test-expected.txt (160730 => 160731)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/fast/events/page-visibility-transition-test-expected.txt 2013-12-17 23:30:04 UTC (rev 160730)
+++ trunk/LayoutTests/fast/events/page-visibility-transition-test-expected.txt 2013-12-17 23:42:56 UTC (rev 160731)
</span><span class="lines">@@ -13,10 +13,6 @@
</span><span class="cx"> PASS document.hidden is true
</span><span class="cx"> PASS document.visibilityState is "visible"
</span><span class="cx"> PASS document.hidden is false
</span><del>-PASS document.visibilityState is "unloaded"
-PASS document.hidden is true
-PASS document.visibilityState is "visible"
-PASS document.hidden is false
</del><span class="cx"> PASS successfullyParsed is true
</span><span class="cx">
</span><span class="cx"> TEST COMPLETE
</span></span></pre></div>
<a id="trunkLayoutTestsfasteventspagevisibilitytransitiontesthtml"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/fast/events/page-visibility-transition-test.html (160730 => 160731)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/fast/events/page-visibility-transition-test.html 2013-12-17 23:30:04 UTC (rev 160730)
+++ trunk/LayoutTests/fast/events/page-visibility-transition-test.html 2013-12-17 23:42:56 UTC (rev 160731)
</span><span class="lines">@@ -95,16 +95,6 @@
</span><span class="cx"> } else if (numVisibilityChanges == 4) {
</span><span class="cx"> checkIsPageVisible();
</span><span class="cx"> numVisibilityChanges++;
</span><del>- makePageUnloaded();
- return;
- } else if (numVisibilityChanges == 5) {
- checkIsPageInUnloaded();
- numVisibilityChanges++;
- makePageVisible();
- return;
- } else if (numVisibilityChanges == 6) {
- checkIsPageVisible();
- numVisibilityChanges++;
</del><span class="cx"> finishTest();
</span><span class="cx"> return;
</span><span class="cx"> } else {
</span></span></pre></div>
<a id="trunkSourceWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/ChangeLog (160730 => 160731)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/ChangeLog 2013-12-17 23:30:04 UTC (rev 160730)
+++ trunk/Source/WebCore/ChangeLog 2013-12-17 23:42:56 UTC (rev 160731)
</span><span class="lines">@@ -1,3 +1,18 @@
</span><ins>+2013-12-17 Gavin Barraclough <barraclough@apple.com>
+
+ Remove PageVisibilityStateUnloaded
+ https://bugs.webkit.org/show_bug.cgi?id=125869
+
+ Reviewed by Anders Carlsson.
+
+ This is not currently supported by WebKit, remove this enum value.
+ We can always add this back later if/when we add support for this state.
+
+ * page/PageVisibilityState.cpp:
+ (WebCore::pageVisibilityStateString):
+ * page/PageVisibilityState.h:
+ - removed PageVisibilityStateUnloaded
+
</ins><span class="cx"> 2013-12-12 Martin Robinson <mrobinson@igalia.com>
</span><span class="cx">
</span><span class="cx"> [GTK] [CMake] Build the plugin process against GTK+ 2
</span></span></pre></div>
<a id="trunkSourceWebCorepagePageVisibilityStatecpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/page/PageVisibilityState.cpp (160730 => 160731)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/page/PageVisibilityState.cpp 2013-12-17 23:30:04 UTC (rev 160730)
+++ trunk/Source/WebCore/page/PageVisibilityState.cpp 2013-12-17 23:42:56 UTC (rev 160731)
</span><span class="lines">@@ -40,7 +40,6 @@
</span><span class="cx"> DEFINE_STATIC_LOCAL(const String, visible, (ASCIILiteral("visible")));
</span><span class="cx"> DEFINE_STATIC_LOCAL(const String, hidden, (ASCIILiteral("hidden")));
</span><span class="cx"> DEFINE_STATIC_LOCAL(const String, prerender, (ASCIILiteral("prerender")));
</span><del>- DEFINE_STATIC_LOCAL(const String, unloaded, (ASCIILiteral("unloaded")));
</del><span class="cx">
</span><span class="cx"> switch (state) {
</span><span class="cx"> case PageVisibilityStateVisible:
</span><span class="lines">@@ -49,8 +48,6 @@
</span><span class="cx"> return hidden;
</span><span class="cx"> case PageVisibilityStatePrerender:
</span><span class="cx"> return prerender;
</span><del>- case PageVisibilityStateUnloaded:
- return unloaded;
</del><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> ASSERT_NOT_REACHED();
</span></span></pre></div>
<a id="trunkSourceWebCorepagePageVisibilityStateh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/page/PageVisibilityState.h (160730 => 160731)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/page/PageVisibilityState.h 2013-12-17 23:30:04 UTC (rev 160730)
+++ trunk/Source/WebCore/page/PageVisibilityState.h 2013-12-17 23:42:56 UTC (rev 160731)
</span><span class="lines">@@ -40,8 +40,7 @@
</span><span class="cx"> enum PageVisibilityState {
</span><span class="cx"> PageVisibilityStateVisible,
</span><span class="cx"> PageVisibilityStateHidden,
</span><del>- PageVisibilityStatePrerender,
- PageVisibilityStateUnloaded
</del><ins>+ PageVisibilityStatePrerender
</ins><span class="cx"> };
</span><span class="cx">
</span><span class="cx"> #if ENABLE(PAGE_VISIBILITY_API)
</span></span></pre></div>
<a id="trunkSourceWebKiteflWebCoreSupportAssertMatchingEnumscpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit/efl/WebCoreSupport/AssertMatchingEnums.cpp (160730 => 160731)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit/efl/WebCoreSupport/AssertMatchingEnums.cpp 2013-12-17 23:30:04 UTC (rev 160730)
+++ trunk/Source/WebKit/efl/WebCoreSupport/AssertMatchingEnums.cpp 2013-12-17 23:42:56 UTC (rev 160731)
</span><span class="lines">@@ -52,7 +52,6 @@
</span><span class="cx"> COMPILE_ASSERT_MATCHING_ENUM(EWK_PAGE_VISIBILITY_STATE_VISIBLE, PageVisibilityStateVisible);
</span><span class="cx"> COMPILE_ASSERT_MATCHING_ENUM(EWK_PAGE_VISIBILITY_STATE_HIDDEN, PageVisibilityStateHidden);
</span><span class="cx"> COMPILE_ASSERT_MATCHING_ENUM(EWK_PAGE_VISIBILITY_STATE_PRERENDER, PageVisibilityStatePrerender);
</span><del>-COMPILE_ASSERT_MATCHING_ENUM(EWK_PAGE_VISIBILITY_STATE_UNLOADED, PageVisibilityStateUnloaded);
</del><span class="cx"> #endif
</span><span class="cx">
</span><span class="cx"> COMPILE_ASSERT_MATCHING_ENUM(EWK_TEXT_SELECTION_NONE, VisibleSelection::NoSelection);
</span></span></pre></div>
<a id="trunkSourceWebKiteflewkewk_viewcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit/efl/ewk/ewk_view.cpp (160730 => 160731)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit/efl/ewk/ewk_view.cpp 2013-12-17 23:30:04 UTC (rev 160730)
+++ trunk/Source/WebKit/efl/ewk/ewk_view.cpp 2013-12-17 23:42:56 UTC (rev 160731)
</span><span class="lines">@@ -4250,6 +4250,10 @@
</span><span class="cx"> EWK_VIEW_SD_GET_OR_RETURN(ewkView, smartData, false);
</span><span class="cx"> EWK_VIEW_PRIV_GET_OR_RETURN(smartData, priv, false);
</span><span class="cx">
</span><ins>+ // WebKit does not curently support the "unloaded" state.
+ if (pageVisibilityState == EWK_PAGE_VISIBILITY_STATE_UNLOADED)
+ return false;
+
</ins><span class="cx"> priv->page->setVisibilityState(static_cast<WebCore::PageVisibilityState>(pageVisibilityState), initialState);
</span><span class="cx">
</span><span class="cx"> return true;
</span></span></pre></div>
<a id="trunkSourceWebKitmacChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit/mac/ChangeLog (160730 => 160731)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit/mac/ChangeLog 2013-12-17 23:30:04 UTC (rev 160730)
+++ trunk/Source/WebKit/mac/ChangeLog 2013-12-17 23:42:56 UTC (rev 160731)
</span><span class="lines">@@ -1,3 +1,19 @@
</span><ins>+2013-12-17 Gavin Barraclough <barraclough@apple.com>
+
+ Remove PageVisibilityStateUnloaded
+ https://bugs.webkit.org/show_bug.cgi?id=125869
+
+ Reviewed by Anders Carlsson.
+
+ This is not currently supported by WebKit, remove this enum value.
+ We can always add this back later if/when we add support for this state.
+
+ * WebView/WebView.mm:
+ (core):
+ (kit):
+ * WebView/WebViewPrivate.h:
+ - removed PageVisibilityStateUnloaded/WebPageVisibilityStateUnloaded
+
</ins><span class="cx"> 2013-12-15 Andy Estes <aestes@apple.com>
</span><span class="cx">
</span><span class="cx"> [iOS] Upstream changes to WebKit Public and Private headers
</span></span></pre></div>
<a id="trunkSourceWebKitmacWebViewWebViewmm"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit/mac/WebView/WebView.mm (160730 => 160731)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit/mac/WebView/WebView.mm 2013-12-17 23:30:04 UTC (rev 160730)
+++ trunk/Source/WebKit/mac/WebView/WebView.mm 2013-12-17 23:42:56 UTC (rev 160731)
</span><span class="lines">@@ -435,8 +435,6 @@
</span><span class="cx"> return PageVisibilityStateHidden;
</span><span class="cx"> case WebPageVisibilityStatePrerender:
</span><span class="cx"> return PageVisibilityStatePrerender;
</span><del>- case WebPageVisibilityStateUnloaded:
- return PageVisibilityStateUnloaded;
</del><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> ASSERT_NOT_REACHED();
</span><span class="lines">@@ -452,8 +450,6 @@
</span><span class="cx"> return WebPageVisibilityStateHidden;
</span><span class="cx"> case PageVisibilityStatePrerender:
</span><span class="cx"> return WebPageVisibilityStatePrerender;
</span><del>- case PageVisibilityStateUnloaded:
- return WebPageVisibilityStateUnloaded;
</del><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> ASSERT_NOT_REACHED();
</span></span></pre></div>
<a id="trunkSourceWebKitmacWebViewWebViewPrivateh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit/mac/WebView/WebViewPrivate.h (160730 => 160731)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit/mac/WebView/WebViewPrivate.h 2013-12-17 23:30:04 UTC (rev 160730)
+++ trunk/Source/WebKit/mac/WebView/WebViewPrivate.h 2013-12-17 23:42:56 UTC (rev 160731)
</span><span class="lines">@@ -156,8 +156,7 @@
</span><span class="cx"> typedef enum {
</span><span class="cx"> WebPageVisibilityStateVisible,
</span><span class="cx"> WebPageVisibilityStateHidden,
</span><del>- WebPageVisibilityStatePrerender,
- WebPageVisibilityStateUnloaded
</del><ins>+ WebPageVisibilityStatePrerender
</ins><span class="cx"> } WebPageVisibilityState;
</span><span class="cx">
</span><span class="cx"> typedef enum {
</span></span></pre></div>
<a id="trunkSourceWebKit2ChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit2/ChangeLog (160730 => 160731)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit2/ChangeLog 2013-12-17 23:30:04 UTC (rev 160730)
+++ trunk/Source/WebKit2/ChangeLog 2013-12-17 23:42:56 UTC (rev 160731)
</span><span class="lines">@@ -1,3 +1,18 @@
</span><ins>+2013-12-17 Gavin Barraclough <barraclough@apple.com>
+
+ Remove PageVisibilityStateUnloaded
+ https://bugs.webkit.org/show_bug.cgi?id=125869
+
+ Reviewed by Anders Carlsson.
+
+ This is not currently supported by WebKit, remove this enum value.
+ We can always add this back later if/when we add support for this state.
+
+ * Shared/API/c/WKPageVisibilityTypes.h:
+ * Shared/API/c/WKSharedAPICast.h:
+ (WebKit::toPageVisibilityState):
+ - removed PageVisibilityStateUnloaded/kWKPageVisibilityStateUnloaded
+
</ins><span class="cx"> 2013-12-12 Martin Robinson <mrobinson@igalia.com>
</span><span class="cx">
</span><span class="cx"> [GTK] [CMake] Build the plugin process against GTK+ 2
</span></span></pre></div>
<a id="trunkSourceWebKit2SharedAPIcWKPageVisibilityTypesh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit2/Shared/API/c/WKPageVisibilityTypes.h (160730 => 160731)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit2/Shared/API/c/WKPageVisibilityTypes.h 2013-12-17 23:30:04 UTC (rev 160730)
+++ trunk/Source/WebKit2/Shared/API/c/WKPageVisibilityTypes.h 2013-12-17 23:42:56 UTC (rev 160731)
</span><span class="lines">@@ -35,8 +35,7 @@
</span><span class="cx"> enum {
</span><span class="cx"> kWKPageVisibilityStateVisible,
</span><span class="cx"> kWKPageVisibilityStateHidden,
</span><del>- kWKPageVisibilityStatePrerender,
- kWKPageVisibilityStateUnloaded
</del><ins>+ kWKPageVisibilityStatePrerender
</ins><span class="cx"> };
</span><span class="cx"> typedef uint32_t WKPageVisibilityState;
</span><span class="cx">
</span></span></pre></div>
<a id="trunkSourceWebKit2SharedAPIcWKSharedAPICasth"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit2/Shared/API/c/WKSharedAPICast.h (160730 => 160731)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit2/Shared/API/c/WKSharedAPICast.h 2013-12-17 23:30:04 UTC (rev 160730)
+++ trunk/Source/WebKit2/Shared/API/c/WKSharedAPICast.h 2013-12-17 23:42:56 UTC (rev 160731)
</span><span class="lines">@@ -853,8 +853,6 @@
</span><span class="cx"> return WebCore::PageVisibilityStateHidden;
</span><span class="cx"> case kWKPageVisibilityStatePrerender:
</span><span class="cx"> return WebCore::PageVisibilityStatePrerender;
</span><del>- case kWKPageVisibilityStateUnloaded:
- return WebCore::PageVisibilityStateUnloaded;
</del><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> ASSERT_NOT_REACHED();
</span></span></pre></div>
<a id="trunkToolsChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Tools/ChangeLog (160730 => 160731)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Tools/ChangeLog 2013-12-17 23:30:04 UTC (rev 160730)
+++ trunk/Tools/ChangeLog 2013-12-17 23:42:56 UTC (rev 160731)
</span><span class="lines">@@ -1,3 +1,21 @@
</span><ins>+2013-12-17 Gavin Barraclough <barraclough@apple.com>
+
+ Remove PageVisibilityStateUnloaded
+ https://bugs.webkit.org/show_bug.cgi?id=125869
+
+ Reviewed by Anders Carlsson.
+
+ This is not currently supported by WebKit, remove this enum value.
+ We can always add this back later if/when we add support for this state.
+
+ * DumpRenderTree/mac/TestRunnerMac.mm:
+ (TestRunner::setPageVisibility):
+ * TestWebKitAPI/Tests/WebKit2/PageVisibilityState.cpp:
+ (TestWebKitAPI::didRunStep3StateChangePrerenderToUnloaded):
+ * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
+ (WTR::TestRunner::setPageVisibility):
+ - remove test for visibility state "unloaded"; this is no longer supported (it never really was).
+
</ins><span class="cx"> 2013-12-12 Martin Robinson <mrobinson@igalia.com>
</span><span class="cx">
</span><span class="cx"> [GTK] [CMake] Build the plugin process against GTK+ 2
</span></span></pre></div>
<a id="trunkToolsDumpRenderTreeeflTestRunnerEflcpp"></a>
<div class="modfile"><h4>Modified: trunk/Tools/DumpRenderTree/efl/TestRunnerEfl.cpp (160730 => 160731)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Tools/DumpRenderTree/efl/TestRunnerEfl.cpp 2013-12-17 23:30:04 UTC (rev 160730)
+++ trunk/Tools/DumpRenderTree/efl/TestRunnerEfl.cpp 2013-12-17 23:42:56 UTC (rev 160731)
</span><span class="lines">@@ -817,8 +817,6 @@
</span><span class="cx"> ewk_view_visibility_state_set(browser->mainView(), EWK_PAGE_VISIBILITY_STATE_HIDDEN, false);
</span><span class="cx"> else if (newVisibility == "prerender")
</span><span class="cx"> ewk_view_visibility_state_set(browser->mainView(), EWK_PAGE_VISIBILITY_STATE_PRERENDER, false);
</span><del>- else if (newVisibility == "unloaded")
- ewk_view_visibility_state_set(browser->mainView(), EWK_PAGE_VISIBILITY_STATE_UNLOADED, false);
</del><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> void TestRunner::setAutomaticLinkDetectionEnabled(bool)
</span></span></pre></div>
<a id="trunkToolsDumpRenderTreemacTestRunnerMacmm"></a>
<div class="modfile"><h4>Modified: trunk/Tools/DumpRenderTree/mac/TestRunnerMac.mm (160730 => 160731)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Tools/DumpRenderTree/mac/TestRunnerMac.mm 2013-12-17 23:30:04 UTC (rev 160730)
+++ trunk/Tools/DumpRenderTree/mac/TestRunnerMac.mm 2013-12-17 23:42:56 UTC (rev 160731)
</span><span class="lines">@@ -1075,8 +1075,6 @@
</span><span class="cx"> [webView _setVisibilityState:WebPageVisibilityStateHidden isInitialState:NO];
</span><span class="cx"> else if (!strcmp(newVisibility, "prerender"))
</span><span class="cx"> [webView _setVisibilityState:WebPageVisibilityStatePrerender isInitialState:NO];
</span><del>- else if (!strcmp(newVisibility, "unloaded"))
- [webView _setVisibilityState:WebPageVisibilityStateUnloaded isInitialState:NO];
</del><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> void TestRunner::grantWebNotificationPermission(JSStringRef jsOrigin)
</span></span></pre></div>
<a id="trunkToolsTestWebKitAPITestsWebKit2PageVisibilityStatecpp"></a>
<div class="modfile"><h4>Modified: trunk/Tools/TestWebKitAPI/Tests/WebKit2/PageVisibilityState.cpp (160730 => 160731)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Tools/TestWebKitAPI/Tests/WebKit2/PageVisibilityState.cpp 2013-12-17 23:30:04 UTC (rev 160730)
+++ trunk/Tools/TestWebKitAPI/Tests/WebKit2/PageVisibilityState.cpp 2013-12-17 23:42:56 UTC (rev 160731)
</span><span class="lines">@@ -38,7 +38,6 @@
</span><span class="cx"> static void didRunStep1StateChangeVisibleToHidden(WKSerializedScriptValueRef, WKErrorRef, void*);
</span><span class="cx"> static void didRunStep2StateChangeHiddenToPrerender(WKSerializedScriptValueRef, WKErrorRef, void*);
</span><span class="cx"> static void didRunStep3StateChangePrerenderToUnloaded(WKSerializedScriptValueRef, WKErrorRef, void*);
</span><del>-static void didRunStep4InStateUnloaded(WKSerializedScriptValueRef, WKErrorRef, void*);
</del><span class="cx">
</span><span class="cx"> static void setPageVisibilityStateWithEvalContinuation(PlatformWebView* webView, WKPageVisibilityState visibilityState, WKPageRunJavaScriptFunction callback)
</span><span class="cx"> {
</span><span class="lines">@@ -86,12 +85,6 @@
</span><span class="cx"> static void didRunStep3StateChangePrerenderToUnloaded(WKSerializedScriptValueRef resultSerializedScriptValue, WKErrorRef error, void* context)
</span><span class="cx"> {
</span><span class="cx"> assertSerializedScriptValueIsStringValue(resultSerializedScriptValue, error, "prerender");
</span><del>- setPageVisibilityStateWithEvalContinuation(static_cast<PlatformWebView*>(context), kWKPageVisibilityStateUnloaded, didRunStep4InStateUnloaded);
-}
-
-static void didRunStep4InStateUnloaded(WKSerializedScriptValueRef resultSerializedScriptValue, WKErrorRef error, void* context)
-{
- assertSerializedScriptValueIsStringValue(resultSerializedScriptValue, error, "unloaded");
</del><span class="cx"> testDone = true;
</span><span class="cx"> }
</span><span class="cx">
</span></span></pre></div>
<a id="trunkToolsWebKitTestRunnerInjectedBundleTestRunnercpp"></a>
<div class="modfile"><h4>Modified: trunk/Tools/WebKitTestRunner/InjectedBundle/TestRunner.cpp (160730 => 160731)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Tools/WebKitTestRunner/InjectedBundle/TestRunner.cpp 2013-12-17 23:30:04 UTC (rev 160730)
+++ trunk/Tools/WebKitTestRunner/InjectedBundle/TestRunner.cpp 2013-12-17 23:42:56 UTC (rev 160731)
</span><span class="lines">@@ -491,8 +491,6 @@
</span><span class="cx"> visibilityState = kWKPageVisibilityStateHidden;
</span><span class="cx"> else if (JSStringIsEqualToUTF8CString(state, "prerender"))
</span><span class="cx"> visibilityState = kWKPageVisibilityStatePrerender;
</span><del>- else if (JSStringIsEqualToUTF8CString(state, "unloaded"))
- visibilityState = kWKPageVisibilityStateUnloaded;
</del><span class="cx">
</span><span class="cx"> InjectedBundle::shared().setVisibilityState(visibilityState, false);
</span><span class="cx"> }
</span></span></pre>
</div>
</div>
</body>
</html>