<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[160719] trunk</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/160719">160719</a></dd>
<dt>Author</dt> <dd>rniwa@webkit.org</dd>
<dt>Date</dt> <dd>2013-12-17 12:10:12 -0800 (Tue, 17 Dec 2013)</dd>
</dl>
<h3>Log Message</h3>
<pre>Invalid dir attributes should resolve to ltr
https://bugs.webkit.org/show_bug.cgi?id=125830
Source/WebCore:
Reviewed by Darin Adler.
Merge https://chromium.googlesource.com/chromium/blink/+/2d592d1c998bec9438e421e1ce1ee6caba05a884
The dir attribute should resolve to direction: ltr by default when the attribute value is
"not in a defined state": http://www.w3.org/TR/2013/WD-html51-20130528/dom.html#the-directionality
Test: fast/dom/HTMLElement/set-and-clear-dir-attribute.html
* html/HTMLElement.cpp:
(WebCore::isLTROrRTLIgnoringCase): Extracted from HTMLElement::directionality.
(WebCore::HTMLElement::collectStyleForPresentationAttribute):
(WebCore::HTMLElement::directionality):
LayoutTests:
Reviewed by Darin Adler.
* fast/dom/HTMLElement/set-and-clear-dir-attribute-expected.txt: Added.
* fast/dom/HTMLElement/set-and-clear-dir-attribute.html: Added.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkLayoutTestsChangeLog">trunk/LayoutTests/ChangeLog</a></li>
<li><a href="#trunkSourceWebCoreChangeLog">trunk/Source/WebCore/ChangeLog</a></li>
<li><a href="#trunkSourceWebCorehtmlHTMLElementcpp">trunk/Source/WebCore/html/HTMLElement.cpp</a></li>
</ul>
<h3>Added Paths</h3>
<ul>
<li><a href="#trunkLayoutTestsfastdomHTMLElementsetandcleardirattributeexpectedtxt">trunk/LayoutTests/fast/dom/HTMLElement/set-and-clear-dir-attribute-expected.txt</a></li>
<li><a href="#trunkLayoutTestsfastdomHTMLElementsetandcleardirattributehtml">trunk/LayoutTests/fast/dom/HTMLElement/set-and-clear-dir-attribute.html</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkLayoutTestsChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/ChangeLog (160718 => 160719)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/ChangeLog 2013-12-17 19:46:32 UTC (rev 160718)
+++ trunk/LayoutTests/ChangeLog 2013-12-17 20:10:12 UTC (rev 160719)
</span><span class="lines">@@ -1,3 +1,13 @@
</span><ins>+2013-12-17 Ryosuke Niwa <rniwa@webkit.org>
+
+ Invalid dir attributes should resolve to ltr
+ https://bugs.webkit.org/show_bug.cgi?id=125830
+
+ Reviewed by Darin Adler.
+
+ * fast/dom/HTMLElement/set-and-clear-dir-attribute-expected.txt: Added.
+ * fast/dom/HTMLElement/set-and-clear-dir-attribute.html: Added.
+
</ins><span class="cx"> 2013-12-17 Mihnea Ovidenie <mihnea@adobe.com>
</span><span class="cx">
</span><span class="cx"> [CSSRegions] Incorrect repaint of fixed element with transformed parent
</span></span></pre></div>
<a id="trunkLayoutTestsfastdomHTMLElementsetandcleardirattributeexpectedtxt"></a>
<div class="addfile"><h4>Added: trunk/LayoutTests/fast/dom/HTMLElement/set-and-clear-dir-attribute-expected.txt (0 => 160719)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/fast/dom/HTMLElement/set-and-clear-dir-attribute-expected.txt (rev 0)
+++ trunk/LayoutTests/fast/dom/HTMLElement/set-and-clear-dir-attribute-expected.txt 2013-12-17 20:10:12 UTC (rev 160719)
</span><span class="lines">@@ -0,0 +1,20 @@
</span><ins>+This tests that setting the dir attribute to rtl and clearing it defaults to ltr.
+
+On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
+
+
+PASS getComputedStyle(document.body).direction is "ltr"
+PASS getComputedStyle(someElementInBody).direction is "ltr"
+PASS document.body.dir = "rtl"; getComputedStyle(document.body).direction is "rtl"
+PASS getComputedStyle(someElementInBody).direction is "rtl"
+PASS someElementInBody.dir = "rtl"; getComputedStyle(someElementInBody).direction is "rtl"
+PASS document.body.dir = ""; getComputedStyle(document.body).direction is "ltr"
+PASS getComputedStyle(someElementInBody).direction is "rtl"
+PASS someElementInBody.dir = ""; getComputedStyle(someElementInBody).direction is "ltr"
+PASS someElementInBody.dir = "ltr"; getComputedStyle(someElementInBody).direction is "ltr"
+PASS document.body.dir = "rtl"; getComputedStyle(document.body).direction is "rtl"
+PASS someElementInBody.dir = ""; getComputedStyle(someElementInBody).direction is "rtl"
+PASS successfullyParsed is true
+
+TEST COMPLETE
+
</ins></span></pre></div>
<a id="trunkLayoutTestsfastdomHTMLElementsetandcleardirattributehtml"></a>
<div class="addfile"><h4>Added: trunk/LayoutTests/fast/dom/HTMLElement/set-and-clear-dir-attribute.html (0 => 160719)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/fast/dom/HTMLElement/set-and-clear-dir-attribute.html (rev 0)
+++ trunk/LayoutTests/fast/dom/HTMLElement/set-and-clear-dir-attribute.html 2013-12-17 20:10:12 UTC (rev 160719)
</span><span class="lines">@@ -0,0 +1,27 @@
</span><ins>+<!DOCTYPE html>
+<html dir="ltr">
+<body>
+<div id="someElementInBody"></div>
+<script src="../../../resources/js-test-pre.js"></script>
+<script>
+
+description('This tests that setting the dir attribute to rtl and clearing it defaults to ltr.');
+
+var someElementInBody = document.getElementById('someElementInBody');
+
+shouldBeEqualToString('getComputedStyle(document.body).direction', 'ltr');
+shouldBeEqualToString('getComputedStyle(someElementInBody).direction', 'ltr');
+shouldBeEqualToString('document.body.dir = "rtl"; getComputedStyle(document.body).direction', 'rtl');
+shouldBeEqualToString('getComputedStyle(someElementInBody).direction', 'rtl');
+shouldBeEqualToString('someElementInBody.dir = "rtl"; getComputedStyle(someElementInBody).direction', 'rtl');
+shouldBeEqualToString('document.body.dir = ""; getComputedStyle(document.body).direction', 'ltr');
+shouldBeEqualToString('getComputedStyle(someElementInBody).direction', 'rtl');
+shouldBeEqualToString('someElementInBody.dir = ""; getComputedStyle(someElementInBody).direction', 'ltr');
+shouldBeEqualToString('someElementInBody.dir = "ltr"; getComputedStyle(someElementInBody).direction', 'ltr');
+shouldBeEqualToString('document.body.dir = "rtl"; getComputedStyle(document.body).direction', 'rtl');
+shouldBeEqualToString('someElementInBody.dir = ""; getComputedStyle(someElementInBody).direction', 'rtl');
+
+</script>
+<script src="../../../resources/js-test-post.js"></script>
+</body>
+</html>
</ins></span></pre></div>
<a id="trunkSourceWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/ChangeLog (160718 => 160719)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/ChangeLog 2013-12-17 19:46:32 UTC (rev 160718)
+++ trunk/Source/WebCore/ChangeLog 2013-12-17 20:10:12 UTC (rev 160719)
</span><span class="lines">@@ -1,3 +1,22 @@
</span><ins>+2013-12-17 Ryosuke Niwa <rniwa@webkit.org>
+
+ Invalid dir attributes should resolve to ltr
+ https://bugs.webkit.org/show_bug.cgi?id=125830
+
+ Reviewed by Darin Adler.
+
+ Merge https://chromium.googlesource.com/chromium/blink/+/2d592d1c998bec9438e421e1ce1ee6caba05a884
+
+ The dir attribute should resolve to direction: ltr by default when the attribute value is
+ "not in a defined state": http://www.w3.org/TR/2013/WD-html51-20130528/dom.html#the-directionality
+
+ Test: fast/dom/HTMLElement/set-and-clear-dir-attribute.html
+
+ * html/HTMLElement.cpp:
+ (WebCore::isLTROrRTLIgnoringCase): Extracted from HTMLElement::directionality.
+ (WebCore::HTMLElement::collectStyleForPresentationAttribute):
+ (WebCore::HTMLElement::directionality):
+
</ins><span class="cx"> 2013-12-17 Mihnea Ovidenie <mihnea@adobe.com>
</span><span class="cx">
</span><span class="cx"> [CSSRegions] Incorrect repaint of fixed element with transformed parent
</span></span></pre></div>
<a id="trunkSourceWebCorehtmlHTMLElementcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/html/HTMLElement.cpp (160718 => 160719)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/html/HTMLElement.cpp 2013-12-17 19:46:32 UTC (rev 160718)
+++ trunk/Source/WebCore/html/HTMLElement.cpp 2013-12-17 20:10:12 UTC (rev 160719)
</span><span class="lines">@@ -162,6 +162,11 @@
</span><span class="cx"> return StyledElement::isPresentationAttribute(name);
</span><span class="cx"> }
</span><span class="cx">
</span><ins>+static bool isLTROrRTLIgnoringCase(const AtomicString& dirAttributeValue)
+{
+ return equalIgnoringCase(dirAttributeValue, "rtl") || equalIgnoringCase(dirAttributeValue, "ltr");
+}
+
</ins><span class="cx"> void HTMLElement::collectStyleForPresentationAttribute(const QualifiedName& name, const AtomicString& value, MutableStyleProperties& style)
</span><span class="cx"> {
</span><span class="cx"> if (name == alignAttr) {
</span><span class="lines">@@ -194,7 +199,8 @@
</span><span class="cx"> if (equalIgnoringCase(value, "auto"))
</span><span class="cx"> addPropertyToPresentationAttributeStyle(style, CSSPropertyUnicodeBidi, unicodeBidiAttributeForDirAuto(*this));
</span><span class="cx"> else {
</span><del>- addPropertyToPresentationAttributeStyle(style, CSSPropertyDirection, value);
</del><ins>+ if (isLTROrRTLIgnoringCase(value))
+ addPropertyToPresentationAttributeStyle(style, CSSPropertyDirection, value);
</ins><span class="cx"> if (!hasTagName(bdiTag) && !hasTagName(bdoTag) && !hasTagName(outputTag))
</span><span class="cx"> addPropertyToPresentationAttributeStyle(style, CSSPropertyUnicodeBidi, CSSValueEmbed);
</span><span class="cx"> }
</span><span class="lines">@@ -866,7 +872,7 @@
</span><span class="cx"> // Skip elements with valid dir attribute
</span><span class="cx"> if (node->isElementNode()) {
</span><span class="cx"> AtomicString dirAttributeValue = toElement(node)->fastGetAttribute(dirAttr);
</span><del>- if (equalIgnoringCase(dirAttributeValue, "rtl") || equalIgnoringCase(dirAttributeValue, "ltr") || equalIgnoringCase(dirAttributeValue, "auto")) {
</del><ins>+ if (isLTROrRTLIgnoringCase(dirAttributeValue) || equalIgnoringCase(dirAttributeValue, "auto")) {
</ins><span class="cx"> node = NodeTraversal::nextSkippingChildren(node, this);
</span><span class="cx"> continue;
</span><span class="cx"> }
</span></span></pre>
</div>
</div>
</body>
</html>