<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[160641] trunk</title>
</head>
<body>

<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt;  }
#msg dl a { font-weight: bold}
#msg dl a:link    { color:#fc3; }
#msg dl a:active  { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff  {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/160641">160641</a></dd>
<dt>Author</dt> <dd>mario.prada@samsung.com</dd>
<dt>Date</dt> <dd>2013-12-16 08:18:30 -0800 (Mon, 16 Dec 2013)</dd>
</dl>

<h3>Log Message</h3>
<pre>[ATK] Expose accessibility objects for more WAI-ARIA roles
https://bugs.webkit.org/show_bug.cgi?id=125596

Reviewed by Chris Fleizach.

Source/WebCore:

Exposed accessibility objects with the proper AtkRoles, some of
them to be provided by the next stable release of ATK.

* accessibility/atk/WebKitAccessibleWrapperAtk.cpp:
(atkRole):

Tools:

Add mappings to DRT &amp; WKTR for the newly exposed roles.

* DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
* WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:

LayoutTests:

Update test to update expectations.

* platform/gtk/accessibility/roles-exposed-expected.txt:
* platform/gtk/accessibility/roles-exposed.html:</pre>

<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkLayoutTestsChangeLog">trunk/LayoutTests/ChangeLog</a></li>
<li><a href="#trunkLayoutTestsplatformgtkaccessibilityrolesexposedexpectedtxt">trunk/LayoutTests/platform/gtk/accessibility/roles-exposed-expected.txt</a></li>
<li><a href="#trunkLayoutTestsplatformgtkaccessibilityrolesexposedhtml">trunk/LayoutTests/platform/gtk/accessibility/roles-exposed.html</a></li>
<li><a href="#trunkSourceWebCoreChangeLog">trunk/Source/WebCore/ChangeLog</a></li>
<li><a href="#trunkSourceWebCoreaccessibilityatkWebKitAccessibleWrapperAtkcpp">trunk/Source/WebCore/accessibility/atk/WebKitAccessibleWrapperAtk.cpp</a></li>
<li><a href="#trunkToolsChangeLog">trunk/Tools/ChangeLog</a></li>
<li><a href="#trunkToolsDumpRenderTreeatkAccessibilityUIElementAtkcpp">trunk/Tools/DumpRenderTree/atk/AccessibilityUIElementAtk.cpp</a></li>
<li><a href="#trunkToolsWebKitTestRunnerInjectedBundleatkAccessibilityUIElementAtkcpp">trunk/Tools/WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp</a></li>
</ul>

</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkLayoutTestsChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/ChangeLog (160640 => 160641)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/ChangeLog        2013-12-16 16:04:50 UTC (rev 160640)
+++ trunk/LayoutTests/ChangeLog        2013-12-16 16:18:30 UTC (rev 160641)
</span><span class="lines">@@ -1,3 +1,15 @@
</span><ins>+2013-12-16  Mario Sanchez Prada  &lt;mario.prada@samsung.com&gt;
+
+        [ATK] Expose accessibility objects for more WAI-ARIA roles
+        https://bugs.webkit.org/show_bug.cgi?id=125596
+
+        Reviewed by Chris Fleizach.
+
+        Update test to update expectations.
+
+        * platform/gtk/accessibility/roles-exposed-expected.txt:
+        * platform/gtk/accessibility/roles-exposed.html:
+
</ins><span class="cx"> 2013-12-16  Eric Carlson  &lt;eric.carlson@apple.com&gt;
</span><span class="cx"> 
</span><span class="cx">         Fix QuickTime plug-in replacement scripting bugs
</span></span></pre></div>
<a id="trunkLayoutTestsplatformgtkaccessibilityrolesexposedexpectedtxt"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/platform/gtk/accessibility/roles-exposed-expected.txt (160640 => 160641)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/platform/gtk/accessibility/roles-exposed-expected.txt        2013-12-16 16:04:50 UTC (rev 160640)
+++ trunk/LayoutTests/platform/gtk/accessibility/roles-exposed-expected.txt        2013-12-16 16:18:30 UTC (rev 160641)
</span><span class="lines">@@ -126,6 +126,9 @@
</span><span class="cx"> PASS: input[type='week']
</span><span class="cx">       AXRole: AXTextField
</span><span class="cx">       
</span><ins>+PASS: math
+      AXRole: AXMath
+      
</ins><span class="cx"> PASS: nav
</span><span class="cx">       AXRole: AXLandmarkNavigation
</span><span class="cx">       
</span><span class="lines">@@ -255,6 +258,12 @@
</span><span class="cx"> PASS: div[role=contentinfo]
</span><span class="cx">       AXRole: AXLandmarkContentInfo
</span><span class="cx">       
</span><ins>+PASS: div[role=definition]
+      AXRole: AXDefinition
+      
+PASS: div[role=dialog]
+      AXRole: AXDialog
+      
</ins><span class="cx"> PASS: div[role=directory]
</span><span class="cx">       AXRole: AXList
</span><span class="cx">       
</span><span class="lines">@@ -296,9 +305,18 @@
</span><span class="cx"> PASS: div[role=option]
</span><span class="cx">       AXRole: AXListItem
</span><span class="cx">       
</span><ins>+PASS: div[role=log]
+      AXRole: AXLog
+      
</ins><span class="cx"> PASS: div[role=main]
</span><span class="cx">       AXRole: AXLandmarkMain
</span><span class="cx">       
</span><ins>+PASS: div[role=marquee]
+      AXRole: AXMarquee
+      
+PASS: div[role=math]
+      AXRole: AXMath
+      
</ins><span class="cx"> PASS: div[role=menu]
</span><span class="cx">       AXRole: AXMenu
</span><span class="cx">       
</span><span class="lines">@@ -326,6 +344,9 @@
</span><span class="cx"> PASS: div[role=navigation]
</span><span class="cx">       AXRole: AXLandmarkNavigation
</span><span class="cx">       
</span><ins>+PASS: div[role=note]
+      AXRole: AXComment
+      
</ins><span class="cx"> PASS: div[role=progressbar]
</span><span class="cx">       AXRole: AXProgressIndicator
</span><span class="cx">       
</span><span class="lines">@@ -359,6 +380,9 @@
</span><span class="cx"> PASS: div[role=textbox]
</span><span class="cx">       AXRole: AXTextField
</span><span class="cx">       
</span><ins>+PASS: div[role=timer]
+      AXRole: AXTimer
+      
</ins><span class="cx"> PASS: div[role=toolbar]
</span><span class="cx">       AXRole: AXToolbar
</span><span class="cx">       
</span></span></pre></div>
<a id="trunkLayoutTestsplatformgtkaccessibilityrolesexposedhtml"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/platform/gtk/accessibility/roles-exposed.html (160640 => 160641)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/platform/gtk/accessibility/roles-exposed.html        2013-12-16 16:04:50 UTC (rev 160640)
+++ trunk/LayoutTests/platform/gtk/accessibility/roles-exposed.html        2013-12-16 16:18:30 UTC (rev 160641)
</span><span class="lines">@@ -1,4 +1,3 @@
</span><del>-
</del><span class="cx"> &lt;!DOCTYPE HTML&gt;
</span><span class="cx"> &lt;html&gt;
</span><span class="cx"> &lt;body&gt;
</span><span class="lines">@@ -90,7 +89,7 @@
</span><span class="cx"> &lt;!-- skipped &lt;link&gt; --&gt;
</span><span class="cx"> &lt;!-- skipped &lt;map&gt; --&gt;
</span><span class="cx"> &lt;!-- skipped ATK: not focusable -- http://webkit.org/b/109018 &lt;mark data-role=&quot;&quot; class=&quot;ex&quot;&gt;X&lt;/mark&gt;--&gt;
</span><del>-&lt;!-- http://webkit.org/b/125493 &lt;math data-role=&quot;AXMath&quot; class=&quot;ex&quot;&gt;X&lt;/math&gt;--&gt;
</del><ins>+&lt;math data-role=&quot;AXMath&quot; class=&quot;ex&quot;&gt;X&lt;/math&gt;
</ins><span class="cx"> &lt;!-- skipped &lt;menu&gt; --&gt;
</span><span class="cx"> &lt;!-- skipped &lt;meta&gt; --&gt;
</span><span class="cx"> &lt;!-- http://webkit.org/b/125491 &lt;meter data-role=&quot;AXProgressIndicator&quot; class=&quot;ex&quot; value=&quot;0.75&quot;&gt;X&lt;/meter&gt;--&gt;
</span><span class="lines">@@ -196,8 +195,8 @@
</span><span class="cx"> &lt;div role=&quot;combobox&quot;                 data-role=&quot;AXComboBox&quot; class=&quot;ex&quot;&gt;X&lt;/div&gt;
</span><span class="cx"> &lt;div role=&quot;complementary&quot;            data-role=&quot;AXLandmarkComplementary&quot; class=&quot;ex&quot;&gt;X&lt;/div&gt;
</span><span class="cx"> &lt;div role=&quot;contentinfo&quot;              data-role=&quot;AXLandmarkContentInfo&quot; class=&quot;ex&quot;&gt;X&lt;/div&gt;
</span><del>-&lt;!-- http://webkit.org/b/125493 &lt;div role=&quot;definition&quot;               data-role=&quot;AXDefinition&quot; class=&quot;ex&quot;&gt;X&lt;/div&gt;--&gt;
-&lt;!-- http://webkit.org/b/125493 &lt;div role=&quot;dialog&quot;                   data-role=&quot;AXGroup&quot; class=&quot;ex&quot;&gt;X&lt;/div&gt;--&gt;
</del><ins>+&lt;div role=&quot;definition&quot;               data-role=&quot;AXDefinition&quot; class=&quot;ex&quot;&gt;X&lt;/div&gt;
+&lt;div role=&quot;dialog&quot;                   data-role=&quot;AXDialog&quot; class=&quot;ex&quot;&gt;X&lt;/div&gt;
</ins><span class="cx"> &lt;div role=&quot;directory&quot;                data-role=&quot;AXList&quot; class=&quot;ex&quot;&gt;X&lt;/div&gt;
</span><span class="cx"> &lt;!-- http://webkit.org/b/125493 &lt;div role=&quot;document&quot;                 data-role=&quot;AXGroup&quot; class=&quot;ex&quot;&gt;X&lt;/div&gt;--&gt;
</span><span class="cx"> &lt;!-- skipped ATK: wrong role &lt;div role=&quot;form&quot;                     data-role=&quot;AXForm&quot; class=&quot;ex&quot;&gt;X&lt;/div&gt;--&gt;
</span><span class="lines">@@ -221,10 +220,10 @@
</span><span class="cx"> &lt;div role=&quot;listbox&quot;                  data-role=&quot;AXListBox&quot; class=&quot;ex&quot;&gt;&lt;!-- http://webkit.org/b/125491 --&gt;
</span><span class="cx">     &lt;div role=&quot;option&quot;               data-role=&quot;AXListItem&quot; class=&quot;ex&quot;&gt;X&lt;/div&gt;
</span><span class="cx"> &lt;/div&gt;
</span><del>-&lt;!-- http://webkit.org/b/125493 &lt;div role=&quot;log&quot;                      data-role=&quot;AXLog&quot; class=&quot;ex&quot;&gt;X&lt;/div&gt;--&gt;
</del><ins>+&lt;div role=&quot;log&quot;                      data-role=&quot;AXLog&quot; class=&quot;ex&quot;&gt;X&lt;/div&gt;
</ins><span class="cx"> &lt;div role=&quot;main&quot;                     data-role=&quot;AXLandmarkMain&quot; class=&quot;ex&quot;&gt;X&lt;/div&gt;
</span><del>-&lt;!-- http://webkit.org/b/125493 &lt;div role=&quot;marquee&quot;                  data-role=&quot;AXMarquee&quot; class=&quot;ex&quot;&gt;X&lt;/div&gt;--&gt;
-&lt;!-- http://webkit.org/b/125493 &lt;div role=&quot;math&quot;                     data-role=&quot;AXMath&quot; class=&quot;ex&quot;&gt;X&lt;/div&gt;--&gt;
</del><ins>+&lt;div role=&quot;marquee&quot;                  data-role=&quot;AXMarquee&quot; class=&quot;ex&quot;&gt;X&lt;/div&gt;
+&lt;div role=&quot;math&quot;                     data-role=&quot;AXMath&quot; class=&quot;ex&quot;&gt;X&lt;/div&gt;
</ins><span class="cx"> &lt;div role=&quot;menu&quot;                     data-role=&quot;AXMenu&quot; class=&quot;ex&quot;&gt;
</span><span class="cx">     &lt;!-- Note: diff between menuitem types is an attribute; need additional non-role verification in another test. --&gt;
</span><span class="cx">     &lt;div role=&quot;menuitem&quot;             data-role=&quot;AXMenuItem&quot; class=&quot;ex&quot;&gt;X&lt;/div&gt;
</span><span class="lines">@@ -238,7 +237,7 @@
</span><span class="cx">     &lt;div role=&quot;menuitemradio&quot;        data-role=&quot;AXRadioMenuItem&quot; class=&quot;ex&quot;&gt;X&lt;/div&gt;
</span><span class="cx"> &lt;/div&gt;
</span><span class="cx"> &lt;div role=&quot;navigation&quot;               data-role=&quot;AXLandmarkNavigation&quot; class=&quot;ex&quot;&gt;X&lt;/div&gt;
</span><del>-&lt;!-- http://webkit.org/b/125493 &lt;div role=&quot;note&quot;                     data-role=&quot;AXComment&quot; class=&quot;ex&quot;&gt;X&lt;/div&gt;--&gt;
</del><ins>+&lt;div role=&quot;note&quot;                     data-role=&quot;AXComment&quot; class=&quot;ex&quot;&gt;X&lt;/div&gt;
</ins><span class="cx"> &lt;!-- skipped: presentation elements should not be exposed directly &lt;div role=&quot;presentation&quot;             data-role=&quot;&quot; class=&quot;ex&quot;&gt;X&lt;/div&gt;--&gt;
</span><span class="cx"> &lt;div role=&quot;progressbar&quot;              data-role=&quot;AXProgressIndicator&quot; class=&quot;ex&quot;&gt;X&lt;/div&gt;
</span><span class="cx"> &lt;div role=&quot;radiogroup&quot;               data-role=&quot;AXGroup&quot; class=&quot;ex&quot;&gt;
</span><span class="lines">@@ -256,7 +255,7 @@
</span><span class="cx"> &lt;/div&gt;
</span><span class="cx"> &lt;!-- skipped ATK: wrong role &lt;div role=&quot;tabpanel&quot;                 data-role=&quot;AXGroup&quot; panel&quot; class=&quot;ex&quot;&gt;X&lt;/div&gt;--&gt;
</span><span class="cx"> &lt;div role=&quot;textbox&quot;                  data-role=&quot;AXTextField&quot; class=&quot;ex&quot;&gt;X&lt;/div&gt;
</span><del>-&lt;!-- http://webkit.org/b/125493 &lt;div role=&quot;timer&quot;                    data-role=&quot;AXTimer&quot; class=&quot;ex&quot;&gt;X&lt;/div&gt;--&gt;
</del><ins>+&lt;div role=&quot;timer&quot;                    data-role=&quot;AXTimer&quot; class=&quot;ex&quot;&gt;X&lt;/div&gt;
</ins><span class="cx"> &lt;div role=&quot;toolbar&quot;                  data-role=&quot;AXToolbar&quot; class=&quot;ex&quot;&gt;X&lt;/div&gt;
</span><span class="cx"> &lt;!-- http://webkit.org/b/125493 &lt;div role=&quot;tooltip&quot;                  data-role=&quot;AXGroup&quot; class=&quot;ex&quot;&gt;X&lt;/div&gt;--&gt;
</span><span class="cx"> &lt;!-- http://webkit.org/b/125493 &lt;div role=&quot;tree&quot;                     data-role=&quot;AXOutline&quot; class=&quot;ex&quot;&gt;--&gt;
</span></span></pre></div>
<a id="trunkSourceWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/ChangeLog (160640 => 160641)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/ChangeLog        2013-12-16 16:04:50 UTC (rev 160640)
+++ trunk/Source/WebCore/ChangeLog        2013-12-16 16:18:30 UTC (rev 160641)
</span><span class="lines">@@ -1,3 +1,16 @@
</span><ins>+2013-12-16  Mario Sanchez Prada  &lt;mario.prada@samsung.com&gt;
+
+        [ATK] Expose accessibility objects for more WAI-ARIA roles
+        https://bugs.webkit.org/show_bug.cgi?id=125596
+
+        Reviewed by Chris Fleizach.
+
+        Exposed accessibility objects with the proper AtkRoles, some of
+        them to be provided by the next stable release of ATK.
+
+        * accessibility/atk/WebKitAccessibleWrapperAtk.cpp:
+        (atkRole):
+
</ins><span class="cx"> 2013-12-16  Eric Carlson  &lt;eric.carlson@apple.com&gt;
</span><span class="cx"> 
</span><span class="cx">         Fix QuickTime plug-in replacement scripting bugs
</span></span></pre></div>
<a id="trunkSourceWebCoreaccessibilityatkWebKitAccessibleWrapperAtkcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/accessibility/atk/WebKitAccessibleWrapperAtk.cpp (160640 => 160641)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/accessibility/atk/WebKitAccessibleWrapperAtk.cpp        2013-12-16 16:04:50 UTC (rev 160640)
+++ trunk/Source/WebCore/accessibility/atk/WebKitAccessibleWrapperAtk.cpp        2013-12-16 16:18:30 UTC (rev 160641)
</span><span class="lines">@@ -665,6 +665,8 @@
</span><span class="cx"> #endif
</span><span class="cx">     case DocumentRole:
</span><span class="cx">         return ATK_ROLE_DOCUMENT_FRAME;
</span><ins>+    case DocumentNoteRole:
+        return ATK_ROLE_COMMENT;
</ins><span class="cx">     case HeadingRole:
</span><span class="cx">         return ATK_ROLE_HEADING;
</span><span class="cx">     case ListBoxRole:
</span><span class="lines">@@ -696,6 +698,16 @@
</span><span class="cx">     case LandmarkApplicationRole:
</span><span class="cx">         return ATK_ROLE_EMBEDDED;
</span><span class="cx"> #if ATK_CHECK_VERSION(2, 11, 3)
</span><ins>+    case ApplicationLogRole:
+        return ATK_ROLE_LOG;
+    case ApplicationMarqueeRole:
+        return ATK_ROLE_MARQUEE;
+    case ApplicationTimerRole:
+        return ATK_ROLE_TIMER;
+    case DefinitionRole:
+        return ATK_ROLE_DEFINITION;
+    case DocumentMathRole:
+        return ATK_ROLE_MATH;
</ins><span class="cx">     case LandmarkBannerRole:
</span><span class="cx">     case LandmarkComplementaryRole:
</span><span class="cx">     case LandmarkContentInfoRole:
</span></span></pre></div>
<a id="trunkToolsChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Tools/ChangeLog (160640 => 160641)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Tools/ChangeLog        2013-12-16 16:04:50 UTC (rev 160640)
+++ trunk/Tools/ChangeLog        2013-12-16 16:18:30 UTC (rev 160641)
</span><span class="lines">@@ -1,5 +1,17 @@
</span><span class="cx"> 2013-12-16  Mario Sanchez Prada  &lt;mario.prada@samsung.com&gt;
</span><span class="cx"> 
</span><ins>+        [ATK] Expose accessibility objects for more WAI-ARIA roles
+        https://bugs.webkit.org/show_bug.cgi?id=125596
+
+        Reviewed by Chris Fleizach.
+
+        Add mappings to DRT &amp; WKTR for the newly exposed roles.
+
+        * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
+        * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
+
+2013-12-16  Mario Sanchez Prada  &lt;mario.prada@samsung.com&gt;
+
</ins><span class="cx">         [ATK] Expose accessibility objects with ATK_ROLE_CHECK_MENU_ITEM
</span><span class="cx">         https://bugs.webkit.org/show_bug.cgi?id=125594
</span><span class="cx"> 
</span></span></pre></div>
<a id="trunkToolsDumpRenderTreeatkAccessibilityUIElementAtkcpp"></a>
<div class="modfile"><h4>Modified: trunk/Tools/DumpRenderTree/atk/AccessibilityUIElementAtk.cpp (160640 => 160641)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Tools/DumpRenderTree/atk/AccessibilityUIElementAtk.cpp        2013-12-16 16:04:50 UTC (rev 160640)
+++ trunk/Tools/DumpRenderTree/atk/AccessibilityUIElementAtk.cpp        2013-12-16 16:18:30 UTC (rev 160641)
</span><span class="lines">@@ -224,6 +224,8 @@
</span><span class="cx">         return &quot;AXColumnHeader&quot;;
</span><span class="cx">     case ATK_ROLE_COMBO_BOX:
</span><span class="cx">         return &quot;AXComboBox&quot;;
</span><ins>+    case ATK_ROLE_COMMENT:
+        return &quot;AXComment&quot;;
</ins><span class="cx">     case ATK_ROLE_DOCUMENT_FRAME:
</span><span class="cx">         return &quot;AXDocument&quot;;
</span><span class="cx">     case ATK_ROLE_DOCUMENT_WEB:
</span><span class="lines">@@ -327,6 +329,16 @@
</span><span class="cx"> #if ATK_CHECK_VERSION(2, 11, 3)
</span><span class="cx">     case ATK_ROLE_ARTICLE:
</span><span class="cx">         return &quot;AXArticle&quot;;
</span><ins>+    case ATK_ROLE_DEFINITION:
+        return &quot;AXDefinition&quot;;
+    case ATK_ROLE_LOG:
+        return &quot;AXLog&quot;;
+    case ATK_ROLE_MARQUEE:
+        return &quot;AXMarquee&quot;;
+    case ATK_ROLE_MATH:
+        return &quot;AXMath&quot;;
+    case ATK_ROLE_TIMER:
+        return &quot;AXTimer&quot;;
</ins><span class="cx"> #endif
</span><span class="cx">     default:
</span><span class="cx">         // We want to distinguish ATK_ROLE_UNKNOWN from a known AtkRole which
</span></span></pre></div>
<a id="trunkToolsWebKitTestRunnerInjectedBundleatkAccessibilityUIElementAtkcpp"></a>
<div class="modfile"><h4>Modified: trunk/Tools/WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp (160640 => 160641)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Tools/WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp        2013-12-16 16:04:50 UTC (rev 160640)
+++ trunk/Tools/WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp        2013-12-16 16:18:30 UTC (rev 160641)
</span><span class="lines">@@ -313,6 +313,8 @@
</span><span class="cx">         return &quot;AXColumnHeader&quot;;
</span><span class="cx">     case ATK_ROLE_COMBO_BOX:
</span><span class="cx">         return &quot;AXComboBox&quot;;
</span><ins>+    case ATK_ROLE_COMMENT:
+        return &quot;AXComment&quot;;
</ins><span class="cx">     case ATK_ROLE_DOCUMENT_FRAME:
</span><span class="cx">         return &quot;AXDocument&quot;;
</span><span class="cx">     case ATK_ROLE_DOCUMENT_WEB:
</span><span class="lines">@@ -416,6 +418,16 @@
</span><span class="cx"> #if ATK_CHECK_VERSION(2, 11, 3)
</span><span class="cx">     case ATK_ROLE_ARTICLE:
</span><span class="cx">         return &quot;AXArticle&quot;;
</span><ins>+    case ATK_ROLE_DEFINITION:
+        return &quot;AXDefinition&quot;;
+    case ATK_ROLE_LOG:
+        return &quot;AXLog&quot;;
+    case ATK_ROLE_MARQUEE:
+        return &quot;AXMarquee&quot;;
+    case ATK_ROLE_MATH:
+        return &quot;AXMath&quot;;
+    case ATK_ROLE_TIMER:
+        return &quot;AXTimer&quot;;
</ins><span class="cx"> #endif
</span><span class="cx">     default:
</span><span class="cx">         // We want to distinguish ATK_ROLE_UNKNOWN from a known AtkRole which
</span></span></pre>
</div>
</div>

</body>
</html>