<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[160597] trunk/Source/WebCore</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/160597">160597</a></dd>
<dt>Author</dt> <dd>commit-queue@webkit.org</dd>
<dt>Date</dt> <dd>2013-12-14 09:53:05 -0800 (Sat, 14 Dec 2013)</dd>
</dl>
<h3>Log Message</h3>
<pre>Small string improvements to JSInjectedScriptHost::type and other bindings
https://bugs.webkit.org/show_bug.cgi?id=125722
Patch by Joseph Pecoraro <pecoraro@apple.com> on 2013-12-14
Reviewed by Timothy Hatcher.
* bindings/js/JSInjectedScriptHostCustom.cpp:
(WebCore::JSInjectedScriptHost::type):
Use SmallStrings, jsNontrivialString and ASCIILiteral.
* bindings/js/JSJavaScriptCallFrameCustom.cpp:
(WebCore::JSJavaScriptCallFrame::type):
Use jsNontrivialString.
* bridge/c/c_instance.cpp:
(JSC::Bindings::CInstance::stringValue):
Use jsNontrivialString and ASCIILiteral.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkSourceWebCoreChangeLog">trunk/Source/WebCore/ChangeLog</a></li>
<li><a href="#trunkSourceWebCorebindingsjsJSInjectedScriptHostCustomcpp">trunk/Source/WebCore/bindings/js/JSInjectedScriptHostCustom.cpp</a></li>
<li><a href="#trunkSourceWebCorebindingsjsJSJavaScriptCallFrameCustomcpp">trunk/Source/WebCore/bindings/js/JSJavaScriptCallFrameCustom.cpp</a></li>
<li><a href="#trunkSourceWebCorebridgecc_instancecpp">trunk/Source/WebCore/bridge/c/c_instance.cpp</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkSourceWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/ChangeLog (160596 => 160597)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/ChangeLog 2013-12-14 12:40:32 UTC (rev 160596)
+++ trunk/Source/WebCore/ChangeLog 2013-12-14 17:53:05 UTC (rev 160597)
</span><span class="lines">@@ -1,3 +1,22 @@
</span><ins>+2013-12-14 Joseph Pecoraro <pecoraro@apple.com>
+
+ Small string improvements to JSInjectedScriptHost::type and other bindings
+ https://bugs.webkit.org/show_bug.cgi?id=125722
+
+ Reviewed by Timothy Hatcher.
+
+ * bindings/js/JSInjectedScriptHostCustom.cpp:
+ (WebCore::JSInjectedScriptHost::type):
+ Use SmallStrings, jsNontrivialString and ASCIILiteral.
+
+ * bindings/js/JSJavaScriptCallFrameCustom.cpp:
+ (WebCore::JSJavaScriptCallFrame::type):
+ Use jsNontrivialString.
+
+ * bridge/c/c_instance.cpp:
+ (JSC::Bindings::CInstance::stringValue):
+ Use jsNontrivialString and ASCIILiteral.
+
</ins><span class="cx"> 2013-12-14 Andreas Kling <akling@apple.com>
</span><span class="cx">
</span><span class="cx"> Move a couple of inlines from RenderObject to RenderElement.
</span></span></pre></div>
<a id="trunkSourceWebCorebindingsjsJSInjectedScriptHostCustomcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/bindings/js/JSInjectedScriptHostCustom.cpp (160596 => 160597)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/bindings/js/JSInjectedScriptHostCustom.cpp 2013-12-14 12:40:32 UTC (rev 160596)
+++ trunk/Source/WebCore/bindings/js/JSInjectedScriptHostCustom.cpp 2013-12-14 17:53:05 UTC (rev 160597)
</span><span class="lines">@@ -128,29 +128,30 @@
</span><span class="cx">
</span><span class="cx"> JSValue value = exec->uncheckedArgument(0);
</span><span class="cx"> if (value.isString())
</span><del>- return jsString(exec, String("string"));
</del><ins>+ return exec->vm().smallStrings.stringString();
</ins><span class="cx"> if (value.inherits(JSArray::info()))
</span><del>- return jsString(exec, String("array"));
</del><ins>+ return jsNontrivialString(exec, ASCIILiteral("array"));
</ins><span class="cx"> if (value.isBoolean())
</span><del>- return jsString(exec, String("boolean"));
</del><ins>+ return exec->vm().smallStrings.booleanString();
</ins><span class="cx"> if (value.isNumber())
</span><del>- return jsString(exec, String("number"));
</del><ins>+ return exec->vm().smallStrings.numberString();
</ins><span class="cx"> if (value.inherits(DateInstance::info()))
</span><del>- return jsString(exec, String("date"));
</del><ins>+ return jsNontrivialString(exec, ASCIILiteral("date"));
</ins><span class="cx"> if (value.inherits(RegExpObject::info()))
</span><del>- return jsString(exec, String("regexp"));
</del><ins>+ return jsNontrivialString(exec, ASCIILiteral("regexp"));
</ins><span class="cx"> if (value.inherits(JSNode::info()))
</span><del>- return jsString(exec, String("node"));
</del><ins>+ return jsNontrivialString(exec, ASCIILiteral("node"));
</ins><span class="cx"> if (value.inherits(JSNodeList::info()))
</span><del>- return jsString(exec, String("array"));
</del><ins>+ return jsNontrivialString(exec, ASCIILiteral("array"));
</ins><span class="cx"> if (value.inherits(JSHTMLCollection::info()))
</span><del>- return jsString(exec, String("array"));
</del><ins>+ return jsNontrivialString(exec, ASCIILiteral("array"));
</ins><span class="cx"> if (value.inherits(JSInt8Array::info()) || value.inherits(JSInt16Array::info()) || value.inherits(JSInt32Array::info()))
</span><del>- return jsString(exec, String("array"));
</del><ins>+ return jsNontrivialString(exec, ASCIILiteral("array"));
</ins><span class="cx"> if (value.inherits(JSUint8Array::info()) || value.inherits(JSUint16Array::info()) || value.inherits(JSUint32Array::info()))
</span><del>- return jsString(exec, String("array"));
</del><ins>+ return jsNontrivialString(exec, ASCIILiteral("array"));
</ins><span class="cx"> if (value.inherits(JSFloat32Array::info()) || value.inherits(JSFloat64Array::info()))
</span><del>- return jsString(exec, String("array"));
</del><ins>+ return jsNontrivialString(exec, ASCIILiteral("array"));
+
</ins><span class="cx"> return jsUndefined();
</span><span class="cx"> }
</span><span class="cx">
</span></span></pre></div>
<a id="trunkSourceWebCorebindingsjsJSJavaScriptCallFrameCustomcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/bindings/js/JSJavaScriptCallFrameCustom.cpp (160596 => 160597)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/bindings/js/JSJavaScriptCallFrameCustom.cpp 2013-12-14 12:40:32 UTC (rev 160596)
+++ trunk/Source/WebCore/bindings/js/JSJavaScriptCallFrameCustom.cpp 2013-12-14 17:53:05 UTC (rev 160597)
</span><span class="lines">@@ -56,10 +56,10 @@
</span><span class="cx"> JSValue JSJavaScriptCallFrame::type(ExecState* exec) const
</span><span class="cx"> {
</span><span class="cx"> switch (impl().type()) {
</span><del>- case DebuggerCallFrame::FunctionType:
- return jsString(exec, ASCIILiteral("function"));
- case DebuggerCallFrame::ProgramType:
- return jsString(exec, ASCIILiteral("program"));
</del><ins>+ case DebuggerCallFrame::FunctionType:
+ return jsNontrivialString(exec, ASCIILiteral("function"));
+ case DebuggerCallFrame::ProgramType:
+ return jsNontrivialString(exec, ASCIILiteral("program"));
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> ASSERT_NOT_REACHED();
</span></span></pre></div>
<a id="trunkSourceWebCorebridgecc_instancecpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/bridge/c/c_instance.cpp (160596 => 160597)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/bridge/c/c_instance.cpp 2013-12-14 12:40:32 UTC (rev 160596)
+++ trunk/Source/WebCore/bridge/c/c_instance.cpp 2013-12-14 17:53:05 UTC (rev 160597)
</span><span class="lines">@@ -283,7 +283,7 @@
</span><span class="cx"> return value;
</span><span class="cx">
</span><span class="cx"> // Fallback to default implementation.
</span><del>- return jsString(exec, "NPObject");
</del><ins>+ return jsNontrivialString(exec, ASCIILiteral("NPObject"));
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> JSValue CInstance::numberValue(ExecState*) const
</span></span></pre>
</div>
</div>
</body>
</html>