<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[160545] trunk/Source/WebCore</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/160545">160545</a></dd>
<dt>Author</dt> <dd>carlosgc@webkit.org</dd>
<dt>Date</dt> <dd>2013-12-13 07:41:09 -0800 (Fri, 13 Dec 2013)</dd>
</dl>
<h3>Log Message</h3>
<pre>REGRESSION(<a href="http://trac.webkit.org/projects/webkit/changeset/155784">r155784</a>): [GTK] Some methods incorrectly removed in <a href="http://trac.webkit.org/projects/webkit/changeset/155784">r155784</a> and deprecated in <a href="http://trac.webkit.org/projects/webkit/changeset/158662">r158662</a>
https://bugs.webkit.org/show_bug.cgi?id=125692
Reviewed by Martin Robinson.
In <a href="http://trac.webkit.org/projects/webkit/changeset/155784">r155784</a> the build was fixed by skipping Console::profile() and
Console::profileEnd(), but the patch also skipped other methods
containing the profile method name. Those were incorrectly
deprecated in <a href="http://trac.webkit.org/projects/webkit/changeset/158662">r158662</a> thinking that the property had been removed
in the idl.
* bindings/gobject/WebKitDOMDeprecated.cpp: Undeprecate
webkit_dom_html_head_element_get_profile and
webkit_dom_html_head_element_set_profile.
* bindings/gobject/WebKitDOMDeprecated.h: Ditto.
* bindings/gobject/WebKitDOMDeprecated.symbols: Ditto.
* bindings/scripts/CodeGeneratorGObject.pm:
(SkipFunction): Skip webkit_dom_console_profile and
webkit_dom_console_profile_end.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkSourceWebCoreChangeLog">trunk/Source/WebCore/ChangeLog</a></li>
<li><a href="#trunkSourceWebCorebindingsgobjectWebKitDOMDeprecatedcpp">trunk/Source/WebCore/bindings/gobject/WebKitDOMDeprecated.cpp</a></li>
<li><a href="#trunkSourceWebCorebindingsgobjectWebKitDOMDeprecatedh">trunk/Source/WebCore/bindings/gobject/WebKitDOMDeprecated.h</a></li>
<li><a href="#trunkSourceWebCorebindingsgobjectWebKitDOMDeprecatedsymbols">trunk/Source/WebCore/bindings/gobject/WebKitDOMDeprecated.symbols</a></li>
<li><a href="#trunkSourceWebCorebindingsscriptsCodeGeneratorGObjectpm">trunk/Source/WebCore/bindings/scripts/CodeGeneratorGObject.pm</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkSourceWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/ChangeLog (160544 => 160545)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/ChangeLog 2013-12-13 14:13:26 UTC (rev 160544)
+++ trunk/Source/WebCore/ChangeLog 2013-12-13 15:41:09 UTC (rev 160545)
</span><span class="lines">@@ -1,3 +1,25 @@
</span><ins>+2013-12-13 Carlos Garcia Campos <cgarcia@igalia.com>
+
+ REGRESSION(r155784): [GTK] Some methods incorrectly removed in r155784 and deprecated in r158662
+ https://bugs.webkit.org/show_bug.cgi?id=125692
+
+ Reviewed by Martin Robinson.
+
+ In r155784 the build was fixed by skipping Console::profile() and
+ Console::profileEnd(), but the patch also skipped other methods
+ containing the profile method name. Those were incorrectly
+ deprecated in r158662 thinking that the property had been removed
+ in the idl.
+
+ * bindings/gobject/WebKitDOMDeprecated.cpp: Undeprecate
+ webkit_dom_html_head_element_get_profile and
+ webkit_dom_html_head_element_set_profile.
+ * bindings/gobject/WebKitDOMDeprecated.h: Ditto.
+ * bindings/gobject/WebKitDOMDeprecated.symbols: Ditto.
+ * bindings/scripts/CodeGeneratorGObject.pm:
+ (SkipFunction): Skip webkit_dom_console_profile and
+ webkit_dom_console_profile_end.
+
</ins><span class="cx"> 2013-12-13 Rob Buis <rob.buis@samsung.com>
</span><span class="cx">
</span><span class="cx"> Clean up SVGScriptElement
</span></span></pre></div>
<a id="trunkSourceWebCorebindingsgobjectWebKitDOMDeprecatedcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/bindings/gobject/WebKitDOMDeprecated.cpp (160544 => 160545)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/bindings/gobject/WebKitDOMDeprecated.cpp 2013-12-13 14:13:26 UTC (rev 160544)
+++ trunk/Source/WebCore/bindings/gobject/WebKitDOMDeprecated.cpp 2013-12-13 15:41:09 UTC (rev 160545)
</span><span class="lines">@@ -547,19 +547,6 @@
</span><span class="cx"> return 0;
</span><span class="cx"> }
</span><span class="cx">
</span><del>-// WebKitDOMHTMLHeadElement
-
-gchar* webkit_dom_html_head_element_get_profile(WebKitDOMHTMLHeadElement* self)
-{
- g_warning("%s: the HeadElement object has been removed from WebKit, this function does nothing.", __func__);
- return g_strdup("");
-}
-
-void webkit_dom_html_head_element_set_profile(WebKitDOMHTMLHeadElement* self, const gchar* value)
-{
- g_warning("%s: the HeadElement object has been removed from WebKit, this function does nothing.", __func__);
-}
-
</del><span class="cx"> // WebKitDOMProcessingInstruction
</span><span class="cx">
</span><span class="cx"> gchar* webkit_dom_processing_instruction_get_data(WebKitDOMProcessingInstruction* self)
</span></span></pre></div>
<a id="trunkSourceWebCorebindingsgobjectWebKitDOMDeprecatedh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/bindings/gobject/WebKitDOMDeprecated.h (160544 => 160545)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/bindings/gobject/WebKitDOMDeprecated.h 2013-12-13 14:13:26 UTC (rev 160544)
+++ trunk/Source/WebCore/bindings/gobject/WebKitDOMDeprecated.h 2013-12-13 15:41:09 UTC (rev 160545)
</span><span class="lines">@@ -552,31 +552,6 @@
</span><span class="cx"> webkit_dom_html_media_element_get_initial_time(WebKitDOMHTMLMediaElement* self);
</span><span class="cx">
</span><span class="cx"> /**
</span><del>- * webkit_dom_html_head_element_get_profile:
- * @self: A #WebKitDOMHTMLHeadElement
- *
- * This functionality has been removed from WebKit, this function does nothing.
- *
- * Returns: a #gchar
- *
- * Deprecated: 2.4
- */
-WEBKIT_DEPRECATED gchar*
-webkit_dom_html_head_element_get_profile(WebKitDOMHTMLHeadElement* self);
-
-/**
- * webkit_dom_html_head_element_set_profile:
- * @self: A #WebKitDOMHTMLHeadElement
- * @value: A #gchar
- *
- * This functionality has been removed from WebKit, this function does nothing.
- *
- * Deprecated: 2.4
- */
-WEBKIT_DEPRECATED void
-webkit_dom_html_head_element_set_profile(WebKitDOMHTMLHeadElement* self, const gchar* value);
-
-/**
</del><span class="cx"> * webkit_dom_processing_instruction_get_data:
</span><span class="cx"> * @self: A #WebKitDOMProcessingInstruction
</span><span class="cx"> *
</span></span></pre></div>
<a id="trunkSourceWebCorebindingsgobjectWebKitDOMDeprecatedsymbols"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/bindings/gobject/WebKitDOMDeprecated.symbols (160544 => 160545)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/bindings/gobject/WebKitDOMDeprecated.symbols 2013-12-13 14:13:26 UTC (rev 160544)
+++ trunk/Source/WebCore/bindings/gobject/WebKitDOMDeprecated.symbols 2013-12-13 15:41:09 UTC (rev 160545)
</span><span class="lines">@@ -44,7 +44,5 @@
</span><span class="cx"> gulong webkit_dom_property_node_list_get_length(void*)
</span><span class="cx"> gdouble webkit_dom_html_media_element_get_start_time(WebKitDOMHTMLMediaElement*)
</span><span class="cx"> gdouble webkit_dom_html_media_element_get_initial_time(WebKitDOMHTMLMediaElement*)
</span><del>-gchar* webkit_dom_html_head_element_get_profile(WebKitDOMHTMLHeadElement*)
-void webkit_dom_html_head_element_set_profile(WebKitDOMHTMLHeadElement*, const gchar*)
</del><span class="cx"> gchar* webkit_dom_processing_instruction_get_data(WebKitDOMProcessingInstruction*)
</span><span class="cx"> void webkit_dom_processing_instruction_set_data(WebKitDOMProcessingInstruction*, const gchar*, GError**)
</span></span></pre></div>
<a id="trunkSourceWebCorebindingsscriptsCodeGeneratorGObjectpm"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/bindings/scripts/CodeGeneratorGObject.pm (160544 => 160545)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/bindings/scripts/CodeGeneratorGObject.pm 2013-12-13 14:13:26 UTC (rev 160544)
+++ trunk/Source/WebCore/bindings/scripts/CodeGeneratorGObject.pm 2013-12-13 15:41:09 UTC (rev 160545)
</span><span class="lines">@@ -304,6 +304,11 @@
</span><span class="cx"> return 1;
</span><span class="cx"> }
</span><span class="cx">
</span><ins>+ # Skip Console::profile() and Console::profileEnd() as they're not correctly generated for the moment.
+ if ($functionName eq "webkit_dom_console_profile" || $functionName eq "webkit_dom_console_profile_end") {
+ return 1;
+ }
+
</ins><span class="cx"> if ($function->signature->name eq "set" and $parentNode->extendedAttributes->{"TypedArray"}) {
</span><span class="cx"> return 1;
</span><span class="cx"> }
</span><span class="lines">@@ -324,7 +329,7 @@
</span><span class="cx"> return 1;
</span><span class="cx"> }
</span><span class="cx">
</span><del>- if ($function->signature->name eq "timeEnd" || $function->signature->name eq "profile" || $function->signature->name eq "profileEnd") {
</del><ins>+ if ($function->signature->name eq "timeEnd") {
</ins><span class="cx"> return 1;
</span><span class="cx"> }
</span><span class="cx">
</span></span></pre>
</div>
</div>
</body>
</html>