<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[160516] branches/jsCStack/Source/JavaScriptCore</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/160516">160516</a></dd>
<dt>Author</dt> <dd>msaboff@apple.com</dd>
<dt>Date</dt> <dd>2013-12-12 16:30:30 -0800 (Thu, 12 Dec 2013)</dd>
</dl>
<h3>Log Message</h3>
<pre>CStack Branch: Put all stack saving and restoring callToJavaScript in {push/pop}CalleeSaves
https://bugs.webkit.org/show_bug.cgi?id=125666
Not yet reviewed.
Eliminated "extraStack" arguments and related stack pointer manipulation for 64 bit platforms.
Both ARM64 and X86_64 already have aligned stacks. Eliminated some related commented out
code.
* llint/LowLevelInterpreter64.asm:</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#branchesjsCStackSourceJavaScriptCoreChangeLog">branches/jsCStack/Source/JavaScriptCore/ChangeLog</a></li>
<li><a href="#branchesjsCStackSourceJavaScriptCorellintLowLevelInterpreter64asm">branches/jsCStack/Source/JavaScriptCore/llint/LowLevelInterpreter64.asm</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="branchesjsCStackSourceJavaScriptCoreChangeLog"></a>
<div class="modfile"><h4>Modified: branches/jsCStack/Source/JavaScriptCore/ChangeLog (160515 => 160516)</h4>
<pre class="diff"><span>
<span class="info">--- branches/jsCStack/Source/JavaScriptCore/ChangeLog 2013-12-13 00:18:47 UTC (rev 160515)
+++ branches/jsCStack/Source/JavaScriptCore/ChangeLog 2013-12-13 00:30:30 UTC (rev 160516)
</span><span class="lines">@@ -1,5 +1,18 @@
</span><span class="cx"> 2013-12-12 Michael Saboff <msaboff@apple.com>
</span><span class="cx">
</span><ins>+ CStack Branch: Put all stack saving and restoring callToJavaScript in {push/pop}CalleeSaves
+ https://bugs.webkit.org/show_bug.cgi?id=125666
+
+ Not yet reviewed.
+
+ Eliminated "extraStack" arguments and related stack pointer manipulation for 64 bit platforms.
+ Both ARM64 and X86_64 already have aligned stacks. Eliminated some related commented out
+ code.
+
+ * llint/LowLevelInterpreter64.asm:
+
+2013-12-12 Michael Saboff <msaboff@apple.com>
+
</ins><span class="cx"> CStack Branch: Eliminate unnecessary add/sub 16 to stack pointer
</span><span class="cx"> https://bugs.webkit.org/show_bug.cgi?id=125653
</span><span class="cx">
</span></span></pre></div>
<a id="branchesjsCStackSourceJavaScriptCorellintLowLevelInterpreter64asm"></a>
<div class="modfile"><h4>Modified: branches/jsCStack/Source/JavaScriptCore/llint/LowLevelInterpreter64.asm (160515 => 160516)</h4>
<pre class="diff"><span>
<span class="info">--- branches/jsCStack/Source/JavaScriptCore/llint/LowLevelInterpreter64.asm 2013-12-13 00:18:47 UTC (rev 160515)
+++ branches/jsCStack/Source/JavaScriptCore/llint/LowLevelInterpreter64.asm 2013-12-13 00:30:30 UTC (rev 160516)
</span><span class="lines">@@ -99,18 +99,16 @@
</span><span class="cx"> end
</span><span class="cx">
</span><span class="cx">
</span><del>-macro functionPrologue(extraStackSpace)
</del><ins>+macro functionPrologue()
</ins><span class="cx"> if X86_64
</span><span class="cx"> push cfr
</span><span class="cx"> move sp, cfr
</span><span class="cx"> elsif ARM64
</span><span class="cx"> pushLRAndFP
</span><span class="cx"> end
</span><del>- subp extraStackSpace, sp
</del><span class="cx"> end
</span><span class="cx">
</span><del>-macro functionEpilogue(extraStackSpace)
- addp extraStackSpace, sp
</del><ins>+macro functionEpilogue()
</ins><span class="cx"> if X86_64
</span><span class="cx"> pop cfr
</span><span class="cx"> elsif ARM64
</span><span class="lines">@@ -118,29 +116,20 @@
</span><span class="cx"> end
</span><span class="cx"> end
</span><span class="cx">
</span><del>-macro callToJavaScriptPrologue(extraStackSpace)
</del><ins>+macro callToJavaScriptPrologue()
</ins><span class="cx"> if X86_64
</span><del>-# push cfr
-# move sp, cfr
</del><span class="cx"> elsif ARM64
</span><span class="cx"> pushLRAndFP
</span><span class="cx"> end
</span><span class="cx"> pushCalleeSaves
</span><del>- if X86_64
- subp extraStackSpace, sp
- end
</del><span class="cx"> end
</span><span class="cx">
</span><del>-macro callToJavaScriptEpilogue(extraStackSpace)
</del><ins>+macro callToJavaScriptEpilogue()
</ins><span class="cx"> addp (CallFrameHeaderSlots-1)*8, cfr, sp
</span><span class="cx"> loadp CallerFrame[cfr], cfr
</span><span class="cx">
</span><del>- if X86_64
- addp extraStackSpace, sp
- end
</del><span class="cx"> popCalleeSaves
</span><span class="cx"> if X86_64
</span><del>-# pop cfr
</del><span class="cx"> elsif ARM64
</span><span class="cx"> popLRAndFP
</span><span class="cx"> end
</span><span class="lines">@@ -166,7 +155,6 @@
</span><span class="cx"> const protoCallFrame = t1
</span><span class="cx"> const topOfStack = t2
</span><span class="cx">
</span><del>- const extraStackSpace = 16
</del><span class="cx"> const previousCFR = t0
</span><span class="cx"> const previousPC = t6
</span><span class="cx"> const temp1 = t0
</span><span class="lines">@@ -178,7 +166,6 @@
</span><span class="cx"> const protoCallFrame = a2
</span><span class="cx"> const topOfStack = a3
</span><span class="cx">
</span><del>- const extraStackSpace = 0
</del><span class="cx"> const previousCFR = t4
</span><span class="cx"> const previousPC = lr
</span><span class="cx"> const temp1 = t3
</span><span class="lines">@@ -190,7 +177,7 @@
</span><span class="cx"> loadp [sp], previousPC
</span><span class="cx"> end
</span><span class="cx"> move cfr, previousCFR
</span><del>- callToJavaScriptPrologue(extraStackSpace)
</del><ins>+ callToJavaScriptPrologue()
</ins><span class="cx">
</span><span class="cx"> checkStackPointerAlignment(temp2, 0xbad0dc01)
</span><span class="cx">
</span><span class="lines">@@ -262,7 +249,7 @@
</span><span class="cx">
</span><span class="cx"> checkStackPointerAlignment(temp3, 0xbad0dc04)
</span><span class="cx">
</span><del>- callToJavaScriptEpilogue(extraStackSpace)
</del><ins>+ callToJavaScriptEpilogue()
</ins><span class="cx"> ret
</span><span class="cx"> end
</span><span class="cx">
</span><span class="lines">@@ -301,7 +288,7 @@
</span><span class="cx"> loadp ScopeChain[cfr], t6
</span><span class="cx"> storep t6, [t3]
</span><span class="cx">
</span><del>- callToJavaScriptEpilogue(16)
</del><ins>+ callToJavaScriptEpilogue()
</ins><span class="cx"> ret
</span><span class="cx">
</span><span class="cx">
</span><span class="lines">@@ -1905,7 +1892,7 @@
</span><span class="cx">
</span><span class="cx"> macro nativeCallTrampoline(executableOffsetToFunction)
</span><span class="cx">
</span><del>- functionPrologue(0)
</del><ins>+ functionPrologue()
</ins><span class="cx"> storep 0, CodeBlock[cfr]
</span><span class="cx"> if X86_64
</span><span class="cx"> loadp ScopeChain[cfr], t0
</span><span class="lines">@@ -1970,7 +1957,7 @@
</span><span class="cx"> end
</span><span class="cx">
</span><span class="cx"> btqnz VM::m_exception[t3], .exception
</span><del>- functionEpilogue(0)
</del><ins>+ functionEpilogue()
</ins><span class="cx"> ret
</span><span class="cx"> .exception:
</span><span class="cx"> if X86_64
</span></span></pre>
</div>
</div>
</body>
</html>