<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[160522] branches/jsCStack/Source/JavaScriptCore</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/160522">160522</a></dd>
<dt>Author</dt> <dd>msaboff@apple.com</dd>
<dt>Date</dt> <dd>2013-12-12 18:06:28 -0800 (Thu, 12 Dec 2013)</dd>
</dl>
<h3>Log Message</h3>
<pre>CStack Branch: Add equivalent values from MaxFrameExtentForSlowPathCall.h to lint files
https://bugs.webkit.org/show_bug.cgi?id=125669
Reviewed by Mark Lam.
Added platform specific value of maxFrameExtentForSlowPathCall to llint code.
Also added ASSERTs to check that we are using the save value in both places.
Per review comments, I also updated the CPU(ARM) || ... in MaxFrameExtentForSlowPathCall.h
to be just CPU(ARM) since it covers all ARM 32 bit variants.
* assembler/MaxFrameExtentForSlowPathCall.h:
* llint/LLIntData.cpp:
(JSC::LLInt::Data::performAssertions):
* llint/LowLevelInterpreter.asm:</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#branchesjsCStackSourceJavaScriptCoreChangeLog">branches/jsCStack/Source/JavaScriptCore/ChangeLog</a></li>
<li><a href="#branchesjsCStackSourceJavaScriptCoreassemblerMaxFrameExtentForSlowPathCallh">branches/jsCStack/Source/JavaScriptCore/assembler/MaxFrameExtentForSlowPathCall.h</a></li>
<li><a href="#branchesjsCStackSourceJavaScriptCorellintLLIntDatacpp">branches/jsCStack/Source/JavaScriptCore/llint/LLIntData.cpp</a></li>
<li><a href="#branchesjsCStackSourceJavaScriptCorellintLowLevelInterpreterasm">branches/jsCStack/Source/JavaScriptCore/llint/LowLevelInterpreter.asm</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="branchesjsCStackSourceJavaScriptCoreChangeLog"></a>
<div class="modfile"><h4>Modified: branches/jsCStack/Source/JavaScriptCore/ChangeLog (160521 => 160522)</h4>
<pre class="diff"><span>
<span class="info">--- branches/jsCStack/Source/JavaScriptCore/ChangeLog 2013-12-13 01:45:45 UTC (rev 160521)
+++ branches/jsCStack/Source/JavaScriptCore/ChangeLog 2013-12-13 02:06:28 UTC (rev 160522)
</span><span class="lines">@@ -1,5 +1,23 @@
</span><span class="cx"> 2013-12-12 Michael Saboff <msaboff@apple.com>
</span><span class="cx">
</span><ins>+ CStack Branch: Add equivalent values from MaxFrameExtentForSlowPathCall.h to lint files
+ https://bugs.webkit.org/show_bug.cgi?id=125669
+
+ Reviewed by Mark Lam.
+
+ Added platform specific value of maxFrameExtentForSlowPathCall to llint code.
+ Also added ASSERTs to check that we are using the save value in both places.
+
+ Per review comments, I also updated the CPU(ARM) || ... in MaxFrameExtentForSlowPathCall.h
+ to be just CPU(ARM) since it covers all ARM 32 bit variants.
+
+ * assembler/MaxFrameExtentForSlowPathCall.h:
+ * llint/LLIntData.cpp:
+ (JSC::LLInt::Data::performAssertions):
+ * llint/LowLevelInterpreter.asm:
+
+2013-12-12 Michael Saboff <msaboff@apple.com>
+
</ins><span class="cx"> CStack Branch: Add the new assembler/MaxFrameExtentForSlowPathCall.h to build files
</span><span class="cx"> https://bugs.webkit.org/show_bug.cgi?id=125668
</span><span class="cx">
</span></span></pre></div>
<a id="branchesjsCStackSourceJavaScriptCoreassemblerMaxFrameExtentForSlowPathCallh"></a>
<div class="modfile"><h4>Modified: branches/jsCStack/Source/JavaScriptCore/assembler/MaxFrameExtentForSlowPathCall.h (160521 => 160522)</h4>
<pre class="diff"><span>
<span class="info">--- branches/jsCStack/Source/JavaScriptCore/assembler/MaxFrameExtentForSlowPathCall.h 2013-12-13 01:45:45 UTC (rev 160521)
+++ branches/jsCStack/Source/JavaScriptCore/assembler/MaxFrameExtentForSlowPathCall.h 2013-12-13 02:06:28 UTC (rev 160522)
</span><span class="lines">@@ -51,7 +51,7 @@
</span><span class="cx"> // All args in registers.
</span><span class="cx"> static const size_t maxFrameExtentForSlowPathCall = 0;
</span><span class="cx">
</span><del>-#elif CPU(ARM) || CPU(ARM_TRADITIONAL) || CPU(ARM_THUMB2)
</del><ins>+#elif CPU(ARM)
</ins><span class="cx"> // First four args in registers, remaining 4 args on stack.
</span><span class="cx"> static const size_t maxFrameExtentForSlowPathCall = 16;
</span><span class="cx">
</span></span></pre></div>
<a id="branchesjsCStackSourceJavaScriptCorellintLLIntDatacpp"></a>
<div class="modfile"><h4>Modified: branches/jsCStack/Source/JavaScriptCore/llint/LLIntData.cpp (160521 => 160522)</h4>
<pre class="diff"><span>
<span class="info">--- branches/jsCStack/Source/JavaScriptCore/llint/LLIntData.cpp 2013-12-13 01:45:45 UTC (rev 160521)
+++ branches/jsCStack/Source/JavaScriptCore/llint/LLIntData.cpp 2013-12-13 02:06:28 UTC (rev 160522)
</span><span class="lines">@@ -33,6 +33,7 @@
</span><span class="cx"> #include "Instruction.h"
</span><span class="cx"> #include "JSScope.h"
</span><span class="cx"> #include "LLIntCLoop.h"
</span><ins>+#include "MaxFrameExtentForSlowPathCall.h"
</ins><span class="cx"> #include "Opcode.h"
</span><span class="cx"> #include "PropertyOffset.h"
</span><span class="cx">
</span><span class="lines">@@ -124,6 +125,13 @@
</span><span class="cx"> ASSERT(ValueUndefined == (TagBitTypeOther | TagBitUndefined));
</span><span class="cx"> ASSERT(ValueNull == TagBitTypeOther);
</span><span class="cx"> #endif
</span><ins>+#if CPU(X86_64) || CPU(ARM64) || ENABLE(LLINT_C_LOOP)
+ ASSERT(maxFrameExtentForSlowPathCall == 0);
+#elif CPU(ARM) || CPU(SH4)
+ ASSERT(maxFrameExtentForSlowPathCall == 16);
+#elif CPU(X86) || CPU(MIPS)
+ ASSERT(maxFrameExtentForSlowPathCall == 32);
+#endif
</ins><span class="cx"> ASSERT(StringType == 5);
</span><span class="cx"> ASSERT(ObjectType == 17);
</span><span class="cx"> ASSERT(FinalObjectType == 18);
</span></span></pre></div>
<a id="branchesjsCStackSourceJavaScriptCorellintLowLevelInterpreterasm"></a>
<div class="modfile"><h4>Modified: branches/jsCStack/Source/JavaScriptCore/llint/LowLevelInterpreter.asm (160521 => 160522)</h4>
<pre class="diff"><span>
<span class="info">--- branches/jsCStack/Source/JavaScriptCore/llint/LowLevelInterpreter.asm 2013-12-13 01:45:45 UTC (rev 160521)
+++ branches/jsCStack/Source/JavaScriptCore/llint/LowLevelInterpreter.asm 2013-12-13 02:06:28 UTC (rev 160522)
</span><span class="lines">@@ -73,6 +73,14 @@
</span><span class="cx"> const LowestTag = DeletedValueTag
</span><span class="cx"> end
</span><span class="cx">
</span><ins>+if X86_64 or ARM64 or C_LOOP
+const maxFrameExtentForSlowPathCall = 0
+elsif ARM or ARMv7_TRADITIONAL or ARMv7 or SH4
+const maxFrameExtentForSlowPathCall = 16
+elsif X86 or MIPS
+const maxFrameExtentForSlowPathCall = 32
+end
+
</ins><span class="cx"> # Watchpoint states
</span><span class="cx"> const ClearWatchpoint = 0
</span><span class="cx"> const IsWatched = 1
</span></span></pre>
</div>
</div>
</body>
</html>