<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[160380] trunk</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/160380">160380</a></dd>
<dt>Author</dt> <dd>mario.prada@samsung.com</dd>
<dt>Date</dt> <dd>2013-12-10 12:12:56 -0800 (Tue, 10 Dec 2013)</dd>
</dl>
<h3>Log Message</h3>
<pre>[ATK] Expose splitter elements with ATK_ROLE_SEPARATOR
https://bugs.webkit.org/show_bug.cgi?id=125522
Reviewed by Chris Fleizach.
Source/WebCore:
Expose objects with SplitterRole role as ATK_ROLE_SEPARATOR.
* accessibility/atk/WebKitAccessibleWrapperAtk.cpp:
(atkRole):
Tools:
Update strings representing ATK_ROLE_SEPARATOR for layout tests.
* DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
* WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
LayoutTests:
Update expected results in layout test for EFL and GTK.
* platform/efl-wk1/accessibility/lists-expected.txt:
* platform/efl-wk2/accessibility/lists-expected.txt:
* platform/gtk/accessibility/lists-expected.txt:</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkLayoutTestsChangeLog">trunk/LayoutTests/ChangeLog</a></li>
<li><a href="#trunkLayoutTestsplatformeflwk1accessibilitylistsexpectedtxt">trunk/LayoutTests/platform/efl-wk1/accessibility/lists-expected.txt</a></li>
<li><a href="#trunkLayoutTestsplatformeflwk2accessibilitylistsexpectedtxt">trunk/LayoutTests/platform/efl-wk2/accessibility/lists-expected.txt</a></li>
<li><a href="#trunkLayoutTestsplatformgtkaccessibilitylistsexpectedtxt">trunk/LayoutTests/platform/gtk/accessibility/lists-expected.txt</a></li>
<li><a href="#trunkSourceWebCoreChangeLog">trunk/Source/WebCore/ChangeLog</a></li>
<li><a href="#trunkSourceWebCoreaccessibilityatkWebKitAccessibleWrapperAtkcpp">trunk/Source/WebCore/accessibility/atk/WebKitAccessibleWrapperAtk.cpp</a></li>
<li><a href="#trunkToolsChangeLog">trunk/Tools/ChangeLog</a></li>
<li><a href="#trunkToolsDumpRenderTreeatkAccessibilityUIElementAtkcpp">trunk/Tools/DumpRenderTree/atk/AccessibilityUIElementAtk.cpp</a></li>
<li><a href="#trunkToolsWebKitTestRunnerInjectedBundleatkAccessibilityUIElementAtkcpp">trunk/Tools/WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkLayoutTestsChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/ChangeLog (160379 => 160380)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/ChangeLog 2013-12-10 20:11:18 UTC (rev 160379)
+++ trunk/LayoutTests/ChangeLog 2013-12-10 20:12:56 UTC (rev 160380)
</span><span class="lines">@@ -1,5 +1,18 @@
</span><span class="cx"> 2013-12-10 Mario Sanchez Prada <mario.prada@samsung.com>
</span><span class="cx">
</span><ins>+ [ATK] Expose splitter elements with ATK_ROLE_SEPARATOR
+ https://bugs.webkit.org/show_bug.cgi?id=125522
+
+ Reviewed by Chris Fleizach.
+
+ Update expected results in layout test for EFL and GTK.
+
+ * platform/efl-wk1/accessibility/lists-expected.txt:
+ * platform/efl-wk2/accessibility/lists-expected.txt:
+ * platform/gtk/accessibility/lists-expected.txt:
+
+2013-12-10 Mario Sanchez Prada <mario.prada@samsung.com>
+
</ins><span class="cx"> [ATK] Elements with role 'alertdialog' should be ATK_ROLE_ALERT
</span><span class="cx"> https://bugs.webkit.org/show_bug.cgi?id=125521
</span><span class="cx">
</span></span></pre></div>
<a id="trunkLayoutTestsplatformeflwk1accessibilitylistsexpectedtxt"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/platform/efl-wk1/accessibility/lists-expected.txt (160379 => 160380)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/platform/efl-wk1/accessibility/lists-expected.txt 2013-12-10 20:11:18 UTC (rev 160379)
+++ trunk/LayoutTests/platform/efl-wk1/accessibility/lists-expected.txt 2013-12-10 20:12:56 UTC (rev 160380)
</span><span class="lines">@@ -84,7 +84,7 @@
</span><span class="cx"> AXChecked: 0
</span><span class="cx"> AXPlatformAttributes: toolkit:WebKitEfl
</span><span class="cx"> ------------
</span><del>-AXRole: AXHorizontalRule
</del><ins>+AXRole: AXSeparator
</ins><span class="cx"> AXParent: AXWebArea
</span><span class="cx"> AXChildren: 0
</span><span class="cx"> AXPosition: { 8.000000, 288.000000 }
</span></span></pre></div>
<a id="trunkLayoutTestsplatformeflwk2accessibilitylistsexpectedtxt"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/platform/efl-wk2/accessibility/lists-expected.txt (160379 => 160380)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/platform/efl-wk2/accessibility/lists-expected.txt 2013-12-10 20:11:18 UTC (rev 160379)
+++ trunk/LayoutTests/platform/efl-wk2/accessibility/lists-expected.txt 2013-12-10 20:12:56 UTC (rev 160380)
</span><span class="lines">@@ -84,7 +84,7 @@
</span><span class="cx"> AXChecked: 0
</span><span class="cx"> AXPlatformAttributes: toolkit:WebKitEfl
</span><span class="cx"> ------------
</span><del>-AXRole: AXHorizontalRule
</del><ins>+AXRole: AXSeparator
</ins><span class="cx"> AXParent: AXWebArea
</span><span class="cx"> AXChildren: 0
</span><span class="cx"> AXPosition: { 0.000000, 0.000000 }
</span></span></pre></div>
<a id="trunkLayoutTestsplatformgtkaccessibilitylistsexpectedtxt"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/platform/gtk/accessibility/lists-expected.txt (160379 => 160380)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/platform/gtk/accessibility/lists-expected.txt 2013-12-10 20:11:18 UTC (rev 160379)
+++ trunk/LayoutTests/platform/gtk/accessibility/lists-expected.txt 2013-12-10 20:12:56 UTC (rev 160380)
</span><span class="lines">@@ -84,7 +84,7 @@
</span><span class="cx"> AXChecked: 0
</span><span class="cx"> AXPlatformAttributes: toolkit:WebKitGtk
</span><span class="cx"> ------------
</span><del>-AXRole: AXHorizontalRule
</del><ins>+AXRole: AXSeparator
</ins><span class="cx"> AXParent: AXWebArea
</span><span class="cx"> AXChildren: 0
</span><span class="cx"> AXPosition: { 8.000000, 276.000000 }
</span></span></pre></div>
<a id="trunkSourceWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/ChangeLog (160379 => 160380)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/ChangeLog 2013-12-10 20:11:18 UTC (rev 160379)
+++ trunk/Source/WebCore/ChangeLog 2013-12-10 20:12:56 UTC (rev 160380)
</span><span class="lines">@@ -1,5 +1,17 @@
</span><span class="cx"> 2013-12-10 Mario Sanchez Prada <mario.prada@samsung.com>
</span><span class="cx">
</span><ins>+ [ATK] Expose splitter elements with ATK_ROLE_SEPARATOR
+ https://bugs.webkit.org/show_bug.cgi?id=125522
+
+ Reviewed by Chris Fleizach.
+
+ Expose objects with SplitterRole role as ATK_ROLE_SEPARATOR.
+
+ * accessibility/atk/WebKitAccessibleWrapperAtk.cpp:
+ (atkRole):
+
+2013-12-10 Mario Sanchez Prada <mario.prada@samsung.com>
+
</ins><span class="cx"> [ATK] Elements with role 'alertdialog' should be ATK_ROLE_ALERT
</span><span class="cx"> https://bugs.webkit.org/show_bug.cgi?id=125521
</span><span class="cx">
</span></span></pre></div>
<a id="trunkSourceWebCoreaccessibilityatkWebKitAccessibleWrapperAtkcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/accessibility/atk/WebKitAccessibleWrapperAtk.cpp (160379 => 160380)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/accessibility/atk/WebKitAccessibleWrapperAtk.cpp 2013-12-10 20:11:18 UTC (rev 160379)
+++ trunk/Source/WebCore/accessibility/atk/WebKitAccessibleWrapperAtk.cpp 2013-12-10 20:12:56 UTC (rev 160380)
</span><span class="lines">@@ -600,7 +600,7 @@
</span><span class="cx"> case SplitGroupRole:
</span><span class="cx"> return ATK_ROLE_SPLIT_PANE;
</span><span class="cx"> case SplitterRole:
</span><del>- return ATK_ROLE_UNKNOWN;
</del><ins>+ return ATK_ROLE_SEPARATOR;
</ins><span class="cx"> case ColorWellRole:
</span><span class="cx"> return ATK_ROLE_COLOR_CHOOSER;
</span><span class="cx"> case ListRole:
</span></span></pre></div>
<a id="trunkToolsChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Tools/ChangeLog (160379 => 160380)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Tools/ChangeLog 2013-12-10 20:11:18 UTC (rev 160379)
+++ trunk/Tools/ChangeLog 2013-12-10 20:12:56 UTC (rev 160380)
</span><span class="lines">@@ -1,3 +1,15 @@
</span><ins>+2013-12-10 Mario Sanchez Prada <mario.prada@samsung.com>
+
+ [ATK] Expose splitter elements with ATK_ROLE_SEPARATOR
+ https://bugs.webkit.org/show_bug.cgi?id=125522
+
+ Reviewed by Chris Fleizach.
+
+ Update strings representing ATK_ROLE_SEPARATOR for layout tests.
+
+ * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
+ * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
+
</ins><span class="cx"> 2013-12-10 Laszlo Vidacs <lac@inf.u-szeged.hu>
</span><span class="cx">
</span><span class="cx"> Add --makeargs option to build-jsc
</span></span></pre></div>
<a id="trunkToolsDumpRenderTreeatkAccessibilityUIElementAtkcpp"></a>
<div class="modfile"><h4>Modified: trunk/Tools/DumpRenderTree/atk/AccessibilityUIElementAtk.cpp (160379 => 160380)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Tools/DumpRenderTree/atk/AccessibilityUIElementAtk.cpp 2013-12-10 20:11:18 UTC (rev 160379)
+++ trunk/Tools/DumpRenderTree/atk/AccessibilityUIElementAtk.cpp 2013-12-10 20:12:56 UTC (rev 160380)
</span><span class="lines">@@ -260,7 +260,7 @@
</span><span class="cx"> case ATK_ROLE_SECTION:
</span><span class="cx"> return "AXSection";
</span><span class="cx"> case ATK_ROLE_SEPARATOR:
</span><del>- return "AXHorizontalRule";
</del><ins>+ return "AXSeparator";
</ins><span class="cx"> case ATK_ROLE_SLIDER:
</span><span class="cx"> return "AXSlider";
</span><span class="cx"> case ATK_ROLE_SPIN_BUTTON:
</span></span></pre></div>
<a id="trunkToolsWebKitTestRunnerInjectedBundleatkAccessibilityUIElementAtkcpp"></a>
<div class="modfile"><h4>Modified: trunk/Tools/WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp (160379 => 160380)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Tools/WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp 2013-12-10 20:11:18 UTC (rev 160379)
+++ trunk/Tools/WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp 2013-12-10 20:12:56 UTC (rev 160380)
</span><span class="lines">@@ -349,7 +349,7 @@
</span><span class="cx"> case ATK_ROLE_SECTION:
</span><span class="cx"> return "AXSection";
</span><span class="cx"> case ATK_ROLE_SEPARATOR:
</span><del>- return "AXHorizontalRule";
</del><ins>+ return "AXSeparator";
</ins><span class="cx"> case ATK_ROLE_SLIDER:
</span><span class="cx"> return "AXSlider";
</span><span class="cx"> case ATK_ROLE_SPIN_BUTTON:
</span></span></pre>
</div>
</div>
</body>
</html>