<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[160370] trunk/Source/WebCore</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/160370">160370</a></dd>
<dt>Author</dt> <dd>akling@apple.com</dd>
<dt>Date</dt> <dd>2013-12-10 08:50:49 -0800 (Tue, 10 Dec 2013)</dd>
</dl>
<h3>Log Message</h3>
<pre>Jettison all StyleResolver data on memory pressure.
<https://webkit.org/b/125498>
The StyleResolver can be rebuilt relatively quickly; we already
have an optimization that discards it some time after last use.
If we find ourseles under serious memory pressure, don't wait for
the timer to kick in, throw everything overboard right away.
~5MB progression post-pressure on Membuster3.
Reviewed by Anders Carlsson.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkSourceWebCoreChangeLog">trunk/Source/WebCore/ChangeLog</a></li>
<li><a href="#trunkSourceWebCorepagePagecpp">trunk/Source/WebCore/page/Page.cpp</a></li>
<li><a href="#trunkSourceWebCorepagePageh">trunk/Source/WebCore/page/Page.h</a></li>
<li><a href="#trunkSourceWebCoreplatformmacMemoryPressureHandlerMacmm">trunk/Source/WebCore/platform/mac/MemoryPressureHandlerMac.mm</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkSourceWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/ChangeLog (160369 => 160370)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/ChangeLog 2013-12-10 16:47:49 UTC (rev 160369)
+++ trunk/Source/WebCore/ChangeLog 2013-12-10 16:50:49 UTC (rev 160370)
</span><span class="lines">@@ -1,3 +1,18 @@
</span><ins>+2013-12-10 Andreas Kling <akling@apple.com>
+
+ Jettison all StyleResolver data on memory pressure.
+ <https://webkit.org/b/125498>
+
+ The StyleResolver can be rebuilt relatively quickly; we already
+ have an optimization that discards it some time after last use.
+
+ If we find ourseles under serious memory pressure, don't wait for
+ the timer to kick in, throw everything overboard right away.
+
+ ~5MB progression post-pressure on Membuster3.
+
+ Reviewed by Anders Carlsson.
+
</ins><span class="cx"> 2013-12-10 Martin Robinson <mrobinson@igalia.com>
</span><span class="cx">
</span><span class="cx"> [GTK] [CMake] Add support for building the DOM bindings
</span></span></pre></div>
<a id="trunkSourceWebCorepagePagecpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/page/Page.cpp (160369 => 160370)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/page/Page.cpp 2013-12-10 16:47:49 UTC (rev 160369)
+++ trunk/Source/WebCore/page/Page.cpp 2013-12-10 16:50:49 UTC (rev 160370)
</span><span class="lines">@@ -487,6 +487,20 @@
</span><span class="cx"> }
</span><span class="cx"> }
</span><span class="cx">
</span><ins>+void Page::jettisonStyleResolversInAllDocuments()
+{
+ if (!allPages)
+ return;
+
+ for (auto it = allPages->begin(), end = allPages->end(); it != end; ++it) {
+ Page& page = **it;
+ for (Frame* frame = &page.mainFrame(); frame; frame = frame->tree().traverseNext()) {
+ if (Document* document = frame->document())
+ document->clearStyleResolver();
+ }
+ }
+}
+
</ins><span class="cx"> void Page::refreshPlugins(bool reload)
</span><span class="cx"> {
</span><span class="cx"> if (!allPages)
</span></span></pre></div>
<a id="trunkSourceWebCorepagePageh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/page/Page.h (160369 => 160370)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/page/Page.h 2013-12-10 16:47:49 UTC (rev 160369)
+++ trunk/Source/WebCore/page/Page.h 2013-12-10 16:50:49 UTC (rev 160370)
</span><span class="lines">@@ -111,6 +111,7 @@
</span><span class="cx">
</span><span class="cx"> public:
</span><span class="cx"> static void updateStyleForAllPagesAfterGlobalChangeInEnvironment();
</span><ins>+ static void jettisonStyleResolversInAllDocuments();
</ins><span class="cx">
</span><span class="cx"> // It is up to the platform to ensure that non-null clients are provided where required.
</span><span class="cx"> struct PageClients {
</span></span></pre></div>
<a id="trunkSourceWebCoreplatformmacMemoryPressureHandlerMacmm"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/platform/mac/MemoryPressureHandlerMac.mm (160369 => 160370)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/platform/mac/MemoryPressureHandlerMac.mm 2013-12-10 16:47:49 UTC (rev 160369)
+++ trunk/Source/WebCore/platform/mac/MemoryPressureHandlerMac.mm 2013-12-10 16:50:49 UTC (rev 160370)
</span><span class="lines">@@ -30,6 +30,7 @@
</span><span class="cx"> #import <WebCore/GCController.h>
</span><span class="cx"> #import <WebCore/FontCache.h>
</span><span class="cx"> #import <WebCore/MemoryCache.h>
</span><ins>+#import <WebCore/Page.h>
</ins><span class="cx"> #import <WebCore/PageCache.h>
</span><span class="cx"> #import <WebCore/LayerPool.h>
</span><span class="cx"> #import <WebCore/ScrollingThread.h>
</span><span class="lines">@@ -163,6 +164,8 @@
</span><span class="cx">
</span><span class="cx"> clearWidthCaches();
</span><span class="cx">
</span><ins>+ Page::jettisonStyleResolversInAllDocuments();
+
</ins><span class="cx"> gcController().discardAllCompiledCode();
</span><span class="cx">
</span><span class="cx"> // FastMalloc has lock-free thread specific caches that can only be cleared from the thread itself.
</span></span></pre>
</div>
</div>
</body>
</html>