<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"

"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">

<html xmlns="http://www.w3.org/1999/xhtml">

<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />

<title>[160323] trunk</title>

</head>

<body>

<style type="text/css"><!--

#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }

#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }

#msg dt:after { content:':';}

#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt;  }

#msg dl a { font-weight: bold}

#msg dl a:link    { color:#fc3; }

#msg dl a:active  { color:#ff0; }

#msg dl a:visited { color:#cc6; }

h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }

#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }

#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }

#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }

#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }

#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }

#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }

#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }

#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }

#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }

#logmsg pre { background: #eee; padding: 1em; }

#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}

#logmsg dl { margin: 0; }

#logmsg dt { font-weight: bold; }

#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }

#logmsg dd:before { content:'\00bb';}

#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }

#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }

#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }

#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }

#logmsg table th.Corner { text-align: left; }

#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }

#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }

#patch { width: 100%; }

#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}

#patch .propset h4, #patch .binary h4 {margin:0;}

#patch pre {padding:0;line-height:1.2em;margin:0;}

#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}

#patch .propset .diff, #patch .binary .diff  {padding:10px 0;}

#patch span {display:block;padding:0 10px;}

#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}

#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}

#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}

#patch .lines, .info {color:#888;background:#fff;}

--></style>

<div id="msg">

<dl class="meta">

<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/160323">160323</a></dd>

<dt>Author</dt> <dd>mario.prada@samsung.com</dd>

<dt>Date</dt> <dd>2013-12-09 12:16:50 -0800 (Mon, 09 Dec 2013)</dd>

</dl>

<h3>Log Message</h3>

<pre>[ATK] Translate ATK_ROLE_SECTION into &quot;AXSection&quot; in DRT/WKTR

https://bugs.webkit.org/show_bug.cgi?id=125456

Reviewed by Chris Fleizach.

Tools:

Return 'AXSection' for section roles instead of 'AXDiv'.

* DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:

* WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:

LayoutTests:

Update expectations for GTK and EFL that were expecting AXDiv for

section roles, so they now expect AXSection.

* accessibility/adjacent-continuations-cause-assertion-failure-expected.txt:

* accessibility/div-within-anchors-causes-crash-expected.txt:

* platform/efl-wk1/accessibility/image-map2-expected.txt:

* platform/efl-wk1/accessibility/transformed-element-expected.txt:

* platform/efl-wk2/accessibility/image-map2-expected.txt:

* platform/efl-wk2/accessibility/transformed-element-expected.txt:

* platform/efl/accessibility/media-emits-object-replacement-expected.txt:

* platform/gtk/accessibility/aria-roles-unignored-expected.txt:

* platform/gtk/accessibility/aria-roles-unignored.html:

* platform/gtk/accessibility/entry-and-password-expected.txt:

* platform/gtk/accessibility/image-map2-expected.txt:

* platform/gtk/accessibility/media-emits-object-replacement-expected.txt:

* platform/gtk/accessibility/object-with-title-expected.txt:

* platform/gtk/accessibility/object-with-title.html:

* platform/gtk/accessibility/replaced-objects-in-anonymous-blocks-expected.txt:

* platform/gtk/accessibility/spans-paragraphs-and-divs-expected.txt:

* platform/gtk/accessibility/spans-paragraphs-and-divs.html:

* platform/gtk/accessibility/transformed-element-expected.txt:</pre>

<h3>Modified Paths</h3>

<ul>

<li><a href="#trunkLayoutTestsChangeLog">trunk/LayoutTests/ChangeLog</a></li>

<li><a href="#trunkLayoutTestsaccessibilityadjacentcontinuationscauseassertionfailureexpectedtxt">trunk/LayoutTests/accessibility/adjacent-continuations-cause-assertion-failure-expected.txt</a></li>

<li><a href="#trunkLayoutTestsaccessibilitydivwithinanchorscausescrashexpectedtxt">trunk/LayoutTests/accessibility/div-within-anchors-causes-crash-expected.txt</a></li>

<li><a href="#trunkLayoutTestsplatformeflaccessibilitymediaemitsobjectreplacementexpectedtxt">trunk/LayoutTests/platform/efl/accessibility/media-emits-object-replacement-expected.txt</a></li>

<li><a href="#trunkLayoutTestsplatformeflwk1accessibilityimagemap2expectedtxt">trunk/LayoutTests/platform/efl-wk1/accessibility/image-map2-expected.txt</a></li>

<li><a href="#trunkLayoutTestsplatformeflwk1accessibilitytransformedelementexpectedtxt">trunk/LayoutTests/platform/efl-wk1/accessibility/transformed-element-expected.txt</a></li>

<li><a href="#trunkLayoutTestsplatformeflwk2accessibilityimagemap2expectedtxt">trunk/LayoutTests/platform/efl-wk2/accessibility/image-map2-expected.txt</a></li>

<li><a href="#trunkLayoutTestsplatformeflwk2accessibilitytransformedelementexpectedtxt">trunk/LayoutTests/platform/efl-wk2/accessibility/transformed-element-expected.txt</a></li>

<li><a href="#trunkLayoutTestsplatformgtkaccessibilityariarolesunignoredexpectedtxt">trunk/LayoutTests/platform/gtk/accessibility/aria-roles-unignored-expected.txt</a></li>

<li><a href="#trunkLayoutTestsplatformgtkaccessibilityariarolesunignoredhtml">trunk/LayoutTests/platform/gtk/accessibility/aria-roles-unignored.html</a></li>

<li><a href="#trunkLayoutTestsplatformgtkaccessibilityentryandpasswordexpectedtxt">trunk/LayoutTests/platform/gtk/accessibility/entry-and-password-expected.txt</a></li>

<li><a href="#trunkLayoutTestsplatformgtkaccessibilityimagemap2expectedtxt">trunk/LayoutTests/platform/gtk/accessibility/image-map2-expected.txt</a></li>

<li><a href="#trunkLayoutTestsplatformgtkaccessibilitymediaemitsobjectreplacementexpectedtxt">trunk/LayoutTests/platform/gtk/accessibility/media-emits-object-replacement-expected.txt</a></li>

<li><a href="#trunkLayoutTestsplatformgtkaccessibilityobjectwithtitleexpectedtxt">trunk/LayoutTests/platform/gtk/accessibility/object-with-title-expected.txt</a></li>

<li><a href="#trunkLayoutTestsplatformgtkaccessibilityobjectwithtitlehtml">trunk/LayoutTests/platform/gtk/accessibility/object-with-title.html</a></li>

<li><a href="#trunkLayoutTestsplatformgtkaccessibilityreplacedobjectsinanonymousblocksexpectedtxt">trunk/LayoutTests/platform/gtk/accessibility/replaced-objects-in-anonymous-blocks-expected.txt</a></li>

<li><a href="#trunkLayoutTestsplatformgtkaccessibilityspansparagraphsanddivsexpectedtxt">trunk/LayoutTests/platform/gtk/accessibility/spans-paragraphs-and-divs-expected.txt</a></li>

<li><a href="#trunkLayoutTestsplatformgtkaccessibilityspansparagraphsanddivshtml">trunk/LayoutTests/platform/gtk/accessibility/spans-paragraphs-and-divs.html</a></li>

<li><a href="#trunkLayoutTestsplatformgtkaccessibilitytransformedelementexpectedtxt">trunk/LayoutTests/platform/gtk/accessibility/transformed-element-expected.txt</a></li>

<li><a href="#trunkToolsChangeLog">trunk/Tools/ChangeLog</a></li>

<li><a href="#trunkToolsDumpRenderTreeatkAccessibilityUIElementAtkcpp">trunk/Tools/DumpRenderTree/atk/AccessibilityUIElementAtk.cpp</a></li>

<li><a href="#trunkToolsWebKitTestRunnerInjectedBundleatkAccessibilityUIElementAtkcpp">trunk/Tools/WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp</a></li>

</ul>

</div>

<div id="patch">

<h3>Diff</h3>

<a id="trunkLayoutTestsChangeLog"></a>

<div class="modfile"><h4>Modified: trunk/LayoutTests/ChangeLog (160322 => 160323)</h4>

<pre class="diff"><span>

<span class="info">--- trunk/LayoutTests/ChangeLog        2013-12-09 19:45:21 UTC (rev 160322)

+++ trunk/LayoutTests/ChangeLog        2013-12-09 20:16:50 UTC (rev 160323)

</span><span class="lines">@@ -1,3 +1,32 @@

</span><ins>+2013-12-09  Mario Sanchez Prada  &lt;mario.prada@samsung.com&gt;

+

+        [ATK] Translate ATK_ROLE_SECTION into &quot;AXSection&quot; in DRT/WKTR

+        https://bugs.webkit.org/show_bug.cgi?id=125456

+

+        Reviewed by Chris Fleizach.

+

+        Update expectations for GTK and EFL that were expecting AXDiv for

+        section roles, so they now expect AXSection.

+

+        * accessibility/adjacent-continuations-cause-assertion-failure-expected.txt:

+        * accessibility/div-within-anchors-causes-crash-expected.txt:

+        * platform/efl-wk1/accessibility/image-map2-expected.txt:

+        * platform/efl-wk1/accessibility/transformed-element-expected.txt:

+        * platform/efl-wk2/accessibility/image-map2-expected.txt:

+        * platform/efl-wk2/accessibility/transformed-element-expected.txt:

+        * platform/efl/accessibility/media-emits-object-replacement-expected.txt:

+        * platform/gtk/accessibility/aria-roles-unignored-expected.txt:

+        * platform/gtk/accessibility/aria-roles-unignored.html:

+        * platform/gtk/accessibility/entry-and-password-expected.txt:

+        * platform/gtk/accessibility/image-map2-expected.txt:

+        * platform/gtk/accessibility/media-emits-object-replacement-expected.txt:

+        * platform/gtk/accessibility/object-with-title-expected.txt:

+        * platform/gtk/accessibility/object-with-title.html:

+        * platform/gtk/accessibility/replaced-objects-in-anonymous-blocks-expected.txt:

+        * platform/gtk/accessibility/spans-paragraphs-and-divs-expected.txt:

+        * platform/gtk/accessibility/spans-paragraphs-and-divs.html:

+        * platform/gtk/accessibility/transformed-element-expected.txt:

+

</ins><span class="cx"> 2013-12-09  Peter Molnar  &lt;pmolnar.u-szeged@partner.samsung.com&gt;

</span><span class="cx"> 

<span class="cx">         Fix handling of 'inherit' and 'initial' for grid lines.

</span></span></pre></div>

<a id="trunkLayoutTestsaccessibilityadjacentcontinuationscauseassertionfailureexpectedtxt"></a>

<div class="modfile"><h4>Modified: trunk/LayoutTests/accessibility/adjacent-continuations-cause-assertion-failure-expected.txt (160322 => 160323)</h4>

<pre class="diff"><span>

<span class="info">--- trunk/LayoutTests/accessibility/adjacent-continuations-cause-assertion-failure-expected.txt        2013-12-09 19:45:21 UTC (rev 160322)

+++ trunk/LayoutTests/accessibility/adjacent-continuations-cause-assertion-failure-expected.txt        2013-12-09 20:16:50 UTC (rev 160323)

</span><span class="lines">@@ -8,8 +8,8 @@

</span><span class="cx"> 

</span><span class="cx"> 

</span><span class="cx"> AXRole: AXWebArea 

</span><del>-    AXRole: AXDiv AXValue: y

-    AXRole: AXDiv AXValue: End of test

</del><ins>+    AXRole: AXSection AXValue: y

+    AXRole: AXSection AXValue: End of test

</ins><span class="cx"> PASS successfullyParsed is true

</span><span class="cx"> 

</span><span class="cx"> TEST COMPLETE

</span></span></pre></div>

<a id="trunkLayoutTestsaccessibilitydivwithinanchorscausescrashexpectedtxt"></a>

<div class="modfile"><h4>Modified: trunk/LayoutTests/accessibility/div-within-anchors-causes-crash-expected.txt (160322 => 160323)</h4>

<pre class="diff"><span>

<span class="info">--- trunk/LayoutTests/accessibility/div-within-anchors-causes-crash-expected.txt        2013-12-09 19:45:21 UTC (rev 160322)

+++ trunk/LayoutTests/accessibility/div-within-anchors-causes-crash-expected.txt        2013-12-09 20:16:50 UTC (rev 160323)

</span><span class="lines">@@ -2,10 +2,10 @@

</span><span class="cx"> Before:

</span><span class="cx"> AXRole: AXWebArea 

</span><span class="cx">     AXRole: AXLink AXValue: 

</span><del>-    AXRole: AXDiv AXValue: End of test

</del><ins>+    AXRole: AXSection AXValue: End of test

</ins><span class="cx"> After:

</span><span class="cx"> AXRole: AXWebArea 

</span><del>-    AXRole: AXDiv AXValue: End of test

</del><ins>+    AXRole: AXSection AXValue: End of test

</ins><span class="cx"> This can cause a crash.

</span><span class="cx"> 