<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[160289] trunk/Source/WebCore</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/160289">160289</a></dd>
<dt>Author</dt> <dd>carlosgc@webkit.org</dd>
<dt>Date</dt> <dd>2013-12-08 10:22:29 -0800 (Sun, 08 Dec 2013)</dd>
</dl>
<h3>Log Message</h3>
<pre>[GTK] Do not skip attributes with only custom setter
https://bugs.webkit.org/show_bug.cgi?id=125417
Reviewed by Gustavo Noronha Silva.
For attributes with a custom setter, we now generate the code as a
read-only attribute with a getter method, unless it also has a
custom getter in which case the attribute is skipped.
* bindings/gobject/GNUmakefile.am: Generate WebKitDOMMediaController
that is now required by an attribute having a custom setter.
* bindings/gobject/WebKitDOMCustom.cpp: Remove methods that are now generated.
* bindings/gobject/WebKitDOMCustom.h: Ditto.
* bindings/gobject/WebKitDOMCustom.symbols: Ditto.
* bindings/gobject/webkitdom.symbols: Add new symbols.
* bindings/scripts/CodeGeneratorGObject.pm:
(SkipAttribute): Do not skip attributes having a custom setter.
(GetWriteableProperties): Do not include attributes having a
custom setter.
(GenerateProperty): Do not return early for attributes having
custom setter.
(GenerateFunctions): Do not generate setter for attributes having
a custom setter.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkSourceWebCoreChangeLog">trunk/Source/WebCore/ChangeLog</a></li>
<li><a href="#trunkSourceWebCorebindingsgobjectGNUmakefileam">trunk/Source/WebCore/bindings/gobject/GNUmakefile.am</a></li>
<li><a href="#trunkSourceWebCorebindingsgobjectWebKitDOMCustomcpp">trunk/Source/WebCore/bindings/gobject/WebKitDOMCustom.cpp</a></li>
<li><a href="#trunkSourceWebCorebindingsgobjectWebKitDOMCustomh">trunk/Source/WebCore/bindings/gobject/WebKitDOMCustom.h</a></li>
<li><a href="#trunkSourceWebCorebindingsgobjectWebKitDOMCustomsymbols">trunk/Source/WebCore/bindings/gobject/WebKitDOMCustom.symbols</a></li>
<li><a href="#trunkSourceWebCorebindingsgobjectwebkitdomsymbols">trunk/Source/WebCore/bindings/gobject/webkitdom.symbols</a></li>
<li><a href="#trunkSourceWebCorebindingsscriptsCodeGeneratorGObjectpm">trunk/Source/WebCore/bindings/scripts/CodeGeneratorGObject.pm</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkSourceWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/ChangeLog (160288 => 160289)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/ChangeLog 2013-12-08 18:16:04 UTC (rev 160288)
+++ trunk/Source/WebCore/ChangeLog 2013-12-08 18:22:29 UTC (rev 160289)
</span><span class="lines">@@ -1,5 +1,31 @@
</span><span class="cx"> 2013-12-08 Carlos Garcia Campos <cgarcia@igalia.com>
</span><span class="cx">
</span><ins>+ [GTK] Do not skip attributes with only custom setter
+ https://bugs.webkit.org/show_bug.cgi?id=125417
+
+ Reviewed by Gustavo Noronha Silva.
+
+ For attributes with a custom setter, we now generate the code as a
+ read-only attribute with a getter method, unless it also has a
+ custom getter in which case the attribute is skipped.
+
+ * bindings/gobject/GNUmakefile.am: Generate WebKitDOMMediaController
+ that is now required by an attribute having a custom setter.
+ * bindings/gobject/WebKitDOMCustom.cpp: Remove methods that are now generated.
+ * bindings/gobject/WebKitDOMCustom.h: Ditto.
+ * bindings/gobject/WebKitDOMCustom.symbols: Ditto.
+ * bindings/gobject/webkitdom.symbols: Add new symbols.
+ * bindings/scripts/CodeGeneratorGObject.pm:
+ (SkipAttribute): Do not skip attributes having a custom setter.
+ (GetWriteableProperties): Do not include attributes having a
+ custom setter.
+ (GenerateProperty): Do not return early for attributes having
+ custom setter.
+ (GenerateFunctions): Do not generate setter for attributes having
+ a custom setter.
+
+2013-12-08 Carlos Garcia Campos <cgarcia@igalia.com>
+
</ins><span class="cx"> [GTK] Do not generate new dispatch_event methods marked as deprecated
</span><span class="cx"> https://bugs.webkit.org/show_bug.cgi?id=125416
</span><span class="cx">
</span></span></pre></div>
<a id="trunkSourceWebCorebindingsgobjectGNUmakefileam"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/bindings/gobject/GNUmakefile.am (160288 => 160289)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/bindings/gobject/GNUmakefile.am 2013-12-08 18:16:04 UTC (rev 160288)
+++ trunk/Source/WebCore/bindings/gobject/GNUmakefile.am 2013-12-08 18:22:29 UTC (rev 160289)
</span><span class="lines">@@ -207,6 +207,8 @@
</span><span class="cx"> DerivedSources/webkitdom/WebKitDOMKeyboardEventPrivate.h \
</span><span class="cx"> DerivedSources/webkitdom/WebKitDOMLocation.cpp \
</span><span class="cx"> DerivedSources/webkitdom/WebKitDOMLocationPrivate.h \
</span><ins>+ DerivedSources/webkitdom/WebKitDOMMediaController.cpp \
+ DerivedSources/webkitdom/WebKitDOMMediaControllerPrivate.h \
</ins><span class="cx"> DerivedSources/webkitdom/WebKitDOMMediaError.cpp \
</span><span class="cx"> DerivedSources/webkitdom/WebKitDOMMediaErrorPrivate.h \
</span><span class="cx"> DerivedSources/webkitdom/WebKitDOMMediaList.cpp \
</span><span class="lines">@@ -287,6 +289,7 @@
</span><span class="cx"> DerivedSources/webkitdom/WebKitDOMCSSStyleDeclaration.h \
</span><span class="cx"> DerivedSources/webkitdom/WebKitDOMCSSStyleSheet.h \
</span><span class="cx"> DerivedSources/webkitdom/WebKitDOMCSSValue.h \
</span><ins>+ DerivedSources/webkitdom/WebKitDOMMediaController.h \
</ins><span class="cx"> DerivedSources/webkitdom/WebKitDOMMediaList.h \
</span><span class="cx"> DerivedSources/webkitdom/WebKitDOMMediaQueryList.h \
</span><span class="cx"> DerivedSources/webkitdom/WebKitDOMStyleMedia.h \
</span></span></pre></div>
<a id="trunkSourceWebCorebindingsgobjectWebKitDOMCustomcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/bindings/gobject/WebKitDOMCustom.cpp (160288 => 160289)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/bindings/gobject/WebKitDOMCustom.cpp 2013-12-08 18:16:04 UTC (rev 160288)
+++ trunk/Source/WebCore/bindings/gobject/WebKitDOMCustom.cpp 2013-12-08 18:22:29 UTC (rev 160289)
</span><span class="lines">@@ -20,15 +20,12 @@
</span><span class="cx"> #include "WebKitDOMCustom.h"
</span><span class="cx">
</span><span class="cx"> #include "JSMainThreadExecState.h"
</span><del>-#include "WebKitDOMAudioTrackPrivate.h"
</del><span class="cx"> #include "WebKitDOMHTMLInputElement.h"
</span><span class="cx"> #include "WebKitDOMHTMLInputElementPrivate.h"
</span><span class="cx"> #include "WebKitDOMHTMLMediaElementPrivate.h"
</span><span class="cx"> #include "WebKitDOMHTMLTextAreaElement.h"
</span><span class="cx"> #include "WebKitDOMHTMLTextAreaElementPrivate.h"
</span><span class="cx"> #include "WebKitDOMPrivate.h"
</span><del>-#include "WebKitDOMTextTrackPrivate.h"
-#include "WebKitDOMVideoTrackPrivate.h"
</del><span class="cx"> #include "gobject/ConvertToUTF8String.h"
</span><span class="cx">
</span><span class="cx"> using namespace WebKit;
</span><span class="lines">@@ -59,87 +56,4 @@
</span><span class="cx"> #endif /* ENABLE(VIDEO) */
</span><span class="cx"> }
</span><span class="cx">
</span><del>-gchar* webkit_dom_audio_track_get_kind(WebKitDOMAudioTrack* self)
-{
-#if ENABLE(VIDEO_TRACK)
- WebCore::JSMainThreadNullState state;
- g_return_val_if_fail(WEBKIT_DOM_IS_AUDIO_TRACK(self), 0);
- WebCore::AudioTrack* item = WebKit::core(self);
- gchar* result = convertToUTF8String(item->kind());
- return result;
-#else
- WEBKIT_WARN_FEATURE_NOT_PRESENT("Video Track")
- return 0;
-#endif /* ENABLE(VIDEO_TRACK) */
-}
</del><span class="cx">
</span><del>-gchar* webkit_dom_audio_track_get_language(WebKitDOMAudioTrack* self)
-{
-#if ENABLE(VIDEO_TRACK)
- WebCore::JSMainThreadNullState state;
- g_return_val_if_fail(WEBKIT_DOM_IS_AUDIO_TRACK(self), 0);
- WebCore::AudioTrack* item = WebKit::core(self);
- gchar* result = convertToUTF8String(item->language());
- return result;
-#else
- WEBKIT_WARN_FEATURE_NOT_PRESENT("Video Track")
- return 0;
-#endif /* ENABLE(VIDEO_TRACK) */
-}
-
-gchar* webkit_dom_text_track_get_kind(WebKitDOMTextTrack* self)
-{
-#if ENABLE(VIDEO_TRACK)
- WebCore::JSMainThreadNullState state;
- g_return_val_if_fail(WEBKIT_DOM_IS_TEXT_TRACK(self), 0);
- WebCore::TextTrack* item = WebKit::core(self);
- gchar* result = convertToUTF8String(item->kind());
- return result;
-#else
- WEBKIT_WARN_FEATURE_NOT_PRESENT("Video Track")
- return 0;
-#endif /* ENABLE(VIDEO_TRACK) */
-}
-
-gchar* webkit_dom_text_track_get_language(WebKitDOMTextTrack* self)
-{
-#if ENABLE(VIDEO_TRACK)
- WebCore::JSMainThreadNullState state;
- g_return_val_if_fail(WEBKIT_DOM_IS_TEXT_TRACK(self), 0);
- WebCore::TextTrack* item = WebKit::core(self);
- gchar* result = convertToUTF8String(item->language());
- return result;
-#else
- WEBKIT_WARN_FEATURE_NOT_PRESENT("Video Track")
- return 0;
-#endif /* ENABLE(VIDEO_TRACK) */
-}
-
-gchar* webkit_dom_video_track_get_kind(WebKitDOMVideoTrack* self)
-{
-#if ENABLE(VIDEO_TRACK)
- WebCore::JSMainThreadNullState state;
- g_return_val_if_fail(WEBKIT_DOM_IS_VIDEO_TRACK(self), 0);
- WebCore::VideoTrack* item = WebKit::core(self);
- gchar* result = convertToUTF8String(item->kind());
- return result;
-#else
- WEBKIT_WARN_FEATURE_NOT_PRESENT("Video Track")
- return 0;
-#endif /* ENABLE(VIDEO_TRACK) */
-}
-
-gchar* webkit_dom_video_track_get_language(WebKitDOMVideoTrack* self)
-{
-#if ENABLE(VIDEO_TRACK)
- WebCore::JSMainThreadNullState state;
- g_return_val_if_fail(WEBKIT_DOM_IS_VIDEO_TRACK(self), 0);
- WebCore::VideoTrack* item = WebKit::core(self);
- gchar* result = convertToUTF8String(item->language());
- return result;
-#else
- WEBKIT_WARN_FEATURE_NOT_PRESENT("Video Track")
- return 0;
-#endif /* ENABLE(VIDEO_TRACK) */
-}
-
</del></span></pre></div>
<a id="trunkSourceWebCorebindingsgobjectWebKitDOMCustomh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/bindings/gobject/WebKitDOMCustom.h (160288 => 160289)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/bindings/gobject/WebKitDOMCustom.h 2013-12-08 18:16:04 UTC (rev 160288)
+++ trunk/Source/WebCore/bindings/gobject/WebKitDOMCustom.h 2013-12-08 18:22:29 UTC (rev 160289)
</span><span class="lines">@@ -50,54 +50,6 @@
</span><span class="cx"> */
</span><span class="cx"> WEBKIT_API gboolean webkit_dom_html_input_element_is_edited(WebKitDOMHTMLInputElement* input);
</span><span class="cx">
</span><del>-/**
- * webkit_dom_audio_track_get_kind:
- * @self: A #WebKitDOMAudioTrack
- *
- * Returns: A #gchar
- */
-WEBKIT_API gchar* webkit_dom_audio_track_get_kind(WebKitDOMAudioTrack* self);
-
-/**
- * webkit_dom_audio_track_get_language:
- * @self: A #WebKitDOMAudioTrack
- *
- * Returns: A #gchar
- */
-WEBKIT_API gchar* webkit_dom_audio_track_get_language(WebKitDOMAudioTrack* self);
-
-/**
- * webkit_dom_text_track_get_kind:
- * @self: A #WebKitDOMTextTrack
- *
- * Returns: A #gchar
- */
-WEBKIT_API gchar* webkit_dom_text_track_get_kind(WebKitDOMTextTrack* self);
-
-/**
- * webkit_dom_text_track_get_language:
- * @self: A #WebKitDOMTextTrack
- *
- * Returns: A #gchar
- */
-WEBKIT_API gchar* webkit_dom_text_track_get_language(WebKitDOMTextTrack* self);
-
-/**
- * webkit_dom_video_track_get_kind:
- * @self: A #WebKitDOMVideoTrack
- *
- * Returns: A #gchar
- */
-WEBKIT_API gchar* webkit_dom_video_track_get_kind(WebKitDOMVideoTrack* self);
-
-/**
- * webkit_dom_video_track_get_language:
- * @self: A #WebKitDOMVideoTrack
- *
- * Returns: A #gchar
- */
-WEBKIT_API gchar* webkit_dom_video_track_get_language(WebKitDOMVideoTrack* self);
-
</del><span class="cx"> G_END_DECLS
</span><span class="cx">
</span><span class="cx"> #endif
</span></span></pre></div>
<a id="trunkSourceWebCorebindingsgobjectWebKitDOMCustomsymbols"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/bindings/gobject/WebKitDOMCustom.symbols (160288 => 160289)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/bindings/gobject/WebKitDOMCustom.symbols 2013-12-08 18:16:04 UTC (rev 160288)
+++ trunk/Source/WebCore/bindings/gobject/WebKitDOMCustom.symbols 2013-12-08 18:22:29 UTC (rev 160289)
</span><span class="lines">@@ -1,9 +1,3 @@
</span><span class="cx"> gboolean webkit_dom_html_text_area_element_is_edited(WebKitDOMHTMLTextAreaElement*)
</span><span class="cx"> gboolean webkit_dom_html_input_element_is_edited(WebKitDOMHTMLInputElement*)
</span><span class="cx"> void webkit_dom_html_media_element_set_current_time(WebKitDOMHTMLMediaElement*, gdouble, GError**)
</span><del>-gchar* webkit_dom_audio_track_get_kind(WebKitDOMAudioTrack*)
-gchar* webkit_dom_audio_track_get_language(WebKitDOMAudioTrack*)
-gchar* webkit_dom_text_track_get_kind(WebKitDOMTextTrack*)
-gchar* webkit_dom_text_track_get_language(WebKitDOMTextTrack*)
-gchar* webkit_dom_video_track_get_kind(WebKitDOMVideoTrack*)
-gchar* webkit_dom_video_track_get_language(WebKitDOMVideoTrack*)
</del></span></pre></div>
<a id="trunkSourceWebCorebindingsgobjectwebkitdomsymbols"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/bindings/gobject/webkitdom.symbols (160288 => 160289)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/bindings/gobject/webkitdom.symbols 2013-12-08 18:16:04 UTC (rev 160288)
+++ trunk/Source/WebCore/bindings/gobject/webkitdom.symbols 2013-12-08 18:22:29 UTC (rev 160289)
</span><span class="lines">@@ -30,6 +30,25 @@
</span><span class="cx"> gchar* webkit_dom_css_value_get_css_text(WebKitDOMCSSValue*)
</span><span class="cx"> void webkit_dom_css_value_set_css_text(WebKitDOMCSSValue*, const gchar*, GError**)
</span><span class="cx"> gushort webkit_dom_css_value_get_css_value_type(WebKitDOMCSSValue*)
</span><ins>+void webkit_dom_media_controller_play(WebKitDOMMediaController*)
+void webkit_dom_media_controller_pause(WebKitDOMMediaController*)
+void webkit_dom_media_controller_unpause(WebKitDOMMediaController*)
+WebKitDOMTimeRanges* webkit_dom_media_controller_get_buffered(WebKitDOMMediaController*)
+WebKitDOMTimeRanges* webkit_dom_media_controller_get_seekable(WebKitDOMMediaController*)
+gdouble webkit_dom_media_controller_get_duration(WebKitDOMMediaController*)
+gdouble webkit_dom_media_controller_get_current_time(WebKitDOMMediaController*)
+void webkit_dom_media_controller_set_current_time(WebKitDOMMediaController*, gdouble)
+gboolean webkit_dom_media_controller_get_paused(WebKitDOMMediaController*)
+WebKitDOMTimeRanges* webkit_dom_media_controller_get_played(WebKitDOMMediaController*)
+gchar* webkit_dom_media_controller_get_playback_state(WebKitDOMMediaController*)
+gdouble webkit_dom_media_controller_get_default_playback_rate(WebKitDOMMediaController*)
+void webkit_dom_media_controller_set_default_playback_rate(WebKitDOMMediaController*, gdouble)
+gdouble webkit_dom_media_controller_get_playback_rate(WebKitDOMMediaController*)
+void webkit_dom_media_controller_set_playback_rate(WebKitDOMMediaController*, gdouble)
+gdouble webkit_dom_media_controller_get_volume(WebKitDOMMediaController*)
+void webkit_dom_media_controller_set_volume(WebKitDOMMediaController*, gdouble, GError**)
+gboolean webkit_dom_media_controller_get_muted(WebKitDOMMediaController*)
+void webkit_dom_media_controller_set_muted(WebKitDOMMediaController*, gboolean)
</ins><span class="cx"> gchar* webkit_dom_media_list_item(WebKitDOMMediaList*, gulong)
</span><span class="cx"> void webkit_dom_media_list_delete_medium(WebKitDOMMediaList*, const gchar*, GError**)
</span><span class="cx"> void webkit_dom_media_list_append_medium(WebKitDOMMediaList*, const gchar*, GError**)
</span><span class="lines">@@ -991,6 +1010,7 @@
</span><span class="cx"> WebKitDOMVideoTrackList* webkit_dom_html_media_element_get_video_tracks(WebKitDOMHTMLMediaElement*)
</span><span class="cx"> gchar* webkit_dom_html_media_element_get_media_group(WebKitDOMHTMLMediaElement*)
</span><span class="cx"> void webkit_dom_html_media_element_set_media_group(WebKitDOMHTMLMediaElement*, const gchar*)
</span><ins>+WebKitDOMMediaController* webkit_dom_html_media_element_get_controller(WebKitDOMHTMLMediaElement*)
</ins><span class="cx"> gboolean webkit_dom_html_menu_element_get_compact(WebKitDOMHTMLMenuElement*)
</span><span class="cx"> void webkit_dom_html_menu_element_set_compact(WebKitDOMHTMLMenuElement*, gboolean)
</span><span class="cx"> gchar* webkit_dom_html_meta_element_get_content(WebKitDOMHTMLMetaElement*)
</span><span class="lines">@@ -1068,6 +1088,7 @@
</span><span class="cx"> WebKitDOMNode* webkit_dom_html_options_collection_named_item(WebKitDOMHTMLOptionsCollection*, const gchar*)
</span><span class="cx"> glong webkit_dom_html_options_collection_get_selected_index(WebKitDOMHTMLOptionsCollection*)
</span><span class="cx"> void webkit_dom_html_options_collection_set_selected_index(WebKitDOMHTMLOptionsCollection*, glong)
</span><ins>+gulong webkit_dom_html_options_collection_get_length(WebKitDOMHTMLOptionsCollection*)
</ins><span class="cx"> gchar* webkit_dom_html_paragraph_element_get_align(WebKitDOMHTMLParagraphElement*)
</span><span class="cx"> void webkit_dom_html_paragraph_element_set_align(WebKitDOMHTMLParagraphElement*, const gchar*)
</span><span class="cx"> gchar* webkit_dom_html_param_element_get_name(WebKitDOMHTMLParamElement*)
</span><span class="lines">@@ -1312,12 +1333,6 @@
</span><span class="cx"> gboolean webkit_dom_html_text_area_element_is_edited(WebKitDOMHTMLTextAreaElement*)
</span><span class="cx"> gboolean webkit_dom_html_input_element_is_edited(WebKitDOMHTMLInputElement*)
</span><span class="cx"> void webkit_dom_html_media_element_set_current_time(WebKitDOMHTMLMediaElement*, gdouble, GError**)
</span><del>-gchar* webkit_dom_audio_track_get_kind(WebKitDOMAudioTrack*)
-gchar* webkit_dom_audio_track_get_language(WebKitDOMAudioTrack*)
-gchar* webkit_dom_text_track_get_kind(WebKitDOMTextTrack*)
-gchar* webkit_dom_text_track_get_language(WebKitDOMTextTrack*)
-gchar* webkit_dom_video_track_get_kind(WebKitDOMVideoTrack*)
-gchar* webkit_dom_video_track_get_language(WebKitDOMVideoTrack*)
</del><span class="cx"> WebKitDOMBlob* webkit_dom_blob_webkit_slice(WebKitDOMBlob*, gint64, gint64, const gchar*)
</span><span class="cx"> gchar* webkit_dom_html_element_get_id(WebKitDOMHTMLElement*)
</span><span class="cx"> void webkit_dom_html_element_set_id(WebKitDOMHTMLElement*, const gchar*)
</span><span class="lines">@@ -1482,6 +1497,14 @@
</span><span class="cx"> void webkit_dom_history_forward(WebKitDOMHistory*)
</span><span class="cx"> void webkit_dom_history_go(WebKitDOMHistory*, glong)
</span><span class="cx"> gulong webkit_dom_history_get_length(WebKitDOMHistory*)
</span><ins>+gchar* webkit_dom_location_get_href(WebKitDOMLocation*)
+gchar* webkit_dom_location_get_protocol(WebKitDOMLocation*)
+gchar* webkit_dom_location_get_host(WebKitDOMLocation*)
+gchar* webkit_dom_location_get_hostname(WebKitDOMLocation*)
+gchar* webkit_dom_location_get_port(WebKitDOMLocation*)
+gchar* webkit_dom_location_get_pathname(WebKitDOMLocation*)
+gchar* webkit_dom_location_get_search(WebKitDOMLocation*)
+gchar* webkit_dom_location_get_hash(WebKitDOMLocation*)
</ins><span class="cx"> gchar* webkit_dom_location_get_origin(WebKitDOMLocation*)
</span><span class="cx"> WebKitDOMDOMStringList* webkit_dom_location_get_ancestor_origins(WebKitDOMLocation*)
</span><span class="cx"> GType webkit_dom_object_get_type(void)
</span><span class="lines">@@ -1625,7 +1648,9 @@
</span><span class="cx"> glong webkit_dom_wheel_event_get_wheel_delta(WebKitDOMWheelEvent*)
</span><span class="cx"> gboolean webkit_dom_wheel_event_get_webkit_direction_inverted_from_device(WebKitDOMWheelEvent*)
</span><span class="cx"> gchar* webkit_dom_audio_track_get_id(WebKitDOMAudioTrack*)
</span><ins>+gchar* webkit_dom_audio_track_get_kind(WebKitDOMAudioTrack*)
</ins><span class="cx"> gchar* webkit_dom_audio_track_get_label(WebKitDOMAudioTrack*)
</span><ins>+gchar* webkit_dom_audio_track_get_language(WebKitDOMAudioTrack*)
</ins><span class="cx"> gboolean webkit_dom_audio_track_get_enabled(WebKitDOMAudioTrack*)
</span><span class="cx"> void webkit_dom_audio_track_set_enabled(WebKitDOMAudioTrack*, gboolean)
</span><span class="cx"> WebKitDOMAudioTrack* webkit_dom_audio_track_list_item(WebKitDOMAudioTrackList*, gulong)
</span><span class="lines">@@ -1652,7 +1677,9 @@
</span><span class="cx"> void webkit_dom_text_track_remove_cue(WebKitDOMTextTrack*, WebKitDOMTextTrackCue*, GError**)
</span><span class="cx"> gboolean webkit_dom_text_track_dispatch_event(WebKitDOMTextTrack*, WebKitDOMEvent*, GError**)
</span><span class="cx"> gchar* webkit_dom_text_track_get_id(WebKitDOMTextTrack*)
</span><ins>+gchar* webkit_dom_text_track_get_kind(WebKitDOMTextTrack*)
</ins><span class="cx"> gchar* webkit_dom_text_track_get_label(WebKitDOMTextTrack*)
</span><ins>+gchar* webkit_dom_text_track_get_language(WebKitDOMTextTrack*)
</ins><span class="cx"> gchar* webkit_dom_text_track_get_mode(WebKitDOMTextTrack*)
</span><span class="cx"> void webkit_dom_text_track_set_mode(WebKitDOMTextTrack*, const gchar*)
</span><span class="cx"> WebKitDOMTextTrackCueList* webkit_dom_text_track_get_cues(WebKitDOMTextTrack*)
</span><span class="lines">@@ -1690,7 +1717,9 @@
</span><span class="cx"> WebKitDOMTextTrackCue* webkit_dom_text_track_cue_list_get_cue_by_id(WebKitDOMTextTrackCueList*, const gchar*)
</span><span class="cx"> gulong webkit_dom_text_track_cue_list_get_length(WebKitDOMTextTrackCueList*)
</span><span class="cx"> gchar* webkit_dom_video_track_get_id(WebKitDOMVideoTrack*)
</span><ins>+gchar* webkit_dom_video_track_get_kind(WebKitDOMVideoTrack*)
</ins><span class="cx"> gchar* webkit_dom_video_track_get_label(WebKitDOMVideoTrack*)
</span><ins>+gchar* webkit_dom_video_track_get_language(WebKitDOMVideoTrack*)
</ins><span class="cx"> gboolean webkit_dom_video_track_get_selected(WebKitDOMVideoTrack*)
</span><span class="cx"> void webkit_dom_video_track_set_selected(WebKitDOMVideoTrack*, gboolean)
</span><span class="cx"> WebKitDOMVideoTrack* webkit_dom_video_track_list_item(WebKitDOMVideoTrackList*, gulong)
</span></span></pre></div>
<a id="trunkSourceWebCorebindingsscriptsCodeGeneratorGObjectpm"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/bindings/scripts/CodeGeneratorGObject.pm (160288 => 160289)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/bindings/scripts/CodeGeneratorGObject.pm 2013-12-08 18:16:04 UTC (rev 160288)
+++ trunk/Source/WebCore/bindings/scripts/CodeGeneratorGObject.pm 2013-12-08 18:22:29 UTC (rev 160289)
</span><span class="lines">@@ -188,8 +188,7 @@
</span><span class="cx"> my $attribute = shift;
</span><span class="cx">
</span><span class="cx"> if ($attribute->signature->extendedAttributes->{"Custom"}
</span><del>- || $attribute->signature->extendedAttributes->{"CustomGetter"}
- || $attribute->signature->extendedAttributes->{"CustomSetter"}) {
</del><ins>+ || $attribute->signature->extendedAttributes->{"CustomGetter"}) {
</ins><span class="cx"> return 1;
</span><span class="cx"> }
</span><span class="cx">
</span><span class="lines">@@ -430,7 +429,8 @@
</span><span class="cx"> # FIXME: We are not generating setters for 'Replaceable'
</span><span class="cx"> # attributes now, but we should somehow.
</span><span class="cx"> my $replaceable = $property->signature->extendedAttributes->{"Replaceable"};
</span><del>- if (!$property->isReadOnly && $hasGtypeSignature && !$replaceable) {
</del><ins>+ my $custom = $property->signature->extendedAttributes->{"CustomSetter"};
+ if (!$property->isReadOnly && $hasGtypeSignature && !$replaceable && !$custom) {
</ins><span class="cx"> push(@result, $property);
</span><span class="cx"> }
</span><span class="cx"> }
</span><span class="lines">@@ -500,12 +500,10 @@
</span><span class="cx"> my $writeable = !$attribute->isReadOnly;
</span><span class="cx">
</span><span class="cx"> my $mutableString = "read-only";
</span><del>- my $custom = $attribute->signature->extendedAttributes->{"Custom"};
- if ($writeable && $custom) {
</del><ins>+ my $hasCustomSetter = $attribute->signature->extendedAttributes->{"CustomSetter"};
+ if ($writeable && $hasCustomSetter) {
</ins><span class="cx"> $mutableStringconst = "read-only (due to custom functions needed in webkitdom)";
</span><del>- return;
- }
- if ($writeable && !$custom) {
</del><ins>+ } elsif ($writeable) {
</ins><span class="cx"> $gparamflag = "WEBKIT_PARAM_READWRITE";
</span><span class="cx"> $mutableStringconst = "read-write";
</span><span class="cx"> }
</span><span class="lines">@@ -1303,7 +1301,8 @@
</span><span class="cx">
</span><span class="cx"> # FIXME: We are not generating setters for 'Replaceable'
</span><span class="cx"> # attributes now, but we should somehow.
</span><del>- if ($attribute->isReadOnly || $attribute->signature->extendedAttributes->{"Replaceable"}) {
</del><ins>+ my $custom = $attribute->signature->extendedAttributes->{"CustomSetter"};
+ if ($attribute->isReadOnly || $attribute->signature->extendedAttributes->{"Replaceable"} || $custom) {
</ins><span class="cx"> next TOP;
</span><span class="cx"> }
</span><span class="cx">
</span></span></pre>
</div>
</div>
</body>
</html>