<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[160224] trunk/Source/WebCore</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/160224">160224</a></dd>
<dt>Author</dt> <dd>akling@apple.com</dd>
<dt>Date</dt> <dd>2013-12-06 09:40:29 -0800 (Fri, 06 Dec 2013)</dd>
</dl>
<h3>Log Message</h3>
<pre>Make remaining CSSValue constructors return PassRef.
<https://webkit.org/b/125337>
Tweak the remaining CSSValue create() helpers to return PassRef
instead of PassRefPtr in the cases where nullptr is never returned.
Reviewed by Anders Carlsson.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkSourceWebCoreChangeLog">trunk/Source/WebCore/ChangeLog</a></li>
<li><a href="#trunkSourceWebCorecssCSSBorderImageSliceValueh">trunk/Source/WebCore/css/CSSBorderImageSliceValue.h</a></li>
<li><a href="#trunkSourceWebCorecssCSSCalculationValuecpp">trunk/Source/WebCore/css/CSSCalculationValue.cpp</a></li>
<li><a href="#trunkSourceWebCorecssCSSCalculationValueh">trunk/Source/WebCore/css/CSSCalculationValue.h</a></li>
<li><a href="#trunkSourceWebCorecssCSSCrossfadeValueh">trunk/Source/WebCore/css/CSSCrossfadeValue.h</a></li>
<li><a href="#trunkSourceWebCorecssCSSFilterImageValueh">trunk/Source/WebCore/css/CSSFilterImageValue.h</a></li>
<li><a href="#trunkSourceWebCorecssCSSGradientValueh">trunk/Source/WebCore/css/CSSGradientValue.h</a></li>
<li><a href="#trunkSourceWebCorecssCSSGridTemplateValueh">trunk/Source/WebCore/css/CSSGridTemplateValue.h</a></li>
<li><a href="#trunkSourceWebCorecssCSSPrimitiveValuecpp">trunk/Source/WebCore/css/CSSPrimitiveValue.cpp</a></li>
<li><a href="#trunkSourceWebCorecssCSSTimingFunctionValueh">trunk/Source/WebCore/css/CSSTimingFunctionValue.h</a></li>
<li><a href="#trunkSourceWebCorecssCSSValuecpp">trunk/Source/WebCore/css/CSSValue.cpp</a></li>
<li><a href="#trunkSourceWebCorecssWebKitCSSSVGDocumentValueh">trunk/Source/WebCore/css/WebKitCSSSVGDocumentValue.h</a></li>
<li><a href="#trunkSourceWebCoresvgSVGColorh">trunk/Source/WebCore/svg/SVGColor.h</a></li>
<li><a href="#trunkSourceWebCoresvgSVGPainth">trunk/Source/WebCore/svg/SVGPaint.h</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkSourceWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/ChangeLog (160223 => 160224)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/ChangeLog 2013-12-06 17:28:44 UTC (rev 160223)
+++ trunk/Source/WebCore/ChangeLog 2013-12-06 17:40:29 UTC (rev 160224)
</span><span class="lines">@@ -1,3 +1,13 @@
</span><ins>+2013-12-06 Andreas Kling <akling@apple.com>
+
+ Make remaining CSSValue constructors return PassRef.
+ <https://webkit.org/b/125337>
+
+ Tweak the remaining CSSValue create() helpers to return PassRef
+ instead of PassRefPtr in the cases where nullptr is never returned.
+
+ Reviewed by Anders Carlsson.
+
</ins><span class="cx"> 2013-12-06 Roger Fong <roger_fong@apple.com>
</span><span class="cx">
</span><span class="cx"> Hook into some shader symbol logic following the ANGLE update in r159533.
</span></span></pre></div>
<a id="trunkSourceWebCorecssCSSBorderImageSliceValueh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/css/CSSBorderImageSliceValue.h (160223 => 160224)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/css/CSSBorderImageSliceValue.h 2013-12-06 17:28:44 UTC (rev 160223)
+++ trunk/Source/WebCore/css/CSSBorderImageSliceValue.h 2013-12-06 17:40:29 UTC (rev 160224)
</span><span class="lines">@@ -36,9 +36,9 @@
</span><span class="cx">
</span><span class="cx"> class CSSBorderImageSliceValue : public CSSValue {
</span><span class="cx"> public:
</span><del>- static PassRefPtr<CSSBorderImageSliceValue> create(PassRefPtr<CSSPrimitiveValue> slices, bool fill)
</del><ins>+ static PassRef<CSSBorderImageSliceValue> create(PassRefPtr<CSSPrimitiveValue> slices, bool fill)
</ins><span class="cx"> {
</span><del>- return adoptRef(new CSSBorderImageSliceValue(slices, fill));
</del><ins>+ return adoptRef(*new CSSBorderImageSliceValue(slices, fill));
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> String customCSSText() const;
</span></span></pre></div>
<a id="trunkSourceWebCorecssCSSCalculationValuecpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/css/CSSCalculationValue.cpp (160223 => 160224)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/css/CSSCalculationValue.cpp 2013-12-06 17:28:44 UTC (rev 160223)
+++ trunk/Source/WebCore/css/CSSCalculationValue.cpp 2013-12-06 17:40:29 UTC (rev 160224)
</span><span class="lines">@@ -750,9 +750,9 @@
</span><span class="cx"> return expression ? adoptRef(new CSSCalcValue(expression, range)) : 0;
</span><span class="cx"> }
</span><span class="cx">
</span><del>-PassRefPtr<CSSCalcValue> CSSCalcValue::create(PassRefPtr<CSSCalcExpressionNode> expression, CalculationPermittedValueRange range)
</del><ins>+PassRef<CSSCalcValue> CSSCalcValue::create(PassRefPtr<CSSCalcExpressionNode> expression, CalculationPermittedValueRange range)
</ins><span class="cx"> {
</span><del>- return adoptRef(new CSSCalcValue(expression, range));
</del><ins>+ return adoptRef(*new CSSCalcValue(expression, range));
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> } // namespace WebCore
</span></span></pre></div>
<a id="trunkSourceWebCorecssCSSCalculationValueh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/css/CSSCalculationValue.h (160223 => 160224)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/css/CSSCalculationValue.h 2013-12-06 17:28:44 UTC (rev 160223)
+++ trunk/Source/WebCore/css/CSSCalculationValue.h 2013-12-06 17:40:29 UTC (rev 160224)
</span><span class="lines">@@ -91,8 +91,8 @@
</span><span class="cx"> class CSSCalcValue : public CSSValue {
</span><span class="cx"> public:
</span><span class="cx"> static PassRefPtr<CSSCalcValue> create(CSSParserString name, CSSParserValueList*, CalculationPermittedValueRange);
</span><del>- static PassRefPtr<CSSCalcValue> create(PassRefPtr<CSSCalcExpressionNode>, CalculationPermittedValueRange = CalculationRangeAll);
- static PassRefPtr<CSSCalcValue> create(const CalculationValue* value, const RenderStyle* style) { return adoptRef(new CSSCalcValue(value, style)); }
</del><ins>+ static PassRef<CSSCalcValue> create(PassRefPtr<CSSCalcExpressionNode>, CalculationPermittedValueRange = CalculationRangeAll);
+ static PassRef<CSSCalcValue> create(const CalculationValue* value, const RenderStyle* style) { return adoptRef(*new CSSCalcValue(value, style)); }
</ins><span class="cx">
</span><span class="cx"> static PassRefPtr<CSSCalcExpressionNode> createExpressionNode(PassRefPtr<CSSPrimitiveValue>, bool isInteger = false);
</span><span class="cx"> static PassRefPtr<CSSCalcExpressionNode> createExpressionNode(PassRefPtr<CSSCalcExpressionNode>, PassRefPtr<CSSCalcExpressionNode>, CalcOperator);
</span></span></pre></div>
<a id="trunkSourceWebCorecssCSSCrossfadeValueh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/css/CSSCrossfadeValue.h (160223 => 160224)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/css/CSSCrossfadeValue.h 2013-12-06 17:28:44 UTC (rev 160223)
+++ trunk/Source/WebCore/css/CSSCrossfadeValue.h 2013-12-06 17:40:29 UTC (rev 160224)
</span><span class="lines">@@ -43,9 +43,9 @@
</span><span class="cx"> class CSSCrossfadeValue : public CSSImageGeneratorValue {
</span><span class="cx"> friend class CrossfadeSubimageObserverProxy;
</span><span class="cx"> public:
</span><del>- static PassRefPtr<CSSCrossfadeValue> create(PassRefPtr<CSSValue> fromValue, PassRefPtr<CSSValue> toValue)
</del><ins>+ static PassRef<CSSCrossfadeValue> create(PassRefPtr<CSSValue> fromValue, PassRefPtr<CSSValue> toValue)
</ins><span class="cx"> {
</span><del>- return adoptRef(new CSSCrossfadeValue(fromValue, toValue));
</del><ins>+ return adoptRef(*new CSSCrossfadeValue(fromValue, toValue));
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> ~CSSCrossfadeValue();
</span></span></pre></div>
<a id="trunkSourceWebCorecssCSSFilterImageValueh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/css/CSSFilterImageValue.h (160223 => 160224)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/css/CSSFilterImageValue.h 2013-12-06 17:28:44 UTC (rev 160223)
+++ trunk/Source/WebCore/css/CSSFilterImageValue.h 2013-12-06 17:40:29 UTC (rev 160224)
</span><span class="lines">@@ -48,9 +48,9 @@
</span><span class="cx"> class CSSFilterImageValue : public CSSImageGeneratorValue {
</span><span class="cx"> friend class FilterSubimageObserverProxy;
</span><span class="cx"> public:
</span><del>- static PassRefPtr<CSSFilterImageValue> create(PassRefPtr<CSSValue> imageValue, PassRefPtr<CSSValue> filterValue)
</del><ins>+ static PassRef<CSSFilterImageValue> create(PassRefPtr<CSSValue> imageValue, PassRefPtr<CSSValue> filterValue)
</ins><span class="cx"> {
</span><del>- return adoptRef(new CSSFilterImageValue(imageValue, filterValue));
</del><ins>+ return adoptRef(*new CSSFilterImageValue(imageValue, filterValue));
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> ~CSSFilterImageValue();
</span></span></pre></div>
<a id="trunkSourceWebCorecssCSSGradientValueh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/css/CSSGradientValue.h (160223 => 160224)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/css/CSSGradientValue.h 2013-12-06 17:28:44 UTC (rev 160223)
+++ trunk/Source/WebCore/css/CSSGradientValue.h 2013-12-06 17:40:29 UTC (rev 160224)
</span><span class="lines">@@ -135,9 +135,9 @@
</span><span class="cx"> class CSSLinearGradientValue : public CSSGradientValue {
</span><span class="cx"> public:
</span><span class="cx">
</span><del>- static PassRefPtr<CSSLinearGradientValue> create(CSSGradientRepeat repeat, CSSGradientType gradientType = CSSLinearGradient)
</del><ins>+ static PassRef<CSSLinearGradientValue> create(CSSGradientRepeat repeat, CSSGradientType gradientType = CSSLinearGradient)
</ins><span class="cx"> {
</span><del>- return adoptRef(new CSSLinearGradientValue(repeat, gradientType));
</del><ins>+ return adoptRef(*new CSSLinearGradientValue(repeat, gradientType));
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> void setAngle(PassRefPtr<CSSPrimitiveValue> val) { m_angle = val; }
</span><span class="lines">@@ -147,9 +147,9 @@
</span><span class="cx"> // Create the gradient for a given size.
</span><span class="cx"> PassRefPtr<Gradient> createGradient(RenderElement*, const IntSize&);
</span><span class="cx">
</span><del>- PassRefPtr<CSSLinearGradientValue> clone() const
</del><ins>+ PassRef<CSSLinearGradientValue> clone() const
</ins><span class="cx"> {
</span><del>- return adoptRef(new CSSLinearGradientValue(*this));
</del><ins>+ return adoptRef(*new CSSLinearGradientValue(*this));
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> bool equals(const CSSLinearGradientValue&) const;
</span><span class="lines">@@ -173,14 +173,14 @@
</span><span class="cx">
</span><span class="cx"> class CSSRadialGradientValue : public CSSGradientValue {
</span><span class="cx"> public:
</span><del>- static PassRefPtr<CSSRadialGradientValue> create(CSSGradientRepeat repeat, CSSGradientType gradientType = CSSRadialGradient)
</del><ins>+ static PassRef<CSSRadialGradientValue> create(CSSGradientRepeat repeat, CSSGradientType gradientType = CSSRadialGradient)
</ins><span class="cx"> {
</span><del>- return adoptRef(new CSSRadialGradientValue(repeat, gradientType));
</del><ins>+ return adoptRef(*new CSSRadialGradientValue(repeat, gradientType));
</ins><span class="cx"> }
</span><span class="cx">
</span><del>- PassRefPtr<CSSRadialGradientValue> clone() const
</del><ins>+ PassRef<CSSRadialGradientValue> clone() const
</ins><span class="cx"> {
</span><del>- return adoptRef(new CSSRadialGradientValue(*this));
</del><ins>+ return adoptRef(*new CSSRadialGradientValue(*this));
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> String customCSSText() const;
</span></span></pre></div>
<a id="trunkSourceWebCorecssCSSGridTemplateValueh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/css/CSSGridTemplateValue.h (160223 => 160224)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/css/CSSGridTemplateValue.h 2013-12-06 17:28:44 UTC (rev 160223)
+++ trunk/Source/WebCore/css/CSSGridTemplateValue.h 2013-12-06 17:40:29 UTC (rev 160224)
</span><span class="lines">@@ -39,7 +39,11 @@
</span><span class="cx">
</span><span class="cx"> class CSSGridTemplateValue : public CSSValue {
</span><span class="cx"> public:
</span><del>- static PassRefPtr<CSSGridTemplateValue> create(const NamedGridAreaMap& gridAreaMap, size_t rowCount, size_t columnCount) { return adoptRef(new CSSGridTemplateValue(gridAreaMap, rowCount, columnCount)); }
</del><ins>+ static PassRef<CSSGridTemplateValue> create(const NamedGridAreaMap& gridAreaMap, size_t rowCount, size_t columnCount)
+ {
+ return adoptRef(*new CSSGridTemplateValue(gridAreaMap, rowCount, columnCount));
+ }
+
</ins><span class="cx"> ~CSSGridTemplateValue() { }
</span><span class="cx">
</span><span class="cx"> String customCSSText() const;
</span></span></pre></div>
<a id="trunkSourceWebCorecssCSSPrimitiveValuecpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/css/CSSPrimitiveValue.cpp (160223 => 160224)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/css/CSSPrimitiveValue.cpp 2013-12-06 17:28:44 UTC (rev 160223)
+++ trunk/Source/WebCore/css/CSSPrimitiveValue.cpp 2013-12-06 17:40:29 UTC (rev 160224)
</span><span class="lines">@@ -303,9 +303,11 @@
</span><span class="cx"> m_primitiveUnitType = CSS_PX;
</span><span class="cx"> m_value.num = adjustFloatForAbsoluteZoom(length.value(), style);
</span><span class="cx"> return;
</span><del>- case Calculated:
- init(CSSCalcValue::create(length.calculationValue().get(), style));
</del><ins>+ case Calculated: {
+ RefPtr<CSSCalcValue> calcValue = CSSCalcValue::create(length.calculationValue().get(), style);
+ init(calcValue.release());
</ins><span class="cx"> return;
</span><ins>+ }
</ins><span class="cx"> case Relative:
</span><span class="cx"> case Undefined:
</span><span class="cx"> ASSERT_NOT_REACHED();
</span></span></pre></div>
<a id="trunkSourceWebCorecssCSSTimingFunctionValueh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/css/CSSTimingFunctionValue.h (160223 => 160224)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/css/CSSTimingFunctionValue.h 2013-12-06 17:28:44 UTC (rev 160223)
+++ trunk/Source/WebCore/css/CSSTimingFunctionValue.h 2013-12-06 17:40:29 UTC (rev 160224)
</span><span class="lines">@@ -33,9 +33,9 @@
</span><span class="cx">
</span><span class="cx"> class CSSCubicBezierTimingFunctionValue : public CSSValue {
</span><span class="cx"> public:
</span><del>- static PassRefPtr<CSSCubicBezierTimingFunctionValue> create(double x1, double y1, double x2, double y2)
</del><ins>+ static PassRef<CSSCubicBezierTimingFunctionValue> create(double x1, double y1, double x2, double y2)
</ins><span class="cx"> {
</span><del>- return adoptRef(new CSSCubicBezierTimingFunctionValue(x1, y1, x2, y2));
</del><ins>+ return adoptRef(*new CSSCubicBezierTimingFunctionValue(x1, y1, x2, y2));
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> String customCSSText() const;
</span><span class="lines">@@ -67,9 +67,9 @@
</span><span class="cx">
</span><span class="cx"> class CSSStepsTimingFunctionValue : public CSSValue {
</span><span class="cx"> public:
</span><del>- static PassRefPtr<CSSStepsTimingFunctionValue> create(int steps, bool stepAtStart)
</del><ins>+ static PassRef<CSSStepsTimingFunctionValue> create(int steps, bool stepAtStart)
</ins><span class="cx"> {
</span><del>- return adoptRef(new CSSStepsTimingFunctionValue(steps, stepAtStart));
</del><ins>+ return adoptRef(*new CSSStepsTimingFunctionValue(steps, stepAtStart));
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> int numberOfSteps() const { return m_steps; }
</span></span></pre></div>
<a id="trunkSourceWebCorecssCSSValuecpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/css/CSSValue.cpp (160223 => 160224)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/css/CSSValue.cpp 2013-12-06 17:28:44 UTC (rev 160223)
+++ trunk/Source/WebCore/css/CSSValue.cpp 2013-12-06 17:40:29 UTC (rev 160224)
</span><span class="lines">@@ -76,7 +76,10 @@
</span><span class="cx">
</span><span class="cx"> class TextCloneCSSValue : public CSSValue {
</span><span class="cx"> public:
</span><del>- static PassRefPtr<TextCloneCSSValue> create(ClassType classType, const String& text) { return adoptRef(new TextCloneCSSValue(classType, text)); }
</del><ins>+ static PassRef<TextCloneCSSValue> create(ClassType classType, const String& text)
+ {
+ return adoptRef(*new TextCloneCSSValue(classType, text));
+ }
</ins><span class="cx">
</span><span class="cx"> String cssText() const { return m_cssText; }
</span><span class="cx">
</span></span></pre></div>
<a id="trunkSourceWebCorecssWebKitCSSSVGDocumentValueh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/css/WebKitCSSSVGDocumentValue.h (160223 => 160224)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/css/WebKitCSSSVGDocumentValue.h 2013-12-06 17:28:44 UTC (rev 160223)
+++ trunk/Source/WebCore/css/WebKitCSSSVGDocumentValue.h 2013-12-06 17:40:29 UTC (rev 160224)
</span><span class="lines">@@ -35,7 +35,10 @@
</span><span class="cx">
</span><span class="cx"> class WebKitCSSSVGDocumentValue : public CSSValue {
</span><span class="cx"> public:
</span><del>- static PassRefPtr<WebKitCSSSVGDocumentValue> create(const String& url) { return adoptRef(new WebKitCSSSVGDocumentValue(url)); }
</del><ins>+ static PassRef<WebKitCSSSVGDocumentValue> create(const String& url)
+ {
+ return adoptRef(*new WebKitCSSSVGDocumentValue(url));
+ }
</ins><span class="cx"> ~WebKitCSSSVGDocumentValue();
</span><span class="cx">
</span><span class="cx"> CachedSVGDocument* cachedSVGDocument() const { return m_document.get(); }
</span></span></pre></div>
<a id="trunkSourceWebCoresvgSVGColorh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/svg/SVGColor.h (160223 => 160224)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/svg/SVGColor.h 2013-12-06 17:28:44 UTC (rev 160223)
+++ trunk/Source/WebCore/svg/SVGColor.h 2013-12-06 17:40:29 UTC (rev 160224)
</span><span class="lines">@@ -40,23 +40,23 @@
</span><span class="cx"> SVG_COLORTYPE_CURRENTCOLOR = 3
</span><span class="cx"> };
</span><span class="cx">
</span><del>- static PassRefPtr<SVGColor> createFromString(const String& rgbColor)
</del><ins>+ static PassRef<SVGColor> createFromString(const String& rgbColor)
</ins><span class="cx"> {
</span><del>- RefPtr<SVGColor> color = adoptRef(new SVGColor(SVG_COLORTYPE_RGBCOLOR));
- color->setColor(colorFromRGBColorString(rgbColor));
- return color.release();
</del><ins>+ auto color = adoptRef(*new SVGColor(SVG_COLORTYPE_RGBCOLOR));
+ color.get().setColor(colorFromRGBColorString(rgbColor));
+ return color;
</ins><span class="cx"> }
</span><span class="cx">
</span><del>- static PassRefPtr<SVGColor> createFromColor(const Color& rgbColor)
</del><ins>+ static PassRef<SVGColor> createFromColor(const Color& rgbColor)
</ins><span class="cx"> {
</span><del>- RefPtr<SVGColor> color = adoptRef(new SVGColor(SVG_COLORTYPE_RGBCOLOR));
- color->setColor(rgbColor);
- return color.release();
</del><ins>+ auto color = adoptRef(*new SVGColor(SVG_COLORTYPE_RGBCOLOR));
+ color.get().setColor(rgbColor);
+ return color;
</ins><span class="cx"> }
</span><span class="cx">
</span><del>- static PassRefPtr<SVGColor> createCurrentColor()
</del><ins>+ static PassRef<SVGColor> createCurrentColor()
</ins><span class="cx"> {
</span><del>- return adoptRef(new SVGColor(SVG_COLORTYPE_CURRENTCOLOR));
</del><ins>+ return adoptRef(*new SVGColor(SVG_COLORTYPE_CURRENTCOLOR));
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> const Color& color() const { return m_color; }
</span></span></pre></div>
<a id="trunkSourceWebCoresvgSVGPainth"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/svg/SVGPaint.h (160223 => 160224)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/svg/SVGPaint.h 2013-12-06 17:28:44 UTC (rev 160223)
+++ trunk/Source/WebCore/svg/SVGPaint.h 2013-12-06 17:40:29 UTC (rev 160224)
</span><span class="lines">@@ -44,45 +44,43 @@
</span><span class="cx"> SVG_PAINTTYPE_URI = 107
</span><span class="cx"> };
</span><span class="cx">
</span><del>- static PassRefPtr<SVGPaint> createUnknown()
</del><ins>+ static PassRef<SVGPaint> createUnknown()
</ins><span class="cx"> {
</span><del>- return adoptRef(new SVGPaint(SVG_PAINTTYPE_UNKNOWN));
</del><ins>+ return adoptRef(*new SVGPaint(SVG_PAINTTYPE_UNKNOWN));
</ins><span class="cx"> }
</span><span class="cx">
</span><del>- static PassRefPtr<SVGPaint> createNone()
</del><ins>+ static PassRef<SVGPaint> createNone()
</ins><span class="cx"> {
</span><del>- return adoptRef(new SVGPaint(SVG_PAINTTYPE_NONE));
</del><ins>+ return adoptRef(*new SVGPaint(SVG_PAINTTYPE_NONE));
</ins><span class="cx"> }
</span><span class="cx">
</span><del>- static PassRefPtr<SVGPaint> createCurrentColor()
</del><ins>+ static PassRef<SVGPaint> createCurrentColor()
</ins><span class="cx"> {
</span><del>- return adoptRef(new SVGPaint(SVG_PAINTTYPE_CURRENTCOLOR));
</del><ins>+ return adoptRef(*new SVGPaint(SVG_PAINTTYPE_CURRENTCOLOR));
</ins><span class="cx"> }
</span><span class="cx">
</span><del>- static PassRefPtr<SVGPaint> createColor(const Color& color)
</del><ins>+ static PassRef<SVGPaint> createColor(const Color& color)
</ins><span class="cx"> {
</span><del>- RefPtr<SVGPaint> paint = adoptRef(new SVGPaint(SVG_PAINTTYPE_RGBCOLOR));
- paint->setColor(color);
- return paint.release();
</del><ins>+ auto paint = adoptRef(*new SVGPaint(SVG_PAINTTYPE_RGBCOLOR));
+ paint.get().setColor(color);
+ return paint;
</ins><span class="cx"> }
</span><span class="cx">
</span><del>- static PassRefPtr<SVGPaint> createURI(const String& uri)
</del><ins>+ static PassRef<SVGPaint> createURI(const String& uri)
</ins><span class="cx"> {
</span><del>- RefPtr<SVGPaint> paint = adoptRef(new SVGPaint(SVG_PAINTTYPE_URI, uri));
- return paint.release();
</del><ins>+ return adoptRef(*new SVGPaint(SVG_PAINTTYPE_URI, uri));
</ins><span class="cx"> }
</span><span class="cx">
</span><del>- static PassRefPtr<SVGPaint> createURIAndColor(const String& uri, const Color& color)
</del><ins>+ static PassRef<SVGPaint> createURIAndColor(const String& uri, const Color& color)
</ins><span class="cx"> {
</span><del>- RefPtr<SVGPaint> paint = adoptRef(new SVGPaint(SVG_PAINTTYPE_URI_RGBCOLOR, uri));
- paint->setColor(color);
- return paint.release();
</del><ins>+ auto paint = adoptRef(*new SVGPaint(SVG_PAINTTYPE_URI_RGBCOLOR, uri));
+ paint.get().setColor(color);
+ return paint;
</ins><span class="cx"> }
</span><span class="cx">
</span><del>- static PassRefPtr<SVGPaint> createURIAndNone(const String& uri)
</del><ins>+ static PassRef<SVGPaint> createURIAndNone(const String& uri)
</ins><span class="cx"> {
</span><del>- RefPtr<SVGPaint> paint = adoptRef(new SVGPaint(SVG_PAINTTYPE_URI_NONE, uri));
- return paint.release();
</del><ins>+ return adoptRef(*new SVGPaint(SVG_PAINTTYPE_URI_NONE, uri));
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> const SVGPaintType& paintType() const { return m_paintType; }
</span><span class="lines">@@ -100,11 +98,11 @@
</span><span class="cx"> private:
</span><span class="cx"> friend class ComputedStyleExtractor;
</span><span class="cx">
</span><del>- static PassRefPtr<SVGPaint> create(const SVGPaintType& type, const String& uri, const Color& color)
</del><ins>+ static PassRef<SVGPaint> create(const SVGPaintType& type, const String& uri, const Color& color)
</ins><span class="cx"> {
</span><del>- RefPtr<SVGPaint> paint = adoptRef(new SVGPaint(type, uri));
- paint->setColor(color);
- return paint.release();
</del><ins>+ auto paint = adoptRef(*new SVGPaint(type, uri));
+ paint.get().setColor(color);
+ return paint;
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> private:
</span></span></pre>
</div>
</div>
</body>
</html>