<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[160100] trunk/Source/JavaScriptCore</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/160100">160100</a></dd>
<dt>Author</dt> <dd>commit-queue@webkit.org</dd>
<dt>Date</dt> <dd>2013-12-04 10:30:49 -0800 (Wed, 04 Dec 2013)</dd>
</dl>
<h3>Log Message</h3>
<pre>REGRESSION (<a href="http://trac.webkit.org/projects/webkit/changeset/160094">r160094</a>): Fix lots of crashes for sh4 architecture.
https://bugs.webkit.org/show_bug.cgi?id=125227
Patch by Julien Brianceau <jbriance@cisco.com> on 2013-12-04
Reviewed by Michael Saboff.
* llint/LowLevelInterpreter32_64.asm: Do not use t4 and t5 as they match a0 and a1.
* offlineasm/registers.rb: Add t7, t8 and t9 in register list for sh4 port.
* offlineasm/sh4.rb: Rearrange RegisterID list and add the missing ones.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkSourceJavaScriptCoreChangeLog">trunk/Source/JavaScriptCore/ChangeLog</a></li>
<li><a href="#trunkSourceJavaScriptCorellintLowLevelInterpreter32_64asm">trunk/Source/JavaScriptCore/llint/LowLevelInterpreter32_64.asm</a></li>
<li><a href="#trunkSourceJavaScriptCoreofflineasmregistersrb">trunk/Source/JavaScriptCore/offlineasm/registers.rb</a></li>
<li><a href="#trunkSourceJavaScriptCoreofflineasmsh4rb">trunk/Source/JavaScriptCore/offlineasm/sh4.rb</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkSourceJavaScriptCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/JavaScriptCore/ChangeLog (160099 => 160100)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/JavaScriptCore/ChangeLog        2013-12-04 18:20:37 UTC (rev 160099)
+++ trunk/Source/JavaScriptCore/ChangeLog        2013-12-04 18:30:49 UTC (rev 160100)
</span><span class="lines">@@ -1,3 +1,14 @@
</span><ins>+2013-12-04 Julien Brianceau <jbriance@cisco.com>
+
+ REGRESSION (r160094): Fix lots of crashes for sh4 architecture.
+ https://bugs.webkit.org/show_bug.cgi?id=125227
+
+ Reviewed by Michael Saboff.
+
+ * llint/LowLevelInterpreter32_64.asm: Do not use t4 and t5 as they match a0 and a1.
+ * offlineasm/registers.rb: Add t7, t8 and t9 in register list for sh4 port.
+ * offlineasm/sh4.rb: Rearrange RegisterID list and add the missing ones.
+
</ins><span class="cx"> 2013-12-03 Joseph Pecoraro <pecoraro@apple.com>
</span><span class="cx">
</span><span class="cx"> Web Inspector: Push Remote Inspector debugging connection management into JavaScriptCore
</span></span></pre></div>
<a id="trunkSourceJavaScriptCorellintLowLevelInterpreter32_64asm"></a>
<div class="modfile"><h4>Modified: trunk/Source/JavaScriptCore/llint/LowLevelInterpreter32_64.asm (160099 => 160100)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/JavaScriptCore/llint/LowLevelInterpreter32_64.asm        2013-12-04 18:20:37 UTC (rev 160099)
+++ trunk/Source/JavaScriptCore/llint/LowLevelInterpreter32_64.asm        2013-12-04 18:30:49 UTC (rev 160100)
</span><span class="lines">@@ -233,8 +233,8 @@
</span><span class="cx"> const previousPC = lr
</span><span class="cx"> const temp1 = t3 # Same as previousCFR
</span><span class="cx"> const temp2 = a3 # Same as topOfStack
</span><del>- const temp3 = t4
- const temp4 = t5
</del><ins>+ const temp3 = t8
+ const temp4 = t9
</ins><span class="cx"> end
</span><span class="cx">
</span><span class="cx"> if X86
</span></span></pre></div>
<a id="trunkSourceJavaScriptCoreofflineasmregistersrb"></a>
<div class="modfile"><h4>Modified: trunk/Source/JavaScriptCore/offlineasm/registers.rb (160099 => 160100)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/JavaScriptCore/offlineasm/registers.rb        2013-12-04 18:20:37 UTC (rev 160099)
+++ trunk/Source/JavaScriptCore/offlineasm/registers.rb        2013-12-04 18:30:49 UTC (rev 160100)
</span><span class="lines">@@ -31,6 +31,10 @@
</span><span class="cx"> "t3",
</span><span class="cx"> "t4",
</span><span class="cx"> "t5",
</span><ins>+ "t6",
+ "t7",
+ "t8",
+ "t9",
</ins><span class="cx"> "cfr",
</span><span class="cx"> "a0",
</span><span class="cx"> "a1",
</span><span class="lines">@@ -42,7 +46,6 @@
</span><span class="cx"> "lr",
</span><span class="cx">
</span><span class="cx"> # 64-bit only registers:
</span><del>- "t6",
</del><span class="cx"> "csr1", # tag type number register
</span><span class="cx"> "csr2" # tag mask register
</span><span class="cx"> ]
</span></span></pre></div>
<a id="trunkSourceJavaScriptCoreofflineasmsh4rb"></a>
<div class="modfile"><h4>Modified: trunk/Source/JavaScriptCore/offlineasm/sh4.rb (160099 => 160100)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/JavaScriptCore/offlineasm/sh4.rb        2013-12-04 18:20:37 UTC (rev 160099)
+++ trunk/Source/JavaScriptCore/offlineasm/sh4.rb        2013-12-04 18:30:49 UTC (rev 160100)
</span><span class="lines">@@ -57,14 +57,6 @@
</span><span class="cx"> class RegisterID
</span><span class="cx"> def sh4Operand
</span><span class="cx"> case name
</span><del>- when "a0"
- "r4"
- when "a1"
- "r5"
- when "a2"
- "r6"
- when "a3"
- "r7"
</del><span class="cx"> when "t0"
</span><span class="cx"> "r0"
</span><span class="cx"> when "t1"
</span><span class="lines">@@ -73,10 +65,18 @@
</span><span class="cx"> "r2"
</span><span class="cx"> when "t3"
</span><span class="cx"> "r10"
</span><del>- when "t4"
</del><ins>+ when "t4", "a0"
</ins><span class="cx"> "r4"
</span><del>- when "t5"
</del><ins>+ when "t5", "a1"
</ins><span class="cx"> "r5"
</span><ins>+ when "t6", "a2"
+ "r6"
+ when "t7", "a3"
+ "r7"
+ when "t8"
+ "r8"
+ when "t9"
+ "r9"
</ins><span class="cx"> when "cfr"
</span><span class="cx"> "r14"
</span><span class="cx"> when "sp"
</span></span></pre>
</div>
</div>
</body>
</html>