<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[160160] trunk/LayoutTests</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/160160">160160</a></dd>
<dt>Author</dt> <dd>samuel_white@apple.com</dd>
<dt>Date</dt> <dd>2013-12-04 22:44:39 -0800 (Wed, 04 Dec 2013)</dd>
</dl>
<h3>Log Message</h3>
<pre>Layout Test platform/mac/accessibility/search-predicate-element-count.html is flaky
https://bugs.webkit.org/show_bug.cgi?id=125195
Reviewed by Chris Fleizach.
Our test checks for AccessibilityObject::isOnscreen which makes sure an element is currently scrolled to a visible
location onscreen. This test was flaky because sometimes elements we thought would be visible weren't. To resolve
this I've moved the elements that are tested for visibility to the very top of the document so they have a tiny
vertical offset and will ALWAYS be visible.
* platform/mac/TestExpectations:
* platform/mac/accessibility/search-predicate-element-count-expected.txt:
* platform/mac/accessibility/search-predicate-element-count.html:</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkLayoutTestsChangeLog">trunk/LayoutTests/ChangeLog</a></li>
<li><a href="#trunkLayoutTestsplatformmacTestExpectations">trunk/LayoutTests/platform/mac/TestExpectations</a></li>
<li><a href="#trunkLayoutTestsplatformmacaccessibilitysearchpredicateelementcountexpectedtxt">trunk/LayoutTests/platform/mac/accessibility/search-predicate-element-count-expected.txt</a></li>
<li><a href="#trunkLayoutTestsplatformmacaccessibilitysearchpredicateelementcounthtml">trunk/LayoutTests/platform/mac/accessibility/search-predicate-element-count.html</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkLayoutTestsChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/ChangeLog (160159 => 160160)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/ChangeLog 2013-12-05 05:11:06 UTC (rev 160159)
+++ trunk/LayoutTests/ChangeLog 2013-12-05 06:44:39 UTC (rev 160160)
</span><span class="lines">@@ -1,3 +1,19 @@
</span><ins>+2013-12-04 Samuel White <samuel_white@apple.com>
+
+ Layout Test platform/mac/accessibility/search-predicate-element-count.html is flaky
+ https://bugs.webkit.org/show_bug.cgi?id=125195
+
+ Reviewed by Chris Fleizach.
+
+ Our test checks for AccessibilityObject::isOnscreen which makes sure an element is currently scrolled to a visible
+ location onscreen. This test was flaky because sometimes elements we thought would be visible weren't. To resolve
+ this I've moved the elements that are tested for visibility to the very top of the document so they have a tiny
+ vertical offset and will ALWAYS be visible.
+
+ * platform/mac/TestExpectations:
+ * platform/mac/accessibility/search-predicate-element-count-expected.txt:
+ * platform/mac/accessibility/search-predicate-element-count.html:
+
</ins><span class="cx"> 2013-12-04 Gurpreet Kaur <k.gurpreet@samsung.com>
</span><span class="cx">
</span><span class="cx"> % unit heights don't work if parent block height is set in vh
</span></span></pre></div>
<a id="trunkLayoutTestsplatformmacTestExpectations"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/platform/mac/TestExpectations (160159 => 160160)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/platform/mac/TestExpectations 2013-12-05 05:11:06 UTC (rev 160159)
+++ trunk/LayoutTests/platform/mac/TestExpectations 2013-12-05 06:44:39 UTC (rev 160160)
</span><span class="lines">@@ -1307,5 +1307,3 @@
</span><span class="cx"> webkit.org/b/124424 webgl/1.0.2/conformance/ogles/GL/tan/tan_001_to_006.html [ Pass Failure ]
</span><span class="cx">
</span><span class="cx"> webkit.org/b/124593 fast/forms/form-associated-element-crash.html [ Pass Timeout ]
</span><del>-
-webkit.org/b/125195 platform/mac/accessibility/search-predicate-element-count.html [ Pass Failure ]
</del></span></pre></div>
<a id="trunkLayoutTestsplatformmacaccessibilitysearchpredicateelementcountexpectedtxt"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/platform/mac/accessibility/search-predicate-element-count-expected.txt (160159 => 160160)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/platform/mac/accessibility/search-predicate-element-count-expected.txt 2013-12-05 05:11:06 UTC (rev 160159)
+++ trunk/LayoutTests/platform/mac/accessibility/search-predicate-element-count-expected.txt 2013-12-05 06:44:39 UTC (rev 160160)
</span><span class="lines">@@ -3,13 +3,13 @@
</span><span class="cx"> On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
</span><span class="cx">
</span><span class="cx">
</span><del>-PASS elementCount is 2
-PASS elementCount is 3
-PASS elementCount is 4
-PASS elementCount is 5
-PASS elementCount is 6
-PASS elementCount is 6
-PASS elementCount is 4
</del><ins>+PASS tableCount is 2
+PASS linkCount is 3
+PASS imageCount is 4
+PASS inputCount is 5
+PASS headingCount is 6
+PASS onscreenCount is 6
+PASS offscreenCount is 4
</ins><span class="cx"> PASS successfullyParsed is true
</span><span class="cx">
</span><span class="cx"> TEST COMPLETE
</span></span></pre></div>
<a id="trunkLayoutTestsplatformmacaccessibilitysearchpredicateelementcounthtml"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/platform/mac/accessibility/search-predicate-element-count.html (160159 => 160160)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/platform/mac/accessibility/search-predicate-element-count.html 2013-12-05 05:11:06 UTC (rev 160159)
+++ trunk/LayoutTests/platform/mac/accessibility/search-predicate-element-count.html 2013-12-05 06:44:39 UTC (rev 160160)
</span><span class="lines">@@ -14,6 +14,14 @@
</span><span class="cx">
</span><span class="cx"> <div id="container">
</span><span class="cx"> <p id="start">Start</p>
</span><ins>+<!-- Headings. -->
+<h1>Heading 1</h1>
+<h2>Heading 2</h2>
+<h3>Heading 3</h3>
+<h4>Heading 4</h4>
+<h5 class="offscreen">Heading 5</h5>
+<h6 class="offscreen">Heading 6</h6>
+<br>
</ins><span class="cx"> <!-- Tables. -->
</span><span class="cx"> <table border="1">
</span><span class="cx"> <tr><th>A</th><th>B</th></tr>
</span><span class="lines">@@ -41,14 +49,6 @@
</span><span class="cx"> <input type="submit" value="Submit">
</span><span class="cx"> <input type="submit" value="Submit">
</span><span class="cx"> <input type="submit" value="Submit">
</span><del>-<br>
-<!-- Headings. -->
-<h1>Heading 1</h1>
-<h2>Heading 2</h2>
-<h3>Heading 3</h3>
-<h4>Heading 4</h4>
-<h5 class="offscreen">Heading 5</h5>
-<h6 class="offscreen">Heading 6</h6>
</del><span class="cx"> </div>
</span><span class="cx">
</span><span class="cx"> <p id="description"></p>
</span><span class="lines">@@ -60,36 +60,35 @@
</span><span class="cx"> if (window.accessibilityController) {
</span><span class="cx"> document.getElementById("container").focus();
</span><span class="cx"> var containerElement = accessibilityController.focusedElement;
</span><del>- var elementCount = 0;
</del><span class="cx"> var startElement = accessibilityController.accessibleElementById("start");
</span><span class="cx">
</span><span class="cx"> // Tables.
</span><del>- elementCount = containerElement.uiElementCountForSearchPredicate(startElement, true, "AXTableSearchKey", "", false);
- shouldBe("elementCount", "2");
</del><ins>+ var tableCount = containerElement.uiElementCountForSearchPredicate(startElement, true, "AXTableSearchKey", "", false);
+ shouldBe("tableCount", "2");
</ins><span class="cx">
</span><span class="cx"> // Links.
</span><del>- elementCount = containerElement.uiElementCountForSearchPredicate(startElement, true, "AXLinkSearchKey", "", false);
- shouldBe("elementCount", "3");
</del><ins>+ var linkCount = containerElement.uiElementCountForSearchPredicate(startElement, true, "AXLinkSearchKey", "", false);
+ shouldBe("linkCount", "3");
</ins><span class="cx">
</span><span class="cx"> // Images.
</span><del>- elementCount = containerElement.uiElementCountForSearchPredicate(startElement, true, "AXGraphicSearchKey", "", false);
- shouldBe("elementCount", "4");
</del><ins>+ var imageCount = containerElement.uiElementCountForSearchPredicate(startElement, true, "AXGraphicSearchKey", "", false);
+ shouldBe("imageCount", "4");
</ins><span class="cx">
</span><span class="cx"> // Inputs.
</span><del>- elementCount = containerElement.uiElementCountForSearchPredicate(startElement, true, "AXButtonSearchKey", "", false);
- shouldBe("elementCount", "5");
</del><ins>+ var inputCount = containerElement.uiElementCountForSearchPredicate(startElement, true, "AXButtonSearchKey", "", false);
+ shouldBe("inputCount", "5");
</ins><span class="cx">
</span><span class="cx"> // Headings.
</span><del>- elementCount = containerElement.uiElementCountForSearchPredicate(startElement, true, "AXHeadingSearchKey", "", false);
- shouldBe("elementCount", "6");
</del><ins>+ var headingCount = containerElement.uiElementCountForSearchPredicate(startElement, true, "AXHeadingSearchKey", "", false);
+ shouldBe("headingCount", "6");
</ins><span class="cx">
</span><span class="cx"> // Onscreen
</span><del>- elementCount = containerElement.uiElementCountForSearchPredicate(startElement, true, "AXHeadingSearchKey", "", false);
- shouldBe("elementCount", "6");
</del><ins>+ var onscreenCount = containerElement.uiElementCountForSearchPredicate(startElement, true, "AXHeadingSearchKey", "", false);
+ shouldBe("onscreenCount", "6");
</ins><span class="cx">
</span><span class="cx"> // Offscreen
</span><del>- elementCount = containerElement.uiElementCountForSearchPredicate(startElement, true, "AXHeadingSearchKey", "", true);
- shouldBe("elementCount", "4");
</del><ins>+ var offscreenCount = containerElement.uiElementCountForSearchPredicate(startElement, true, "AXHeadingSearchKey", "", true);
+ shouldBe("offscreenCount", "4");
</ins><span class="cx">
</span><span class="cx"> // Hide superfluous text.
</span><span class="cx"> document.getElementById("container").style.display = "none";
</span></span></pre>
</div>
</div>
</body>
</html>