<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[160134] trunk/Source/WebInspectorUI</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/160134">160134</a></dd>
<dt>Author</dt> <dd>graouts@apple.com</dd>
<dt>Date</dt> <dd>2013-12-04 15:20:54 -0800 (Wed, 04 Dec 2013)</dd>
</dl>
<h3>Log Message</h3>
<pre>Web Inspector: "data detectors" menu on hover for actionable tokens
https://bugs.webkit.org/show_bug.cgi?id=124363
Reviewed by Timothy Hatcher.
Add a new WebInspector.HoverMenu class to display an overlay menu that is presented
with respect to a target frame that it draws itself around adding a customizable
action button to its right. The menu uses fade animations as it's presented and
dismissed and a single delegation method is fired when the button is pressed. Finally,
just like a popover, it automatically dismisses itself upon scrolling anywhere
outside of its bounds.
* UserInterface/HoverMenu.css: Added.
* UserInterface/HoverMenu.js: Added.
(WebInspector.HoverMenu):
(WebInspector.HoverMenu.prototype.get element):
(WebInspector.HoverMenu.prototype.dismiss):
(WebInspector.HoverMenu.prototype.handleEvent):
(WebInspector.HoverMenu.prototype._handleClickEvent):
* UserInterface/Images/HoverMenuButton.png: Added.
* UserInterface/Images/HoverMenuButton@2x.png: Added.
* UserInterface/Main.html:</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkSourceWebInspectorUIChangeLog">trunk/Source/WebInspectorUI/ChangeLog</a></li>
<li><a href="#trunkSourceWebInspectorUIUserInterfaceMainhtml">trunk/Source/WebInspectorUI/UserInterface/Main.html</a></li>
</ul>
<h3>Added Paths</h3>
<ul>
<li><a href="#trunkSourceWebInspectorUIUserInterfaceHoverMenucss">trunk/Source/WebInspectorUI/UserInterface/HoverMenu.css</a></li>
<li><a href="#trunkSourceWebInspectorUIUserInterfaceHoverMenujs">trunk/Source/WebInspectorUI/UserInterface/HoverMenu.js</a></li>
<li><a href="#trunkSourceWebInspectorUIUserInterfaceImagesHoverMenuButtonpng">trunk/Source/WebInspectorUI/UserInterface/Images/HoverMenuButton.png</a></li>
<li><a href="#trunkSourceWebInspectorUIUserInterfaceImagesHoverMenuButton2xpng">trunk/Source/WebInspectorUI/UserInterface/Images/HoverMenuButton@2x.png</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkSourceWebInspectorUIChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebInspectorUI/ChangeLog (160133 => 160134)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebInspectorUI/ChangeLog        2013-12-04 23:20:48 UTC (rev 160133)
+++ trunk/Source/WebInspectorUI/ChangeLog        2013-12-04 23:20:54 UTC (rev 160134)
</span><span class="lines">@@ -1,5 +1,30 @@
</span><span class="cx"> 2013-12-04 Antoine Quint <graouts@apple.com>
</span><span class="cx">
</span><ins>+ Web Inspector: "data detectors" menu on hover for actionable tokens
+ https://bugs.webkit.org/show_bug.cgi?id=124363
+
+ Reviewed by Timothy Hatcher.
+
+ Add a new WebInspector.HoverMenu class to display an overlay menu that is presented
+ with respect to a target frame that it draws itself around adding a customizable
+ action button to its right. The menu uses fade animations as it's presented and
+ dismissed and a single delegation method is fired when the button is pressed. Finally,
+ just like a popover, it automatically dismisses itself upon scrolling anywhere
+ outside of its bounds.
+
+ * UserInterface/HoverMenu.css: Added.
+ * UserInterface/HoverMenu.js: Added.
+ (WebInspector.HoverMenu):
+ (WebInspector.HoverMenu.prototype.get element):
+ (WebInspector.HoverMenu.prototype.dismiss):
+ (WebInspector.HoverMenu.prototype.handleEvent):
+ (WebInspector.HoverMenu.prototype._handleClickEvent):
+ * UserInterface/Images/HoverMenuButton.png: Added.
+ * UserInterface/Images/HoverMenuButton@2x.png: Added.
+ * UserInterface/Main.html:
+
+2013-12-04 Antoine Quint <graouts@apple.com>
+
</ins><span class="cx"> Web Inspector: edited color should serialize back to original format when possible
</span><span class="cx"> https://bugs.webkit.org/show_bug.cgi?id=125244
</span><span class="cx">
</span></span></pre></div>
<a id="trunkSourceWebInspectorUIUserInterfaceHoverMenucss"></a>
<div class="addfile"><h4>Added: trunk/Source/WebInspectorUI/UserInterface/HoverMenu.css (0 => 160134)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebInspectorUI/UserInterface/HoverMenu.css         (rev 0)
+++ trunk/Source/WebInspectorUI/UserInterface/HoverMenu.css        2013-12-04 23:20:54 UTC (rev 160134)
</span><span class="lines">@@ -0,0 +1,68 @@
</span><ins>+/*
+ * Copyright (C) 2013 Apple Inc. All rights reserved.
+ *
+ * Redistribution and use in source and binary forms, with or without
+ * modification, are permitted provided that the following conditions
+ * are met:
+ * 1. Redistributions of source code must retain the above copyright
+ * notice, this list of conditions and the following disclaimer.
+ * 2. Redistributions in binary form must reproduce the above copyright
+ * notice, this list of conditions and the following disclaimer in the
+ * documentation and/or other materials provided with the distribution.
+ *
+ * THIS SOFTWARE IS PROVIDED BY APPLE INC. AND ITS CONTRIBUTORS ``AS IS''
+ * AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO,
+ * THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR
+ * PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL APPLE INC. OR ITS CONTRIBUTORS
+ * BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR
+ * CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF
+ * SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS
+ * INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN
+ * CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE)
+ * ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF
+ * THE POSSIBILITY OF SUCH DAMAGE.
+ */
+
+.hover-menu {
+ position: absolute;
+ display: -webkit-flex;
+
+ /* Exceptionally use content-box such that the frame set is that of the highlighted string
+ and styling adds the required padding around it */
+ box-sizing: content-box;
+
+ /* Position the icon to the right of the menu and centered vertically */
+ -webkit-justify-content: flex-end;
+ -webkit-align-items: center;
+
+ /* Provide extra room for the icon */
+ padding-left: 2px;
+ padding-right: 16px;
+
+ min-height: 17px;
+
+ border-radius: 4px;
+ border: 2px solid rgba(0, 0, 0, 0.22);
+
+ -webkit-transform: translate3d(-3px, -5px, 0);
+
+ pointer-events: none;
+ opacity: 0;
+
+ transition: opacity 350ms;
+}
+
+.hover-menu.visible {
+ opacity: 1;
+}
+
+.hover-menu > img {
+ width: 15px;
+ height: 13px;
+ -webkit-transform: translateX(14px);
+ content: -webkit-image-set(url(Images/HoverMenuButton.png) 1x, url(Images/HoverMenuButton@2x.png) 2x);
+}
+
+.hover-menu.visible > img {
+ pointer-events: all;
+}
</ins></span></pre></div>
<a id="trunkSourceWebInspectorUIUserInterfaceHoverMenujs"></a>
<div class="addfile"><h4>Added: trunk/Source/WebInspectorUI/UserInterface/HoverMenu.js (0 => 160134)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebInspectorUI/UserInterface/HoverMenu.js         (rev 0)
+++ trunk/Source/WebInspectorUI/UserInterface/HoverMenu.js        2013-12-04 23:20:54 UTC (rev 160134)
</span><span class="lines">@@ -0,0 +1,107 @@
</span><ins>+/*
+ * Copyright (C) 2013 Apple Inc. All rights reserved.
+ *
+ * Redistribution and use in source and binary forms, with or without
+ * modification, are permitted provided that the following conditions
+ * are met:
+ * 1. Redistributions of source code must retain the above copyright
+ * notice, this list of conditions and the following disclaimer.
+ * 2. Redistributions in binary form must reproduce the above copyright
+ * notice, this list of conditions and the following disclaimer in the
+ * documentation and/or other materials provided with the distribution.
+ *
+ * THIS SOFTWARE IS PROVIDED BY APPLE INC. AND ITS CONTRIBUTORS ``AS IS''
+ * AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO,
+ * THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR
+ * PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL APPLE INC. OR ITS CONTRIBUTORS
+ * BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR
+ * CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF
+ * SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS
+ * INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN
+ * CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE)
+ * ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF
+ * THE POSSIBILITY OF SUCH DAMAGE.
+ */
+
+WebInspector.HoverMenu = function(delegate)
+{
+ WebInspector.Object.call(this);
+
+ this.delegate = delegate;
+
+ this._element = document.createElement("div");
+ this._element.className = WebInspector.HoverMenu.StyleClassName;
+ this._element.addEventListener("transitionend", this, true);
+
+ this._button = this._element.appendChild(document.createElement("img"));
+ this._button.addEventListener("click", this);
+}
+
+WebInspector.HoverMenu.StyleClassName = "hover-menu";
+WebInspector.HoverMenu.VisibleClassName = "visible";
+
+WebInspector.HoverMenu.prototype = {
+ constructor: WebInspector.HoverMenu,
+ __proto__: WebInspector.Object.prototype,
+
+ // Public
+
+ get element()
+ {
+ return this._element;
+ },
+
+ present: function(targetFrame)
+ {
+ var style = this._element.style;
+ style.left = Math.ceil(targetFrame.origin.x) + "px";
+ style.top = Math.ceil(targetFrame.origin.y) + "px";
+ style.width = Math.ceil(targetFrame.size.width) + "px";
+ style.height = Math.ceil(targetFrame.size.height) + "px";
+
+ var element = this._element;
+ document.body.appendChild(element);
+ setTimeout(function() {
+ element.classList.add(WebInspector.HoverMenu.VisibleClassName);
+ });
+
+ window.addEventListener("scroll", this, true);
+ },
+
+ dismiss: function()
+ {
+ if (this._element.parentNode !== document.body)
+ return;
+
+ this._element.classList.remove(WebInspector.HoverMenu.VisibleClassName);
+
+ window.removeEventListener("scroll", this, true);
+ },
+
+ // Protected
+
+ handleEvent: function(event)
+ {
+ switch (event.type) {
+ case "scroll":
+ if (!this._element.contains(event.target))
+ this.dismiss();
+ break;
+ case "click":
+ this._handleClickEvent(event);
+ break;
+ case "transitionend":
+ if (!this._element.classList.contains(WebInspector.HoverMenu.VisibleClassName))
+ this._element.remove();
+ break;
+ }
+ },
+
+ // Private
+
+ _handleClickEvent: function(event)
+ {
+ if (this.delegate && typeof this.delegate.hoverMenuWasActivated === "function")
+ this.delegate.hoverMenuWasActivated(this);
+ }
+}
</ins></span></pre></div>
<a id="trunkSourceWebInspectorUIUserInterfaceImagesHoverMenuButtonpng"></a>
<div class="addfile"><h4>Added: trunk/Source/WebInspectorUI/UserInterface/Images/HoverMenuButton.png (0 => 160134)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebInspectorUI/UserInterface/Images/HoverMenuButton.png         (rev 0)
+++ trunk/Source/WebInspectorUI/UserInterface/Images/HoverMenuButton.png        2013-12-04 23:20:54 UTC (rev 160134)
</span><span class="lines">@@ -0,0 +1,30 @@
</span><ins>+\x89PNG
+
+
+IHDR
+ v4A         pHYs