<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[160012] trunk/Source/WebCore</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/160012">160012</a></dd>
<dt>Author</dt> <dd>seokju@webkit.org</dd>
<dt>Date</dt> <dd>2013-12-03 10:08:34 -0800 (Tue, 03 Dec 2013)</dd>
</dl>
<h3>Log Message</h3>
<pre>Web Inspector: webViewResized() is not used anywhere in WebInspectorUI
https://bugs.webkit.org/show_bug.cgi?id=125137
Reviewed by Darin Adler.
Remove leftover code.
No new tests, no behavior changes.
* inspector/InspectorController.cpp:
* inspector/InspectorController.h:
* inspector/InspectorOverlay.cpp:
* inspector/InspectorOverlay.h:
* inspector/InspectorPageAgent.cpp:
* inspector/InspectorPageAgent.h:</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkSourceWebCoreChangeLog">trunk/Source/WebCore/ChangeLog</a></li>
<li><a href="#trunkSourceWebCoreinspectorInspectorControllercpp">trunk/Source/WebCore/inspector/InspectorController.cpp</a></li>
<li><a href="#trunkSourceWebCoreinspectorInspectorControllerh">trunk/Source/WebCore/inspector/InspectorController.h</a></li>
<li><a href="#trunkSourceWebCoreinspectorInspectorOverlaycpp">trunk/Source/WebCore/inspector/InspectorOverlay.cpp</a></li>
<li><a href="#trunkSourceWebCoreinspectorInspectorOverlayh">trunk/Source/WebCore/inspector/InspectorOverlay.h</a></li>
<li><a href="#trunkSourceWebCoreinspectorInspectorPageAgentcpp">trunk/Source/WebCore/inspector/InspectorPageAgent.cpp</a></li>
<li><a href="#trunkSourceWebCoreinspectorInspectorPageAgenth">trunk/Source/WebCore/inspector/InspectorPageAgent.h</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkSourceWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/ChangeLog (160011 => 160012)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/ChangeLog 2013-12-03 17:40:37 UTC (rev 160011)
+++ trunk/Source/WebCore/ChangeLog 2013-12-03 18:08:34 UTC (rev 160012)
</span><span class="lines">@@ -1,3 +1,21 @@
</span><ins>+2013-12-03 Seokju Kwon <seokju@webkit.org>
+
+ Web Inspector: webViewResized() is not used anywhere in WebInspectorUI
+ https://bugs.webkit.org/show_bug.cgi?id=125137
+
+ Reviewed by Darin Adler.
+
+ Remove leftover code.
+
+ No new tests, no behavior changes.
+
+ * inspector/InspectorController.cpp:
+ * inspector/InspectorController.h:
+ * inspector/InspectorOverlay.cpp:
+ * inspector/InspectorOverlay.h:
+ * inspector/InspectorPageAgent.cpp:
+ * inspector/InspectorPageAgent.h:
+
</ins><span class="cx"> 2013-12-03 László Langó <lango@inf.u-szeged.hu>
</span><span class="cx">
</span><span class="cx"> ASSERTION FAILED: !value || (value->isPrimitiveValue()) in WebCore::StyleProperties::getLayeredShorthandValue.
</span></span></pre></div>
<a id="trunkSourceWebCoreinspectorInspectorControllercpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/inspector/InspectorController.cpp (160011 => 160012)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/inspector/InspectorController.cpp 2013-12-03 17:40:37 UTC (rev 160011)
+++ trunk/Source/WebCore/inspector/InspectorController.cpp 2013-12-03 18:08:34 UTC (rev 160012)
</span><span class="lines">@@ -279,11 +279,6 @@
</span><span class="cx"> IdentifiersFactory::setProcessId(processId);
</span><span class="cx"> }
</span><span class="cx">
</span><del>-void InspectorController::webViewResized(const IntSize& size)
-{
- m_pageAgent->webViewResized(size);
-}
-
</del><span class="cx"> bool InspectorController::isUnderTest()
</span><span class="cx"> {
</span><span class="cx"> return m_isUnderTest;
</span></span></pre></div>
<a id="trunkSourceWebCoreinspectorInspectorControllerh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/inspector/InspectorController.h (160011 => 160012)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/inspector/InspectorController.h 2013-12-03 17:40:37 UTC (rev 160011)
+++ trunk/Source/WebCore/inspector/InspectorController.h 2013-12-03 18:08:34 UTC (rev 160012)
</span><span class="lines">@@ -95,7 +95,6 @@
</span><span class="cx"> void connectFrontend(InspectorFrontendChannel*);
</span><span class="cx"> void disconnectFrontend();
</span><span class="cx"> void setProcessId(long);
</span><del>- void webViewResized(const IntSize&);
</del><span class="cx">
</span><span class="cx"> void inspect(Node*);
</span><span class="cx"> void drawHighlight(GraphicsContext&) const;
</span></span></pre></div>
<a id="trunkSourceWebCoreinspectorInspectorOverlaycpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/inspector/InspectorOverlay.cpp (160011 => 160012)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/inspector/InspectorOverlay.cpp 2013-12-03 17:40:37 UTC (rev 160011)
+++ trunk/Source/WebCore/inspector/InspectorOverlay.cpp 2013-12-03 18:08:34 UTC (rev 160012)
</span><span class="lines">@@ -275,12 +275,6 @@
</span><span class="cx"> buildQuadHighlight(m_page, *m_highlightQuad, m_quadHighlightConfig, highlight);
</span><span class="cx"> }
</span><span class="cx">
</span><del>-void InspectorOverlay::resize(const IntSize& size)
-{
- m_size = size;
- update();
-}
-
</del><span class="cx"> void InspectorOverlay::setPausedInDebuggerMessage(const String* message)
</span><span class="cx"> {
</span><span class="cx"> m_pausedInDebuggerMessage = message ? *message : String();
</span></span></pre></div>
<a id="trunkSourceWebCoreinspectorInspectorOverlayh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/inspector/InspectorOverlay.h (160011 => 160012)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/inspector/InspectorOverlay.h 2013-12-03 17:40:37 UTC (rev 160011)
+++ trunk/Source/WebCore/inspector/InspectorOverlay.h 2013-12-03 18:08:34 UTC (rev 160012)
</span><span class="lines">@@ -113,7 +113,6 @@
</span><span class="cx"> void paint(GraphicsContext&);
</span><span class="cx"> void drawOutline(GraphicsContext*, const LayoutRect&, const Color&);
</span><span class="cx"> void getHighlight(Highlight*) const;
</span><del>- void resize(const IntSize&);
</del><span class="cx">
</span><span class="cx"> void setPausedInDebuggerMessage(const String*);
</span><span class="cx">
</span></span></pre></div>
<a id="trunkSourceWebCoreinspectorInspectorPageAgentcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/inspector/InspectorPageAgent.cpp (160011 => 160012)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/inspector/InspectorPageAgent.cpp 2013-12-03 17:40:37 UTC (rev 160011)
+++ trunk/Source/WebCore/inspector/InspectorPageAgent.cpp 2013-12-03 18:08:34 UTC (rev 160012)
</span><span class="lines">@@ -386,11 +386,6 @@
</span><span class="cx"> #endif
</span><span class="cx"> }
</span><span class="cx">
</span><del>-void InspectorPageAgent::webViewResized(const IntSize& size)
-{
- m_overlay->resize(m_screenWidthOverride ? size : IntSize());
-}
-
</del><span class="cx"> void InspectorPageAgent::enable(ErrorString*)
</span><span class="cx"> {
</span><span class="cx"> m_enabled = true;
</span></span></pre></div>
<a id="trunkSourceWebCoreinspectorInspectorPageAgenth"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/inspector/InspectorPageAgent.h (160011 => 160012)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/inspector/InspectorPageAgent.h 2013-12-03 17:40:37 UTC (rev 160011)
+++ trunk/Source/WebCore/inspector/InspectorPageAgent.h 2013-12-03 18:08:34 UTC (rev 160012)
</span><span class="lines">@@ -165,8 +165,6 @@
</span><span class="cx"> virtual void didCreateFrontendAndBackend(InspectorFrontendChannel*, InspectorBackendDispatcher*) OVERRIDE;
</span><span class="cx"> virtual void willDestroyFrontendAndBackend() OVERRIDE;
</span><span class="cx">
</span><del>- void webViewResized(const IntSize&);
-
</del><span class="cx"> // Cross-agents API
</span><span class="cx"> Page* page() { return m_page; }
</span><span class="cx"> Frame* mainFrame();
</span></span></pre>
</div>
</div>
</body>
</html>