<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[160072] trunk/Source/WebCore</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/160072">160072</a></dd>
<dt>Author</dt> <dd>rniwa@webkit.org</dd>
<dt>Date</dt> <dd>2013-12-03 23:44:43 -0800 (Tue, 03 Dec 2013)</dd>
</dl>
<h3>Log Message</h3>
<pre>bgColor, setBgColor, alinkColor, setAlinkColor, and etc... on HTMLBodyElement are useless
https://bugs.webkit.org/show_bug.cgi?id=125208
Reviewed by Antti Koivisto.
Merge https://chromium.googlesource.com/chromium/blink/+/49b1eeabbbf573d5271288c66d2b566cf33a09cf
These member functions of HTMLBodyElement were only used by corresponding functions in HTMLDocument
since they had the Reflect option specified in HTMLBodyElement.idl.
Removed the functions and directly called getAttribute and setAttribute in relevant functions in
HTMLDocument. The optimization to avoid assignment is no longer needed here since we've added that
optimization to setAttributeInternal a while ago.
* html/HTMLBodyElement.cpp:
* html/HTMLBodyElement.h:
* html/HTMLDocument.cpp:
(WebCore::HTMLDocument::bgColor):
(WebCore::HTMLDocument::setBgColor):
(WebCore::HTMLDocument::fgColor):
(WebCore::HTMLDocument::setFgColor):
(WebCore::HTMLDocument::alinkColor):
(WebCore::HTMLDocument::setAlinkColor):
(WebCore::HTMLDocument::linkColor):
(WebCore::HTMLDocument::setLinkColor):
(WebCore::HTMLDocument::vlinkColor):
(WebCore::HTMLDocument::setVlinkColor):
* html/HTMLDocument.h:</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkSourceWebCoreChangeLog">trunk/Source/WebCore/ChangeLog</a></li>
<li><a href="#trunkSourceWebCorehtmlHTMLBodyElementcpp">trunk/Source/WebCore/html/HTMLBodyElement.cpp</a></li>
<li><a href="#trunkSourceWebCorehtmlHTMLBodyElementh">trunk/Source/WebCore/html/HTMLBodyElement.h</a></li>
<li><a href="#trunkSourceWebCorehtmlHTMLDocumentcpp">trunk/Source/WebCore/html/HTMLDocument.cpp</a></li>
<li><a href="#trunkSourceWebCorehtmlHTMLDocumenth">trunk/Source/WebCore/html/HTMLDocument.h</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkSourceWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/ChangeLog (160071 => 160072)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/ChangeLog 2013-12-04 06:50:54 UTC (rev 160071)
+++ trunk/Source/WebCore/ChangeLog 2013-12-04 07:44:43 UTC (rev 160072)
</span><span class="lines">@@ -1,3 +1,34 @@
</span><ins>+2013-12-03 Ryosuke Niwa <rniwa@webkit.org>
+
+ bgColor, setBgColor, alinkColor, setAlinkColor, and etc... on HTMLBodyElement are useless
+ https://bugs.webkit.org/show_bug.cgi?id=125208
+
+ Reviewed by Antti Koivisto.
+
+ Merge https://chromium.googlesource.com/chromium/blink/+/49b1eeabbbf573d5271288c66d2b566cf33a09cf
+
+ These member functions of HTMLBodyElement were only used by corresponding functions in HTMLDocument
+ since they had the Reflect option specified in HTMLBodyElement.idl.
+
+ Removed the functions and directly called getAttribute and setAttribute in relevant functions in
+ HTMLDocument. The optimization to avoid assignment is no longer needed here since we've added that
+ optimization to setAttributeInternal a while ago.
+
+ * html/HTMLBodyElement.cpp:
+ * html/HTMLBodyElement.h:
+ * html/HTMLDocument.cpp:
+ (WebCore::HTMLDocument::bgColor):
+ (WebCore::HTMLDocument::setBgColor):
+ (WebCore::HTMLDocument::fgColor):
+ (WebCore::HTMLDocument::setFgColor):
+ (WebCore::HTMLDocument::alinkColor):
+ (WebCore::HTMLDocument::setAlinkColor):
+ (WebCore::HTMLDocument::linkColor):
+ (WebCore::HTMLDocument::setLinkColor):
+ (WebCore::HTMLDocument::vlinkColor):
+ (WebCore::HTMLDocument::setVlinkColor):
+ * html/HTMLDocument.h:
+
</ins><span class="cx"> 2013-12-03 Andreas Kling <akling@apple.com>
</span><span class="cx">
</span><span class="cx"> Add a CSSProperty::isDirectionAwareProperty() helper.
</span></span></pre></div>
<a id="trunkSourceWebCorehtmlHTMLBodyElementcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/html/HTMLBodyElement.cpp (160071 => 160072)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/html/HTMLBodyElement.cpp 2013-12-04 06:50:54 UTC (rev 160071)
+++ trunk/Source/WebCore/html/HTMLBodyElement.cpp 2013-12-04 07:44:43 UTC (rev 160072)
</span><span class="lines">@@ -188,56 +188,6 @@
</span><span class="cx"> return rendererIsEditable() || HTMLElement::supportsFocus();
</span><span class="cx"> }
</span><span class="cx">
</span><del>-String HTMLBodyElement::aLink() const
-{
- return getAttribute(alinkAttr);
-}
-
-void HTMLBodyElement::setALink(const String& value)
-{
- setAttribute(alinkAttr, value);
-}
-
-String HTMLBodyElement::bgColor() const
-{
- return getAttribute(bgcolorAttr);
-}
-
-void HTMLBodyElement::setBgColor(const String& value)
-{
- setAttribute(bgcolorAttr, value);
-}
-
-String HTMLBodyElement::link() const
-{
- return getAttribute(linkAttr);
-}
-
-void HTMLBodyElement::setLink(const String& value)
-{
- setAttribute(linkAttr, value);
-}
-
-String HTMLBodyElement::text() const
-{
- return getAttribute(textAttr);
-}
-
-void HTMLBodyElement::setText(const String& value)
-{
- setAttribute(textAttr, value);
-}
-
-String HTMLBodyElement::vLink() const
-{
- return getAttribute(vlinkAttr);
-}
-
-void HTMLBodyElement::setVLink(const String& value)
-{
- setAttribute(vlinkAttr, value);
-}
-
</del><span class="cx"> static int adjustForZoom(int value, Frame& frame)
</span><span class="cx"> {
</span><span class="cx"> float zoomFactor = frame.pageZoomFactor() * frame.frameScaleFactor();
</span></span></pre></div>
<a id="trunkSourceWebCorehtmlHTMLBodyElementh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/html/HTMLBodyElement.h (160071 => 160072)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/html/HTMLBodyElement.h 2013-12-04 06:50:54 UTC (rev 160071)
+++ trunk/Source/WebCore/html/HTMLBodyElement.h 2013-12-04 07:44:43 UTC (rev 160072)
</span><span class="lines">@@ -36,17 +36,6 @@
</span><span class="cx"> static PassRefPtr<HTMLBodyElement> create(const QualifiedName&, Document&);
</span><span class="cx"> virtual ~HTMLBodyElement();
</span><span class="cx">
</span><del>- String aLink() const;
- void setALink(const String&);
- String bgColor() const;
- void setBgColor(const String&);
- String link() const;
- void setLink(const String&);
- String text() const;
- void setText(const String&);
- String vLink() const;
- void setVLink(const String&);
-
</del><span class="cx"> // Declared virtual in Element
</span><span class="cx"> DEFINE_WINDOW_ATTRIBUTE_EVENT_LISTENER(blur);
</span><span class="cx"> DEFINE_WINDOW_ATTRIBUTE_EVENT_LISTENER(error);
</span></span></pre></div>
<a id="trunkSourceWebCorehtmlHTMLDocumentcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/html/HTMLDocument.cpp (160071 => 160072)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/html/HTMLDocument.cpp 2013-12-04 06:50:54 UTC (rev 160071)
+++ trunk/Source/WebCore/html/HTMLDocument.cpp 2013-12-04 07:44:43 UTC (rev 160072)
</span><span class="lines">@@ -158,114 +158,84 @@
</span><span class="cx"> return false;
</span><span class="cx"> }
</span><span class="cx">
</span><del>-String HTMLDocument::bgColor()
</del><ins>+const AtomicString& HTMLDocument::bgColor() const
</ins><span class="cx"> {
</span><del>- HTMLElement* b = body();
- HTMLBodyElement* bodyElement = (b && b->hasTagName(bodyTag)) ? toHTMLBodyElement(b) : 0;
-
- if (!bodyElement)
- return String();
- return bodyElement->bgColor();
</del><ins>+ HTMLElement* bodyElement = body();
+ if (!bodyElement || !isHTMLBodyElement(bodyElement))
+ return emptyAtom;
+ return bodyElement->getAttribute(bgcolorAttr);
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> void HTMLDocument::setBgColor(const String& value)
</span><span class="cx"> {
</span><del>- HTMLElement* b = body();
- HTMLBodyElement* bodyElement = (b && b->hasTagName(bodyTag)) ? toHTMLBodyElement(b) : 0;
-
- if (bodyElement)
- bodyElement->setBgColor(value);
</del><ins>+ HTMLElement* bodyElement = body();
+ if (!bodyElement || !isHTMLBodyElement(bodyElement))
+ return;
+ bodyElement->setAttribute(bgcolorAttr, value);
</ins><span class="cx"> }
</span><span class="cx">
</span><del>-String HTMLDocument::fgColor()
</del><ins>+const AtomicString& HTMLDocument::fgColor() const
</ins><span class="cx"> {
</span><del>- HTMLElement* b = body();
- HTMLBodyElement* bodyElement = (b && b->hasTagName(bodyTag)) ? toHTMLBodyElement(b) : 0;
-
- if (!bodyElement)
- return String();
- return bodyElement->text();
</del><ins>+ HTMLElement* bodyElement = body();
+ if (!bodyElement || !isHTMLBodyElement(bodyElement))
+ return emptyAtom;
+ return bodyElement->getAttribute(textAttr);
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> void HTMLDocument::setFgColor(const String& value)
</span><span class="cx"> {
</span><del>- HTMLElement* b = body();
- HTMLBodyElement* bodyElement = (b && b->hasTagName(bodyTag)) ? toHTMLBodyElement(b) : 0;
-
- if (bodyElement)
- bodyElement->setText(value);
</del><ins>+ HTMLElement* bodyElement = body();
+ if (!bodyElement || !isHTMLBodyElement(bodyElement))
+ return;
+ bodyElement->setAttribute(textAttr, value);
</ins><span class="cx"> }
</span><span class="cx">
</span><del>-String HTMLDocument::alinkColor()
</del><ins>+const AtomicString& HTMLDocument::alinkColor() const
</ins><span class="cx"> {
</span><del>- HTMLElement* b = body();
- HTMLBodyElement* bodyElement = (b && b->hasTagName(bodyTag)) ? toHTMLBodyElement(b) : 0;
-
- if (!bodyElement)
- return String();
- return bodyElement->aLink();
</del><ins>+ HTMLElement* bodyElement = body();
+ if (!bodyElement || !isHTMLBodyElement(bodyElement))
+ return emptyAtom;
+ return bodyElement->getAttribute(alinkAttr);
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> void HTMLDocument::setAlinkColor(const String& value)
</span><span class="cx"> {
</span><del>- HTMLElement* b = body();
- HTMLBodyElement* bodyElement = (b && b->hasTagName(bodyTag)) ? toHTMLBodyElement(b) : 0;
-
- if (bodyElement) {
- // This check is a bit silly, but some benchmarks like to set the
- // document's link colors over and over to the same value and we
- // don't want to incur a style update each time.
- if (bodyElement->aLink() != value)
- bodyElement->setALink(value);
- }
</del><ins>+ HTMLElement* bodyElement = body();
+ if (!bodyElement || !isHTMLBodyElement(bodyElement))
+ return;
+ bodyElement->setAttribute(alinkAttr, value);
</ins><span class="cx"> }
</span><span class="cx">
</span><del>-String HTMLDocument::linkColor()
</del><ins>+const AtomicString& HTMLDocument::linkColor() const
</ins><span class="cx"> {
</span><del>- HTMLElement* b = body();
- HTMLBodyElement* bodyElement = (b && b->hasTagName(bodyTag)) ? toHTMLBodyElement(b) : 0;
-
- if (!bodyElement)
- return String();
- return bodyElement->link();
</del><ins>+ HTMLElement* bodyElement = body();
+ if (!bodyElement || !isHTMLBodyElement(bodyElement))
+ return emptyAtom;
+ return bodyElement->getAttribute(linkAttr);
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> void HTMLDocument::setLinkColor(const String& value)
</span><span class="cx"> {
</span><del>- HTMLElement* b = body();
- HTMLBodyElement* bodyElement = (b && b->hasTagName(bodyTag)) ? toHTMLBodyElement(b) : 0;
-
- if (bodyElement) {
- // This check is a bit silly, but some benchmarks like to set the
- // document's link colors over and over to the same value and we
- // don't want to incur a style update each time.
- if (bodyElement->link() != value)
- bodyElement->setLink(value);
- }
</del><ins>+ HTMLElement* bodyElement = body();
+ if (!bodyElement || !isHTMLBodyElement(bodyElement))
+ return;
+ return bodyElement->setAttribute(linkAttr, value);
</ins><span class="cx"> }
</span><span class="cx">
</span><del>-String HTMLDocument::vlinkColor()
</del><ins>+const AtomicString& HTMLDocument::vlinkColor() const
</ins><span class="cx"> {
</span><del>- HTMLElement* b = body();
- HTMLBodyElement* bodyElement = (b && b->hasTagName(bodyTag)) ? toHTMLBodyElement(b) : 0;
-
- if (!bodyElement)
- return String();
- return bodyElement->vLink();
</del><ins>+ HTMLElement* bodyElement = body();
+ if (!bodyElement || !isHTMLBodyElement(bodyElement))
+ return emptyAtom;
+ return bodyElement->getAttribute(vlinkAttr);
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> void HTMLDocument::setVlinkColor(const String& value)
</span><span class="cx"> {
</span><del>- HTMLElement* b = body();
- HTMLBodyElement* bodyElement = (b && b->hasTagName(bodyTag)) ? toHTMLBodyElement(b) : 0;
-
- if (bodyElement) {
- // This check is a bit silly, but some benchmarks like to set the
- // document's link colors over and over to the same value and we
- // don't want to incur a style update each time.
- if (bodyElement->vLink() != value)
- bodyElement->setVLink(value);
- }
</del><ins>+ HTMLElement* bodyElement = body();
+ if (!bodyElement || !isHTMLBodyElement(bodyElement))
+ return;
+ return bodyElement->setAttribute(vlinkAttr, value);
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> void HTMLDocument::captureEvents()
</span></span></pre></div>
<a id="trunkSourceWebCorehtmlHTMLDocumenth"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/html/HTMLDocument.h (160071 => 160072)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/html/HTMLDocument.h 2013-12-04 06:50:54 UTC (rev 160071)
+++ trunk/Source/WebCore/html/HTMLDocument.h 2013-12-04 07:44:43 UTC (rev 160072)
</span><span class="lines">@@ -49,15 +49,15 @@
</span><span class="cx"> Element* activeElement();
</span><span class="cx"> bool hasFocus();
</span><span class="cx">
</span><del>- String bgColor();
</del><ins>+ const AtomicString& bgColor() const;
</ins><span class="cx"> void setBgColor(const String&);
</span><del>- String fgColor();
</del><ins>+ const AtomicString& fgColor() const;
</ins><span class="cx"> void setFgColor(const String&);
</span><del>- String alinkColor();
</del><ins>+ const AtomicString& alinkColor() const;
</ins><span class="cx"> void setAlinkColor(const String&);
</span><del>- String linkColor();
</del><ins>+ const AtomicString& linkColor() const;
</ins><span class="cx"> void setLinkColor(const String&);
</span><del>- String vlinkColor();
</del><ins>+ const AtomicString& vlinkColor() const;
</ins><span class="cx"> void setVlinkColor(const String&);
</span><span class="cx">
</span><span class="cx"> void clear();
</span></span></pre>
</div>
</div>
</body>
</html>