<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[159946] trunk/Source/WebInspectorUI</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/159946">159946</a></dd>
<dt>Author</dt> <dd>graouts@apple.com</dd>
<dt>Date</dt> <dd>2013-12-02 11:55:52 -0800 (Mon, 02 Dec 2013)</dd>
</dl>
<h3>Log Message</h3>
<pre>Web Inspector: add a method to add padding around a WebInspector.Rect
https://bugs.webkit.org/show_bug.cgi?id=125072
Reviewed by Joseph Pecoraro.
Add a new WebInspector.Rect.prototype.pad() method which does not alter
the rectangle it's called and returns a new rect much like .inset(). I've
checked all call sites and there was no reuse of the rectangle that was
padded so this patch won't have any side effects.
* UserInterface/Breakpoint.js:
(WebInspector.Breakpoint.prototype._showEditBreakpointPopover):
* UserInterface/CSSStyleDeclarationTextEditor.js:
* UserInterface/Geometry.js:
(WebInspector.Rect.prototype.pad):
* UserInterface/LayerTreeSidebarPanel.js:
(WebInspector.LayerTreeSidebarPanel.prototype._updatePopoverForSelectedNode):
* UserInterface/SourceCodeTextEditor.js:
(WebInspector.SourceCodeTextEditor.prototype._showPopover):
* UserInterface/TimelineDataGrid.js:
(WebInspector.TimelineDataGrid.prototype._updatePopoverForSelectedNode):</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkSourceWebInspectorUIChangeLog">trunk/Source/WebInspectorUI/ChangeLog</a></li>
<li><a href="#trunkSourceWebInspectorUIUserInterfaceBreakpointjs">trunk/Source/WebInspectorUI/UserInterface/Breakpoint.js</a></li>
<li><a href="#trunkSourceWebInspectorUIUserInterfaceCSSStyleDeclarationTextEditorjs">trunk/Source/WebInspectorUI/UserInterface/CSSStyleDeclarationTextEditor.js</a></li>
<li><a href="#trunkSourceWebInspectorUIUserInterfaceGeometryjs">trunk/Source/WebInspectorUI/UserInterface/Geometry.js</a></li>
<li><a href="#trunkSourceWebInspectorUIUserInterfaceLayerTreeSidebarPaneljs">trunk/Source/WebInspectorUI/UserInterface/LayerTreeSidebarPanel.js</a></li>
<li><a href="#trunkSourceWebInspectorUIUserInterfaceSourceCodeTextEditorjs">trunk/Source/WebInspectorUI/UserInterface/SourceCodeTextEditor.js</a></li>
<li><a href="#trunkSourceWebInspectorUIUserInterfaceTimelineDataGridjs">trunk/Source/WebInspectorUI/UserInterface/TimelineDataGrid.js</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkSourceWebInspectorUIChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebInspectorUI/ChangeLog (159945 => 159946)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebInspectorUI/ChangeLog 2013-12-02 19:55:30 UTC (rev 159945)
+++ trunk/Source/WebInspectorUI/ChangeLog 2013-12-02 19:55:52 UTC (rev 159946)
</span><span class="lines">@@ -1,3 +1,27 @@
</span><ins>+2013-12-02 Antoine Quint <graouts@apple.com>
+
+ Web Inspector: add a method to add padding around a WebInspector.Rect
+ https://bugs.webkit.org/show_bug.cgi?id=125072
+
+ Reviewed by Joseph Pecoraro.
+
+ Add a new WebInspector.Rect.prototype.pad() method which does not alter
+ the rectangle it's called and returns a new rect much like .inset(). I've
+ checked all call sites and there was no reuse of the rectangle that was
+ padded so this patch won't have any side effects.
+
+ * UserInterface/Breakpoint.js:
+ (WebInspector.Breakpoint.prototype._showEditBreakpointPopover):
+ * UserInterface/CSSStyleDeclarationTextEditor.js:
+ * UserInterface/Geometry.js:
+ (WebInspector.Rect.prototype.pad):
+ * UserInterface/LayerTreeSidebarPanel.js:
+ (WebInspector.LayerTreeSidebarPanel.prototype._updatePopoverForSelectedNode):
+ * UserInterface/SourceCodeTextEditor.js:
+ (WebInspector.SourceCodeTextEditor.prototype._showPopover):
+ * UserInterface/TimelineDataGrid.js:
+ (WebInspector.TimelineDataGrid.prototype._updatePopoverForSelectedNode):
+
</ins><span class="cx"> 2013-11-26 Antoine Quint <graouts@apple.com>
</span><span class="cx">
</span><span class="cx"> Web Inspector: Allow showing a context menu on all mouse events.
</span></span></pre></div>
<a id="trunkSourceWebInspectorUIUserInterfaceBreakpointjs"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebInspectorUI/UserInterface/Breakpoint.js (159945 => 159946)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebInspectorUI/UserInterface/Breakpoint.js 2013-12-02 19:55:30 UTC (rev 159945)
+++ trunk/Source/WebInspectorUI/UserInterface/Breakpoint.js 2013-12-02 19:55:52 UTC (rev 159946)
</span><span class="lines">@@ -480,18 +480,12 @@
</span><span class="cx">
</span><span class="cx"> _showEditBreakpointPopover: function(boundingClientRect)
</span><span class="cx"> {
</span><del>- const padding = 2;
</del><span class="cx"> var bounds = WebInspector.Rect.rectFromClientRect(boundingClientRect);
</span><del>-
</del><span class="cx"> bounds.origin.x -= 1; // Move the anchor left one pixel so it looks more centered.
</span><del>- bounds.origin.x -= padding;
- bounds.origin.y -= padding;
- bounds.size.width += padding * 2;
- bounds.size.height += padding * 2;
</del><span class="cx">
</span><span class="cx"> this._popover = this._popover || new WebInspector.Popover(this);
</span><span class="cx"> this._popover.content = this._editBreakpointPopoverContentElement();
</span><del>- this._popover.present(bounds, [WebInspector.RectEdge.MAX_Y]);
</del><ins>+ this._popover.present(bounds.pad(2), [WebInspector.RectEdge.MAX_Y]);
</ins><span class="cx">
</span><span class="cx"> if (!this._keyboardShortcutEsc) {
</span><span class="cx"> this._keyboardShortcutEsc = new WebInspector.KeyboardShortcut(null, WebInspector.KeyboardShortcut.Key.Escape);
</span></span></pre></div>
<a id="trunkSourceWebInspectorUIUserInterfaceCSSStyleDeclarationTextEditorjs"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebInspectorUI/UserInterface/CSSStyleDeclarationTextEditor.js (159945 => 159946)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebInspectorUI/UserInterface/CSSStyleDeclarationTextEditor.js 2013-12-02 19:55:30 UTC (rev 159945)
+++ trunk/Source/WebInspectorUI/UserInterface/CSSStyleDeclarationTextEditor.js 2013-12-02 19:55:52 UTC (rev 159946)
</span><span class="lines">@@ -750,14 +750,9 @@
</span><span class="cx"> }.bind(this));
</span><span class="cx">
</span><span class="cx"> var bounds = WebInspector.Rect.rectFromClientRect(swatch.getBoundingClientRect());
</span><del>- const padding = 2;
- bounds.origin.x -= padding;
- bounds.origin.y -= padding;
- bounds.size.width += padding * 2;
- bounds.size.height += padding * 2;
</del><span class="cx">
</span><span class="cx"> this._colorPickerPopover.content = colorPicker.element;
</span><del>- this._colorPickerPopover.present(bounds, [WebInspector.RectEdge.MIN_X]);
</del><ins>+ this._colorPickerPopover.present(bounds.pad(2), [WebInspector.RectEdge.MIN_X]);
</ins><span class="cx">
</span><span class="cx"> colorPicker.color = color;
</span><span class="cx"> }
</span></span></pre></div>
<a id="trunkSourceWebInspectorUIUserInterfaceGeometryjs"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebInspectorUI/UserInterface/Geometry.js (159945 => 159946)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebInspectorUI/UserInterface/Geometry.js 2013-12-02 19:55:30 UTC (rev 159945)
+++ trunk/Source/WebInspectorUI/UserInterface/Geometry.js 2013-12-02 19:55:52 UTC (rev 159946)
</span><span class="lines">@@ -126,6 +126,16 @@
</span><span class="cx"> );
</span><span class="cx"> },
</span><span class="cx">
</span><ins>+ pad: function(padding)
+ {
+ return new WebInspector.Rect(
+ this.origin.x - padding,
+ this.origin.y - padding,
+ this.size.width + padding * 2,
+ this.size.height + padding * 2
+ );
+ },
+
</ins><span class="cx"> minX: function()
</span><span class="cx"> {
</span><span class="cx"> return this.origin.x;
</span></span></pre></div>
<a id="trunkSourceWebInspectorUIUserInterfaceLayerTreeSidebarPaneljs"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebInspectorUI/UserInterface/LayerTreeSidebarPanel.js (159945 => 159946)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebInspectorUI/UserInterface/LayerTreeSidebarPanel.js 2013-12-02 19:55:30 UTC (rev 159945)
+++ trunk/Source/WebInspectorUI/UserInterface/LayerTreeSidebarPanel.js 2013-12-02 19:55:52 UTC (rev 159946)
</span><span class="lines">@@ -337,16 +337,11 @@
</span><span class="cx"> popover = this._popover = new WebInspector.Popover;
</span><span class="cx">
</span><span class="cx"> var targetFrame = WebInspector.Rect.rectFromClientRect(dataGridNode.element.getBoundingClientRect());
</span><del>- const padding = 2;
- targetFrame.origin.x -= padding;
- targetFrame.origin.y -= padding;
- targetFrame.size.width += padding * 2;
- targetFrame.size.height += padding * 2;
</del><span class="cx">
</span><span class="cx"> if (content)
</span><span class="cx"> popover.content = content;
</span><span class="cx">
</span><del>- popover.present(targetFrame, [WebInspector.RectEdge.MIN_X]);
</del><ins>+ popover.present(targetFrame.pad(2), [WebInspector.RectEdge.MIN_X]);
</ins><span class="cx"> },
</span><span class="cx">
</span><span class="cx"> _hidePopover: function()
</span></span></pre></div>
<a id="trunkSourceWebInspectorUIUserInterfaceSourceCodeTextEditorjs"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebInspectorUI/UserInterface/SourceCodeTextEditor.js (159945 => 159946)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebInspectorUI/UserInterface/SourceCodeTextEditor.js 2013-12-02 19:55:30 UTC (rev 159945)
+++ trunk/Source/WebInspectorUI/UserInterface/SourceCodeTextEditor.js 2013-12-02 19:55:52 UTC (rev 159946)
</span><span class="lines">@@ -1091,15 +1091,9 @@
</span><span class="cx">
</span><span class="cx"> content.classList.add(WebInspector.SourceCodeTextEditor.PopoverDebuggerContentStyleClassName);
</span><span class="cx">
</span><del>- const padding = 5;
- bounds.origin.x -= padding;
- bounds.origin.y -= padding;
- bounds.size.width += padding * 2;
- bounds.size.height += padding * 2;
-
</del><span class="cx"> this._popover = this._popover || new WebInspector.Popover(this);
</span><span class="cx"> this._popover.content = content;
</span><del>- this._popover.present(bounds, [WebInspector.RectEdge.MIN_Y, WebInspector.RectEdge.MAX_Y, WebInspector.RectEdge.MAX_X]);
</del><ins>+ this._popover.present(bounds.pad(5), [WebInspector.RectEdge.MIN_Y, WebInspector.RectEdge.MAX_Y, WebInspector.RectEdge.MAX_X]);
</ins><span class="cx">
</span><span class="cx"> this._trackPopoverEvents();
</span><span class="cx">
</span></span></pre></div>
<a id="trunkSourceWebInspectorUIUserInterfaceTimelineDataGridjs"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebInspectorUI/UserInterface/TimelineDataGrid.js (159945 => 159946)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebInspectorUI/UserInterface/TimelineDataGrid.js 2013-12-02 19:55:30 UTC (rev 159945)
+++ trunk/Source/WebInspectorUI/UserInterface/TimelineDataGrid.js 2013-12-02 19:55:52 UTC (rev 159946)
</span><span class="lines">@@ -217,16 +217,10 @@
</span><span class="cx"> delete this._hidePopoverContentClearTimeout;
</span><span class="cx"> }
</span><span class="cx">
</span><del>- const padding = 2;
- targetFrame.origin.x -= padding;
- targetFrame.origin.y -= padding;
- targetFrame.size.width += padding * 2;
- targetFrame.size.height += padding * 2;
-
</del><span class="cx"> if (updateContent)
</span><span class="cx"> this._popover.content = this._createPopoverContent();
</span><span class="cx">
</span><del>- this._popover.present(targetFrame, [WebInspector.RectEdge.MAX_Y, WebInspector.RectEdge.MIN_Y, WebInspector.RectEdge.MAX_X]);
</del><ins>+ this._popover.present(targetFrame.pad(2), [WebInspector.RectEdge.MAX_Y, WebInspector.RectEdge.MIN_Y, WebInspector.RectEdge.MAX_X]);
</ins><span class="cx"> },
</span><span class="cx">
</span><span class="cx"> _createPopoverContent: function()
</span></span></pre>
</div>
</div>
</body>
</html>