<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[159732] trunk/Source/WebCore</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/159732">159732</a></dd>
<dt>Author</dt> <dd>timothy_horton@apple.com</dd>
<dt>Date</dt> <dd>2013-11-24 00:34:26 -0800 (Sun, 24 Nov 2013)</dd>
</dl>
<h3>Log Message</h3>
<pre>REGRESSION (<a href="http://trac.webkit.org/projects/webkit/changeset/156291">r156291</a>): TileController tiles don't always repaint when they resize
https://bugs.webkit.org/show_bug.cgi?id=124796
Reviewed by Simon Fraser.
In removing platformCALayerDidCreateTiles, <a href="http://trac.webkit.org/projects/webkit/changeset/156291">r156291</a> also removed
the call to setNeedsDisplay when tiles are resized, without
putting it somewhere else.
* platform/graphics/ca/mac/TileController.mm:
(WebCore::TileController::setNeedsDisplay):
Use hasStaleContent when invalidating a whole tile, just
like we do for partial tile repaints.
(WebCore::TileController::setTileNeedsDisplayInRect):
Mark hasStaleContent for any unparented layers, so they'll be painted
when they are reparented.
(WebCore::TileController::ensureTilesForRect):
Invalidate the whole tile when it changes size.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkSourceWebCoreChangeLog">trunk/Source/WebCore/ChangeLog</a></li>
<li><a href="#trunkSourceWebCoreplatformgraphicscamacTileControllermm">trunk/Source/WebCore/platform/graphics/ca/mac/TileController.mm</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkSourceWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/ChangeLog (159731 => 159732)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/ChangeLog 2013-11-23 16:20:14 UTC (rev 159731)
+++ trunk/Source/WebCore/ChangeLog 2013-11-24 08:34:26 UTC (rev 159732)
</span><span class="lines">@@ -1,3 +1,26 @@
</span><ins>+2013-11-24 Tim Horton <timothy_horton@apple.com>
+
+ REGRESSION (r156291): TileController tiles don't always repaint when they resize
+ https://bugs.webkit.org/show_bug.cgi?id=124796
+
+ Reviewed by Simon Fraser.
+
+ In removing platformCALayerDidCreateTiles, r156291 also removed
+ the call to setNeedsDisplay when tiles are resized, without
+ putting it somewhere else.
+
+ * platform/graphics/ca/mac/TileController.mm:
+ (WebCore::TileController::setNeedsDisplay):
+ Use hasStaleContent when invalidating a whole tile, just
+ like we do for partial tile repaints.
+
+ (WebCore::TileController::setTileNeedsDisplayInRect):
+ Mark hasStaleContent for any unparented layers, so they'll be painted
+ when they are reparented.
+
+ (WebCore::TileController::ensureTilesForRect):
+ Invalidate the whole tile when it changes size.
+
</ins><span class="cx"> 2013-11-23 Xabier Rodriguez Calvar <calvaris@igalia.com>
</span><span class="cx">
</span><span class="cx"> [GStreamer] Remove 0.10 codepath
</span></span></pre></div>
<a id="trunkSourceWebCoreplatformgraphicscamacTileControllermm"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/platform/graphics/ca/mac/TileController.mm (159731 => 159732)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/platform/graphics/ca/mac/TileController.mm 2013-11-23 16:20:14 UTC (rev 159731)
+++ trunk/Source/WebCore/platform/graphics/ca/mac/TileController.mm 2013-11-24 08:34:26 UTC (rev 159732)
</span><span class="lines">@@ -98,9 +98,14 @@
</span><span class="cx">
</span><span class="cx"> void TileController::setNeedsDisplay()
</span><span class="cx"> {
</span><del>- for (TileMap::const_iterator it = m_tiles.begin(), end = m_tiles.end(); it != end; ++it) {
- const TileInfo& tileInfo = it->value;
- tileInfo.layer->setNeedsDisplay();
</del><ins>+ for (TileMap::iterator it = m_tiles.begin(), end = m_tiles.end(); it != end; ++it) {
+ TileInfo& tileInfo = it->value;
+ IntRect tileRect = rectForTileIndex(it->key);
+
+ if (tileRect.intersects(m_primaryTileCoverageRect) && tileInfo.layer->superlayer())
+ tileInfo.layer->setNeedsDisplay();
+ else
+ tileInfo.hasStaleContent = true;
</ins><span class="cx"> }
</span><span class="cx"> }
</span><span class="cx">
</span><span class="lines">@@ -149,7 +154,7 @@
</span><span class="cx">
</span><span class="cx"> // We could test for intersection with the visible rect. This would reduce painting yet more,
</span><span class="cx"> // but may make scrolling stale tiles into view more frequent.
</span><del>- if (tileRect.intersects(coverageRectInTileCoords)) {
</del><ins>+ if (tileRect.intersects(coverageRectInTileCoords) && tileLayer->superlayer()) {
</ins><span class="cx"> tileLayer->setNeedsDisplay(&tileRepaintRect);
</span><span class="cx">
</span><span class="cx"> if (owningGraphicsLayer()->platformCALayerShowRepaintCounter(0)) {
</span><span class="lines">@@ -869,6 +874,7 @@
</span><span class="cx"> if (shouldChangeTileLayerFrame) {
</span><span class="cx"> tileInfo.layer->setBounds(FloatRect(FloatPoint(), tileRect.size()));
</span><span class="cx"> tileInfo.layer->setPosition(tileRect.location());
</span><ins>+ tileInfo.layer->setNeedsDisplay();
</ins><span class="cx"> }
</span><span class="cx"> }
</span><span class="cx">
</span></span></pre>
</div>
</div>
</body>
</html>