<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[159726] trunk</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/159726">159726</a></dd>
<dt>Author</dt> <dd>rniwa@webkit.org</dd>
<dt>Date</dt> <dd>2013-11-22 20:50:45 -0800 (Fri, 22 Nov 2013)</dd>
</dl>
<h3>Log Message</h3>
<pre>Layout Test editing/deleting/password-delete-performance.html is failing
https://bugs.webkit.org/show_bug.cgi?id=124781
Reviewed by Alexey Proskuryakov.
PerformanceTests:
Add a new performance test to replace editing/deleting/password-delete-performance.html.
We skip this test by default since it's a micro benchmark.
* Interactive/DeletingInPasswordField.html: Added.
* Skipped:
LayoutTests:
Removed the test that has been timing out.
* TestExpectations:
* editing/deleting/password-delete-performance.html: Removed.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkLayoutTestsChangeLog">trunk/LayoutTests/ChangeLog</a></li>
<li><a href="#trunkLayoutTestsTestExpectations">trunk/LayoutTests/TestExpectations</a></li>
<li><a href="#trunkPerformanceTestsChangeLog">trunk/PerformanceTests/ChangeLog</a></li>
<li><a href="#trunkPerformanceTestsSkipped">trunk/PerformanceTests/Skipped</a></li>
</ul>
<h3>Added Paths</h3>
<ul>
<li><a href="#trunkPerformanceTestsInteractiveDeletingInPasswordFieldhtml">trunk/PerformanceTests/Interactive/DeletingInPasswordField.html</a></li>
</ul>
<h3>Removed Paths</h3>
<ul>
<li><a href="#trunkLayoutTestseditingdeletingpassworddeleteperformancehtml">trunk/LayoutTests/editing/deleting/password-delete-performance.html</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkLayoutTestsChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/ChangeLog (159725 => 159726)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/ChangeLog 2013-11-23 03:43:57 UTC (rev 159725)
+++ trunk/LayoutTests/ChangeLog 2013-11-23 04:50:45 UTC (rev 159726)
</span><span class="lines">@@ -1,3 +1,15 @@
</span><ins>+2013-11-22 Ryosuke Niwa <rniwa@webkit.org>
+
+ Layout Test editing/deleting/password-delete-performance.html is failing
+ https://bugs.webkit.org/show_bug.cgi?id=124781
+
+ Reviewed by Alexey Proskuryakov.
+
+ Removed the test that has been timing out.
+
+ * TestExpectations:
+ * editing/deleting/password-delete-performance.html: Removed.
+
</ins><span class="cx"> 2013-11-22 Brendan Long <b.long@cablelabs.com>
</span><span class="cx">
</span><span class="cx"> Fire "change" event on TextTrackList when a TextTrack's mode changes
</span></span></pre></div>
<a id="trunkLayoutTestsTestExpectations"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/TestExpectations (159725 => 159726)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/TestExpectations 2013-11-23 03:43:57 UTC (rev 159725)
+++ trunk/LayoutTests/TestExpectations 2013-11-23 04:50:45 UTC (rev 159726)
</span><span class="lines">@@ -69,6 +69,3 @@
</span><span class="cx"> # The spec is not clear if the MediaStream ended event should be fired if stop is called on each MediaStream's track
</span><span class="cx"> # Skipping it for now, then put it again when the spec decides it
</span><span class="cx"> fast/mediastream/MediaStream-onended.html [ Skip ]
</span><del>-
-# Times out on most runs
-webkit.org/b/124781 editing/deleting/password-delete-performance.html [ Skip ]
</del></span></pre></div>
<a id="trunkLayoutTestseditingdeletingpassworddeleteperformancehtml"></a>
<div class="delfile"><h4>Deleted: trunk/LayoutTests/editing/deleting/password-delete-performance.html (159725 => 159726)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/editing/deleting/password-delete-performance.html 2013-11-23 03:43:57 UTC (rev 159725)
+++ trunk/LayoutTests/editing/deleting/password-delete-performance.html 2013-11-23 04:50:45 UTC (rev 159726)
</span><span class="lines">@@ -1,31 +0,0 @@
</span><del>-<!DOCTYPE html>
-<html>
- <body>
- <p id="description">This test ensures that deleting characters from a password field that follows large content blocks is not slow.
- To run the test manually, delete the character from the password field. The user agent should not freeze.</p>
-
- <div id="content" style="height:0px; overflow:hidden;"> </div>
- <input id="field" type="password" value="A">
-
- <script src="../editing.js"></script>
- <script>
- if (window.testRunner)
- testRunner.dumpAsText();
-
- var newContent = '<p>Lorem ipsum dolor sit amet, consectetuer adipiscing elit.</p>';
- for (var i = 0; i < 15; i++) {
- newContent += newContent;
- }
-
- var contentDiv = document.getElementById('content');
- contentDiv.innerHTML = newContent;
-
- document.getElementById("field").focus();
- document.execCommand("Delete");
-
- // We clear the content div to avoid having its content appear in the test harness output.
- if (window.testRunner)
- contentDiv.innerHTML = "";
- </script>
- </body>
-</html>
</del></span></pre></div>
<a id="trunkPerformanceTestsChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/PerformanceTests/ChangeLog (159725 => 159726)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/PerformanceTests/ChangeLog 2013-11-23 03:43:57 UTC (rev 159725)
+++ trunk/PerformanceTests/ChangeLog 2013-11-23 04:50:45 UTC (rev 159726)
</span><span class="lines">@@ -1,3 +1,16 @@
</span><ins>+2013-11-22 Ryosuke Niwa <rniwa@webkit.org>
+
+ Layout Test editing/deleting/password-delete-performance.html is failing
+ https://bugs.webkit.org/show_bug.cgi?id=124781
+
+ Reviewed by Alexey Proskuryakov.
+
+ Add a new performance test to replace editing/deleting/password-delete-performance.html.
+ We skip this test by default since it's a micro benchmark.
+
+ * Interactive/DeletingInPasswordField.html: Added.
+ * Skipped:
+
</ins><span class="cx"> 2013-11-18 Sergio Villar Senin <svillar@igalia.com>
</span><span class="cx">
</span><span class="cx"> [CSS Grid Layout] Improve content-sized track layout
</span></span></pre></div>
<a id="trunkPerformanceTestsInteractiveDeletingInPasswordFieldhtml"></a>
<div class="addfile"><h4>Added: trunk/PerformanceTests/Interactive/DeletingInPasswordField.html (0 => 159726)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/PerformanceTests/Interactive/DeletingInPasswordField.html (rev 0)
+++ trunk/PerformanceTests/Interactive/DeletingInPasswordField.html 2013-11-23 04:50:45 UTC (rev 159726)
</span><span class="lines">@@ -0,0 +1,32 @@
</span><ins>+<!DOCTYPE html>
+<html>
+<body>
+<div id="content" style="height:0px; overflow:hidden;"> </div>
+<input id="field" type="password" value="">
+<script src="../resources/runner.js"></script>
+<script>
+var content = document.getElementById('content');
+var field = document.getElementById('field');
+
+var newContent = '<p>Lorem ipsum dolor sit amet, consectetuer adipiscing elit.</p>';
+for (var i = 0; i < 12; i++)
+ newContent += newContent;
+content.innerHTML = newContent;
+
+PerfTestRunner.measureTime({
+ unit: 'ms',
+ setup: function () {
+ field.value = 'A';
+ },
+ run: function () {
+ field.focus();
+ document.execCommand('Delete');
+ },
+ done: function () {
+ content.innerHTML = '';
+ }
+});
+
+</script>
+</body>
+</html>
</ins></span></pre></div>
<a id="trunkPerformanceTestsSkipped"></a>
<div class="modfile"><h4>Modified: trunk/PerformanceTests/Skipped (159725 => 159726)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/PerformanceTests/Skipped 2013-11-23 03:43:57 UTC (rev 159725)
+++ trunk/PerformanceTests/Skipped 2013-11-23 04:50:45 UTC (rev 159726)
</span><span class="lines">@@ -2,6 +2,7 @@
</span><span class="cx"> DOM/TraverseChildNodes.html
</span><span class="cx"> Interactive/SelectAll.html
</span><span class="cx"> Interactive/CopyAll.html
</span><ins>+Interactive/DeletingInPasswordField.html
</ins><span class="cx">
</span><span class="cx"> # Not enabled by default on some ports
</span><span class="cx"> Mutation
</span></span></pre>
</div>
</div>
</body>
</html>