<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[159389] trunk</title>
</head>
<body>

<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt;  }
#msg dl a { font-weight: bold}
#msg dl a:link    { color:#fc3; }
#msg dl a:active  { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff  {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/159389">159389</a></dd>
<dt>Author</dt> <dd>antti@apple.com</dd>
<dt>Date</dt> <dd>2013-11-17 13:37:25 -0800 (Sun, 17 Nov 2013)</dd>
</dl>

<h3>Log Message</h3>
<pre>REGRESSION (<a href="http://trac.webkit.org/projects/webkit/changeset/158774">r158774</a>): Iteration over element children is broken
https://bugs.webkit.org/show_bug.cgi?id=124145

Source/WebCore: 

Reviewed by Anders Carlsson.
        
Mutation during traversal invalidates the position cache. After the mid-point we start
traversing backwards as it the shortest path. However backward traversal of children-only
HTMLCollection was wrong and would end up going to descendants.
        
Reduction by yannick.poirier@inverto.tv.

Test: fast/dom/htmlcollection-children-mutation.html

* html/HTMLCollection.cpp:
(WebCore::HTMLCollection::collectionTraverseBackward):
        
    Traverse direct children only when m_shouldOnlyIncludeDirectChildren bit is set.

LayoutTests: 

Reviewed by Anders Carlsson.

* fast/dom/htmlcollection-children-mutation-expected.txt: Added.
* fast/dom/htmlcollection-children-mutation.html: Added.</pre>

<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkLayoutTestsChangeLog">trunk/LayoutTests/ChangeLog</a></li>
<li><a href="#trunkSourceWebCoreChangeLog">trunk/Source/WebCore/ChangeLog</a></li>
<li><a href="#trunkSourceWebCorehtmlHTMLCollectioncpp">trunk/Source/WebCore/html/HTMLCollection.cpp</a></li>
</ul>

<h3>Added Paths</h3>
<ul>
<li><a href="#trunkLayoutTestsfastdomhtmlcollectionchildrenmutationexpectedtxt">trunk/LayoutTests/fast/dom/htmlcollection-children-mutation-expected.txt</a></li>
<li><a href="#trunkLayoutTestsfastdomhtmlcollectionchildrenmutationhtml">trunk/LayoutTests/fast/dom/htmlcollection-children-mutation.html</a></li>
</ul>

</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkLayoutTestsChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/ChangeLog (159388 => 159389)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/ChangeLog        2013-11-17 21:00:28 UTC (rev 159388)
+++ trunk/LayoutTests/ChangeLog        2013-11-17 21:37:25 UTC (rev 159389)
</span><span class="lines">@@ -1,5 +1,15 @@
</span><span class="cx"> 2013-11-17  Antti Koivisto  &lt;antti@apple.com&gt;
</span><span class="cx"> 
</span><ins>+        REGRESSION (r158774): Iteration over element children is broken
+        https://bugs.webkit.org/show_bug.cgi?id=124145
+
+        Reviewed by Anders Carlsson.
+
+        * fast/dom/htmlcollection-children-mutation-expected.txt: Added.
+        * fast/dom/htmlcollection-children-mutation.html: Added.
+
+2013-11-17  Antti Koivisto  &lt;antti@apple.com&gt;
+
</ins><span class="cx">         Simple line path does not respect visibility:hidden
</span><span class="cx">         https://bugs.webkit.org/show_bug.cgi?id=124467
</span><span class="cx"> 
</span></span></pre></div>
<a id="trunkLayoutTestsfastdomhtmlcollectionchildrenmutationexpectedtxt"></a>
<div class="addfile"><h4>Added: trunk/LayoutTests/fast/dom/htmlcollection-children-mutation-expected.txt (0 => 159389)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/fast/dom/htmlcollection-children-mutation-expected.txt                                (rev 0)
+++ trunk/LayoutTests/fast/dom/htmlcollection-children-mutation-expected.txt        2013-11-17 21:37:25 UTC (rev 159389)
</span><span class="lines">@@ -0,0 +1,15 @@
</span><ins>+Test traversing children using HTMLCollection while mutating DOM
+
+On success, you will see a series of &quot;PASS&quot; messages, followed by &quot;TEST COMPLETE&quot;.
+
+
+PASS child.firstChild.innerText is &quot;child 0&quot;
+PASS child.firstChild.innerText is &quot;child 1&quot;
+PASS child.firstChild.innerText is &quot;child 2&quot;
+PASS child.firstChild.innerText is &quot;child 3&quot;
+PASS child.firstChild.innerText is &quot;child 4&quot;
+PASS child is null
+PASS successfullyParsed is true
+
+TEST COMPLETE
+
</ins></span></pre></div>
<a id="trunkLayoutTestsfastdomhtmlcollectionchildrenmutationhtml"></a>
<div class="addfile"><h4>Added: trunk/LayoutTests/fast/dom/htmlcollection-children-mutation.html (0 => 159389)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/fast/dom/htmlcollection-children-mutation.html                                (rev 0)
+++ trunk/LayoutTests/fast/dom/htmlcollection-children-mutation.html        2013-11-17 21:37:25 UTC (rev 159389)
</span><span class="lines">@@ -0,0 +1,35 @@
</span><ins>+&lt;!DOCTYPE html&gt;
+&lt;html&gt;
+&lt;head&gt;
+&lt;meta charset=&quot;utf-8&quot;&gt;
+&lt;script src=&quot;../../resources/js-test-pre.js&quot;&gt;&lt;/script&gt;
+&lt;/head&gt;
+&lt;body&gt;
+&lt;div id=&quot;test&quot; style=&quot;display:none&quot;&gt;
+&lt;div&gt;&lt;span&gt;&lt;/span&gt;&lt;/div&gt;
+&lt;div&gt;&lt;span&gt;&lt;/span&gt;&lt;/div&gt;
+&lt;div&gt;&lt;span&gt;&lt;/span&gt;&lt;/div&gt;
+&lt;div&gt;&lt;span&gt;&lt;/span&gt;&lt;/div&gt;
+&lt;div&gt;&lt;span&gt;&lt;/span&gt;&lt;/div&gt;
+&lt;/div&gt;
+&lt;script&gt;
+
+description(&quot;Test traversing children using HTMLCollection while mutating DOM&quot;);
+
+try {
+var test = document.getElementById(&quot;test&quot;);
+for (var i = 0; i &lt; test.children.length; i++)
+    test.children[i].firstChild.innerHTML = &quot;child &quot; + i;
+} catch(e) {}
+
+var child = test.firstElementChild;
+for (var i = 0; i &lt; 5; i++) {
+    shouldBeEqualToString(&quot;child.firstChild.innerText&quot;, &quot;child &quot; + i);
+    child = child.nextElementSibling;
+}
+shouldBeNull(&quot;child&quot;);
+
+&lt;/script&gt;
+&lt;script src=&quot;../../resources/js-test-post.js&quot;&gt;&lt;/script&gt;
+&lt;/body&gt;
+&lt;/html&gt;
</ins></span></pre></div>
<a id="trunkSourceWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/ChangeLog (159388 => 159389)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/ChangeLog        2013-11-17 21:00:28 UTC (rev 159388)
+++ trunk/Source/WebCore/ChangeLog        2013-11-17 21:37:25 UTC (rev 159389)
</span><span class="lines">@@ -1,3 +1,23 @@
</span><ins>+2013-11-17  Antti Koivisto  &lt;antti@apple.com&gt;
+
+        REGRESSION (r158774): Iteration over element children is broken
+        https://bugs.webkit.org/show_bug.cgi?id=124145
+
+        Reviewed by Anders Carlsson.
+        
+        Mutation during traversal invalidates the position cache. After the mid-point we start
+        traversing backwards as it the shortest path. However backward traversal of children-only
+        HTMLCollection was wrong and would end up going to descendants.
+        
+        Reduction by yannick.poirier@inverto.tv.
+
+        Test: fast/dom/htmlcollection-children-mutation.html
+
+        * html/HTMLCollection.cpp:
+        (WebCore::HTMLCollection::collectionTraverseBackward):
+        
+            Traverse direct children only when m_shouldOnlyIncludeDirectChildren bit is set.
+
</ins><span class="cx"> 2013-11-17  Zoltan Horvath  &lt;zoltan@webkit.org&gt;
</span><span class="cx"> 
</span><span class="cx">         Move LineLayoutState.h into rendering/line
</span></span></pre></div>
<a id="trunkSourceWebCorehtmlHTMLCollectioncpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/html/HTMLCollection.cpp (159388 => 159389)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/html/HTMLCollection.cpp        2013-11-17 21:00:28 UTC (rev 159388)
+++ trunk/Source/WebCore/html/HTMLCollection.cpp        2013-11-17 21:37:25 UTC (rev 159389)
</span><span class="lines">@@ -354,6 +354,11 @@
</span><span class="cx">     // FIXME: This should be optimized similarly to the forward case.
</span><span class="cx">     auto&amp; root = rootNode();
</span><span class="cx">     Element* element = &amp;current;
</span><ins>+    if (m_shouldOnlyIncludeDirectChildren) {
+        for (; count &amp;&amp; element ; --count)
+            element = iterateForPreviousElement(ElementTraversal::previousSibling(element));
+        return element;
+    }
</ins><span class="cx">     for (; count &amp;&amp; element ; --count)
</span><span class="cx">         element = iterateForPreviousElement(ElementTraversal::previous(element, &amp;root));
</span><span class="cx">     return element;
</span></span></pre>
</div>
</div>

</body>
</html>