<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[159093] trunk/Source/WebCore</title>
</head>
<body>

<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt;  }
#msg dl a { font-weight: bold}
#msg dl a:link    { color:#fc3; }
#msg dl a:active  { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff  {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/159093">159093</a></dd>
<dt>Author</dt> <dd>commit-queue@webkit.org</dd>
<dt>Date</dt> <dd>2013-11-11 20:39:59 -0800 (Mon, 11 Nov 2013)</dd>
</dl>

<h3>Log Message</h3>
<pre>Web Inspector: Remove some unused generated code
https://bugs.webkit.org/show_bug.cgi?id=124179

Patch by Joseph Pecoraro &lt;pecoraro@apple.com&gt; on 2013-11-11
Reviewed by Timothy Hatcher.

* inspector/CodeGeneratorInspectorStrings.py:</pre>

<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkSourceWebCoreChangeLog">trunk/Source/WebCore/ChangeLog</a></li>
<li><a href="#trunkSourceWebCoreinspectorCodeGeneratorInspectorStringspy">trunk/Source/WebCore/inspector/CodeGeneratorInspectorStrings.py</a></li>
</ul>

</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkSourceWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/ChangeLog (159092 => 159093)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/ChangeLog        2013-11-12 04:39:34 UTC (rev 159092)
+++ trunk/Source/WebCore/ChangeLog        2013-11-12 04:39:59 UTC (rev 159093)
</span><span class="lines">@@ -1,3 +1,12 @@
</span><ins>+2013-11-11  Joseph Pecoraro  &lt;pecoraro@apple.com&gt;
+
+        Web Inspector: Remove some unused generated code
+        https://bugs.webkit.org/show_bug.cgi?id=124179
+
+        Reviewed by Timothy Hatcher.
+
+        * inspector/CodeGeneratorInspectorStrings.py:
+
</ins><span class="cx"> 2013-11-11  Gyuyoung Kim  &lt;gyuyoung.kim@samsung.com&gt;
</span><span class="cx"> 
</span><span class="cx">         Clean up static_cast&lt;Element*&gt; usage
</span></span></pre></div>
<a id="trunkSourceWebCoreinspectorCodeGeneratorInspectorStringspy"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/inspector/CodeGeneratorInspectorStrings.py (159092 => 159093)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/inspector/CodeGeneratorInspectorStrings.py        2013-11-12 04:39:34 UTC (rev 159092)
+++ trunk/Source/WebCore/inspector/CodeGeneratorInspectorStrings.py        2013-11-12 04:39:59 UTC (rev 159093)
</span><span class="lines">@@ -33,9 +33,8 @@
</span><span class="cx"> &quot;&quot;&quot;    class $domainClassName {
</span><span class="cx">     public:
</span><span class="cx">         $domainClassName(InspectorFrontendChannel* inspectorFrontendChannel) : m_inspectorFrontendChannel(inspectorFrontendChannel) { }
</span><del>-${frontendDomainMethodDeclarations}        void setInspectorFrontendChannel(InspectorFrontendChannel* inspectorFrontendChannel) { m_inspectorFrontendChannel = inspectorFrontendChannel; }
-        InspectorFrontendChannel* getInspectorFrontendChannel() { return m_inspectorFrontendChannel; }
-    private:
</del><ins>+${frontendDomainMethodDeclarations}
+    protected:
</ins><span class="cx">         InspectorFrontendChannel* m_inspectorFrontendChannel;
</span><span class="cx">     };
</span><span class="cx"> 
</span><span class="lines">@@ -67,8 +66,8 @@
</span><span class="cx"> {
</span><span class="cx">     RefPtr&lt;InspectorObject&gt; jsonMessage = InspectorObject::create();
</span><span class="cx">     jsonMessage-&gt;setString(&quot;method&quot;, &quot;$domainName.$eventName&quot;);
</span><del>-$code    if (m_inspectorFrontendChannel)
-        m_inspectorFrontendChannel-&gt;sendMessageToFrontend(jsonMessage-&gt;toJSONString());
</del><ins>+$code
+    m_inspectorFrontendChannel-&gt;sendMessageToFrontend(jsonMessage-&gt;toJSONString());
</ins><span class="cx"> }
</span><span class="cx"> &quot;&quot;&quot;)
</span><span class="cx"> 
</span><span class="lines">@@ -182,7 +181,6 @@
</span><span class="cx">     void reportProtocolError(const long* const callId, CommonErrorCode, const String&amp; errorMessage) const;
</span><span class="cx">     virtual void reportProtocolError(const long* const callId, CommonErrorCode, const String&amp; errorMessage, PassRefPtr&lt;InspectorArray&gt; data) const = 0;
</span><span class="cx">     virtual void dispatch(const String&amp; message) = 0;
</span><del>-    static bool getCommandName(const String&amp; message, String* result);
</del><span class="cx"> 
</span><span class="cx">     enum MethodNames {
</span><span class="cx"> $methodNamesEnumContent
</span><span class="lines">@@ -460,22 +458,6 @@
</span><span class="cx">     return getPropertyValueImpl&lt;PassRefPtr&lt;InspectorArray&gt;, RefPtr&lt;InspectorArray&gt;, InspectorArray*&gt;(object, name, valueFound, protocolErrors, 0, AsMethodBridges::asArray, &quot;Array&quot;);
</span><span class="cx"> }
</span><span class="cx"> 
</span><del>-bool InspectorBackendDispatcher::getCommandName(const String&amp; message, String* result)
-{
-    RefPtr&lt;InspectorValue&gt; value = InspectorValue::parseJSON(message);
-    if (!value)
-        return false;
-
-    RefPtr&lt;InspectorObject&gt; object = value-&gt;asObject();
-    if (!object)
-        return false;
-
-    if (!object-&gt;getString(&quot;method&quot;, result))
-        return false;
-
-    return true;
-}
-
</del><span class="cx"> InspectorBackendDispatcher::CallbackBase::CallbackBase(PassRefPtr&lt;InspectorBackendDispatcherImpl&gt; backendImpl, int id)
</span><span class="cx">     : m_backendImpl(backendImpl), m_id(id), m_alreadySent(false) {}
</span><span class="cx"> 
</span></span></pre>
</div>
</div>

</body>
</html>