<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[158567] trunk/Source/WebCore</title>
</head>
<body>

<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt;  }
#msg dl a { font-weight: bold}
#msg dl a:link    { color:#fc3; }
#msg dl a:active  { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff  {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/158567">158567</a></dd>
<dt>Author</dt> <dd>akling@apple.com</dd>
<dt>Date</dt> <dd>2013-11-04 04:21:51 -0800 (Mon, 04 Nov 2013)</dd>
</dl>

<h3>Log Message</h3>
<pre>Make more CSSValue subclass constructors return PassRef.
&lt;https://webkit.org/b/123731&gt;

Make the constructor helpers for the following classes return
PassRef instead of PassRefPtr:

    - CSSFontValue
    - CSSImageSetValue
    - CSSUnicodeRangeValue
    - WebKitCSSArrayFunctionValue
    - WebKitCSSFilterValue
    - WebKitCSSMatFunctionValue
    - WebKitCSSMixFunctionValue
    - WebKitCSSShaderValue
    - WebKitCSSTransformValue

Reviewed by Antti Koivisto.</pre>

<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkSourceWebCoreChangeLog">trunk/Source/WebCore/ChangeLog</a></li>
<li><a href="#trunkSourceWebCorecssCSSFontValueh">trunk/Source/WebCore/css/CSSFontValue.h</a></li>
<li><a href="#trunkSourceWebCorecssCSSImageSetValueh">trunk/Source/WebCore/css/CSSImageSetValue.h</a></li>
<li><a href="#trunkSourceWebCorecssCSSUnicodeRangeValueh">trunk/Source/WebCore/css/CSSUnicodeRangeValue.h</a></li>
<li><a href="#trunkSourceWebCorecssWebKitCSSArrayFunctionValueh">trunk/Source/WebCore/css/WebKitCSSArrayFunctionValue.h</a></li>
<li><a href="#trunkSourceWebCorecssWebKitCSSFilterValueh">trunk/Source/WebCore/css/WebKitCSSFilterValue.h</a></li>
<li><a href="#trunkSourceWebCorecssWebKitCSSMatFunctionValueh">trunk/Source/WebCore/css/WebKitCSSMatFunctionValue.h</a></li>
<li><a href="#trunkSourceWebCorecssWebKitCSSMixFunctionValueh">trunk/Source/WebCore/css/WebKitCSSMixFunctionValue.h</a></li>
<li><a href="#trunkSourceWebCorecssWebKitCSSShaderValueh">trunk/Source/WebCore/css/WebKitCSSShaderValue.h</a></li>
<li><a href="#trunkSourceWebCorecssWebKitCSSTransformValueh">trunk/Source/WebCore/css/WebKitCSSTransformValue.h</a></li>
</ul>

</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkSourceWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/ChangeLog (158566 => 158567)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/ChangeLog        2013-11-04 12:16:47 UTC (rev 158566)
+++ trunk/Source/WebCore/ChangeLog        2013-11-04 12:21:51 UTC (rev 158567)
</span><span class="lines">@@ -1,3 +1,23 @@
</span><ins>+2013-11-04  Andreas Kling  &lt;akling@apple.com&gt;
+
+        Make more CSSValue subclass constructors return PassRef.
+        &lt;https://webkit.org/b/123731&gt;
+
+        Make the constructor helpers for the following classes return
+        PassRef instead of PassRefPtr:
+
+            - CSSFontValue
+            - CSSImageSetValue
+            - CSSUnicodeRangeValue
+            - WebKitCSSArrayFunctionValue
+            - WebKitCSSFilterValue
+            - WebKitCSSMatFunctionValue
+            - WebKitCSSMixFunctionValue
+            - WebKitCSSShaderValue
+            - WebKitCSSTransformValue
+
+        Reviewed by Antti Koivisto.
+
</ins><span class="cx"> 2013-11-04  Jozsef Berta  &lt;jberta@inf.u-szeged.hu&gt;
</span><span class="cx"> 
</span><span class="cx">         Buildfix after r158182 for GCC 4.6
</span></span></pre></div>
<a id="trunkSourceWebCorecssCSSFontValueh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/css/CSSFontValue.h (158566 => 158567)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/css/CSSFontValue.h        2013-11-04 12:16:47 UTC (rev 158566)
+++ trunk/Source/WebCore/css/CSSFontValue.h        2013-11-04 12:21:51 UTC (rev 158567)
</span><span class="lines">@@ -32,9 +32,9 @@
</span><span class="cx"> 
</span><span class="cx"> class CSSFontValue : public CSSValue {
</span><span class="cx"> public:
</span><del>-    static PassRefPtr&lt;CSSFontValue&gt; create()
</del><ins>+    static PassRef&lt;CSSFontValue&gt; create()
</ins><span class="cx">     {
</span><del>-        return adoptRef(new CSSFontValue);
</del><ins>+        return adoptRef(*new CSSFontValue);
</ins><span class="cx">     }
</span><span class="cx"> 
</span><span class="cx">     String customCSSText() const;
</span></span></pre></div>
<a id="trunkSourceWebCorecssCSSImageSetValueh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/css/CSSImageSetValue.h (158566 => 158567)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/css/CSSImageSetValue.h        2013-11-04 12:16:47 UTC (rev 158566)
+++ trunk/Source/WebCore/css/CSSImageSetValue.h        2013-11-04 12:21:51 UTC (rev 158567)
</span><span class="lines">@@ -40,9 +40,9 @@
</span><span class="cx"> class CSSImageSetValue : public CSSValueList {
</span><span class="cx"> public:
</span><span class="cx"> 
</span><del>-    static PassRefPtr&lt;CSSImageSetValue&gt; create()
</del><ins>+    static PassRef&lt;CSSImageSetValue&gt; create()
</ins><span class="cx">     {
</span><del>-        return adoptRef(new CSSImageSetValue());
</del><ins>+        return adoptRef(*new CSSImageSetValue());
</ins><span class="cx">     }
</span><span class="cx">     ~CSSImageSetValue();
</span><span class="cx"> 
</span></span></pre></div>
<a id="trunkSourceWebCorecssCSSUnicodeRangeValueh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/css/CSSUnicodeRangeValue.h (158566 => 158567)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/css/CSSUnicodeRangeValue.h        2013-11-04 12:16:47 UTC (rev 158566)
+++ trunk/Source/WebCore/css/CSSUnicodeRangeValue.h        2013-11-04 12:21:51 UTC (rev 158567)
</span><span class="lines">@@ -34,9 +34,9 @@
</span><span class="cx"> 
</span><span class="cx"> class CSSUnicodeRangeValue : public CSSValue {
</span><span class="cx"> public:
</span><del>-    static PassRefPtr&lt;CSSUnicodeRangeValue&gt; create(UChar32 from, UChar32 to)
</del><ins>+    static PassRef&lt;CSSUnicodeRangeValue&gt; create(UChar32 from, UChar32 to)
</ins><span class="cx">     {
</span><del>-        return adoptRef(new CSSUnicodeRangeValue(from, to));
</del><ins>+        return adoptRef(*new CSSUnicodeRangeValue(from, to));
</ins><span class="cx">     }
</span><span class="cx"> 
</span><span class="cx">     UChar32 from() const { return m_from; }
</span></span></pre></div>
<a id="trunkSourceWebCorecssWebKitCSSArrayFunctionValueh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/css/WebKitCSSArrayFunctionValue.h (158566 => 158567)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/css/WebKitCSSArrayFunctionValue.h        2013-11-04 12:16:47 UTC (rev 158566)
+++ trunk/Source/WebCore/css/WebKitCSSArrayFunctionValue.h        2013-11-04 12:21:51 UTC (rev 158567)
</span><span class="lines">@@ -39,9 +39,9 @@
</span><span class="cx"> 
</span><span class="cx"> class WebKitCSSArrayFunctionValue : public CSSValueList {
</span><span class="cx"> public:
</span><del>-    static PassRefPtr&lt;WebKitCSSArrayFunctionValue&gt; create()
</del><ins>+    static PassRef&lt;WebKitCSSArrayFunctionValue&gt; create()
</ins><span class="cx">     {
</span><del>-        return adoptRef(new WebKitCSSArrayFunctionValue());
</del><ins>+        return adoptRef(*new WebKitCSSArrayFunctionValue());
</ins><span class="cx">     }
</span><span class="cx"> 
</span><span class="cx">     String customCSSText() const;
</span></span></pre></div>
<a id="trunkSourceWebCorecssWebKitCSSFilterValueh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/css/WebKitCSSFilterValue.h (158566 => 158567)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/css/WebKitCSSFilterValue.h        2013-11-04 12:16:47 UTC (rev 158566)
+++ trunk/Source/WebCore/css/WebKitCSSFilterValue.h        2013-11-04 12:21:51 UTC (rev 158567)
</span><span class="lines">@@ -57,9 +57,9 @@
</span><span class="cx"> 
</span><span class="cx">     static bool typeUsesSpaceSeparator(FilterOperationType);
</span><span class="cx"> 
</span><del>-    static PassRefPtr&lt;WebKitCSSFilterValue&gt; create(FilterOperationType type)
</del><ins>+    static PassRef&lt;WebKitCSSFilterValue&gt; create(FilterOperationType type)
</ins><span class="cx">     {
</span><del>-        return adoptRef(new WebKitCSSFilterValue(type));
</del><ins>+        return adoptRef(*new WebKitCSSFilterValue(type));
</ins><span class="cx">     }
</span><span class="cx"> 
</span><span class="cx">     String customCSSText() const;
</span></span></pre></div>
<a id="trunkSourceWebCorecssWebKitCSSMatFunctionValueh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/css/WebKitCSSMatFunctionValue.h (158566 => 158567)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/css/WebKitCSSMatFunctionValue.h        2013-11-04 12:16:47 UTC (rev 158566)
+++ trunk/Source/WebCore/css/WebKitCSSMatFunctionValue.h        2013-11-04 12:21:51 UTC (rev 158567)
</span><span class="lines">@@ -39,9 +39,9 @@
</span><span class="cx"> 
</span><span class="cx"> class WebKitCSSMatFunctionValue : public CSSValueList {
</span><span class="cx"> public:
</span><del>-    static PassRefPtr&lt;WebKitCSSMatFunctionValue&gt; create()
</del><ins>+    static PassRef&lt;WebKitCSSMatFunctionValue&gt; create()
</ins><span class="cx">     {
</span><del>-        return adoptRef(new WebKitCSSMatFunctionValue());
</del><ins>+        return adoptRef(*new WebKitCSSMatFunctionValue);
</ins><span class="cx">     }
</span><span class="cx"> 
</span><span class="cx">     String customCSSText() const;
</span></span></pre></div>
<a id="trunkSourceWebCorecssWebKitCSSMixFunctionValueh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/css/WebKitCSSMixFunctionValue.h (158566 => 158567)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/css/WebKitCSSMixFunctionValue.h        2013-11-04 12:16:47 UTC (rev 158566)
+++ trunk/Source/WebCore/css/WebKitCSSMixFunctionValue.h        2013-11-04 12:21:51 UTC (rev 158567)
</span><span class="lines">@@ -39,9 +39,9 @@
</span><span class="cx"> 
</span><span class="cx"> class WebKitCSSMixFunctionValue : public CSSValueList {
</span><span class="cx"> public:
</span><del>-    static PassRefPtr&lt;WebKitCSSMixFunctionValue&gt; create()
</del><ins>+    static PassRef&lt;WebKitCSSMixFunctionValue&gt; create()
</ins><span class="cx">     {
</span><del>-        return adoptRef(new WebKitCSSMixFunctionValue());
</del><ins>+        return adoptRef(*new WebKitCSSMixFunctionValue());
</ins><span class="cx">     }
</span><span class="cx"> 
</span><span class="cx">     String customCSSText() const;
</span></span></pre></div>
<a id="trunkSourceWebCorecssWebKitCSSShaderValueh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/css/WebKitCSSShaderValue.h (158566 => 158567)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/css/WebKitCSSShaderValue.h        2013-11-04 12:16:47 UTC (rev 158566)
+++ trunk/Source/WebCore/css/WebKitCSSShaderValue.h        2013-11-04 12:21:51 UTC (rev 158567)
</span><span class="lines">@@ -43,7 +43,7 @@
</span><span class="cx"> 
</span><span class="cx"> class WebKitCSSShaderValue : public CSSValue {
</span><span class="cx"> public:
</span><del>-    static PassRefPtr&lt;WebKitCSSShaderValue&gt; create(const String&amp; url) { return adoptRef(new WebKitCSSShaderValue(url)); }
</del><ins>+    static PassRef&lt;WebKitCSSShaderValue&gt; create(const String&amp; url) { return adoptRef(*new WebKitCSSShaderValue(url)); }
</ins><span class="cx">     ~WebKitCSSShaderValue();
</span><span class="cx"> 
</span><span class="cx">     const String&amp; format() const { return m_format; }
</span><span class="lines">@@ -58,7 +58,7 @@
</span><span class="cx">     bool equals(const WebKitCSSShaderValue&amp;) const;
</span><span class="cx"> 
</span><span class="cx"> private:
</span><del>-    WebKitCSSShaderValue(const String&amp; url);
</del><ins>+    explicit WebKitCSSShaderValue(const String&amp; url);
</ins><span class="cx"> 
</span><span class="cx">     String m_url;
</span><span class="cx">     String m_format;
</span></span></pre></div>
<a id="trunkSourceWebCorecssWebKitCSSTransformValueh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/css/WebKitCSSTransformValue.h (158566 => 158567)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/css/WebKitCSSTransformValue.h        2013-11-04 12:16:47 UTC (rev 158566)
+++ trunk/Source/WebCore/css/WebKitCSSTransformValue.h        2013-11-04 12:21:51 UTC (rev 158567)
</span><span class="lines">@@ -60,9 +60,9 @@
</span><span class="cx">         Matrix3DTransformOperation
</span><span class="cx">     };
</span><span class="cx"> 
</span><del>-    static PassRefPtr&lt;WebKitCSSTransformValue&gt; create(TransformOperationType type)
</del><ins>+    static PassRef&lt;WebKitCSSTransformValue&gt; create(TransformOperationType type)
</ins><span class="cx">     {
</span><del>-        return adoptRef(new WebKitCSSTransformValue(type));
</del><ins>+        return adoptRef(*new WebKitCSSTransformValue(type));
</ins><span class="cx">     }
</span><span class="cx"> 
</span><span class="cx">     String customCSSText() const;
</span></span></pre>
</div>
</div>

</body>
</html>