<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[158581] trunk/Source/WebCore</title>
</head>
<body>

<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt;  }
#msg dl a { font-weight: bold}
#msg dl a:link    { color:#fc3; }
#msg dl a:active  { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff  {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/158581">158581</a></dd>
<dt>Author</dt> <dd>dbates@webkit.org</dd>
<dt>Date</dt> <dd>2013-11-04 10:42:21 -0800 (Mon, 04 Nov 2013)</dd>
</dl>

<h3>Log Message</h3>
<pre>Revert SetCGFontRenderingMode() build fix for Chromium Mac
https://bugs.webkit.org/show_bug.cgi?id=123633

Reviewed by Darin Adler.

Reverts &lt;http://trac.webkit.org/changeset/134380&gt;, which
was a Chromium Mac build fix for &lt;http://trac.webkit.org/changeset/134348&gt;
(https://bugs.webkit.org/show_bug.cgi?id=101787). Chromium doesn't
build against top-of-tree WebKit.

* platform/graphics/mac/FontMac.mm:
(WebCore::Font::drawGlyphs):
* platform/mac/WebCoreSystemInterface.h:
* platform/mac/WebCoreSystemInterface.mm:</pre>

<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkSourceWebCoreChangeLog">trunk/Source/WebCore/ChangeLog</a></li>
<li><a href="#trunkSourceWebCoreplatformgraphicsmacFontMacmm">trunk/Source/WebCore/platform/graphics/mac/FontMac.mm</a></li>
<li><a href="#trunkSourceWebCoreplatformmacWebCoreSystemInterfaceh">trunk/Source/WebCore/platform/mac/WebCoreSystemInterface.h</a></li>
<li><a href="#trunkSourceWebCoreplatformmacWebCoreSystemInterfacemm">trunk/Source/WebCore/platform/mac/WebCoreSystemInterface.mm</a></li>
</ul>

</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkSourceWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/ChangeLog (158580 => 158581)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/ChangeLog        2013-11-04 18:21:37 UTC (rev 158580)
+++ trunk/Source/WebCore/ChangeLog        2013-11-04 18:42:21 UTC (rev 158581)
</span><span class="lines">@@ -1,3 +1,20 @@
</span><ins>+2013-11-04  Daniel Bates  &lt;dabates@apple.com&gt;
+
+        Revert SetCGFontRenderingMode() build fix for Chromium Mac
+        https://bugs.webkit.org/show_bug.cgi?id=123633
+
+        Reviewed by Darin Adler.
+
+        Reverts &lt;http://trac.webkit.org/changeset/134380&gt;, which
+        was a Chromium Mac build fix for &lt;http://trac.webkit.org/changeset/134348&gt;
+        (https://bugs.webkit.org/show_bug.cgi?id=101787). Chromium doesn't
+        build against top-of-tree WebKit.
+
+        * platform/graphics/mac/FontMac.mm:
+        (WebCore::Font::drawGlyphs):
+        * platform/mac/WebCoreSystemInterface.h:
+        * platform/mac/WebCoreSystemInterface.mm:
+
</ins><span class="cx"> 2013-11-04  Commit Queue  &lt;commit-queue@webkit.org&gt;
</span><span class="cx"> 
</span><span class="cx">         Unreviewed, rolling out r158526.
</span></span></pre></div>
<a id="trunkSourceWebCoreplatformgraphicsmacFontMacmm"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/platform/graphics/mac/FontMac.mm (158580 => 158581)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/platform/graphics/mac/FontMac.mm        2013-11-04 18:21:37 UTC (rev 158580)
+++ trunk/Source/WebCore/platform/graphics/mac/FontMac.mm        2013-11-04 18:42:21 UTC (rev 158581)
</span><span class="lines">@@ -186,11 +186,7 @@
</span><span class="cx">     }
</span><span class="cx">     CGContextSetTextMatrix(cgContext, matrix);
</span><span class="cx"> 
</span><del>-#if PLATFORM(MAC)
</del><span class="cx">     wkSetCGFontRenderingMode(cgContext, drawFont, context-&gt;shouldSubpixelQuantizeFonts());
</span><del>-#else
-    wkSetCGFontRenderingMode(cgContext, drawFont);
-#endif
</del><span class="cx">     if (drawFont)
</span><span class="cx">         CGContextSetFontSize(cgContext, 1.0f);
</span><span class="cx">     else
</span></span></pre></div>
<a id="trunkSourceWebCoreplatformmacWebCoreSystemInterfaceh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/platform/mac/WebCoreSystemInterface.h (158580 => 158581)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/platform/mac/WebCoreSystemInterface.h        2013-11-04 18:21:37 UTC (rev 158580)
+++ trunk/Source/WebCore/platform/mac/WebCoreSystemInterface.h        2013-11-04 18:42:21 UTC (rev 158581)
</span><span class="lines">@@ -191,11 +191,7 @@
</span><span class="cx"> extern NSArray *(*wkQTGetSitesInMediaDownloadCache)();
</span><span class="cx"> extern void (*wkQTClearMediaDownloadCacheForSite)(NSString *site);
</span><span class="cx"> extern void (*wkQTClearMediaDownloadCache)();
</span><del>-#if PLATFORM(MAC)
</del><span class="cx"> extern void (*wkSetCGFontRenderingMode)(CGContextRef, NSFont*, BOOL);
</span><del>-#else
-extern void (*wkSetCGFontRenderingMode)(CGContextRef, NSFont*);
-#endif
</del><span class="cx"> extern void (*wkSetDragImage)(NSImage*, NSPoint offset);
</span><span class="cx"> extern void (*wkSetNSURLConnectionDefersCallbacks)(NSURLConnection *, BOOL);
</span><span class="cx"> extern void (*wkSetNSURLRequestShouldContentSniff)(NSMutableURLRequest *, BOOL);
</span></span></pre></div>
<a id="trunkSourceWebCoreplatformmacWebCoreSystemInterfacemm"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/platform/mac/WebCoreSystemInterface.mm (158580 => 158581)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/platform/mac/WebCoreSystemInterface.mm        2013-11-04 18:21:37 UTC (rev 158580)
+++ trunk/Source/WebCore/platform/mac/WebCoreSystemInterface.mm        2013-11-04 18:42:21 UTC (rev 158581)
</span><span class="lines">@@ -83,11 +83,7 @@
</span><span class="cx"> void (*wkQTClearMediaDownloadCacheForSite)(NSString *site);
</span><span class="cx"> void (*wkQTClearMediaDownloadCache)();
</span><span class="cx"> 
</span><del>-#if PLATFORM(MAC)
</del><span class="cx"> void (*wkSetCGFontRenderingMode)(CGContextRef, NSFont*, BOOL);
</span><del>-#else
-void (*wkSetCGFontRenderingMode)(CGContextRef, NSFont*);
-#endif
</del><span class="cx"> void (*wkSetDragImage)(NSImage*, NSPoint offset);
</span><span class="cx"> void (*wkSetBaseCTM)(CGContextRef, CGAffineTransform);
</span><span class="cx"> void (*wkSetPatternPhaseInUserSpace)(CGContextRef, CGPoint point);
</span></span></pre>
</div>
</div>

</body>
</html>