<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[152768] trunk</title>
</head>
<body>

<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt;  }
#msg dl a { font-weight: bold}
#msg dl a:link    { color:#fc3; }
#msg dl a:active  { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff  {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/152768">152768</a></dd>
<dt>Author</dt> <dd>commit-queue@webkit.org</dd>
<dt>Date</dt> <dd>2013-07-17 00:20:34 -0700 (Wed, 17 Jul 2013)</dd>
</dl>

<h3>Log Message</h3>
<pre>ASSERTION FAILED: layoutState-&gt;m_renderer == this in WebCore::RenderBlock::offsetFromLogicalTopOfFirstPage
https://bugs.webkit.org/show_bug.cgi?id=118587

Patch by Mihai Maerean &lt;mmaerean@adobe.com&gt; on 2013-07-17
Reviewed by David Hyatt.

Source/WebCore:

The fix consists in not calling containingBlockLogicalHeightForPositioned for flow threads (in
RenderBox::availableLogicalHeightUsing) as it gets to handle the RenderView as it would have been flowed into
the flow thread.

Test: fast/regions/crash-div-outside-body-vertical-rl.html

* rendering/RenderBox.cpp:
(WebCore::RenderBox::availableLogicalHeightUsing):

LayoutTests:

* fast/regions/crash-div-outside-body-vertical-rl-expected.html: Added.
* fast/regions/crash-div-outside-body-vertical-rl.html: Added.</pre>

<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkLayoutTestsChangeLog">trunk/LayoutTests/ChangeLog</a></li>
<li><a href="#trunkSourceWebCoreChangeLog">trunk/Source/WebCore/ChangeLog</a></li>
<li><a href="#trunkSourceWebCorerenderingRenderBoxcpp">trunk/Source/WebCore/rendering/RenderBox.cpp</a></li>
</ul>

<h3>Added Paths</h3>
<ul>
<li><a href="#trunkLayoutTestsfastregionscrashdivoutsidebodyverticalrlexpectedhtml">trunk/LayoutTests/fast/regions/crash-div-outside-body-vertical-rl-expected.html</a></li>
<li><a href="#trunkLayoutTestsfastregionscrashdivoutsidebodyverticalrlhtml">trunk/LayoutTests/fast/regions/crash-div-outside-body-vertical-rl.html</a></li>
</ul>

</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkLayoutTestsChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/ChangeLog (152767 => 152768)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/ChangeLog        2013-07-17 07:19:15 UTC (rev 152767)
+++ trunk/LayoutTests/ChangeLog        2013-07-17 07:20:34 UTC (rev 152768)
</span><span class="lines">@@ -1,3 +1,13 @@
</span><ins>+2013-07-17  Mihai Maerean  &lt;mmaerean@adobe.com&gt;
+
+        ASSERTION FAILED: layoutState-&gt;m_renderer == this in WebCore::RenderBlock::offsetFromLogicalTopOfFirstPage
+        https://bugs.webkit.org/show_bug.cgi?id=118587
+
+        Reviewed by David Hyatt.
+
+        * fast/regions/crash-div-outside-body-vertical-rl-expected.html: Added.
+        * fast/regions/crash-div-outside-body-vertical-rl.html: Added.
+
</ins><span class="cx"> 2013-07-16  Alex Christensen  &lt;achristensen@apple.com&gt;
</span><span class="cx"> 
</span><span class="cx">         Added passing WebGL tests.
</span></span></pre></div>
<a id="trunkLayoutTestsfastregionscrashdivoutsidebodyverticalrlexpectedhtml"></a>
<div class="addfile"><h4>Added: trunk/LayoutTests/fast/regions/crash-div-outside-body-vertical-rl-expected.html (0 => 152768)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/fast/regions/crash-div-outside-body-vertical-rl-expected.html                                (rev 0)
+++ trunk/LayoutTests/fast/regions/crash-div-outside-body-vertical-rl-expected.html        2013-07-17 07:20:34 UTC (rev 152768)
</span><span class="lines">@@ -0,0 +1,9 @@
</span><ins>+&lt;!doctype html&gt;
+&lt;html&gt;
+    &lt;head&gt;
+        &lt;title&gt;118587 - ASSERTION FAILED: layoutState-&amp;gt;m_renderer == this in WebCore::RenderBlock::offsetFromLogicalTopOfFirstPage&lt;/title&gt;
+    &lt;/head&gt;
+
+    &lt;div style=&quot;display:none&quot; &gt;FAIL: this should not be visible as it's not flowed anywhere.&lt;/div&gt;
+    &lt;body style=&quot;-webkit-writing-mode: vertical-rl;&quot;&gt;PASS: test for 118587 - passes if it doesn't crash or assert.&lt;/body&gt;
+&lt;/html&gt;
</ins><span class="cx">\ No newline at end of file
</span></span></pre></div>
<a id="trunkLayoutTestsfastregionscrashdivoutsidebodyverticalrlhtml"></a>
<div class="addfile"><h4>Added: trunk/LayoutTests/fast/regions/crash-div-outside-body-vertical-rl.html (0 => 152768)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/fast/regions/crash-div-outside-body-vertical-rl.html                                (rev 0)
+++ trunk/LayoutTests/fast/regions/crash-div-outside-body-vertical-rl.html        2013-07-17 07:20:34 UTC (rev 152768)
</span><span class="lines">@@ -0,0 +1,9 @@
</span><ins>+&lt;!doctype html&gt;
+&lt;html&gt;
+    &lt;head&gt;
+        &lt;title&gt;118587 - ASSERTION FAILED: layoutState-&amp;gt;m_renderer == this in WebCore::RenderBlock::offsetFromLogicalTopOfFirstPage&lt;/title&gt;
+    &lt;/head&gt;
+
+    &lt;div style=&quot;-webkit-flow-into: flow&quot; &gt;FAIL: this should not be visible as it's not flowed anywhere.&lt;/div&gt;
+    &lt;body style=&quot;-webkit-writing-mode: vertical-rl;&quot;&gt;PASS: test for 118587 - passes if it doesn't crash or assert.&lt;/body&gt;
+&lt;/html&gt;
</ins><span class="cx">\ No newline at end of file
</span></span></pre></div>
<a id="trunkSourceWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/ChangeLog (152767 => 152768)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/ChangeLog        2013-07-17 07:19:15 UTC (rev 152767)
+++ trunk/Source/WebCore/ChangeLog        2013-07-17 07:20:34 UTC (rev 152768)
</span><span class="lines">@@ -1,3 +1,19 @@
</span><ins>+2013-07-17  Mihai Maerean  &lt;mmaerean@adobe.com&gt;
+
+        ASSERTION FAILED: layoutState-&gt;m_renderer == this in WebCore::RenderBlock::offsetFromLogicalTopOfFirstPage
+        https://bugs.webkit.org/show_bug.cgi?id=118587
+
+        Reviewed by David Hyatt.
+
+        The fix consists in not calling containingBlockLogicalHeightForPositioned for flow threads (in
+        RenderBox::availableLogicalHeightUsing) as it gets to handle the RenderView as it would have been flowed into
+        the flow thread.
+
+        Test: fast/regions/crash-div-outside-body-vertical-rl.html
+
+        * rendering/RenderBox.cpp:
+        (WebCore::RenderBox::availableLogicalHeightUsing):
+
</ins><span class="cx"> 2013-07-17  Kangil Han  &lt;kangil.han@samsung.com&gt;
</span><span class="cx"> 
</span><span class="cx">         Use toHTMLMediaElement
</span></span></pre></div>
<a id="trunkSourceWebCorerenderingRenderBoxcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/rendering/RenderBox.cpp (152767 => 152768)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/rendering/RenderBox.cpp        2013-07-17 07:19:15 UTC (rev 152767)
+++ trunk/Source/WebCore/rendering/RenderBox.cpp        2013-07-17 07:20:34 UTC (rev 152768)
</span><span class="lines">@@ -2854,7 +2854,7 @@
</span><span class="cx">         return logicalHeight() - borderAndPaddingLogicalHeight();
</span><span class="cx">     }
</span><span class="cx"> 
</span><del>-    if (h.isPercent() &amp;&amp; isOutOfFlowPositioned()) {
</del><ins>+    if (h.isPercent() &amp;&amp; isOutOfFlowPositioned() &amp;&amp; !isRenderFlowThread()) {
</ins><span class="cx">         // FIXME: This is wrong if the containingBlock has a perpendicular writing mode.
</span><span class="cx">         LayoutUnit availableHeight = containingBlockLogicalHeightForPositioned(containingBlock());
</span><span class="cx">         return adjustContentBoxLogicalHeightForBoxSizing(valueForLength(h, availableHeight));
</span></span></pre>
</div>
</div>

</body>
</html>