<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[152141] trunk/Source/WebInspectorUI</title>
</head>
<body>

<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt;  }
#msg dl a { font-weight: bold}
#msg dl a:link    { color:#fc3; }
#msg dl a:active  { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff  {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/152141">152141</a></dd>
<dt>Author</dt> <dd>commit-queue@webkit.org</dd>
<dt>Date</dt> <dd>2013-06-27 17:17:22 -0700 (Thu, 27 Jun 2013)</dd>
</dl>

<h3>Log Message</h3>
<pre>Web Inspector: AX: Add container ARIA roles (toolbar, main, labeled regions, etc.)
so the layout is more discoverable to screen reader users
https://bugs.webkit.org/show_bug.cgi?id=118104

Patch by James Craig &lt;james@cookiecrook.com&gt; on 2013-06-27
Reviewed by Timothy Hatcher.

Made the basic layout (toolbar, sidebars, main) of the Web Inspector understandable
and navigable with VoiceOver.

* Localizations/en.lproj/localizedStrings.js:
* UserInterface/ButtonNavigationItem.js:
* UserInterface/CSSStyleDetailsSidebarPanel.js:
* UserInterface/DashboardManager.js:
* UserInterface/Main.js:
* UserInterface/NavigationBar.js:
* UserInterface/NavigationItem.js:
* UserInterface/NavigationSidebarPanel.js:
* UserInterface/RadioButtonNavigationItem.js:
* UserInterface/Sidebar.js:
* UserInterface/SidebarPanel.js:
* UserInterface/Toolbar.js:</pre>

<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkSourceWebInspectorUIChangeLog">trunk/Source/WebInspectorUI/ChangeLog</a></li>
<li><a href="#trunkSourceWebInspectorUILocalizationsenlprojlocalizedStringsjs">trunk/Source/WebInspectorUI/Localizations/en.lproj/localizedStrings.js</a></li>
<li><a href="#trunkSourceWebInspectorUIUserInterfaceButtonNavigationItemjs">trunk/Source/WebInspectorUI/UserInterface/ButtonNavigationItem.js</a></li>
<li><a href="#trunkSourceWebInspectorUIUserInterfaceCSSStyleDetailsSidebarPaneljs">trunk/Source/WebInspectorUI/UserInterface/CSSStyleDetailsSidebarPanel.js</a></li>
<li><a href="#trunkSourceWebInspectorUIUserInterfaceDashboardManagerjs">trunk/Source/WebInspectorUI/UserInterface/DashboardManager.js</a></li>
<li><a href="#trunkSourceWebInspectorUIUserInterfaceMainjs">trunk/Source/WebInspectorUI/UserInterface/Main.js</a></li>
<li><a href="#trunkSourceWebInspectorUIUserInterfaceNavigationBarjs">trunk/Source/WebInspectorUI/UserInterface/NavigationBar.js</a></li>
<li><a href="#trunkSourceWebInspectorUIUserInterfaceNavigationItemjs">trunk/Source/WebInspectorUI/UserInterface/NavigationItem.js</a></li>
<li><a href="#trunkSourceWebInspectorUIUserInterfaceNavigationSidebarPaneljs">trunk/Source/WebInspectorUI/UserInterface/NavigationSidebarPanel.js</a></li>
<li><a href="#trunkSourceWebInspectorUIUserInterfaceRadioButtonNavigationItemjs">trunk/Source/WebInspectorUI/UserInterface/RadioButtonNavigationItem.js</a></li>
<li><a href="#trunkSourceWebInspectorUIUserInterfaceSidebarjs">trunk/Source/WebInspectorUI/UserInterface/Sidebar.js</a></li>
<li><a href="#trunkSourceWebInspectorUIUserInterfaceSidebarPaneljs">trunk/Source/WebInspectorUI/UserInterface/SidebarPanel.js</a></li>
<li><a href="#trunkSourceWebInspectorUIUserInterfaceToolbarjs">trunk/Source/WebInspectorUI/UserInterface/Toolbar.js</a></li>
</ul>

</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkSourceWebInspectorUIChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebInspectorUI/ChangeLog (152140 => 152141)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebInspectorUI/ChangeLog        2013-06-28 00:14:57 UTC (rev 152140)
+++ trunk/Source/WebInspectorUI/ChangeLog        2013-06-28 00:17:22 UTC (rev 152141)
</span><span class="lines">@@ -1,5 +1,29 @@
</span><span class="cx"> 2013-06-27  James Craig  &lt;james@cookiecrook.com&gt;
</span><span class="cx"> 
</span><ins>+        Web Inspector: AX: Add container ARIA roles (toolbar, main, labeled regions, etc.) 
+        so the layout is more discoverable to screen reader users
+        https://bugs.webkit.org/show_bug.cgi?id=118104
+
+        Reviewed by Timothy Hatcher.
+
+        Made the basic layout (toolbar, sidebars, main) of the Web Inspector understandable
+        and navigable with VoiceOver.
+
+        * Localizations/en.lproj/localizedStrings.js:
+        * UserInterface/ButtonNavigationItem.js:
+        * UserInterface/CSSStyleDetailsSidebarPanel.js:
+        * UserInterface/DashboardManager.js:
+        * UserInterface/Main.js:
+        * UserInterface/NavigationBar.js:
+        * UserInterface/NavigationItem.js:
+        * UserInterface/NavigationSidebarPanel.js:
+        * UserInterface/RadioButtonNavigationItem.js:
+        * UserInterface/Sidebar.js:
+        * UserInterface/SidebarPanel.js:
+        * UserInterface/Toolbar.js:
+
+2013-06-27  James Craig  &lt;james@cookiecrook.com&gt;
+
</ins><span class="cx">         Web Inspector: AX: Console log of the Inspector does not announce output for screen readers
</span><span class="cx">         https://bugs.webkit.org/show_bug.cgi?id=115976
</span><span class="cx"> 
</span></span></pre></div>
<a id="trunkSourceWebInspectorUILocalizationsenlprojlocalizedStringsjs"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebInspectorUI/Localizations/en.lproj/localizedStrings.js (152140 => 152141)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebInspectorUI/Localizations/en.lproj/localizedStrings.js        2013-06-28 00:14:57 UTC (rev 152140)
+++ trunk/Source/WebInspectorUI/Localizations/en.lproj/localizedStrings.js        2013-06-28 00:17:22 UTC (rev 152141)
</span><span class="lines">@@ -28,6 +28,7 @@
</span><span class="cx"> localizedStrings[&quot;(anonymous function)&quot;] = &quot;(anonymous function)&quot;;
</span><span class="cx"> localizedStrings[&quot;1 match&quot;] = &quot;1 match&quot;;
</span><span class="cx"> localizedStrings[&quot;999+&quot;] = &quot;999+&quot;;
</span><ins>+localizedStrings[&quot;Activity Viewer&quot;] = &quot;Activity Viewer&quot;;
</ins><span class="cx"> localizedStrings[&quot;Add Attribute&quot;] = &quot;Add Attribute&quot;;
</span><span class="cx"> localizedStrings[&quot;Add New&quot;] = &quot;Add New&quot;;
</span><span class="cx"> localizedStrings[&quot;All&quot;] = &quot;All&quot;;
</span><span class="lines">@@ -82,6 +83,7 @@
</span><span class="cx"> localizedStrings[&quot;Console errors, click to show the Console&quot;] = &quot;Console errors, click to show the Console&quot;;
</span><span class="cx"> localizedStrings[&quot;Console logs, click to show the Console&quot;] = &quot;Console logs, click to show the Console&quot;;
</span><span class="cx"> localizedStrings[&quot;Console warnings, click to show the Console&quot;] = &quot;Console warnings, click to show the Console&quot;;
</span><ins>+localizedStrings[&quot;Content&quot;] = &quot;Content&quot;;
</ins><span class="cx"> localizedStrings[&quot;Continue script execution (%s or %s)&quot;] = &quot;Continue script execution (%s or %s)&quot;;
</span><span class="cx"> localizedStrings[&quot;Cookies&quot;] = &quot;Cookies&quot;;
</span><span class="cx"> localizedStrings[&quot;Copy Row&quot;] = &quot;Copy Row&quot;;
</span></span></pre></div>
<a id="trunkSourceWebInspectorUIUserInterfaceButtonNavigationItemjs"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebInspectorUI/UserInterface/ButtonNavigationItem.js (152140 => 152141)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebInspectorUI/UserInterface/ButtonNavigationItem.js        2013-06-28 00:14:57 UTC (rev 152140)
+++ trunk/Source/WebInspectorUI/UserInterface/ButtonNavigationItem.js        2013-06-28 00:17:22 UTC (rev 152141)
</span><span class="lines">@@ -23,7 +23,7 @@
</span><span class="cx">  * THE POSSIBILITY OF SUCH DAMAGE.
</span><span class="cx">  */
</span><span class="cx"> 
</span><del>-WebInspector.ButtonNavigationItem = function(identifier, toolTipOrLabel, image, imageWidth, imageHeight, suppressEmboss) {
</del><ins>+WebInspector.ButtonNavigationItem = function(identifier, toolTipOrLabel, image, imageWidth, imageHeight, suppressEmboss, role, label) {
</ins><span class="cx">     WebInspector.NavigationItem.call(this, identifier);
</span><span class="cx"> 
</span><span class="cx">     console.assert(identifier);
</span><span class="lines">@@ -32,6 +32,11 @@
</span><span class="cx">     this.toolTip = toolTipOrLabel;
</span><span class="cx"> 
</span><span class="cx">     this._element.addEventListener(&quot;click&quot;, this._mouseClicked.bind(this));
</span><ins>+    
+    this._element.setAttribute(&quot;role&quot;, role || &quot;button&quot;);
+    
+    if (label) 
+        this._element.setAttribute(&quot;aria-label&quot;, label);
</ins><span class="cx"> 
</span><span class="cx">     this._imageWidth = imageWidth || 16;
</span><span class="cx">     this._imageHeight = imageHeight || 16;
</span></span></pre></div>
<a id="trunkSourceWebInspectorUIUserInterfaceCSSStyleDetailsSidebarPaneljs"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebInspectorUI/UserInterface/CSSStyleDetailsSidebarPanel.js (152140 => 152141)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebInspectorUI/UserInterface/CSSStyleDetailsSidebarPanel.js        2013-06-28 00:14:57 UTC (rev 152140)
+++ trunk/Source/WebInspectorUI/UserInterface/CSSStyleDetailsSidebarPanel.js        2013-06-28 00:17:22 UTC (rev 152141)
</span><span class="lines">@@ -29,7 +29,7 @@
</span><span class="cx"> 
</span><span class="cx">     this._selectedPanel = null;
</span><span class="cx"> 
</span><del>-    this._navigationBar = new WebInspector.NavigationBar;
</del><ins>+    this._navigationBar = new WebInspector.NavigationBar(null, null, &quot;tablist&quot;);
</ins><span class="cx">     this._navigationBar.addEventListener(WebInspector.NavigationBar.Event.NavigationItemSelected, this._navigationItemSelected, this);
</span><span class="cx">     this.element.appendChild(this._navigationBar.element);
</span><span class="cx"> 
</span></span></pre></div>
<a id="trunkSourceWebInspectorUIUserInterfaceDashboardManagerjs"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebInspectorUI/UserInterface/DashboardManager.js (152140 => 152141)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebInspectorUI/UserInterface/DashboardManager.js        2013-06-28 00:14:57 UTC (rev 152140)
+++ trunk/Source/WebInspectorUI/UserInterface/DashboardManager.js        2013-06-28 00:17:22 UTC (rev 152141)
</span><span class="lines">@@ -26,7 +26,7 @@
</span><span class="cx"> WebInspector.DashboardManager = function() {
</span><span class="cx">     WebInspector.Object.call(this);
</span><span class="cx"> 
</span><del>-    this.toolbarItem = new WebInspector.NavigationItem(&quot;dashboard&quot;);
</del><ins>+    this.toolbarItem = new WebInspector.NavigationItem(&quot;dashboard&quot;, &quot;group&quot;, WebInspector.UIString(&quot;Activity Viewer&quot;));
</ins><span class="cx">     this._view = new WebInspector.DashboardView(this.toolbarItem.element);
</span><span class="cx"> 
</span><span class="cx">     this._waitingForFirstMainResourceToStartTrackingSize = true;
</span></span></pre></div>
<a id="trunkSourceWebInspectorUIUserInterfaceMainjs"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebInspectorUI/UserInterface/Main.js (152140 => 152141)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebInspectorUI/UserInterface/Main.js        2013-06-28 00:14:57 UTC (rev 152140)
+++ trunk/Source/WebInspectorUI/UserInterface/Main.js        2013-06-28 00:17:22 UTC (rev 152141)
</span><span class="lines">@@ -144,6 +144,10 @@
</span><span class="cx">     this.toolbar = new WebInspector.Toolbar(document.getElementById(&quot;toolbar&quot;));
</span><span class="cx">     this.toolbar.addEventListener(WebInspector.Toolbar.Event.DisplayModeDidChange, this._toolbarDisplayModeDidChange, this);
</span><span class="cx">     this.toolbar.addEventListener(WebInspector.Toolbar.Event.SizeModeDidChange, this._toolbarSizeModeDidChange, this);
</span><ins>+    
+    var contentElement = document.getElementById(&quot;content&quot;);
+    contentElement.setAttribute(&quot;role&quot;, &quot;main&quot;);
+    contentElement.setAttribute(&quot;aria-label&quot;, WebInspector.UIString(&quot;Content&quot;));
</ins><span class="cx"> 
</span><span class="cx">     this.contentBrowser = new WebInspector.ContentBrowser(document.getElementById(&quot;content-browser&quot;), this);
</span><span class="cx">     this.contentBrowser.addEventListener(WebInspector.ContentBrowser.Event.CurrentRepresentedObjectsDidChange, this._contentBrowserRepresentedObjectsDidChange, this);
</span><span class="lines">@@ -165,7 +169,7 @@
</span><span class="cx">     this.navigationSidebar.addEventListener(WebInspector.Sidebar.Event.WidthDidChange, this._sidebarWidthDidChange, this);
</span><span class="cx">     this.navigationSidebar.addEventListener(WebInspector.Sidebar.Event.SidebarPanelSelected, this._navigationSidebarPanelSelected, this);
</span><span class="cx"> 
</span><del>-    this.rightSidebar = this.detailsSidebar = new WebInspector.Sidebar(document.getElementById(&quot;details-sidebar&quot;), WebInspector.Sidebar.Sides.Right);
</del><ins>+    this.rightSidebar = this.detailsSidebar = new WebInspector.Sidebar(document.getElementById(&quot;details-sidebar&quot;), WebInspector.Sidebar.Sides.Right, &quot;group&quot;, WebInspector.UIString(&quot;Details&quot;));
</ins><span class="cx">     this.detailsSidebar.addEventListener(WebInspector.Sidebar.Event.CollapsedStateDidChange, this._sidebarCollapsedStateDidChange, this);
</span><span class="cx">     this.detailsSidebar.addEventListener(WebInspector.Sidebar.Event.WidthDidChange, this._sidebarWidthDidChange, this);
</span><span class="cx">     this.detailsSidebar.addEventListener(WebInspector.Sidebar.Event.SidebarPanelSelected, this._detailsSidebarPanelSelected, this);
</span></span></pre></div>
<a id="trunkSourceWebInspectorUIUserInterfaceNavigationBarjs"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebInspectorUI/UserInterface/NavigationBar.js (152140 => 152141)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebInspectorUI/UserInterface/NavigationBar.js        2013-06-28 00:14:57 UTC (rev 152140)
+++ trunk/Source/WebInspectorUI/UserInterface/NavigationBar.js        2013-06-28 00:17:22 UTC (rev 152141)
</span><span class="lines">@@ -23,12 +23,17 @@
</span><span class="cx">  * THE POSSIBILITY OF SUCH DAMAGE.
</span><span class="cx">  */
</span><span class="cx"> 
</span><del>-WebInspector.NavigationBar = function(element, navigationItems) {
</del><ins>+WebInspector.NavigationBar = function(element, navigationItems, role, label) {
</ins><span class="cx">     WebInspector.Object.call(this);
</span><span class="cx"> 
</span><span class="cx">     this._element = element || document.createElement(&quot;div&quot;);
</span><span class="cx">     this._element.classList.add(this.constructor.StyleClassName || WebInspector.NavigationBar.StyleClassName);
</span><span class="cx">     this._element.tabIndex = 0;
</span><ins>+    
+    if (role)
+        this._element.setAttribute(&quot;role&quot;, role);
+    if (label)
+        this._element.setAttribute(&quot;aria-label&quot;, label);
</ins><span class="cx"> 
</span><span class="cx">     this._element.addEventListener(&quot;focus&quot;, this._focus.bind(this), false);
</span><span class="cx">     this._element.addEventListener(&quot;blur&quot;, this._blur.bind(this), false);
</span></span></pre></div>
<a id="trunkSourceWebInspectorUIUserInterfaceNavigationItemjs"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebInspectorUI/UserInterface/NavigationItem.js (152140 => 152141)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebInspectorUI/UserInterface/NavigationItem.js        2013-06-28 00:14:57 UTC (rev 152140)
+++ trunk/Source/WebInspectorUI/UserInterface/NavigationItem.js        2013-06-28 00:17:22 UTC (rev 152141)
</span><span class="lines">@@ -23,12 +23,17 @@
</span><span class="cx">  * THE POSSIBILITY OF SUCH DAMAGE.
</span><span class="cx">  */
</span><span class="cx"> 
</span><del>-WebInspector.NavigationItem = function(identifier) {
</del><ins>+WebInspector.NavigationItem = function(identifier, role, label) {
</ins><span class="cx">     WebInspector.Object.call(this);
</span><span class="cx"> 
</span><span class="cx">     this._identifier = identifier || null;
</span><span class="cx"> 
</span><span class="cx">     this._element = document.createElement(&quot;div&quot;);
</span><ins>+    
+    if (role) 
+        this._element.setAttribute(&quot;role&quot;, role);
+    if (label)
+        this._element.setAttribute(&quot;aria-label&quot;, label);
</ins><span class="cx"> 
</span><span class="cx">     var classNames = this._classNames;
</span><span class="cx">     for (var i = 0; i &lt; classNames.length; ++i)
</span></span></pre></div>
<a id="trunkSourceWebInspectorUIUserInterfaceNavigationSidebarPaneljs"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebInspectorUI/UserInterface/NavigationSidebarPanel.js (152140 => 152141)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebInspectorUI/UserInterface/NavigationSidebarPanel.js        2013-06-28 00:14:57 UTC (rev 152140)
+++ trunk/Source/WebInspectorUI/UserInterface/NavigationSidebarPanel.js        2013-06-28 00:17:22 UTC (rev 152141)
</span><span class="lines">@@ -23,7 +23,7 @@
</span><span class="cx">  * THE POSSIBILITY OF SUCH DAMAGE.
</span><span class="cx">  */
</span><span class="cx"> 
</span><del>-WebInspector.NavigationSidebarPanel = function(identifier, displayName, image, keyboardShortcutKey, autoPruneOldTopLevelResourceTreeElements, autoHideToolbarItemWhenEmpty, wantsTopOverflowShadow, element) {
</del><ins>+WebInspector.NavigationSidebarPanel = function(identifier, displayName, image, keyboardShortcutKey, autoPruneOldTopLevelResourceTreeElements, autoHideToolbarItemWhenEmpty, wantsTopOverflowShadow, element, role, label) {
</ins><span class="cx">     if (keyboardShortcutKey)
</span><span class="cx">         this._keyboardShortcut = new WebInspector.KeyboardShortcut(WebInspector.KeyboardShortcut.Modifier.Control, keyboardShortcutKey, this.toggle.bind(this));
</span><span class="cx"> 
</span><span class="lines">@@ -35,7 +35,7 @@
</span><span class="cx">         var hideToolTip = WebInspector.UIString(&quot;Hide the %s navigation sidebar&quot;).format(displayName);
</span><span class="cx">     }
</span><span class="cx"> 
</span><del>-    WebInspector.SidebarPanel.call(this, identifier, displayName, showToolTip, hideToolTip, image, element);
</del><ins>+    WebInspector.SidebarPanel.call(this, identifier, displayName, showToolTip, hideToolTip, image, element, role, label || displayName);
</ins><span class="cx"> 
</span><span class="cx">     this.element.classList.add(WebInspector.NavigationSidebarPanel.StyleClassName);
</span><span class="cx"> 
</span></span></pre></div>
<a id="trunkSourceWebInspectorUIUserInterfaceRadioButtonNavigationItemjs"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebInspectorUI/UserInterface/RadioButtonNavigationItem.js (152140 => 152141)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebInspectorUI/UserInterface/RadioButtonNavigationItem.js        2013-06-28 00:14:57 UTC (rev 152140)
+++ trunk/Source/WebInspectorUI/UserInterface/RadioButtonNavigationItem.js        2013-06-28 00:17:22 UTC (rev 152141)
</span><span class="lines">@@ -24,7 +24,7 @@
</span><span class="cx">  */
</span><span class="cx"> 
</span><span class="cx"> WebInspector.RadioButtonNavigationItem = function(identifier, toolTip, image, imageWidth, imageHeight) {
</span><del>-    WebInspector.ButtonNavigationItem.call(this, identifier, toolTip, image, imageWidth, imageHeight);
</del><ins>+    WebInspector.ButtonNavigationItem.call(this, identifier, toolTip, image, imageWidth, imageHeight, null, &quot;tab&quot;);
</ins><span class="cx"> };
</span><span class="cx"> 
</span><span class="cx"> WebInspector.RadioButtonNavigationItem.StyleClassName = &quot;radio&quot;;
</span><span class="lines">@@ -43,10 +43,13 @@
</span><span class="cx"> 
</span><span class="cx">     set selected(flag)
</span><span class="cx">     {
</span><del>-        if (flag)
</del><ins>+        if (flag) {
</ins><span class="cx">             this.element.classList.add(WebInspector.RadioButtonNavigationItem.SelectedStyleClassName);
</span><del>-        else
</del><ins>+            this.element.setAttribute(&quot;aria-selected&quot;, &quot;true&quot;);
+        } else {
</ins><span class="cx">             this.element.classList.remove(WebInspector.RadioButtonNavigationItem.SelectedStyleClassName);
</span><ins>+            this.element.setAttribute(&quot;aria-selected&quot;, &quot;false&quot;);
+        }
</ins><span class="cx">     },
</span><span class="cx"> 
</span><span class="cx">     get active()
</span><span class="lines">@@ -85,15 +88,19 @@
</span><span class="cx"> 
</span><span class="cx">         var isSelected = this.selected;
</span><span class="cx"> 
</span><del>-        if (!isSelected)
</del><ins>+        if (!isSelected) {
</ins><span class="cx">             this.element.classList.add(WebInspector.RadioButtonNavigationItem.SelectedStyleClassName);
</span><ins>+            this.element.setAttribute(&quot;aria-selected&quot;, &quot;true&quot;);
+        }
</ins><span class="cx"> 
</span><span class="cx">         var selectedWidth = this.element.offsetWidth;
</span><span class="cx">         if (selectedWidth)
</span><span class="cx">             this.element.style.minWidth = selectedWidth + &quot;px&quot;;
</span><span class="cx"> 
</span><del>-        if (!isSelected)
</del><ins>+        if (!isSelected) {
</ins><span class="cx">             this.element.classList.remove(WebInspector.RadioButtonNavigationItem.SelectedStyleClassName);
</span><ins>+            this.element.setAttribute(&quot;aria-selected&quot;, &quot;false&quot;);
+        }
</ins><span class="cx">     },
</span><span class="cx"> 
</span><span class="cx">     // Private
</span></span></pre></div>
<a id="trunkSourceWebInspectorUIUserInterfaceSidebarjs"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebInspectorUI/UserInterface/Sidebar.js (152140 => 152141)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebInspectorUI/UserInterface/Sidebar.js        2013-06-28 00:14:57 UTC (rev 152140)
+++ trunk/Source/WebInspectorUI/UserInterface/Sidebar.js        2013-06-28 00:17:22 UTC (rev 152141)
</span><span class="lines">@@ -23,7 +23,7 @@
</span><span class="cx">  * THE POSSIBILITY OF SUCH DAMAGE.
</span><span class="cx">  */
</span><span class="cx"> 
</span><del>-WebInspector.Sidebar = function(element, side, sidebarPanels) {
</del><ins>+WebInspector.Sidebar = function(element, side, sidebarPanels, role, label) {
</ins><span class="cx">     WebInspector.Object.call(this);
</span><span class="cx"> 
</span><span class="cx">     console.assert(!side || side === WebInspector.Sidebar.Sides.Left || side === WebInspector.Sidebar.Sides.Right);
</span><span class="lines">@@ -34,6 +34,10 @@
</span><span class="cx">     this._element.classList.add(WebInspector.Sidebar.CollapsedStyleClassName);
</span><span class="cx">     this._element.classList.add(this._side);
</span><span class="cx"> 
</span><ins>+    this._element.setAttribute(&quot;role&quot;, role || &quot;group&quot;);
+    if (label)
+        this._element.setAttribute(&quot;aria-label&quot;, label);
+
</ins><span class="cx">     this._resizeElement = document.createElement(&quot;div&quot;);
</span><span class="cx">     this._resizeElement.classList.add(WebInspector.Sidebar.ResizeElementStyleClassName);
</span><span class="cx">     this._resizeElement.addEventListener(&quot;mousedown&quot;, this._resizerMouseDown.bind(this), false);
</span></span></pre></div>
<a id="trunkSourceWebInspectorUIUserInterfaceSidebarPaneljs"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebInspectorUI/UserInterface/SidebarPanel.js (152140 => 152141)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebInspectorUI/UserInterface/SidebarPanel.js        2013-06-28 00:14:57 UTC (rev 152140)
+++ trunk/Source/WebInspectorUI/UserInterface/SidebarPanel.js        2013-06-28 00:17:22 UTC (rev 152141)
</span><span class="lines">@@ -23,7 +23,7 @@
</span><span class="cx">  * THE POSSIBILITY OF SUCH DAMAGE.
</span><span class="cx">  */
</span><span class="cx"> 
</span><del>-WebInspector.SidebarPanel = function(identifier, displayName, showToolTip, hideToolTip, image, element) {
</del><ins>+WebInspector.SidebarPanel = function(identifier, displayName, showToolTip, hideToolTip, image, element, role, label) {
</ins><span class="cx">     WebInspector.Object.call(this);
</span><span class="cx"> 
</span><span class="cx">     this._identifier = identifier;
</span><span class="lines">@@ -35,6 +35,10 @@
</span><span class="cx">     this._element = element || document.createElement(&quot;div&quot;);
</span><span class="cx">     this._element.classList.add(WebInspector.SidebarPanel.StyleClassName);
</span><span class="cx">     this._element.classList.add(identifier);
</span><ins>+
+    this._element.setAttribute(&quot;role&quot;, role || &quot;group&quot;);
+    this._element.setAttribute(&quot;aria-label&quot;, label || displayName);
+
</ins><span class="cx"> };
</span><span class="cx"> 
</span><span class="cx"> WebInspector.SidebarPanel.StyleClassName = &quot;panel&quot;;
</span></span></pre></div>
<a id="trunkSourceWebInspectorUIUserInterfaceToolbarjs"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebInspectorUI/UserInterface/Toolbar.js (152140 => 152141)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebInspectorUI/UserInterface/Toolbar.js        2013-06-28 00:14:57 UTC (rev 152140)
+++ trunk/Source/WebInspectorUI/UserInterface/Toolbar.js        2013-06-28 00:17:22 UTC (rev 152141)
</span><span class="lines">@@ -24,7 +24,7 @@
</span><span class="cx">  */
</span><span class="cx"> 
</span><span class="cx"> WebInspector.Toolbar = function(element, navigationItems) {
</span><del>-    WebInspector.NavigationBar.call(this, element, navigationItems);
</del><ins>+    WebInspector.NavigationBar.call(this, element, navigationItems, &quot;toolbar&quot;);
</ins><span class="cx"> 
</span><span class="cx">     this.displayMode = WebInspector.Toolbar.DisplayMode.IconAndLabelVertical;
</span><span class="cx">     this.sizeMode = WebInspector.Toolbar.SizeMode.Normal;
</span></span></pre>
</div>
</div>

</body>
</html>