<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[151665] trunk</title>
</head>
<body>

<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt;  }
#msg dl a { font-weight: bold}
#msg dl a:link    { color:#fc3; }
#msg dl a:active  { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff  {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/151665">151665</a></dd>
<dt>Author</dt> <dd>bfulgham@apple.com</dd>
<dt>Date</dt> <dd>2013-06-17 18:30:44 -0700 (Mon, 17 Jun 2013)</dd>
</dl>

<h3>Log Message</h3>
<pre>AX: Correct accessibility role when -webkit-box:display is used.
https://bugs.webkit.org/show_bug.cgi?id=117706

Reviewed by Chris Fleizach.

Source/WebCore: 

accessibility/box-styled-lists.html

* accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::determineAccessibilityRole): If HTML token is
of the list element type, treat it as a ListItemRole accessibility role, regardless
of what specific renderer is being used.

LayoutTests: 

* accessibility/box-styled-lists.html: Added.
* platform/efl/TestExpectations:
* platform/gtk/TestExpectations:
* platform/mac/accessibility/box-styled-lists-expected.txt: Added.
* platform/win/TestExpectations:
* platform/win/accessibility/box-styled-lists-expected.txt: Added.</pre>

<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkLayoutTestsChangeLog">trunk/LayoutTests/ChangeLog</a></li>
<li><a href="#trunkLayoutTestsplatformeflTestExpectations">trunk/LayoutTests/platform/efl/TestExpectations</a></li>
<li><a href="#trunkLayoutTestsplatformgtkTestExpectations">trunk/LayoutTests/platform/gtk/TestExpectations</a></li>
<li><a href="#trunkSourceWebCoreChangeLog">trunk/Source/WebCore/ChangeLog</a></li>
<li><a href="#trunkSourceWebCoreaccessibilityAccessibilityRenderObjectcpp">trunk/Source/WebCore/accessibility/AccessibilityRenderObject.cpp</a></li>
</ul>

<h3>Added Paths</h3>
<ul>
<li><a href="#trunkLayoutTestsaccessibilityboxstyledlistshtml">trunk/LayoutTests/accessibility/box-styled-lists.html</a></li>
<li><a href="#trunkLayoutTestsplatformmacaccessibilityboxstyledlistsexpectedtxt">trunk/LayoutTests/platform/mac/accessibility/box-styled-lists-expected.txt</a></li>
<li><a href="#trunkLayoutTestsplatformwinaccessibilityboxstyledlistsexpectedtxt">trunk/LayoutTests/platform/win/accessibility/box-styled-lists-expected.txt</a></li>
</ul>

</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkLayoutTestsChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/ChangeLog (151664 => 151665)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/ChangeLog        2013-06-18 01:19:13 UTC (rev 151664)
+++ trunk/LayoutTests/ChangeLog        2013-06-18 01:30:44 UTC (rev 151665)
</span><span class="lines">@@ -1,3 +1,17 @@
</span><ins>+2013-06-17  Brent Fulgham  &lt;bfulgham@apple.com&gt;
+
+        AX: Correct accessibility role when -webkit-box:display is used.
+        https://bugs.webkit.org/show_bug.cgi?id=117706
+
+        Reviewed by Chris Fleizach.
+
+        * accessibility/box-styled-lists.html: Added.
+        * platform/efl/TestExpectations:
+        * platform/gtk/TestExpectations:
+        * platform/mac/accessibility/box-styled-lists-expected.txt: Added.
+        * platform/win/TestExpectations:
+        * platform/win/accessibility/box-styled-lists-expected.txt: Added.
+
</ins><span class="cx"> 2013-06-17  Ryosuke Niwa  &lt;rniwa@webkit.org&gt;
</span><span class="cx"> 
</span><span class="cx">         Mac rebaseline.
</span></span></pre></div>
<a id="trunkLayoutTestsaccessibilityboxstyledlistshtml"></a>
<div class="addfile"><h4>Added: trunk/LayoutTests/accessibility/box-styled-lists.html (0 => 151665)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/accessibility/box-styled-lists.html                                (rev 0)
+++ trunk/LayoutTests/accessibility/box-styled-lists.html        2013-06-18 01:30:44 UTC (rev 151665)
</span><span class="lines">@@ -0,0 +1,54 @@
</span><ins>+&lt;!DOCTYPE html&gt;
+&lt;html&gt;
+&lt;script&gt;
+
+    if (window.testRunner)
+        testRunner.dumpAsText();
+&lt;/script&gt;
+&lt;head&gt;
+&lt;style&gt;
+    ol {
+        display: -webkit-box;
+    }
+    ul {
+        display: -webkit-box;
+    }
+    li {
+        display: -webkit-box;
+    }
+&lt;/style&gt; 
+&lt;/head&gt;
+&lt;body id=&quot;body&quot;&gt;
+  &lt;div&gt;
+    &lt;div&gt;
+      &lt;ul&gt;
+        &lt;li id=&quot;test 1&quot;&gt;test 1&lt;/li&gt;
+        &lt;li&gt;test 2&lt;/li&gt;
+      &lt;/ul&gt;
+    &lt;/div&gt;
+  &lt;/div&gt;
+  &lt;div&gt;
+    &lt;div&gt;
+      &lt;ol&gt;
+        &lt;li id=&quot;test a&quot;&gt;test a&lt;/li&gt;
+        &lt;li&gt;test b&lt;/li&gt;
+      &lt;/ol&gt;
+    &lt;/div&gt;
+  &lt;/div&gt;
+
+    &lt;BR&gt;&lt;BR&gt;&lt;BR&gt;&lt;hr&gt;&lt;BR&gt;
+    &lt;div id=&quot;result&quot;&gt;&lt;/div&gt;    
+
+    &lt;script&gt;
+        if (window.accessibilityController) {
+            var result = document.getElementById(&quot;result&quot;);
+
+            var olListElement = window.accessibilityController.accessibleElementById(&quot;test 1&quot;);
+            result.innerText += 'il in ol role: ' + olListElement.role + &quot;\n\n&quot;;
+
+            var ulListElement = window.accessibilityController.accessibleElementById(&quot;test a&quot;);
+            result.innerText += 'il in ul role: ' + ulListElement.role + &quot;\n\n&quot;;
+        }
+    &lt;/script&gt;
+&lt;/body&gt;
+&lt;/html&gt;
</ins></span></pre></div>
<a id="trunkLayoutTestsplatformeflTestExpectations"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/platform/efl/TestExpectations (151664 => 151665)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/platform/efl/TestExpectations        2013-06-18 01:19:13 UTC (rev 151664)
+++ trunk/LayoutTests/platform/efl/TestExpectations        2013-06-18 01:30:44 UTC (rev 151665)
</span><span class="lines">@@ -1778,3 +1778,5 @@
</span><span class="cx"> webkit.org/b/116587 http/tests/websocket/tests/hybi/close-on-navigate-new-location.html [ Skip ]
</span><span class="cx"> webkit.org/b/116587 http/tests/websocket/tests/hybi/multiple-subprotocols.html [ Skip ]
</span><span class="cx"> webkit.org/b/116587 http/tests/websocket/tests/hybi/reload-crash.html [ Skip ]
</span><ins>+
+webkit.org/b/117706 accessibility/box-styled-lists.html [ Failure ]
</ins></span></pre></div>
<a id="trunkLayoutTestsplatformgtkTestExpectations"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/platform/gtk/TestExpectations (151664 => 151665)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/platform/gtk/TestExpectations        2013-06-18 01:19:13 UTC (rev 151664)
+++ trunk/LayoutTests/platform/gtk/TestExpectations        2013-06-18 01:30:44 UTC (rev 151665)
</span><span class="lines">@@ -1409,6 +1409,8 @@
</span><span class="cx"> webkit.org/b/113168 fast/js/large-expressions.html [ Failure ]
</span><span class="cx"> webkit.org/b/113168 fast/js/toString-stack-overflow.html [ Failure ]
</span><span class="cx"> 
</span><ins>+webkit.org/b/117706 accessibility/box-styled-lists.html [ Failure ]
+
</ins><span class="cx"> #////////////////////////////////////////////////////////////////////////////////////////
</span><span class="cx"> # End of Tests failing
</span><span class="cx"> #////////////////////////////////////////////////////////////////////////////////////////
</span></span></pre></div>
<a id="trunkLayoutTestsplatformmacaccessibilityboxstyledlistsexpectedtxt"></a>
<div class="addfile"><h4>Added: trunk/LayoutTests/platform/mac/accessibility/box-styled-lists-expected.txt (0 => 151665)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/platform/mac/accessibility/box-styled-lists-expected.txt                                (rev 0)
+++ trunk/LayoutTests/platform/mac/accessibility/box-styled-lists-expected.txt        2013-06-18 01:30:44 UTC (rev 151665)
</span><span class="lines">@@ -0,0 +1,13 @@
</span><ins>+test 1
+test 2
+test a
+test b
+
+
+
+
+il in ol role: AXRole: AXGroup
+
+il in ul role: AXRole: AXGroup
+
+
</ins></span></pre></div>
<a id="trunkLayoutTestsplatformwinaccessibilityboxstyledlistsexpectedtxt"></a>
<div class="addfile"><h4>Added: trunk/LayoutTests/platform/win/accessibility/box-styled-lists-expected.txt (0 => 151665)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/platform/win/accessibility/box-styled-lists-expected.txt                                (rev 0)
+++ trunk/LayoutTests/platform/win/accessibility/box-styled-lists-expected.txt        2013-06-18 01:30:44 UTC (rev 151665)
</span><span class="lines">@@ -0,0 +1,13 @@
</span><ins>+test 1
+test 2
+test a
+test b
+
+
+
+
+il in ol role: list item
+
+il in ul role: list item
+
+
</ins></span></pre></div>
<a id="trunkSourceWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/ChangeLog (151664 => 151665)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/ChangeLog        2013-06-18 01:19:13 UTC (rev 151664)
+++ trunk/Source/WebCore/ChangeLog        2013-06-18 01:30:44 UTC (rev 151665)
</span><span class="lines">@@ -1,3 +1,17 @@
</span><ins>+2013-06-14  Brent Fulgham  &lt;bfulgham@apple.com&gt;
+
+        AX: Correct accessibility role when -webkit-box:display is used.
+        https://bugs.webkit.org/show_bug.cgi?id=117706
+
+        Reviewed by Chris Fleizach.
+
+        accessibility/box-styled-lists.html
+
+        * accessibility/AccessibilityRenderObject.cpp:
+        (WebCore::AccessibilityRenderObject::determineAccessibilityRole): If HTML token is
+        of the list element type, treat it as a ListItemRole accessibility role, regardless
+        of what specific renderer is being used.
+
</ins><span class="cx"> 2013-06-17  Roger Fong  &lt;roger_fong@apple.com&gt;
</span><span class="cx"> 
</span><span class="cx">         Add some UNUSED_PARAMs to RenderBlock.cpp so that it builds properly if CSS_EXCLUSIONS is disabled.
</span></span></pre></div>
<a id="trunkSourceWebCoreaccessibilityAccessibilityRenderObjectcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/accessibility/AccessibilityRenderObject.cpp (151664 => 151665)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/accessibility/AccessibilityRenderObject.cpp        2013-06-18 01:19:13 UTC (rev 151664)
+++ trunk/Source/WebCore/accessibility/AccessibilityRenderObject.cpp        2013-06-18 01:30:44 UTC (rev 151665)
</span><span class="lines">@@ -2437,7 +2437,7 @@
</span><span class="cx">             return ImageMapRole;
</span><span class="cx">         return WebCoreLinkRole;
</span><span class="cx">     }
</span><del>-    if (cssBox &amp;&amp; cssBox-&gt;isListItem())
</del><ins>+    if ((cssBox &amp;&amp; cssBox-&gt;isListItem()) || (node &amp;&amp; node-&gt;hasTagName(liTag)))
</ins><span class="cx">         return ListItemRole;
</span><span class="cx">     if (m_renderer-&gt;isListMarker())
</span><span class="cx">         return ListMarkerRole;
</span></span></pre>
</div>
</div>

</body>
</html>