<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[150699] trunk/Source</title>
</head>
<body>

<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt;  }
#msg dl a { font-weight: bold}
#msg dl a:link    { color:#fc3; }
#msg dl a:active  { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff  {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/150699">150699</a></dd>
<dt>Author</dt> <dd>akling@apple.com</dd>
<dt>Date</dt> <dd>2013-05-25 19:27:32 -0700 (Sat, 25 May 2013)</dd>
</dl>

<h3>Log Message</h3>
<pre>Remove Document::getFocusableNodes().
&lt;http://webkit.org/b/116773&gt;

Reviewed by Joseph Pecoraro.

Source/WebCore:

This was added in <a href="http://trac.webkit.org/projects/webkit/changeset/42191">r42191</a> and there are no remaining clients of the API.

* dom/Document.cpp:
* dom/Document.h:
* WebCore.exp.in:

Source/WebKit/mac:

Remove the private _focusableNodes API on DOMDocument, it has no clients.

* DOM/WebDOMOperations.mm:
* DOM/WebDOMOperationsPrivate.h:</pre>

<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkSourceWebCoreChangeLog">trunk/Source/WebCore/ChangeLog</a></li>
<li><a href="#trunkSourceWebCoreWebCoreexpin">trunk/Source/WebCore/WebCore.exp.in</a></li>
<li><a href="#trunkSourceWebCoredomDocumentcpp">trunk/Source/WebCore/dom/Document.cpp</a></li>
<li><a href="#trunkSourceWebCoredomDocumenth">trunk/Source/WebCore/dom/Document.h</a></li>
<li><a href="#trunkSourceWebKitmacChangeLog">trunk/Source/WebKit/mac/ChangeLog</a></li>
<li><a href="#trunkSourceWebKitmacDOMWebDOMOperationsmm">trunk/Source/WebKit/mac/DOM/WebDOMOperations.mm</a></li>
<li><a href="#trunkSourceWebKitmacDOMWebDOMOperationsPrivateh">trunk/Source/WebKit/mac/DOM/WebDOMOperationsPrivate.h</a></li>
</ul>

</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkSourceWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/ChangeLog (150698 => 150699)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/ChangeLog        2013-05-26 02:22:58 UTC (rev 150698)
+++ trunk/Source/WebCore/ChangeLog        2013-05-26 02:27:32 UTC (rev 150699)
</span><span class="lines">@@ -1,5 +1,18 @@
</span><span class="cx"> 2013-05-25  Andreas Kling  &lt;akling@apple.com&gt;
</span><span class="cx"> 
</span><ins>+        Remove Document::getFocusableNodes().
+        &lt;http://webkit.org/b/116773&gt;
+
+        Reviewed by Joseph Pecoraro.
+
+        This was added in r42191 and there are no remaining clients of the API.
+
+        * dom/Document.cpp:
+        * dom/Document.h:
+        * WebCore.exp.in:
+
+2013-05-25  Andreas Kling  &lt;akling@apple.com&gt;
+
</ins><span class="cx">         Move Node::focusDelegate() to Element.
</span><span class="cx">         &lt;http://webkit.org/b/116768&gt;
</span><span class="cx"> 
</span></span></pre></div>
<a id="trunkSourceWebCoreWebCoreexpin"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/WebCore.exp.in (150698 => 150699)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/WebCore.exp.in        2013-05-26 02:22:58 UTC (rev 150698)
+++ trunk/Source/WebCore/WebCore.exp.in        2013-05-26 02:27:32 UTC (rev 150699)
</span><span class="lines">@@ -1051,7 +1051,6 @@
</span><span class="cx"> __ZN7WebCore8Document14setFocusedNodeEN3WTF10PassRefPtrINS_4NodeEEENS_14FocusDirectionE
</span><span class="cx"> __ZN7WebCore8Document16isPageBoxVisibleEi
</span><span class="cx"> __ZN7WebCore8Document16shortcutIconURLsEv
</span><del>-__ZN7WebCore8Document17getFocusableNodesERN3WTF6VectorINS1_6RefPtrINS_4NodeEEELm0ENS1_15CrashOnOverflowEEE
</del><span class="cx"> __ZN7WebCore8Document20styleResolverChangedENS_23StyleResolverUpdateFlagE
</span><span class="cx"> __ZN7WebCore8Document22createDocumentFragmentEv
</span><span class="cx"> __ZN7WebCore8Document23didAddWheelEventHandlerEv
</span></span></pre></div>
<a id="trunkSourceWebCoredomDocumentcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/dom/Document.cpp (150698 => 150699)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/dom/Document.cpp        2013-05-26 02:22:58 UTC (rev 150698)
+++ trunk/Source/WebCore/dom/Document.cpp        2013-05-26 02:27:32 UTC (rev 150699)
</span><span class="lines">@@ -3459,17 +3459,7 @@
</span><span class="cx">     updateStyleIfNeeded();
</span><span class="cx">     return !focusChangeBlocked;
</span><span class="cx"> }
</span><del>-    
-void Document::getFocusableNodes(Vector&lt;RefPtr&lt;Node&gt; &gt;&amp; nodes)
-{
-    updateLayout();
</del><span class="cx"> 
</span><del>-    for (Node* node = firstChild(); node; node = NodeTraversal::next(node)) {
-        if (node-&gt;isFocusable())
-            nodes.append(node);
-    }
-}
-  
</del><span class="cx"> void Document::setCSSTarget(Element* n)
</span><span class="cx"> {
</span><span class="cx">     if (m_cssTarget)
</span></span></pre></div>
<a id="trunkSourceWebCoredomDocumenth"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/dom/Document.h (150698 => 150699)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/dom/Document.h        2013-05-26 02:22:58 UTC (rev 150698)
+++ trunk/Source/WebCore/dom/Document.h        2013-05-26 02:27:32 UTC (rev 150699)
</span><span class="lines">@@ -675,8 +675,6 @@
</span><span class="cx">     UserActionElementSet&amp; userActionElements()  { return m_userActionElements; }
</span><span class="cx">     const UserActionElementSet&amp; userActionElements() const { return m_userActionElements; }
</span><span class="cx"> 
</span><del>-    void getFocusableNodes(Vector&lt;RefPtr&lt;Node&gt; &gt;&amp;);
-    
</del><span class="cx">     // The m_ignoreAutofocus flag specifies whether or not the document has been changed by the user enough 
</span><span class="cx">     // for WebCore to ignore the autofocus attribute on any form controls
</span><span class="cx">     bool ignoreAutofocus() const { return m_ignoreAutofocus; };
</span></span></pre></div>
<a id="trunkSourceWebKitmacChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit/mac/ChangeLog (150698 => 150699)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit/mac/ChangeLog        2013-05-26 02:22:58 UTC (rev 150698)
+++ trunk/Source/WebKit/mac/ChangeLog        2013-05-26 02:27:32 UTC (rev 150699)
</span><span class="lines">@@ -1,3 +1,15 @@
</span><ins>+2013-05-25  Andreas Kling  &lt;akling@apple.com&gt;
+
+        Remove Document::getFocusableNodes().
+        &lt;http://webkit.org/b/116773&gt;
+
+        Reviewed by Joseph Pecoraro.
+
+        Remove the private _focusableNodes API on DOMDocument, it has no clients.
+
+        * DOM/WebDOMOperations.mm:
+        * DOM/WebDOMOperationsPrivate.h:
+
</ins><span class="cx"> 2013-05-25  Simon Fraser  &lt;simon.fraser@apple.com&gt;
</span><span class="cx"> 
</span><span class="cx">         Unprefix Page Visibility API
</span></span></pre></div>
<a id="trunkSourceWebKitmacDOMWebDOMOperationsmm"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit/mac/DOM/WebDOMOperations.mm (150698 => 150699)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit/mac/DOM/WebDOMOperations.mm        2013-05-26 02:22:58 UTC (rev 150698)
+++ trunk/Source/WebKit/mac/DOM/WebDOMOperations.mm        2013-05-26 02:27:32 UTC (rev 150699)
</span><span class="lines">@@ -183,20 +183,6 @@
</span><span class="cx"> 
</span><span class="cx"> @end
</span><span class="cx"> 
</span><del>-@implementation DOMDocument (WebDOMDocumentOperationsPrivate)
-
-- (NSArray *)_focusableNodes
-{
-    Vector&lt;RefPtr&lt;Node&gt; &gt; nodes;
-    core(self)-&gt;getFocusableNodes(nodes);
-    NSMutableArray *array = [NSMutableArray arrayWithCapacity:nodes.size()];
-    for (unsigned i = 0; i &lt; nodes.size(); ++i)
-        [array addObject:kit(nodes[i].get())];
-    return array;
-}
-
-@end
-
</del><span class="cx"> @implementation DOMRange (WebDOMRangeOperations)
</span><span class="cx"> 
</span><span class="cx"> - (WebArchive *)webArchive
</span></span></pre></div>
<a id="trunkSourceWebKitmacDOMWebDOMOperationsPrivateh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit/mac/DOM/WebDOMOperationsPrivate.h (150698 => 150699)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit/mac/DOM/WebDOMOperationsPrivate.h        2013-05-26 02:22:58 UTC (rev 150698)
+++ trunk/Source/WebKit/mac/DOM/WebDOMOperationsPrivate.h        2013-05-26 02:27:32 UTC (rev 150699)
</span><span class="lines">@@ -33,10 +33,6 @@
</span><span class="cx"> + (DOMElement *)_DOMElementFromJSContext:(JSContextRef)context value:(JSValueRef)value;
</span><span class="cx"> @end
</span><span class="cx"> 
</span><del>-@interface DOMDocument (WebDOMDocumentOperationsPrivate)
-- (NSArray *)_focusableNodes;
-@end
-
</del><span class="cx"> @interface DOMHTMLInputElement (WebDOMHTMLInputElementOperationsPrivate)
</span><span class="cx"> - (void)_setAutofilled:(BOOL)autofilled;
</span><span class="cx"> @end
</span></span></pre>
</div>
</div>

</body>
</html>