<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[150249] trunk/Source/WebCore</title>
</head>
<body>

<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt;  }
#msg dl a { font-weight: bold}
#msg dl a:link    { color:#fc3; }
#msg dl a:active  { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff  {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/150249">150249</a></dd>
<dt>Author</dt> <dd>ch.dumez@sisa.samsung.com</dd>
<dt>Date</dt> <dd>2013-05-17 05:24:50 -0700 (Fri, 17 May 2013)</dd>
</dl>

<h3>Log Message</h3>
<pre>Remove custom code for MessageEvent.ports getter
https://bugs.webkit.org/show_bug.cgi?id=116304

Reviewed by Kentaro Hara.

Remove Custom code for the &quot;ports&quot; attribute getter in MessageEvent
IDL interface. The JSC bindings generator already supports attributes
of type MessagePortArray.

No new tests, already covered by existing layout tests and bindings
tests.

* bindings/js/JSMessageEventCustom.cpp: Remove Custom code for ports getter.
* bindings/scripts/CodeGeneratorJS.pm:
(NativeToJSValue): Small tweak to correctly handle the case where impl-&gt;ports()
returns NULL and avoid crashing in this case.
* bindings/scripts/test/JS/JSTestSerializedScriptValueInterface.cpp: Rebaseline due
to bindings generator tweak.
* dom/MessageEvent.idl: Remove [CustomGetter] extended attribute for 'ports' attribute
and switch to MessagePortArray type.</pre>

<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkSourceWebCoreChangeLog">trunk/Source/WebCore/ChangeLog</a></li>
<li><a href="#trunkSourceWebCorebindingsjsJSMessageEventCustomcpp">trunk/Source/WebCore/bindings/js/JSMessageEventCustom.cpp</a></li>
<li><a href="#trunkSourceWebCorebindingsscriptsCodeGeneratorJSpm">trunk/Source/WebCore/bindings/scripts/CodeGeneratorJS.pm</a></li>
<li><a href="#trunkSourceWebCorebindingsscriptstestJSJSTestSerializedScriptValueInterfacecpp">trunk/Source/WebCore/bindings/scripts/test/JS/JSTestSerializedScriptValueInterface.cpp</a></li>
<li><a href="#trunkSourceWebCoredomMessageEventidl">trunk/Source/WebCore/dom/MessageEvent.idl</a></li>
</ul>

</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkSourceWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/ChangeLog (150248 => 150249)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/ChangeLog        2013-05-17 12:22:59 UTC (rev 150248)
+++ trunk/Source/WebCore/ChangeLog        2013-05-17 12:24:50 UTC (rev 150249)
</span><span class="lines">@@ -1,3 +1,26 @@
</span><ins>+2013-05-17  Christophe Dumez  &lt;ch.dumez@sisa.samsung.com&gt;
+
+        Remove custom code for MessageEvent.ports getter
+        https://bugs.webkit.org/show_bug.cgi?id=116304
+
+        Reviewed by Kentaro Hara.
+
+        Remove Custom code for the &quot;ports&quot; attribute getter in MessageEvent
+        IDL interface. The JSC bindings generator already supports attributes
+        of type MessagePortArray.
+
+        No new tests, already covered by existing layout tests and bindings
+        tests.
+
+        * bindings/js/JSMessageEventCustom.cpp: Remove Custom code for ports getter.
+        * bindings/scripts/CodeGeneratorJS.pm:
+        (NativeToJSValue): Small tweak to correctly handle the case where impl-&gt;ports()
+        returns NULL and avoid crashing in this case.
+        * bindings/scripts/test/JS/JSTestSerializedScriptValueInterface.cpp: Rebaseline due
+        to bindings generator tweak.
+        * dom/MessageEvent.idl: Remove [CustomGetter] extended attribute for 'ports' attribute
+        and switch to MessagePortArray type.
+
</ins><span class="cx"> 2013-05-16  Jesus Sanchez-Palencia  &lt;jesus.palencia@openbossa.org&gt;
</span><span class="cx"> 
</span><span class="cx">         Add stubs for ContextMenu and ContextMenuItem
</span></span></pre></div>
<a id="trunkSourceWebCorebindingsjsJSMessageEventCustomcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/bindings/js/JSMessageEventCustom.cpp (150248 => 150249)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/bindings/js/JSMessageEventCustom.cpp        2013-05-17 12:22:59 UTC (rev 150248)
+++ trunk/Source/WebCore/bindings/js/JSMessageEventCustom.cpp        2013-05-17 12:24:50 UTC (rev 150249)
</span><span class="lines">@@ -88,18 +88,6 @@
</span><span class="cx">     return result;
</span><span class="cx"> }
</span><span class="cx"> 
</span><del>-JSValue JSMessageEvent::ports(ExecState* exec) const
-{
-    MessagePortArray* ports = static_cast&lt;MessageEvent*&gt;(impl())-&gt;ports();
-    if (!ports)
-        return constructEmptyArray(exec, 0, globalObject());
-
-    MarkedArgumentBuffer list;
-    for (size_t i = 0; i &lt; ports-&gt;size(); i++)
-        list.append(toJS(exec, globalObject(), (*ports)[i].get()));
-    return constructArray(exec, 0, globalObject(), list);
-}
-
</del><span class="cx"> static JSC::JSValue handleInitMessageEvent(JSMessageEvent* jsEvent, JSC::ExecState* exec)
</span><span class="cx"> {
</span><span class="cx">     const String&amp; typeArg = exec-&gt;argument(0).toString(exec)-&gt;value(exec);
</span></span></pre></div>
<a id="trunkSourceWebCorebindingsscriptsCodeGeneratorJSpm"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/bindings/scripts/CodeGeneratorJS.pm (150248 => 150249)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/bindings/scripts/CodeGeneratorJS.pm        2013-05-17 12:22:59 UTC (rev 150248)
+++ trunk/Source/WebCore/bindings/scripts/CodeGeneratorJS.pm        2013-05-17 12:24:50 UTC (rev 150249)
</span><span class="lines">@@ -3557,7 +3557,7 @@
</span><span class="cx">         AddToImplIncludes(&quot;MessagePort.h&quot;, $conditional);
</span><span class="cx">         AddToImplIncludes(&quot;JSMessagePort.h&quot;, $conditional);
</span><span class="cx">         AddToImplIncludes(&quot;&lt;runtime/JSArray.h&gt;&quot;, $conditional);
</span><del>-        return &quot;jsArray(exec, $globalObject, *$value)&quot;;
</del><ins>+        return &quot;$value ? jsArray(exec, $globalObject, *$value) : constructEmptyArray(exec, 0, castedThis-&gt;globalObject())&quot;;
</ins><span class="cx">     } else {
</span><span class="cx">         # Default, include header with same name.
</span><span class="cx">         AddToImplIncludes(&quot;JS$type.h&quot;, $conditional);
</span></span></pre></div>
<a id="trunkSourceWebCorebindingsscriptstestJSJSTestSerializedScriptValueInterfacecpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/bindings/scripts/test/JS/JSTestSerializedScriptValueInterface.cpp (150248 => 150249)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/bindings/scripts/test/JS/JSTestSerializedScriptValueInterface.cpp        2013-05-17 12:22:59 UTC (rev 150248)
+++ trunk/Source/WebCore/bindings/scripts/test/JS/JSTestSerializedScriptValueInterface.cpp        2013-05-17 12:24:50 UTC (rev 150249)
</span><span class="lines">@@ -179,7 +179,7 @@
</span><span class="cx">     JSTestSerializedScriptValueInterface* castedThis = jsCast&lt;JSTestSerializedScriptValueInterface*&gt;(asObject(slotBase));
</span><span class="cx">     UNUSED_PARAM(exec);
</span><span class="cx">     TestSerializedScriptValueInterface* impl = static_cast&lt;TestSerializedScriptValueInterface*&gt;(castedThis-&gt;impl());
</span><del>-    JSValue result = jsArray(exec, castedThis-&gt;globalObject(), *impl-&gt;ports());
</del><ins>+    JSValue result = impl-&gt;ports() ? jsArray(exec, castedThis-&gt;globalObject(), *impl-&gt;ports()) : constructEmptyArray(exec, 0, castedThis-&gt;globalObject());
</ins><span class="cx">     return result;
</span><span class="cx"> }
</span><span class="cx"> 
</span></span></pre></div>
<a id="trunkSourceWebCoredomMessageEventidl"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/dom/MessageEvent.idl (150248 => 150249)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/dom/MessageEvent.idl        2013-05-17 12:22:59 UTC (rev 150248)
+++ trunk/Source/WebCore/dom/MessageEvent.idl        2013-05-17 12:24:50 UTC (rev 150249)
</span><span class="lines">@@ -34,7 +34,7 @@
</span><span class="cx">     [InitializedByEventConstructor] readonly attribute DOMWindow source;
</span><span class="cx"> #if defined(LANGUAGE_JAVASCRIPT) &amp;&amp; LANGUAGE_JAVASCRIPT
</span><span class="cx">     [InitializedByEventConstructor, CachedAttribute, CustomGetter] readonly attribute any data;
</span><del>-    [InitializedByEventConstructor, CustomGetter] readonly attribute Array ports;
</del><ins>+    [InitializedByEventConstructor] readonly attribute MessagePortArray ports;
</ins><span class="cx"> 
</span><span class="cx">     [Custom] void initMessageEvent([Default=Undefined] optional DOMString typeArg, 
</span><span class="cx">                                    [Default=Undefined] optional boolean canBubbleArg, 
</span></span></pre>
</div>
</div>

</body>
</html>