<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[150318] trunk/Source/WebCore</title>
</head>
<body>

<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt;  }
#msg dl a { font-weight: bold}
#msg dl a:link    { color:#fc3; }
#msg dl a:active  { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff  {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/150318">150318</a></dd>
<dt>Author</dt> <dd>akling@apple.com</dd>
<dt>Date</dt> <dd>2013-05-17 19:56:20 -0700 (Fri, 17 May 2013)</dd>
</dl>

<h3>Log Message</h3>
<pre>Ads on theverge.com cause repaints when hovered, even though content doesn't visibly change.
&lt;http://webkit.org/b/116344&gt;

Reviewed by Darin Adler.

Teach RenderStyle::diff() to ignore differences in the outline value if both styles have non-visible outlines.

* rendering/style/RenderStyle.cpp:
(WebCore::RenderStyle::diff):
* rendering/style/StyleBackgroundData.cpp:
(WebCore::StyleBackgroundData::isEquivalentForPainting):
* rendering/style/StyleBackgroundData.h:
(StyleBackgroundData):</pre>

<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkSourceWebCoreChangeLog">trunk/Source/WebCore/ChangeLog</a></li>
<li><a href="#trunkSourceWebCorerenderingstyleRenderStylecpp">trunk/Source/WebCore/rendering/style/RenderStyle.cpp</a></li>
<li><a href="#trunkSourceWebCorerenderingstyleStyleBackgroundDatacpp">trunk/Source/WebCore/rendering/style/StyleBackgroundData.cpp</a></li>
<li><a href="#trunkSourceWebCorerenderingstyleStyleBackgroundDatah">trunk/Source/WebCore/rendering/style/StyleBackgroundData.h</a></li>
</ul>

</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkSourceWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/ChangeLog (150317 => 150318)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/ChangeLog        2013-05-18 02:40:37 UTC (rev 150317)
+++ trunk/Source/WebCore/ChangeLog        2013-05-18 02:56:20 UTC (rev 150318)
</span><span class="lines">@@ -1,5 +1,21 @@
</span><span class="cx"> 2013-05-17  Andreas Kling  &lt;akling@apple.com&gt;
</span><span class="cx"> 
</span><ins>+        Ads on theverge.com cause repaints when hovered, even though content doesn't visibly change.
+        &lt;http://webkit.org/b/116344&gt;
+
+        Reviewed by Darin Adler.
+
+        Teach RenderStyle::diff() to ignore differences in the outline value if both styles have non-visible outlines.
+
+        * rendering/style/RenderStyle.cpp:
+        (WebCore::RenderStyle::diff):
+        * rendering/style/StyleBackgroundData.cpp:
+        (WebCore::StyleBackgroundData::isEquivalentForPainting):
+        * rendering/style/StyleBackgroundData.h:
+        (StyleBackgroundData):
+
+2013-05-17  Andreas Kling  &lt;akling@apple.com&gt;
+
</ins><span class="cx">         Plug leak in CSSSelectorList::deleteSelectors().
</span><span class="cx">         &lt;http://webkit.org/b/116371&gt;
</span><span class="cx">         &lt;rdar://problem/13930698&gt;
</span></span></pre></div>
<a id="trunkSourceWebCorerenderingstyleRenderStylecpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/rendering/style/RenderStyle.cpp (150317 => 150318)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/rendering/style/RenderStyle.cpp        2013-05-18 02:40:37 UTC (rev 150317)
+++ trunk/Source/WebCore/rendering/style/RenderStyle.cpp        2013-05-18 02:56:20 UTC (rev 150318)
</span><span class="lines">@@ -679,7 +679,7 @@
</span><span class="cx">         || inherited_flags.m_printColorAdjust != other-&gt;inherited_flags.m_printColorAdjust
</span><span class="cx">         || inherited_flags._insideLink != other-&gt;inherited_flags._insideLink
</span><span class="cx">         || surround-&gt;border != other-&gt;surround-&gt;border
</span><del>-        || *m_background.get() != *other-&gt;m_background.get()
</del><ins>+        || !m_background-&gt;isEquivalentForPainting(*other-&gt;m_background)
</ins><span class="cx">         || rareInheritedData-&gt;userModify != other-&gt;rareInheritedData-&gt;userModify
</span><span class="cx">         || rareInheritedData-&gt;userSelect != other-&gt;rareInheritedData-&gt;userSelect
</span><span class="cx">         || rareNonInheritedData-&gt;userDrag != other-&gt;rareNonInheritedData-&gt;userDrag
</span></span></pre></div>
<a id="trunkSourceWebCorerenderingstyleStyleBackgroundDatacpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/rendering/style/StyleBackgroundData.cpp (150317 => 150318)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/rendering/style/StyleBackgroundData.cpp        2013-05-18 02:40:37 UTC (rev 150317)
+++ trunk/Source/WebCore/rendering/style/StyleBackgroundData.cpp        2013-05-18 02:56:20 UTC (rev 150318)
</span><span class="lines">@@ -46,4 +46,13 @@
</span><span class="cx">     return m_background == o.m_background &amp;&amp; m_color == o.m_color &amp;&amp; m_outline == o.m_outline;
</span><span class="cx"> }
</span><span class="cx"> 
</span><ins>+bool StyleBackgroundData::isEquivalentForPainting(const StyleBackgroundData&amp; other) const
+{
+    if (m_background != other.m_background || m_color != other.m_color)
+        return false;
+    if (!m_outline.isVisible() &amp;&amp; !other.m_outline.isVisible())
+        return true;
+    return m_outline == other.m_outline;
+}
+
</ins><span class="cx"> } // namespace WebCore
</span></span></pre></div>
<a id="trunkSourceWebCorerenderingstyleStyleBackgroundDatah"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/rendering/style/StyleBackgroundData.h (150317 => 150318)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/rendering/style/StyleBackgroundData.h        2013-05-18 02:40:37 UTC (rev 150317)
+++ trunk/Source/WebCore/rendering/style/StyleBackgroundData.h        2013-05-18 02:56:20 UTC (rev 150318)
</span><span class="lines">@@ -45,6 +45,8 @@
</span><span class="cx">         return !(*this == o);
</span><span class="cx">     }
</span><span class="cx"> 
</span><ins>+    bool isEquivalentForPainting(const StyleBackgroundData&amp;) const;
+
</ins><span class="cx">     const FillLayer&amp; background() const { return m_background; }
</span><span class="cx">     const Color&amp; color() const { return m_color; }
</span><span class="cx">     const OutlineValue&amp; outline() const { return m_outline; }
</span></span></pre>
</div>
</div>

</body>
</html>